Re: Review Request 129261: Hide the "Show Menu Bar" action if all the menubars are native

2016-12-30 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129261/ --- (Updated Dec. 30, 2016, 11:57 a.m.) Status -- This change has been

Re: Review Request 129261: Hide the "Show Menu Bar" action if all the menubars are native

2016-12-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129261/#review101667 --- Fix it, then Ship it! Looks good now. Indeed this is

Re: Review Request 129261: Hide the "Show Menu Bar" action if all the menubars are native

2016-12-29 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129261/ --- (Updated Dec. 29, 2016, 11:01 p.m.) Review request for KDE Frameworks.

Re: Review Request 129261: Hide the "Show Menu Bar" action if all the menubars are native

2016-12-29 Thread Albert Astals Cid
> On Dec. 29, 2016, 9:24 a.m., David Faure wrote: > > src/kstandardaction.cpp, line 199 > > > > > > If an application creates many "show menu bar" actions, e.g. one per > > window in a many-windows process,

Re: Review Request 129261: Hide the "Show Menu Bar" action if all the menubars are native

2016-12-28 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129261/ --- (Updated Dec. 28, 2016, 10:47 p.m.) Review request for KDE Frameworks.

Re: Review Request 129261: Hide the "Show Menu Bar" action if all the menubars are native

2016-11-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129261/#review100639 --- Fix it, then Ship it! src/kstandardaction.cpp (line

Re: Review Request 129261: Hide the "Show Menu Bar" action if all the menubars are native

2016-10-27 Thread Kai Uwe Broulik
> On Okt. 27, 2016, 10:38 vorm., Kai Uwe Broulik wrote: > > The problem with isNativeMenuBar() is that it returns true if the window > > *may* be a native menu bar, for example when the platform theme removes the > > AA_DontUseNativeMenuBar qApp flag. This does not mean that the platform > >

Re: Review Request 129261: Hide the "Show Menu Bar" action if all the menubars are native

2016-10-27 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129261/#review100331 --- The problem with isNativeMenuBar() is that it returns true

Re: Review Request 129261: Hide the "Show Menu Bar" action if all the menubars are native

2016-10-25 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129261/#review100279 --- +1 pretty cool! - Aleix Pol Gonzalez On Oct. 26, 2016,

Review Request 129261: Hide the "Show Menu Bar" action if all the menubars are native

2016-10-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129261/ --- Review request for KDE Frameworks. Repository: kconfigwidgets