On Mon, 2014-09-15 at 10:38 -0400, Nick Krause wrote:
After issues with the community I am wondering how to improve my rep
Since you ignore good advice from *lots of* people and you are incapable
to learn anything: by going somewhere else and not trolling here around.
Bernd
--
I
Robert P. J. Day rpj...@crashcourse.ca writes:
oh, and while i'm here, i'm going to point out a couple other things
you should avoid if you're trying to get your first patch into the
kernel -- unsurprisingly, nick has violated both of these guidelines a
number of times.
first, good
I wouldn't touch those with a ten foot pole.
On 16 Sep 2014 14:46, nick xerofo...@gmail.com wrote:
I am attaching two check patch patches I wrote in the last few days as I
am unable to get a reply
from the maintainers. Would someone please send them off for me.
Thanks,
Nick
On 14-09-16 08:47 AM, Kristofer Hallin wrote:
I wouldn't touch those with a ten foot pole.
On 16 Sep 2014 14:46, nick xerofo...@gmail.com wrote:
I am attaching two check patch patches I wrote in the last few days as I
am unable to get a reply
from the maintainers. Would someone please
I am attaching two check patch patches I wrote in the last few days as I am
unable to get a reply
from the maintainers. Would someone please send them off for me.
Thanks,
Nick
From 7bf4229fa2f9c4fcf3243bc738c74bfdc58a6594 Mon Sep 17 00:00:00 2001
From: Nicholas Krause xerofo...@gmail.com
Date:
On Tue, 16 Sep 2014, nick wrote:
I am attaching two check patch patches I wrote in the last few days
as I am unable to get a reply from the maintainers. Would someone
please send them off for me.
hey, kids ... remember what i wrote recently about, at the very
least, having a grammatically
On Tue, 16 Sep 2014, nick wrote:
I am attaching two check patch patches I wrote in the last few days
as I am unable to get a reply from the maintainers. Would someone
please send them off for me.
oh, and remember how i wrote *explicitly* that the patch message
should match the properties of
= platform_get_drvdata(pdev);
+
unregister_netdev(priv-ndev);
mdiobus_unregister(priv-mii_bus);
mdiobus_free(priv-mii_bus);
--
1.9.1
ohhh .. yeah .. and both the patch failed when i tried to apply them to
next-20140916
why are we wasting our time for your patches
tried to apply them to
next-20140916
why are we wasting our time for your patches , which are bound to have
some problem
thanks
sudip
___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org
On Thu, 11 Sep 2014, Leon Romanovsky wrote:
Linux kernel memory is not page-able, but memory allocated through vmalloc
can still cause page fault. How device drivers using vmalloc handle this?
Pages allocated via vmalloc call won't generate page-faults.
Kernel faults are used on some
.. and both the patch failed when i tried to apply them to
next-20140916
why are we wasting our time for your patches , which are bound to have some
problem
thanks
sudip
___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
)
{
struct xlr_net_priv *priv = platform_get_drvdata(pdev);
+
unregister_netdev(priv-ndev);
mdiobus_unregister(priv-mii_bus);
mdiobus_free(priv-mii_bus);
--
1.9.1
ohhh .. yeah .. and both the patch failed when i tried to apply them to
next-20140916
why are we
On Tue, 16 Sep 2014 08:44:27 -0400, nick said:
I am attaching two check patch patches I wrote in the last few days as I am
unable to get a reply
from the maintainers. Would someone please send them off for me.
I am attaching. Fail 3 words in.
That's why you aren't getting a reply from the
them to
next-20140916
why are we wasting our time for your patches , which are bound to have some
problem
thanks
sudip
___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo
To add to this, if you're trying to compile a kernel to work for a specific
platform or board and it's not working, 'make menuconfig' is your friend for
taking a bare bones kernel .config and making it your own.
-Original Message-
From: linux-newbie-ow...@vger.kernel.org
On 2014-09-07 17:12:33 (+0800), lx lxlenovos...@gmail.com wrote:
I want to send a udp packet in kernel module. the codes is:
Why?
// iph-version = 4; iph-ihl = 5;
put_unaligned(0x45, (unsigned char *)send_iph);
send_iph-tos = 0;
put_unaligned(htons(iph_len), (send_iph-tot_len));
On Tue, Sep 16, 2014 at 10:19 AM, valdis.kletni...@vt.edu wrote:
On Tue, 16 Sep 2014 08:44:27 -0400, nick said:
I am attaching two check patch patches I wrote in the last few days as I am
unable to get a reply
from the maintainers. Would someone please send them off for me.
I am
On Tue, Sep 16, 2014 at 5:44 PM, Nick Krause xerofo...@gmail.com wrote:
On Tue, Sep 16, 2014 at 10:19 AM, valdis.kletni...@vt.edu wrote:
On Tue, 16 Sep 2014 08:44:27 -0400, nick said:
I am attaching two check patch patches I wrote in the last few days as I am
unable to get a reply
from the
Nick,
Use this guide: http://kernelnewbies.org/OPWfirstpatch
It's a tutorial that shows you how to setup and send patches.
And memorize these references:
http://lxr.free-electrons.com/source/Documentation/SubmitChecklist
http://lxr.free-electrons.com/source/Documentation/development-process/
On Tue, 16 Sep 2014 11:57:35 -0400, Lidza Louina said:
Use this guide: http://kernelnewbies.org/OPWfirstpatch
It's a tutorial that shows you how to setup and send patches.
Don't bother.
He's been pointed at that at least once a week for the past two months,
and everybody from me to Greg KH
On Tue, Sep 16, 2014 at 11:44:59AM -0400, Nick Krause wrote:
On Tue, Sep 16, 2014 at 10:19 AM, valdis.kletni...@vt.edu wrote:
On Tue, 16 Sep 2014 08:44:27 -0400, nick said:
I am attaching two check patch patches I wrote in the last few days as I
am unable to get a reply
from the
On Tue, 16 Sep 2014, valdis.kletni...@vt.edu wrote:
On Tue, 16 Sep 2014 11:57:35 -0400, Lidza Louina said:
Use this guide: http://kernelnewbies.org/OPWfirstpatch
It's a tutorial that shows you how to setup and send patches.
Don't bother.
He's been pointed at that at least once a week
On Tue, 16 Sep 2014, Lidza Louina wrote:
Nick,
Use this guide: http://kernelnewbies.org/OPWfirstpatch
It's a tutorial that shows you how to setup and send patches.
And memorize these references:
http://lxr.free-electrons.com/source/Documentation/SubmitChecklist
On 9/16/14, Nick Krause xerofo...@gmail.com wrote:
On Tue, Sep 16, 2014 at 10:19 AM, valdis.kletni...@vt.edu wrote:
On Tue, 16 Sep 2014 08:44:27 -0400, nick said:
I am attaching two check patch patches I wrote in the last few days as I
am unable to get a reply
from the maintainers. Would
On Tue, Sep 16, 2014 at 12:57 PM, Sudip Mukherjee
sudipm.mukher...@gmail.com wrote:
On 9/16/14, Nick Krause xerofo...@gmail.com wrote:
On Tue, Sep 16, 2014 at 10:19 AM, valdis.kletni...@vt.edu wrote:
On Tue, 16 Sep 2014 08:44:27 -0400, nick said:
I am attaching two check patch patches I
On Tue, 16 Sep 2014, Nick Krause wrote:
I am going to resend my patch and see if it's good ...
because, of course, that's the correct order of events -- send the
patch, *then* validate its correctness.
ban. for the love of mutt, please, ban. there is no excuse for this
anymore.
rday
--
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/16/2014 01:12 PM, Nick Krause wrote:
I am going to resend my patch and see if it's good and if not I am
going to leave for a while.
You may want to consider fixing them, by applying the advice
provided by many people, before resending them.
On Tue, 16 Sep 2014 13:12:32 -0400, Nick Krause said:
I am going to resend my patch and see if it's good
Why bother? We already *know* it won't be.
You could amaze and astound us all by seeing if it's good *before* you hit send.
But I'm not holding my breath.
and if not I am going to leave
On Tue, 16 Sep 2014 13:28:06 -0400, Rik van Riel said:
-BEGIN PGP SIGNED MESSAGE-
On 09/16/2014 01:12 PM, Nick Krause wrote:
I am going to resend my patch and see if it's good and if not I am
going to leave for a while.
You may want to consider fixing them, by applying the advice
Hello,
In my pci driver for a certain pci device, I implemented the pci error
handler functions (error_detected, slot_reset methods, etc). I want
to trigger a pci error for me to exercise those handlers and observe
its behavior. I've read from the pci error recovery kernel
documentation that
On Wed, Sep 17, 2014 at 02:04:04AM +0800, Alvin Abitria wrote:
Hello,
In my pci driver for a certain pci device, I implemented the pci error
handler functions (error_detected, slot_reset methods, etc). I want
to trigger a pci error for me to exercise those handlers and observe
its
On Tue, Sep 16, 2014 at 1:39 PM, valdis.kletni...@vt.edu wrote:
On Tue, 16 Sep 2014 13:28:06 -0400, Rik van Riel said:
-BEGIN PGP SIGNED MESSAGE-
On 09/16/2014 01:12 PM, Nick Krause wrote:
I am going to resend my patch and see if it's good and if not I am
going to leave for a
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/16/2014 02:36 PM, Kristofer Hallin wrote:
On Tue, Sep 16, 2014 at 8:29 PM, Nick Krause xerofo...@gmail.com
wrote:
On Tue, Sep 16, 2014 at 1:39 PM, valdis.kletni...@vt.edu
wrote:
On Tue, 16 Sep 2014 13:28:06 -0400, Rik van Riel said:
I am fixing them first and them sending them out. I am going to listen now and
only do them correctly.
Nick, you're very close to being banned from kernelnewbies too, so
please give some thought to other people's advise or else this might
be your last email to kernelnewbies.
As a first step,
On Tue, 16 Sep 2014, Rik van Riel wrote:
Nick,
this is a chance for you to prove the nay-sayers wrong (or right).
When re-posting your patch, you can include information on what tips
you got on how to improve the patch, and how you applied that
information in the new version of the patch.
Fixing trivial checkpatch warnings about missing line after declarations
Signed-off-by: Nicholas Krause xerofo...@gmail.com
---
drivers/staging/wlan-ng/hfa384x.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/wlan-ng/hfa384x.h
b/drivers/staging/wlan-ng/hfa384x.h
index
On 14-09-16 05:20 PM, Nicholas Krause wrote:
Fixing trivial checkpatch warnings about missing line after declarations
Signed-off-by: Nicholas Krause xerofo...@gmail.com
---
drivers/staging/wlan-ng/hfa384x.h | 3 +++
1 file changed, 3 insertions(+)
diff --git
and for a third (fourth?) time, unable to use proper grammar in the
commit message. shocked ... shocked, i am.
rday
--
Robert P. J. Day Ottawa, Ontario, CANADA
Fixing trivial checkpatch warnings about missing line after declarations
Signed-off-by: Nicholas Krause xerofo...@gmail.com
---
drivers/staging/wlan-ng/hfa384x.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/wlan-ng/hfa384x.h
b/drivers/staging/wlan-ng/hfa384x.h
index
On Tue, 16 Sep 2014, Nicholas Krause wrote:
Fixing trivial checkpatch warnings about missing line after declarations
Signed-off-by: Nicholas Krause xerofo...@gmail.com
---
drivers/staging/wlan-ng/hfa384x.h | 3 +++
1 file changed, 3 insertions(+)
diff --git
On Tue, 16 Sep 2014 17:23:05 -0400, nick said:
I checked this patch and there seems to be issues that any of you have stated
before after not applying or grammar e.t.c.
If there seem to be issues, why did you bother posting it?
pgpf6oJH5i0Dq.pgp
Description: PGP signature
Fixing trivial checkpatch warnings about missing blanks lines after
declarations.
Signed-off-by: Nicholas Krause xerofo...@gmail.com
---
drivers/staging/wlan-ng/hfa384x.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/wlan-ng/hfa384x.h
On 14-09-16 05:58 PM, Nicholas Krause wrote:
Fixing trivial checkpatch warnings about missing blanks lines after
declarations.
Signed-off-by: Nicholas Krause xerofo...@gmail.com
---
drivers/staging/wlan-ng/hfa384x.h | 3 +++
1 file changed, 3 insertions(+)
diff --git
After numerous tries at good patches and still failing , I am listening to what
you guys stated
about my patches check it applies, grammar and build checks. I am still unable
to get a good patch
and would really appreciate it if someone walks me through one good patch as I
will learn this will
In general, stand-alone patches to fix checkpatch whining are a Bad Idea(TM).
Here's why...
First off, the type of programmer who is tempted to do checkpatch cleanup
as My First Kernel Patch are, by and large, novices.
The code in the kernel falls into one of several states of use and
On Tue, Sep 16, 2014 at 08:25:51PM -0400, Valdis Kletnieks wrote:
In general, stand-alone patches to fix checkpatch whining are a Bad
Idea(TM).
snip
And here's why checkpatch patches are a Good Idea(TM):
- it teaches you how to set up your email client properly
- it teaches you how to
On Tue, 2014-09-16 at 17:59 -0400, nick wrote:
On 14-09-16 05:58 PM, Nicholas Krause wrote:
Fixing trivial checkpatch warnings about missing blanks lines after
declarations.
blanks lines after declarations.
I checked my grammar. I am assuming I am still wrong through.
On Tue, Sep 16, 2014 at 7:25 PM, Valdis Kletnieks
valdis.kletni...@vt.edu wrote:
In general, stand-alone patches to fix checkpatch whining are a Bad
Idea(TM).
That's just YOUR opinion. GregKH actually made a presentation to help
us n00bs do exactly that:
Fixing trivial checkpatch warnings about missing blank lines after declarations.
Signed-off-by: Nicholas Krause xerofo...@gmail.com
---
drivers/staging/wlan-ng/hfa384x.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/wlan-ng/hfa384x.h
b/drivers/staging/wlan-ng/hfa384x.h
On 14-09-16 10:41 PM, Nicholas Krause wrote:
Fixing trivial checkpatch warnings about missing blank lines after
declarations.
Signed-off-by: Nicholas Krause xerofo...@gmail.com
---
drivers/staging/wlan-ng/hfa384x.h | 3 +++
1 file changed, 3 insertions(+)
diff --git
On Sun, Sep 14, 2014 at 2:11 AM, Ran Shalit ransha...@gmail.com wrote:
On Thu, Sep 11, 2014 at 12:24 PM, Ran Shalit ransha...@gmail.com wrote:
On Thu, Sep 11, 2014 at 8:32 AM, AYAN KUMAR HALDER ayankum...@gmail.com
wrote:
On Thu, Sep 11, 2014 at 12:55 AM, valdis.kletni...@vt.edu wrote:
On Wed, Sep 17, 2014 at 11:16 AM, Peter Teoh htmldevelo...@gmail.com
wrote:
On Sun, Sep 14, 2014 at 2:11 AM, Ran Shalit ransha...@gmail.com wrote:
On Thu, Sep 11, 2014 at 12:24 PM, Ran Shalit ransha...@gmail.com wrote:
On Thu, Sep 11, 2014 at 8:32 AM, AYAN KUMAR HALDER
On Tue, 16 Sep 2014 20:35:35 -0500, Greg Donald said:
fs/* currently contains 96,375 errors and 22,555 warnings.
[/usr/src/linux-next] find fs -type f -name '*.[ch]' | xargs cat | wc -l
1138557
96K errors seemed to be a tad high. So.. doublechecking..
[/usr/src/linux-next] for i in `find
On Tue, Sep 16, 2014 at 11:42:18PM -0400, valdis.kletni...@vt.edu wrote:
(And this sort of analysis is exactly *why* people need to apply their brains
when looking at checkpatch output)
No one has ever said that they shouldn't.
Remember, I know _lots_ of kernel developers who started with
On Wed, Sep 17, 2014 at 10:26 AM, Greg KH g...@kroah.com wrote:
On Tue, Sep 16, 2014 at 11:42:18PM -0400, valdis.kletni...@vt.edu wrote:
(And this sort of analysis is exactly *why* people need to apply their brains
when looking at checkpatch output)
No one has ever said that they
55 matches
Mail list logo
