Hi Russell-
Looks good. There were just a couple formatting issues (parentheses go on
newlines) that I fixed and pushed the patch.
Thank you for the contribution!
-S
2018-04-02 4:52 GMT-07:00 Russell Oliver :
> Updated patch, which also should fix rotations for rectangles. This should
> be a c
Updated patch, which also should fix rotations for rectangles. This should
be a complete fix for the reported bug.
On Sat, Mar 31, 2018 at 11:07 PM Russell Oliver
wrote:
> No I won't have time to.
>
> There is still the issue of Eagle rectangles with a rotation applied not
> being imported corre
No I won't have time to.
There is still the issue of Eagle rectangles with a rotation applied not
being imported correctly too.
On Sat, 31 Mar 2018 14:03 Seth Hillbrand, wrote:
> Hi Russell-
>
> Will you have time to update this patch? If not, I'm happy to revise it
> to handle the cases this
Hi Russell-
Will you have time to update this patch? If not, I'm happy to revise it to
handle the cases this weekend. We're getting close to rc2 and I'd like to
get your fix in before it is released.
Best-
Seth
2018-03-27 13:12 GMT-07:00 Seth Hillbrand :
> Hi Russell-
>
> I was unclear. The
Hi Russell-
I was unclear. The change in the LSET makes sense. But it looks like you
are not setting the solderpaste margin when the solderpaste layer is
enabled. I think you need to handle both the case where the paste is
enabled and where it is disabled.
-S
2018-03-27 12:53 GMT-07:00 Russel
The cream setting is the eagle equivalent to enabling/disabling the
soldering paste layer for the pad. Hence the change in the layer set.
On Wed, 28 Mar 2018 03:14 Seth Hillbrand, wrote:
> Hi Russell-
>
> Thanks for the patch. However, currently, if there is no e.cream setting,
> the local sold
Hi Russell-
Thanks for the patch. However, currently, if there is no e.cream setting,
the local solderpaste margin gets set. In your patch, if the setting is
missing, that doesn't happen.
Is this your intention?
-S
2018-03-27 5:06 GMT-07:00 Russell Oliver :
> This fixes the issue where the c
This fixes the issue where the cream setting is ignored when setting the
layer set for the pad, but the bug report also mentions that the rotation
for rectangles are ignored during import. They rectangle is niavely
converted to a polygon.
0001-Eagle-Import-Correct-layer-set-based-on-cream-settin.
8 matches
Mail list logo