[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2016-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Brendan Gallagher changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Co

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2016-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Brendan Gallagher changed: What|Removed |Added Status|Patch doesn't apply |Passed QA --- Comment #

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2016-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Brendan Gallagher changed: What|Removed |Added Status|Passed QA |Patch doesn't apply ---

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2016-02-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2016-02-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2016-02-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Tomás Cohen Arazi changed: What|Removed |Added Status|Pushed to Master|ASSIGNED

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2016-02-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You a

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2016-02-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #42 from Tomás Cohen Arazi --- Created attachment 48476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48476&action=edit Bug 15288: (QA followup) Tests still point to old 500.tt file This patch fixes t

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2016-01-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #41 from Marc Véron --- Created attachment 47464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47464&action=edit Bug 15288: (follow-up) Make t/db_dependent/Auth.t pass Changed test from (deleted) 500.

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2016-01-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #40 from Jonathan Druart --- Please fix t_db_dependent_Auth_t.The file errors/500.tt should be accessible (contains integers) (734) http://jenkins.koha-community.org/job/Koha_Master_D8/lastBuild/testReport/junit/%28root

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2016-01-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Brendan Gallagher changed: What|Removed |Added CC||bren...@bywatersolutions

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2016-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #38 from Aleisha Amohia --- *** Bug 14573 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bug

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2016-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #37 from Aleisha Amohia --- (In reply to Marcel de Rooy from comment #36) > [1] For more consistency, it would be nice to have the same reasons for an > error listed on opac and intranet. Perhaps from a shared include or

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2016-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #36 from Marcel de Rooy --- QA Comment: Thanks for the follow-up, Marc. Looks good to me now. No blockers, but maybe for future improvement: [1] For more consistency, it would be nice to have the same reasons for an error

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2016-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #34 from Marcel de Rooy --- Created attachment 46323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46323&action=edit Bug 15288: (followup) Remove obsolete *.tt files Follwoing files were not yet deleted

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2016-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #35 from Marcel de Rooy --- Created attachment 46324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46324&action=edit Bug 15288: (followup) Better wording for OPAC error page This patch changes the wordi

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2016-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are recei

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2016-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marcel de Rooy changed: What|Removed |Added Attachment #45425|0 |1 is obsolete|

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2016-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2016-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #46303|0 |1 is obso

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2016-01-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- Y

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2016-01-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marc Véron changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #30 f

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2016-01-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #29 from Marc Véron --- Created attachment 46303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46303&action=edit Bug 15288: (followup) Better wording for OPAC error page This patch changes the wording o

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2016-01-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #28 from Aleisha Amohia --- (In reply to Marc Véron from comment #27) > Hi Aleisha, as a native speaker, would you have time to do a follow up with > your wording? - That would be great. Have you had a look at my error me

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2015-12-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #27 from Marc Véron --- Hi Aleisha, as a native speaker, would you have time to do a follow up with your wording? - That would be great. -- You are receiving this mail because: You are watching all bug changes. _

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2015-12-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #26 from Aleisha Amohia --- (In reply to Héctor Eduardo Castro Avalos from comment #25) > Hi Marc you can use the paragraphs from bug 14573, like Aleisha proposes. > What do you think about it, Marcel and Aleisha? > > Reg

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2015-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Héctor Eduardo Castro Avalos changed: What|Removed |Added CC||aleishaamo...@

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2015-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community.

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2015-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #24 from Marc Véron --- Search for better wording for 400 / 402: See: https://tools.ietf.org/html/rfc2616#section-10.4 10.4.1 400 Bad Request The request could not be understood by the server due to malformed synta

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2015-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2015-12-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Signed Off -- You are rec

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2015-12-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #22 from Marc Véron --- What is now the status of this bug - can we switch back to Signed off? -- You are receiving this mail because: You are watching all bug changes. ___ Koh

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2015-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz ---

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2015-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #20 from Katrin Fischer --- I am not sure we should build in hooks for template modifications like this - we have a template system if people really really want to do this, with a fallback to the standard template, already

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2015-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 paxed changed: What|Removed |Added CC||pasi.kalli...@pttk.fi --- Comment #1

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2015-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #18 from Marc Véron --- (In reply to Marc Véron from comment #14) > (In reply to Jonathan Druart from comment #13) > > Could you ask on koha[-devel] or irc please? > > http://irc.koha-community.org/koha/2015-12-10#i_17663

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2015-12-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #17 from Katrin Fischer --- I think I don't quite understand since it would have never occurred to me to customize them (apart from CSS/Javascript). I have checked the code - they will still show a unique class for the dif

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2015-12-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #16 from Jonathan Druart --- (In reply to Katrin Fischer from comment #15) > Hm, I think we will always have changes happen that will have people rework > their customizations a bit. Changes make sense to me on first glan

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2015-12-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2015-12-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #14 from Marc Véron --- (In reply to Jonathan Druart from comment #13) > Could you ask on koha[-devel] or irc please? http://irc.koha-community.org/koha/2015-12-10#i_1766309 http://irc.koha-community.org/koha/2015-12-10#i

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2015-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Jonathan Druart changed: What|Removed |Added Status|Signed Off |In Discussion --- Comment

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2015-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2015-12-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Héctor Eduardo Castro Avalos changed: What|Removed |Added Status|Needs Signoff |Signed Off --

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2015-12-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Héctor Eduardo Castro Avalos changed: What|Removed |Added Attachment #45424|0 |1 is o

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2015-12-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Héctor Eduardo Castro Avalos changed: What|Removed |Added Attachment #45422|0 |1 is o

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2015-12-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #9 from Marc Véron --- Created attachment 45424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45424&action=edit Bug 15288: (followup) Remove obsolete *.tt files Follwoing files were not yet deleted: ko

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2015-12-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marc Véron changed: What|Removed |Added Attachment #45396|0 |1 is obsolete|

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2015-12-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marc Véron changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are recei

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2015-12-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marc Véron changed: What|Removed |Added Attachment #45357|0 |1 is obsolete|

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2015-12-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marc Véron changed: What|Removed |Added Summary|Staff error pages: Code |Error pages: Code

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2015-12-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #7 from Marc Véron --- Created attachment 45396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45396&action=edit Bug 15288: Error pages: Code duplication removal and better translatability This patch cha