[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #84548|0 |1 is obsolete|

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #84547|0 |1 is obsolete|

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #84546|0 |1 is obsolete|

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #84543|0 |1 is obsolete|

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #84545|0 |1 is obsolete|

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #84544|0 |1 is obsolete|

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #84550|0 |1 is obsolete|

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #84549|0 |1 is obsolete|

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #84551|0 |1 is obsolete|

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #84553|0 |1 is obsolete|

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #84552|0 |1 is obsolete|

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |ASSIGNED --- Comment #237

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Martha Fuerst changed: What|Removed |Added CC||mfue...@hmcpl.org --- Comme

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #239 from David Cook --- (In reply to Aleisha Amohia from comment #237) > I have a bit of time now, tackling this again. I'll try and fix the patches > so they are easier to work with. Awesome! Feel free to ping me when

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch comp

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What|Removed |Added Attachment #87979|0 |1 is obsolete|

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #241 from Aleisha Amohia --- Created attachment 117129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117129&action=edit Bug 15565: Place multiple holds on one record on staff client Test plan: 1) Appl

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #242 from Aleisha Amohia --- Created attachment 117130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117130&action=edit Bug 15565: Place multiple holds on one record on OPAC Test plan: 1) Apply patch

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Attachment #117128|0 |1 is obsolete|

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Attachment #117129|0 |1 is obsolete|

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Attachment #117130|0 |1 is obsolete|

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #246 fr

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #247 from David Cook --- If someone else signs this off, I could potentially QA it... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs m

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #248 from Martha Fuerst --- I've tried testing this using the Bywater sandboxes, but I can't get the pop-up to show up with the current test plan (step 6). When I set maxreserves to 3, I still don't get an alert when tryi

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #249 from David Cook --- (In reply to Martha Fuerst from comment #248) > I've tried testing this using the Bywater sandboxes, but I can't get the > pop-up to show up with the current test plan (step 6). When I set > maxre

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Attachment #117131|0 |1 is obsolete|

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Attachment #117132|0 |1 is obsolete|

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Attachment #117133|0 |1 is obsolete|

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #253 from David Cook --- Slightly updated test plan. Everything is working well in koha-testing-docker. Test plan: 0) git bz apply 15565 1) restart_all 2) Set the maxreserves system preference to 3 (from 50) 3) Set the f

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #254

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #255 from David Cook --- (In reply to David Cook from comment #254) > Going to set this back to "Needs Signoff" so it's clearer that someone other > than me should test it. But FYI it is passing the QA tools: root@kohad

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #120365|0 |1 is obsole

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #120367|0 |1 is obsole

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #120366|0 |1 is obsole

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #260 from David Cook --- (In reply to Victor Grousset/tuxayo from comment #259) > Is that expected that Holds allowed (total) isn't taken into account? > my $lowestvalue = min( $maxreserves, $remaining_holds_for_r

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added CC||cbran...@cdalibrary.org --- Co

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Jason Robb changed: What|Removed |Added CC||jr...@sekls.org -- You are re

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- C

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #223 from David Cook --- Would it be possible to get squash these patches? I think rebasing 13 patches where the first one is failing is going to be not a very pleasurable task. It looks like these are the files changed:

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #224 from David Cook --- (In reply to David Cook from comment #223) > Would it be possible to get squash these patches? I think rebasing 13 > patches where the first one is failing is going to be not a very pleasurable >

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #225 from David Cook --- Trying to find a base to merge these into easily so I can squash them and it's tough. 18.11, 19.05, 19.11... I never knew that Koha's holds code was changed so frequently. Aleisha, even if you d

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #226 from Jonathan Druart --- (In reply to David Cook from comment #225) > Aleisha, even if you don't squash them, could you let me know the parent > commit for these patches from your last rebase? See https://gist.gith

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #227 from David Cook --- (In reply to Jonathan Druart from comment #226) > (In reply to David Cook from comment #225) > > Aleisha, even if you don't squash them, could you let me know the parent > > commit for these patch

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #228 from David Cook --- It's actually quite interesting... I just tried `git log --before="2019-04-16"`, which looks good at a glance, but it doesn't include f668fecec3771b633068f89dcead2312471f9425. Yet, f668fecec3771b

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #229 from David Cook --- We can trust that commit 1b5635bebd75c418fdda68036e1e91f857cb1e4d was probably made and applied on May 30 2019 as it includes the release notes for 19.05.00. Aleisha posted a comment about patche

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #230 from Aleisha Amohia --- I don't have time to get to this right now and probably won't for a while, but it is on my list. -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #231 from David Cook --- (In reply to Aleisha Amohia from comment #230) > I don't have time to get to this right now and probably won't for a while, > but it is on my list. I'm happy to collaborate on it as it's increase

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #232 from David Cook --- I've put in some effort into rebasing these patches (and skipping many of them), but there's so many different changes that it's difficult to keep it all straight and the existing test plans are c

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #233 from David Cook --- On the plus side, rebasing actually exposed a bug in master! So yay! -- You are receiving this mail because: You are watching all bug changes. ___ Koh

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #234 from David Cook --- (Apologies if my above comments came across as rude or disrespectful. I'm not trying to criticize anyone. I'm just really keen to move forward, as I have a library that really wants multiple holds

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #235 from Jonathan Druart --- Patches applied correctly for me: % git log --before="2019-04-16" --oneline|head -n1 7e218b81e6 Bug 21953: (follow-up) Fix test count % git checkout -b bug_15565 7e218b81e6 % yes|git bz ap

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Niamh Walker-Headon changed: What|Removed |Added CC||niamh.walkerhea...@hse

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #236 from David Cook --- Thanks, Jonathan. I haven't looked at it yet, but I'm hoping I'll get the time to do so at some point. -- You are receiving this mail because: You are watching all bug changes. _

<    1   2   3   4