https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Martin Renvoize changed:
What|Removed |Added
Attachment #124059|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Martin Renvoize changed:
What|Removed |Added
Attachment #124058|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Martin Renvoize changed:
What|Removed |Added
Attachment #124057|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Martin Renvoize changed:
What|Removed |Added
Attachment #124056|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #57 from Katrin Fischer ---
(In reply to Marcel de Rooy from comment #52)
> (In reply to Katrin Fischer from comment #15)
> > We could also start supporting other ASCII characters like ;/% for subfield
> > codes..
>
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #56 from Jonathan Druart ---
> Refactor instead of staying in between?
The first step took 10 months to be pushed... It's not very motivating to
continue.
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #55 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #54)
> (In reply to Marcel de Rooy from comment #53)
> > I have the feeling here that we took the wrong road and now we are on it,
> > lets just
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #54 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #53)
> I have the feeling here that we took the wrong road and now we are on it,
> lets just continue following it.
Why? Can you detail?
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #53 from Marcel de Rooy ---
I have the feeling here that we took the wrong road and now we are on it, lets
just continue following it.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #52 from Marcel de Rooy ---
(In reply to Katrin Fischer from comment #15)
> We could also start supporting other ASCII characters like ;/% for subfield
> codes..
Does not sound like a good plan to me.
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #51 from Katrin Fischer ---
Note: only the first patch was from me - as that had been signed off, I felt I
could for the follow-ups.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #50 from Katrin Fischer ---
I've fixed a little conflict, signed the patches off, filed bug 28892 for the
search issue and... would like to throw them back into the queue.
I feel like we should still push these patches,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #49 from Katrin Fischer ---
Created attachment 124059
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124059=edit
Bug 20689: (follow-up) Correct scope of template variables
The removal of the s should
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #48 from Katrin Fischer ---
Created attachment 124058
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124058=edit
Bug 20689: (follow-up) Tiny typo fix
Signed-off-by: Katrin Fischer
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #47 from Katrin Fischer ---
Created attachment 124057
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124057=edit
Bug 20689: (follow-up) Make it possible to add capital letter subfields to item
search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Katrin Fischer changed:
What|Removed |Added
Attachment #87955|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Katrin Fischer changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Katrin Fischer changed:
What|Removed |Added
Blocks|28892 |
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Katrin Fischer changed:
What|Removed |Added
Blocks||28892
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #45 from Katrin Fischer ---
(In reply to Fridolin Somers from comment #40)
> (In reply to Nick Clemens from comment #39)
> > We need to figure a method to make the query case sensitive
>
> Looks like we can set COLLATE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #44 from Katrin Fischer ---
*** Bug 15384 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #43 from Katrin Fischer ---
*** Bug 13561 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #42 from Nick Clemens ---
(In reply to Owen Leonard from comment #41)
> (In reply to Nick Clemens from comment #39)
> > The problem seems to be in ExtractValue:
> ...
> > This returns both 'A' and 'a' subfields
>
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Owen Leonard changed:
What|Removed |Added
Version|unspecified |master
--- Comment #41 from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #40 from Fridolin SOMERS ---
(In reply to Nick Clemens from comment #39)
> We need to figure a method to make the query case sensitive
Looks like we can set COLLATE like :
select city_name from cities where
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #39 from Nick Clemens ---
The problem seems to be in ExtractValue:
SELECT
ExtractValue(metadata,
'//record/datafield[@tag="520"]/subfield[@code="A"]')
FROM biblio_metadata
WHERE
ExtractValue(metadata,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #38 from Owen Leonard ---
My patch doesn't address this issue:
> 2 - While other fields worked, setting 520$A and searching for a unique
> value in that field failed, not sure why
I was unable to reproduce the problem.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Owen Leonard changed:
What|Removed |Added
Status|Passed QA |Failed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #37 from Owen Leonard ---
Created attachment 88294
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88294=edit
Bug 20689: (follow-up) Correct scope of template variables
The removal of the s should have
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Owen Leonard changed:
What|Removed |Added
Status|Failed QA |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Nick Clemens changed:
What|Removed |Added
CC||n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #35 from Chris Cormack ---
Created attachment 87957
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87957=edit
Bug 20689 Follow - tiny typo fix
--
You are receiving this mail because:
You are watching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Chris Cormack changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Chris Cormack changed:
What|Removed |Added
Attachment #83827|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Chris Cormack changed:
What|Removed |Added
Attachment #83795|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #32 from Owen Leonard ---
(In reply to Jonathan Druart from comment #30)
> My concern it that they must be identical, but nothing indicate it (reading
> the code).
Similar to how the maxlength attribute on input fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #31 from Katrin Fischer ---
It gives us a nicer error message in the correct GUI language I guess?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #30 from Jonathan Druart
---
My concern it that they must be identical, but nothing indicate it (reading the
code).
In that case why the JS check when the patterns is enough?
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #29 from Owen Leonard ---
(In reply to Jonathan Druart from comment #28)
> Should not we have only 1 check?
The pattern attribute in the markup is a non-JS fallback to the jQuery
validation. It's not strictly necessary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #28 from Jonathan Druart
---
Owen, I see
pattern="[a-zA-Z0-9]+
and
jQuery.validator.addMethod("marcfield", function(value, element) {
return this.optional(element) || /^[0-9a-zA-Z]+$/.test(value);
},
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Fridolin SOMERS changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
José-Mario Monteiro-Santos changed:
What|Removed |Added
Attachment #83796|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #26 from Owen Leonard ---
Created attachment 83796
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83796=edit
Bug 20689: (follow-up) Make it possible to add capital letter subfields to item
search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Owen Leonard changed:
What|Removed |Added
Attachment #81150|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Owen Leonard changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #23 from M. Tompsett ---
Created attachment 81151
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81151=edit
Bug 20689: (follow-up) Make it possible to add capital letter subfields to item
search fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
M. Tompsett changed:
What|Removed |Added
Attachment #80712|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
M. Tompsett changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Owen Leonard changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Owen Leonard changed:
What|Removed |Added
Attachment #80713|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Martin Renvoize changed:
What|Removed |Added
Attachment #80539|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Martin Renvoize changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Martin Renvoize changed:
What|Removed |Added
Attachment #79779|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #18 from Martin Renvoize ---
(In reply to Marcel de Rooy from comment #14)
> Not sure if we should facilitate MARC deviation ?
I don't think this is too terrible a deviation, especially as it appears to
already be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #15 from Katrin Fischer ---
We could also start supporting other ASCII characters like ;/% for subfield
codes, that would give us more subfields for items to use - but it won't work
right now and the upper case letter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Katrin Fischer changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Katrin Fischer changed:
What|Removed |Added
Attachment #80538|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #12 from Owen Leonard ---
Created attachment 80538
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80538=edit
Bug 20689: (follow-up) Make it possible to add capital letter subfields to item
search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Owen Leonard changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Martin Renvoize changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #10 from Jonathan Druart
---
So maybe just a JS check for \d | \w ?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #9 from Katrin Fischer ---
We don't do this in the MARC frameworks and I think some odd characters would
be allowed in the standard... I've thought about it and tried to implement an
HTML filter, but didn't succeed. But
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #7 from Katrin Fischer ---
(In reply to Séverine Queune from comment #6)
> Great enhancement Katrin !
> Thanks a lot !
Thx for testing!
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Séverine Queune changed:
What|Removed |Added
CC||severine.que...@bulac.fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Séverine Queune changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Séverine Queune changed:
What|Removed |Added
Attachment #79554|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Katrin Fischer changed:
What|Removed |Added
Attachment #77640|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Katrin Fischer changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Katrin Fischer changed:
What|Removed |Added
Patch complexity|--- |Small patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
--- Comment #3 from Katrin Fischer ---
Created attachment 77640
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77640=edit
Bug 20689: Replace marc (sub)field pull downs with input fields on item search
fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689
Katrin Fischer changed:
What|Removed |Added
Summary|Make it possible to add |Make it possible to add
78 matches
Mail list logo
