Re: BUG: sleeping function called from invalid context at mm/slub.c:793

2011-01-11 Thread Avi Kivity
On 01/10/2011 09:31 PM, Kirill A. Shutemov wrote: On Mon, Jan 10, 2011 at 10:52:05AM -0600, Christoph Lameter wrote: > > On Mon, 10 Jan 2011, Kirill A. Shutemov wrote: > > > Every time I run qemu with KVM enabled I get this in dmesg: > > > > [ 182.878328] BUG: sleeping function called from

Re: [PATCH 2/4] KVM: Simplify exit path on decode failure

2011-01-11 Thread Avi Kivity
On 01/10/2011 07:17 PM, Jan Kiszka wrote: Am 04.01.2011 14:14, Avi Kivity wrote: > 'goto done' leads to a maze of checks and actions, all pointless. Bail > out immediately if we can't decode. > > Signed-off-by: Avi Kivity > --- > arch/x86/kvm/x86.c |2 +- > 1 files changed, 1 insertio

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-11 Thread Markus Armbruster
Jan Kiszka writes: > Am 10.01.2011 22:06, Jan Kiszka wrote: >>> kvmclock should be created with >>> kvm_state as a parameter and kvm_vm_ioctl() is passed the stored >>> reference. Taking a global reference to kvm_state in machine_init is >>> not a bad thing, obviously the machine initializatio

Re: [GIT PULL] KVM updates for the 2.6.38 merge window

2011-01-11 Thread Avi Kivity
On 01/10/2011 09:31 PM, Linus Torvalds wrote: On Mon, Jan 10, 2011 at 1:21 AM, Avi Kivity wrote: > > - asynchronous page faults, which allow a guest to continue processing > interrupts even when its memory is being paged in; in the case of a Linux > 2.6.38+ guest, it will receive a notificati

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Avi Kivity
On 01/10/2011 10:11 PM, Anthony Liguori wrote: On 01/08/2011 02:47 AM, Jan Kiszka wrote: OK, but I don't want to argue about the ioeventfd API. So let's put this case aside. :) I often reply too quickly without explaining myself. Let me use ioeventfd as an example to highlight why KVMState i

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Avi Kivity
On 01/10/2011 10:23 PM, Anthony Liguori wrote: I don't see how ioapic, pit, or pic have a system scope. They are not bound to any CPU like the APIC which you may have in mind. And none of the above interact with KVM. They're implemented by kvm. What deeper interaction do you have in mind?

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-11 Thread Gerd Hoffmann
Hi, Actually, there is already a channel to pass pointers to qdev devices: the pointer property hack. I'm not sure we should contribute to its user base or take the chance for a cleanup, but we are not alone with this requirement. Point below remains valid, though. It is considered bad/hacki

<    1   2