Re: [PATCH][STABLE-0.12] qemu-kvm: Disable cpu_set command to avoid segfault

2010-01-18 Thread Gleb Natapov
On Mon, Jan 18, 2010 at 02:08:40PM +0200, Avi Kivity wrote: > On 01/18/2010 02:03 PM, Gleb Natapov wrote: > > > >>We should certainly fix it, but I doubt it's a good fit for the stable tree. > >> > >>Gleb, what would it take? > >I have no idea about what causes segfault, so can't really tell how >

Re: [PATCH][STABLE-0.12] qemu-kvm: Disable cpu_set command to avoid segfault

2010-01-18 Thread Avi Kivity
On 01/18/2010 02:03 PM, Gleb Natapov wrote: We should certainly fix it, but I doubt it's a good fit for the stable tree. Gleb, what would it take? I have no idea about what causes segfault, so can't really tell how invasive fix would be, but fixing segfault is not enough we will have to

Re: [PATCH][STABLE-0.12] qemu-kvm: Disable cpu_set command to avoid segfault

2010-01-18 Thread Gleb Natapov
On Mon, Jan 18, 2010 at 01:57:04PM +0200, Avi Kivity wrote: > On 01/18/2010 01:49 PM, Daniel P. Berrange wrote: > > > >>Daniel, how is libvirt going to react to this? > >At this precise point in time it won't react since its not using it, but > >in a week's time when we have finished the libvirt co

Re: [PATCH][STABLE-0.12] qemu-kvm: Disable cpu_set command to avoid segfault

2010-01-18 Thread Avi Kivity
On 01/18/2010 01:49 PM, Daniel P. Berrange wrote: Daniel, how is libvirt going to react to this? At this precise point in time it won't react since its not using it, but in a week's time when we have finished the libvirt code to use 'cpu_set' it'll be less happy ! Can't we actually fix

Re: [PATCH][STABLE-0.12] qemu-kvm: Disable cpu_set command to avoid segfault

2010-01-18 Thread Daniel P. Berrange
On Mon, Jan 18, 2010 at 01:34:21PM +0200, Avi Kivity wrote: > On 01/11/2010 07:27 PM, Ryota Ozaki wrote: > >CPU hotplug feature is lost in this version. Even worse > >cpu_set qemu command may cause segfault. > > > >This patch fix the problem by just disabling it. It is > >enough for the stable bran

Re: [PATCH][STABLE-0.12] qemu-kvm: Disable cpu_set command to avoid segfault

2010-01-18 Thread Avi Kivity
On 01/11/2010 07:27 PM, Ryota Ozaki wrote: CPU hotplug feature is lost in this version. Even worse cpu_set qemu command may cause segfault. This patch fix the problem by just disabling it. It is enough for the stable branch. Signed-off-by: Ryota Ozaki Cc: Gleb Natapov --- monitor.c |4 +++

[PATCH][STABLE-0.12] qemu-kvm: Disable cpu_set command to avoid segfault

2010-01-11 Thread Ryota Ozaki
CPU hotplug feature is lost in this version. Even worse cpu_set qemu command may cause segfault. This patch fix the problem by just disabling it. It is enough for the stable branch. Signed-off-by: Ryota Ozaki Cc: Gleb Natapov --- monitor.c |4 +++- 1 files changed, 3 insertions(+), 1 delet