Re: [PATCH 2/2] KVM: Fix kvm_free_physmem_slot memory leak.

2008-11-07 Thread François Diakhate
On Thu, Nov 6, 2008 at 4:14 PM, Avi Kivity [EMAIL PROTECTED] wrote: What happens here if the both free and dont have nonzero, differnt -userspace_addr values? Is is even possible? I dont think it can happen in the current kvm code, but I put that test in order to respect the function behaviour

Re: [PATCH 2/2] KVM: Fix kvm_free_physmem_slot memory leak.

2008-10-28 Thread François Diakhate
[Updated the patch taking your comments into account] Make sure that kvm_free_physmem_slot also frees the VM memory if it was allocated by the kernel. Signed-off-by: François Diakhaté [EMAIL PROTECTED] --- arch/x86/kvm/x86.c | 10 +- virt/kvm/kvm_main.c | 18 ++ 2

Re: [PATCH 2/2] KVM: Fix kvm_free_physmem_slot memory leak.

2008-10-28 Thread François Diakhate
[Sorry, I realized I forgot to check style, here is the fixed patch] Make sure that kvm_free_physmem_slot also frees the VM memory if it was allocated by the kernel. Signed-off-by: François Diakhaté [EMAIL PROTECTED] --- arch/x86/kvm/x86.c | 10 +- virt/kvm/kvm_main.c | 19