Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2011-01-03 Thread Luiz Capitulino
On Mon, 20 Dec 2010 14:09:05 +0800 Lai Jiangshan wrote: > On 12/17/2010 11:25 PM, Avi Kivity wrote: > > On 12/17/2010 01:22 PM, Luiz Capitulino wrote: > >> > > >> > I think Avi's suggest is better, and I will use > >> > "inject-nmi" (without cpu-index argument) to send NMI to all cpus, > >> >

Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-19 Thread Lai Jiangshan
On 12/17/2010 11:25 PM, Avi Kivity wrote: > On 12/17/2010 01:22 PM, Luiz Capitulino wrote: >> > >> > I think Avi's suggest is better, and I will use >> > "inject-nmi" (without cpu-index argument) to send NMI to all cpus, >> > like physical GUI. If some one want to send NMI to a set of cpus, >> >

Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-17 Thread Avi Kivity
On 12/17/2010 01:22 PM, Luiz Capitulino wrote: > > I think Avi's suggest is better, and I will use > "inject-nmi" (without cpu-index argument) to send NMI to all cpus, > like physical GUI. If some one want to send NMI to a set of cpus, > he can use "inject-nmi" multiple times. His suggestion

Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-17 Thread Luiz Capitulino
On Fri, 17 Dec 2010 14:20:15 +0800 Lai Jiangshan wrote: > On 12/16/2010 09:17 PM, Luiz Capitulino wrote: > > On Thu, 16 Dec 2010 15:11:50 +0200 > > Avi Kivity wrote: > >> > >> Why have an argument at all? Always nmi to all cpus. > > > > I think Avi's suggest is better, and I will use > "injec

Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-16 Thread Lai Jiangshan
On 12/16/2010 09:17 PM, Luiz Capitulino wrote: > On Thu, 16 Dec 2010 15:11:50 +0200 > Avi Kivity wrote: >> >> Why have an argument at all? Always nmi to all cpus. > I think Avi's suggest is better, and I will use "inject-nmi" (without cpu-index argument) to send NMI to all cpus, like physical G

Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-16 Thread Luiz Capitulino
On Thu, 16 Dec 2010 15:11:50 +0200 Avi Kivity wrote: > On 12/16/2010 03:09 PM, Luiz Capitulino wrote: > > On Thu, 16 Dec 2010 14:50:08 +0200 > > Avi Kivity wrote: > > > > > On 12/16/2010 01:47 PM, Markus Armbruster wrote: > > > > > > > > > > This has the feature of injecting the nmi in ju

Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-16 Thread Avi Kivity
On 12/16/2010 03:09 PM, Luiz Capitulino wrote: On Thu, 16 Dec 2010 14:50:08 +0200 Avi Kivity wrote: > On 12/16/2010 01:47 PM, Markus Armbruster wrote: > > > > > > This has the feature of injecting the nmi in just some cpus, although I'm > > > not sure this is going to be desired/use

Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-16 Thread Luiz Capitulino
On Thu, 16 Dec 2010 14:50:08 +0200 Avi Kivity wrote: > On 12/16/2010 01:47 PM, Markus Armbruster wrote: > > > > > > This has the feature of injecting the nmi in just some cpus, although I'm > > > not sure this is going to be desired/useful. > > > > Use case for NMI-ing a subset of the CPUs? > >

Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-16 Thread Avi Kivity
On 12/16/2010 01:47 PM, Markus Armbruster wrote: > > This has the feature of injecting the nmi in just some cpus, although I'm > not sure this is going to be desired/useful. Use case for NMI-ing a subset of the CPUs? Heck, use case for anything else but "NMI all"? Exactly. -- error compili

Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-16 Thread Markus Armbruster
Luiz Capitulino writes: > On Thu, 16 Dec 2010 11:03:38 +0200 > Avi Kivity wrote: > >> On 12/15/2010 08:00 PM, Luiz Capitulino wrote: >> > > > >> > > > Looks like a GUI feature to me, >> > > >> > > Really? Can't see how you can build "NMI to all CPUs" from "NMI this >> > > CPU". Or am I mi

Re: [PATCH v3] qemu,qmp: convert do_inject_nmi() to QObject, QError

2010-12-16 Thread Luiz Capitulino
On Thu, 16 Dec 2010 12:51:14 +0200 Avi Kivity wrote: > On 12/16/2010 12:48 PM, Luiz Capitulino wrote: > > Ok, I didn't know that, but I had another idea: the command could accept > > either a single cpu index or a list: > > > > > >{ "execute": "inject-nmi", "arguments": { "cpus": 2 } } > > >

Re: [PATCH v3] qemu,qmp: convert do_inject_nmi() to QObject, QError

2010-12-16 Thread Avi Kivity
On 12/16/2010 12:48 PM, Luiz Capitulino wrote: Ok, I didn't know that, but I had another idea: the command could accept either a single cpu index or a list: { "execute": "inject-nmi", "arguments": { "cpus": 2 } } { "execute": "inject-nmi", "arguments": { "cpus": [1, 2, 3, 4] } } This ha

Re: [PATCH v3] qemu,qmp: convert do_inject_nmi() to QObject, QError

2010-12-16 Thread Luiz Capitulino
On Thu, 16 Dec 2010 11:03:38 +0200 Avi Kivity wrote: > On 12/15/2010 08:00 PM, Luiz Capitulino wrote: > > > > > > > > Looks like a GUI feature to me, > > > > > > Really? Can't see how you can build "NMI to all CPUs" from "NMI this > > > CPU". Or am I misunderstanding you? > > > > I guess s

Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-16 Thread Markus Armbruster
Luiz Capitulino writes: > On Wed, 15 Dec 2010 18:45:09 +0100 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > On Wed, 15 Dec 2010 19:18:32 +0200 >> > Avi Kivity wrote: [...] >> >> I'd like to see cpu-index made optional; if not present, nmi all cpus >> >> (that's what the nmi

Re: [PATCH v3] qemu,qmp: convert do_inject_nmi() to QObject, QError

2010-12-16 Thread Avi Kivity
On 12/15/2010 08:00 PM, Luiz Capitulino wrote: > > > > Looks like a GUI feature to me, > > Really? Can't see how you can build "NMI to all CPUs" from "NMI this > CPU". Or am I misunderstanding you? I guess so. Avi referred to 'nmi button on many machines', I assumed he meant a virtual mac

Re: [PATCH v3] qemu,qmp: convert do_inject_nmi() to QObject, QError

2010-12-15 Thread Luiz Capitulino
On Wed, 15 Dec 2010 18:45:09 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Wed, 15 Dec 2010 19:18:32 +0200 > > Avi Kivity wrote: > > > >> On 12/15/2010 07:09 PM, Luiz Capitulino wrote: > >> > On Wed, 15 Dec 2010 17:49:27 +0800 > >> > Lai Jiangshan wrote: > >> > > >> > > >

Re: [Qemu-devel] [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-15 Thread Luiz Capitulino
On Wed, 15 Dec 2010 18:39:07 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Wed, 15 Dec 2010 11:49:23 +0100 > > Markus Armbruster wrote: > > > >> Lai Jiangshan writes: > >> > >> > Convert do_inject_nmi() to QObject, QError, we need to use it(via > >> > libvirt). > >> > >

Re: [PATCH v3] qemu,qmp: convert do_inject_nmi() to QObject, QError

2010-12-15 Thread Markus Armbruster
Luiz Capitulino writes: > On Wed, 15 Dec 2010 19:18:32 +0200 > Avi Kivity wrote: > >> On 12/15/2010 07:09 PM, Luiz Capitulino wrote: >> > On Wed, 15 Dec 2010 17:49:27 +0800 >> > Lai Jiangshan wrote: >> > >> > > >> > > Convert do_inject_nmi() to QObject, QError, we need to use it(via >> > > li

Re: [Qemu-devel] [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-15 Thread Markus Armbruster
Luiz Capitulino writes: > On Wed, 15 Dec 2010 11:49:23 +0100 > Markus Armbruster wrote: > >> Lai Jiangshan writes: >> >> > Convert do_inject_nmi() to QObject, QError, we need to use it(via libvirt). >> > >> > changed from v1 >> > Add document. >> > Add error handling when the cpu index is inva

Re: [PATCH v3] qemu,qmp: convert do_inject_nmi() to QObject, QError

2010-12-15 Thread Luiz Capitulino
On Wed, 15 Dec 2010 19:18:32 +0200 Avi Kivity wrote: > On 12/15/2010 07:09 PM, Luiz Capitulino wrote: > > On Wed, 15 Dec 2010 17:49:27 +0800 > > Lai Jiangshan wrote: > > > > > > > > Convert do_inject_nmi() to QObject, QError, we need to use it(via > > > libvirt). > > > > > > changed from v1 >

Re: [PATCH v3] qemu,qmp: convert do_inject_nmi() to QObject, QError

2010-12-15 Thread Avi Kivity
On 12/15/2010 07:09 PM, Luiz Capitulino wrote: On Wed, 15 Dec 2010 17:49:27 +0800 Lai Jiangshan wrote: > > Convert do_inject_nmi() to QObject, QError, we need to use it(via libvirt). > > changed from v1 > Add document. > Add error handling when the cpu index is invalid. > > changed from v2

Re: [Qemu-devel] [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-15 Thread Luiz Capitulino
On Wed, 15 Dec 2010 11:49:23 +0100 Markus Armbruster wrote: > Lai Jiangshan writes: > > > Convert do_inject_nmi() to QObject, QError, we need to use it(via libvirt). > > > > changed from v1 > > Add document. > > Add error handling when the cpu index is invalid. > > > > changed from v2 > > use Q

Re: [PATCH v3] qemu,qmp: convert do_inject_nmi() to QObject, QError

2010-12-15 Thread Luiz Capitulino
On Wed, 15 Dec 2010 17:49:27 +0800 Lai Jiangshan wrote: > > Convert do_inject_nmi() to QObject, QError, we need to use it(via libvirt). > > changed from v1 > Add document. > Add error handling when the cpu index is invalid. > > changed from v2 > use QERR_INVALID_PARAMETER_VALUE as Markus sugge

Re: [Qemu-devel] [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-15 Thread Markus Armbruster
Lai Jiangshan writes: > Convert do_inject_nmi() to QObject, QError, we need to use it(via libvirt). > > changed from v1 > Add document. > Add error handling when the cpu index is invalid. > > changed from v2 > use QERR_INVALID_PARAMETER_VALUE as Markus suggest. > > Signed-off-by: Lai Jiangshan

[PATCH v3] qemu,qmp: convert do_inject_nmi() to QObject, QError

2010-12-15 Thread Lai Jiangshan
Convert do_inject_nmi() to QObject, QError, we need to use it(via libvirt). changed from v1 Add document. Add error handling when the cpu index is invalid. changed from v2 use QERR_INVALID_PARAMETER_VALUE as Markus suggest. Signed-off-by: Lai Jiangshan --- diff --git a/hmp-commands.hx b/hmp-c