[PATCH 06/39] KVM: fix i8259 reset irq acking

2008-09-25 Thread Avi Kivity
From: Marcelo Tosatti <[EMAIL PROTECTED]> The irq ack during pic reset has three problems: - Ignores slave/master PIC, using gsi 0-8 for both. - Generates an ACK even if the APIC is in control. - Depends upon IMR being clear, which is broken if the irq was masked at the time it was generated. Th

Re: KVM: fix i8259 reset irq acking

2008-08-17 Thread Avi Kivity
Avi Kivity wrote: > Avi Kivity wrote: >> Marcelo Tosatti wrote: >>> On Wed, Aug 13, 2008 at 01:40:34PM +0300, Avi Kivity wrote: >>> Marcelo Tosatti wrote: > The irq ack during pic reset has three problems: > > - Ignores slave/master PIC, using gsi 0-8 for both. > - Ge

Re: KVM: fix i8259 reset irq acking

2008-08-17 Thread Avi Kivity
Avi Kivity wrote: Marcelo Tosatti wrote: On Wed, Aug 13, 2008 at 01:40:34PM +0300, Avi Kivity wrote: Marcelo Tosatti wrote: The irq ack during pic reset has three problems: - Ignores slave/master PIC, using gsi 0-8 for both. - Generates an ACK even if the APIC is in control. - Depends u

Re: KVM: fix i8259 reset irq acking

2008-08-16 Thread Avi Kivity
Marcelo Tosatti wrote: On Wed, Aug 13, 2008 at 01:40:34PM +0300, Avi Kivity wrote: Marcelo Tosatti wrote: The irq ack during pic reset has three problems: - Ignores slave/master PIC, using gsi 0-8 for both. - Generates an ACK even if the APIC is in control. - Depends upon IMR being cle

Re: KVM: fix i8259 reset irq acking

2008-08-14 Thread Marcelo Tosatti
On Wed, Aug 13, 2008 at 01:40:34PM +0300, Avi Kivity wrote: > Marcelo Tosatti wrote: >> The irq ack during pic reset has three problems: >> >> - Ignores slave/master PIC, using gsi 0-8 for both. >> - Generates an ACK even if the APIC is in control. >> - Depends upon IMR being clear, which is broken

Re: KVM: fix i8259 reset irq acking

2008-08-13 Thread Avi Kivity
Marcelo Tosatti wrote: The irq ack during pic reset has three problems: - Ignores slave/master PIC, using gsi 0-8 for both. - Generates an ACK even if the APIC is in control. - Depends upon IMR being clear, which is broken if the irq was masked at the time it was generated. The last one cause

KVM: fix i8259 reset irq acking

2008-07-31 Thread Marcelo Tosatti
The irq ack during pic reset has three problems: - Ignores slave/master PIC, using gsi 0-8 for both. - Generates an ACK even if the APIC is in control. - Depends upon IMR being clear, which is broken if the irq was masked at the time it was generated. The last one causes the BIOS to hang after