Re: [PATCH] KVM: x86: reset RVI upon system reset

2014-12-15 Thread Paolo Bonzini
On 15/12/2014 02:52, Zhang Haoyu wrote: > Yes, I find it, > but what's the relationship between > https://git.kernel.org/cgit/virt/kvm/kvm.git/log/?h=next This is branch "next". > and > https://git.kernel.org/cgit/virt/kvm/kvm.git/log/ ? This is branch "master". Paolo -- To unsubscribe fro

Re: [PATCH] KVM: x86: reset RVI upon system reset

2014-12-14 Thread Zhang Haoyu
On 2014-12-12 18:27:14, Paolo Bonzini wrote: > > >On 12/12/2014 10:56, Zhang Haoyu wrote: >> Strange, I didn't find this commit in >> https://git.kernel.org/cgit/virt/kvm/kvm.git/log/ >> but found it from the repository downloaded by git clone >> git://git.kernel.org/pub/scm/virt/kvm/kvm.git > >

Re: [PATCH] KVM: x86: reset RVI upon system reset

2014-12-12 Thread Paolo Bonzini
On 12/12/2014 10:56, Zhang Haoyu wrote: > Strange, I didn't find this commit in > https://git.kernel.org/cgit/virt/kvm/kvm.git/log/ > but found it from the repository downloaded by git clone > git://git.kernel.org/pub/scm/virt/kvm/kvm.git It's here: https://git.kernel.org/cgit/virt/kvm/kvm.g

RE: [PATCH] KVM: x86: reset RVI upon system reset

2014-12-12 Thread Zhang Haoyu
On 2014-12-11 19:06:33, Zhang, Yang Z wrote: >Zhang Haoyu wrote on 2014-12-11: >> Then? > >It's already in upstream KVM > Strange, I didn't find this commit in https://git.kernel.org/cgit/virt/kvm/kvm.git/log/ but found it from the repository downloaded by git clone git://git.kernel.org/pub/scm/

Re: [PATCH] KVM: x86: reset RVI upon system reset

2014-12-11 Thread Paolo Bonzini
On 11/12/2014 09:15, Zhang Haoyu wrote: >> >> if (is_guest_mode(vcpu) && nested_exit_on_intr(vcpu)) >> >> return; >> >> if (!is_guest_mode(vcpu)) { >> >> vmx_set_rvi(max_irr); >> >> return; >> >> } >> >> >> >>

RE: [PATCH] KVM: x86: reset RVI upon system reset

2014-12-11 Thread Zhang, Yang Z
Zhang Haoyu wrote on 2014-12-11: > Then? It's already in upstream KVM commit 4114c27d450bef228be9c7b0c40a888e18a3a636 Author: Wei Wang Date: Wed Nov 5 10:53:43 2014 +0800 KVM: x86: reset RVI upon system reset A bug was reported as follows: when running Windows 7 32-bit guests on

RE: [PATCH] KVM: x86: reset RVI upon system reset

2014-12-11 Thread Zhang Haoyu
Then? >> On 05/11/2014 10:02, Chen, Tiejun wrote: I think both are ok. If we zero max_irr in vmx_set_rvi(), we still need this check: if ((is_guest_mode(vcpu) && nested_exit_on_intr(vcpu)) || max_irr == -1) >>> >>> No, I don't think we need to add this. >> >> You don't,

RE: [PATCH] KVM: x86: reset RVI upon system reset

2014-11-05 Thread Zhang, Yang Z
Paolo Bonzini wrote on 2014-11-05: > > > On 05/11/2014 10:02, Chen, Tiejun wrote: >>> I think both are ok. >>> If we zero max_irr in vmx_set_rvi(), we still need this check: >>> if ((is_guest_mode(vcpu) && nested_exit_on_intr(vcpu)) || max_irr >>> == >>> -1) >> >> No, I don't think we need to ad

Re: [PATCH] KVM: x86: reset RVI upon system reset

2014-11-05 Thread Paolo Bonzini
On 05/11/2014 10:02, Chen, Tiejun wrote: >> I think both are ok. >> If we zero max_irr in vmx_set_rvi(), we still need this check: >> if ((is_guest_mode(vcpu) && nested_exit_on_intr(vcpu)) || max_irr == -1) > > No, I don't think we need to add this. You don't, because the code will look like:

Re: [PATCH] KVM: x86: reset RVI upon system reset

2014-11-05 Thread Chen, Tiejun
On 2014/11/5 16:50, Wang, Wei W wrote: On 05/11/2014 4:07, Tiejun Chen wrote: A bug was reported as follows: when running Windows 7 32-bit guests on qemu-kvm, sometimes the guests run into blue screen during reboot. The problem was that a guest's RVI was not cleared when it rebooted. This patch

RE: [PATCH] KVM: x86: reset RVI upon system reset

2014-11-05 Thread Wang, Wei W
On 05/11/2014 4:07, Tiejun Chen wrote: > >>> A bug was reported as follows: when running Windows 7 32-bit guests > >>> on qemu-kvm, sometimes the guests run into blue screen during > >>> reboot. The problem was that a guest's RVI was not cleared when it > >>> rebooted. This > >> patch has fixed the

Re: [PATCH] KVM: x86: reset RVI upon system reset

2014-11-05 Thread Chen, Tiejun
On 2014/11/5 15:39, Wang, Wei W wrote: On 05/11/2014 2:14, Tiejun Chen wrote: A bug was reported as follows: when running Windows 7 32-bit guests on qemu-kvm, sometimes the guests run into blue screen during reboot. The problem was that a guest's RVI was not cleared when it rebooted. This patch

RE: [PATCH] KVM: x86: reset RVI upon system reset

2014-11-04 Thread Wang, Wei W
On 05/11/2014 2:14, Tiejun Chen wrote: > > A bug was reported as follows: when running Windows 7 32-bit guests on > > qemu-kvm, sometimes the guests run into blue screen during reboot. The > > problem was that a guest's RVI was not cleared when it rebooted. This > patch has fixed the problem. > > >

Re: [PATCH] KVM: x86: reset RVI upon system reset

2014-11-04 Thread Chen, Tiejun
On 2014/11/5 10:53, Wei Wang wrote: A bug was reported as follows: when running Windows 7 32-bit guests on qemu-kvm, sometimes the guests run into blue screen during reboot. The problem was that a guest's RVI was not cleared when it rebooted. This patch has fixed the problem. Signed-off-by: Wei