Re: [PATCH retry] arch/ia64/kvm/kvm-ia64.c: Add local_irq_restore in error handling code

2008-07-26 Thread Avi Kivity
Julia Lawall wrote: From: Julia Lawall [EMAIL PROTECTED] There is a call to local_irq_restore in the normal exit case, so it would seem that there should be one on an error return as well. The semantic patch that finds this problem is as follows: (http://www.emn.fr/x-info/coccinelle/)

Re: [PATCH retry] arch/ia64/kvm/kvm-ia64.c: Add local_irq_restore in error handling code

2008-07-22 Thread Matthew Wilcox
On Tue, Jul 22, 2008 at 09:38:18PM +0200, Julia Lawall wrote: There is a call to local_irq_restore in the normal exit case, so it would seem that there should be one on an error return as well. Patch looks good to me: Reviewed-by: Matthew Wilcox [EMAIL PROTECTED] -- Intel are signing my

RE: [PATCH retry] arch/ia64/kvm/kvm-ia64.c: Add local_irq_restore in error handling code

2008-07-22 Thread Zhang, Xiantao
Julia Lawall wrote: From: Julia Lawall [EMAIL PROTECTED] There is a call to local_irq_restore in the normal exit case, so it would seem that there should be one on an error return as well. The semantic patch that finds this problem is as follows: (http://www.emn.fr/x-info/coccinelle/)