Re: [PATCH] virtio: Define and use per-architecture pfn shift constants

2008-11-06 Thread Anthony Liguori
Hollis Blanchard wrote: # HG changeset patch # User Hollis Blanchard [EMAIL PROTECTED] # Date 1225946980 21600 # Node ID f58566dfe20e841604e1377ff41e9e0501c1cf18 # Parent f776b102380286dd173a3b89f7dc976140812517 virtio: Define and use per-architecture pfn shift constants Both sides of the

Re: [PATCH] virtio: Define and use per-architecture pfn shift constants

2008-11-06 Thread Hollis Blanchard
On Thu, 2008-11-06 at 10:49 +, Mark McLoughlin wrote: On Wed, 2008-11-05 at 22:49 -0600, Hollis Blanchard wrote: - info-queue = kzalloc(PAGE_ALIGN(vring_size(num,PAGE_SIZE)), GFP_KERNEL); + vring_bytes = PAGE_ALIGN(vring_size(num, VRING_PAGE_SIZE)); + info-queue =

Re: [PATCH] virtio: Define and use per-architecture pfn shift constants

2008-11-06 Thread Anthony Liguori
Hollis Blanchard wrote: On Thu, 2008-11-06 at 10:49 +, Mark McLoughlin wrote: But actually, why do we align the size anyway? I assume it's so that the last page in the ring (containing the used fields) could be safely mapped into another guest's address space, without fear of

Re: [PATCH] virtio: Define and use per-architecture pfn shift constants

2008-11-06 Thread Anthony Liguori
Hollis Blanchard wrote: # HG changeset patch # User Hollis Blanchard [EMAIL PROTECTED] # Date 1225946980 21600 # Node ID f58566dfe20e841604e1377ff41e9e0501c1cf18 # Parent f776b102380286dd173a3b89f7dc976140812517 virtio: Define and use per-architecture pfn shift constants Both sides of the