Re: [PATCH v9 07/11] arm/arm64: vgic: Implement KVM_DEV_ARM_VGIC_GRP_LEVEL_INFO ioctl

2016-11-29 Thread Peter Maydell
On 29 November 2016 at 21:09, Christoffer Dall wrote: > Actually, I'm not sure what the semantics of the line level ioctl should > be for edge-triggered interrupts? My inclination is that it shouldn't > have any effect at this point, but that would mean that at this point we > should only set the

Unable to use perf in VM

2016-11-29 Thread Itaru Kitayama
Hi, In a VM (virsh controlled, KVM acceleration enabled) on a recent kvmarm kernel host, I find I am unable to use perf to obtain performance statistics for a complex task like kernel build. (I've verified this is seen with a Fedora 25 VM and host combination as well) APM folks CC'ed think this m

Re: [PATCH v9 07/11] arm/arm64: vgic: Implement KVM_DEV_ARM_VGIC_GRP_LEVEL_INFO ioctl

2016-11-29 Thread Christoffer Dall
On Tue, Nov 29, 2016 at 10:06:27PM +0530, Vijay Kilari wrote: > On Tue, Nov 29, 2016 at 1:20 AM, Christoffer Dall > wrote: > > On Wed, Nov 23, 2016 at 06:31:54PM +0530, vijay.kil...@gmail.com wrote: > >> From: Vijaya Kumar K > >> > >> Userspace requires to store and restore of line_level for > >>

Re: [PATCH] KVM: arm/arm64: Access CNTHCTL_EL2 bit fields correctly

2016-11-29 Thread Jintack Lim
On Tue, Nov 29, 2016 at 11:53 AM, Suzuki K Poulose wrote: > On 29/11/16 09:36, Marc Zyngier wrote: >> >> On 29/11/16 03:28, Jintack Lim wrote: >>> >>> On Mon, Nov 28, 2016 at 1:39 PM, Marc Zyngier >>> wrote: On 28/11/16 17:43, Marc Zyngier wrote: >>> >>> This looks much cleaner than my

Re: [PATCH V5 02/10] ras: acpi/apei: cper: generic error data entry v3 per ACPI 6.1

2016-11-29 Thread Baicar, Tyler
On 11/29/2016 4:29 AM, Shiju Jose wrote: @@ -451,12 +484,12 @@ void cper_estatus_print(const char *pfx, printk("%s""event severity: %s\n", pfx, cper_severity_str(severity)); data_len = estatus->data_length; gdata = (struct acpi_hest_generic_data *)(estatus + 1); +

Re: [PATCH] KVM: arm/arm64: Access CNTHCTL_EL2 bit fields correctly

2016-11-29 Thread Suzuki K Poulose
On 29/11/16 09:36, Marc Zyngier wrote: On 29/11/16 03:28, Jintack Lim wrote: On Mon, Nov 28, 2016 at 1:39 PM, Marc Zyngier wrote: On 28/11/16 17:43, Marc Zyngier wrote: This looks much cleaner than my patch. While we are at it, is it worth to consider that we just need to set those bits once

Re: [PATCH v9 07/11] arm/arm64: vgic: Implement KVM_DEV_ARM_VGIC_GRP_LEVEL_INFO ioctl

2016-11-29 Thread Vijay Kilari
On Tue, Nov 29, 2016 at 1:20 AM, Christoffer Dall wrote: > On Wed, Nov 23, 2016 at 06:31:54PM +0530, vijay.kil...@gmail.com wrote: >> From: Vijaya Kumar K >> >> Userspace requires to store and restore of line_level for >> level triggered interrupts using ioctl KVM_DEV_ARM_VGIC_GRP_LEVEL_INFO. >>

Re: [PATCH V5 03/10] efi: parse ARMv8 processor error

2016-11-29 Thread Baicar, Tyler
Hello James, On 11/25/2016 11:23 AM, James Morse wrote: Hi Tyler, On 21/11/16 22:35, Tyler Baicar wrote: Add support for ARMv8 Common Platform Error Record (CPER). UEFI 2.6 specification adds support for ARMv8 specific processor error information to be reported as part of the CPER records. Thi

RE: [PATCH V5 02/10] ras: acpi/apei: cper: generic error data entry v3 per ACPI 6.1

2016-11-29 Thread Shiju Jose
Hi Tyler, Please find the following comment. Thanks, Shiju > > Currently when a RAS error is reported it is not timestamped. > The ACPI 6.1 spec adds the timestamp field to the generic error data > entry v3 structure. The timestamp of when the firmware generated the > error is now being report

RE: [PATCH V5 02/10] ras: acpi/apei: cper: generic error data entry v3 per ACPI 6.1

2016-11-29 Thread Shiju Jose
> -Original Message- > From: linux-acpi-ow...@vger.kernel.org [mailto:linux-acpi- > ow...@vger.kernel.org] On Behalf Of Tyler Baicar > Sent: 21 November 2016 22:36 > To: marc.zyng...@arm.com; pbonz...@redhat.com; rkrc...@redhat.com; > li...@armlinux.org.uk; catalin.mari...@arm.com; will.dea

Re: [PATCH v2] arm64: head.S: Fix CNTHCTL_EL2 access on VHE system

2016-11-29 Thread Catalin Marinas
On Mon, Nov 28, 2016 at 09:13:02PM -0500, Jintack Lim wrote: > From: Jintack > > Bit positions of CNTHCTL_EL2 are changing depending on HCR_EL2.E2H bit. > EL1PCEN and EL1PCTEN are 1st and 0th bits when E2H is not set, but they > are 11th and 10th bits respectively when E2H is set. Current code i

Re: [PATCH] KVM: arm/arm64: Access CNTHCTL_EL2 bit fields correctly

2016-11-29 Thread Jintack Lim
On Tue, Nov 29, 2016 at 4:36 AM, Marc Zyngier wrote: > On 29/11/16 03:28, Jintack Lim wrote: >> On Mon, Nov 28, 2016 at 1:39 PM, Marc Zyngier wrote: >>> On 28/11/16 17:43, Marc Zyngier wrote: Hi Jintack, >> >> Hi Marc, >> On 28/11/16 16:46, Jintack Lim wrote: > Bit positions of

Re: [PATCH] KVM: arm/arm64: Access CNTHCTL_EL2 bit fields correctly

2016-11-29 Thread Marc Zyngier
On 29/11/16 10:47, Christoffer Dall wrote: > On Tue, Nov 29, 2016 at 09:37:07AM +, Marc Zyngier wrote: >> On 28/11/16 19:42, Christoffer Dall wrote: >>> On Mon, Nov 28, 2016 at 06:39:04PM +, Marc Zyngier wrote: On 28/11/16 17:43, Marc Zyngier wrote: > Hi Jintack, > > On 28/

Re: [PATCH v9 06/11] arm/arm64: vgic: Implement VGICv3 CPU interface access

2016-11-29 Thread Christoffer Dall
On Tue, Nov 29, 2016 at 03:31:44PM +0530, Vijay Kilari wrote: > On Tue, Nov 29, 2016 at 2:07 PM, Christoffer Dall > wrote: > > On Tue, Nov 29, 2016 at 01:08:26PM +0530, Vijay Kilari wrote: > >> On Tue, Nov 29, 2016 at 1:09 AM, Christoffer Dall > >> wrote: > >> > On Wed, Nov 23, 2016 at 06:31:53PM

Re: [PATCH] KVM: arm/arm64: Access CNTHCTL_EL2 bit fields correctly

2016-11-29 Thread Christoffer Dall
On Tue, Nov 29, 2016 at 09:37:07AM +, Marc Zyngier wrote: > On 28/11/16 19:42, Christoffer Dall wrote: > > On Mon, Nov 28, 2016 at 06:39:04PM +, Marc Zyngier wrote: > >> On 28/11/16 17:43, Marc Zyngier wrote: > >>> Hi Jintack, > >>> > >>> On 28/11/16 16:46, Jintack Lim wrote: > Bit pos

Re: [PATCH v9 06/11] arm/arm64: vgic: Implement VGICv3 CPU interface access

2016-11-29 Thread Vijay Kilari
On Tue, Nov 29, 2016 at 2:07 PM, Christoffer Dall wrote: > On Tue, Nov 29, 2016 at 01:08:26PM +0530, Vijay Kilari wrote: >> On Tue, Nov 29, 2016 at 1:09 AM, Christoffer Dall >> wrote: >> > On Wed, Nov 23, 2016 at 06:31:53PM +0530, vijay.kil...@gmail.com wrote: >> >> From: Vijaya Kumar K >> >> >>

Re: [PATCH] KVM: arm/arm64: Access CNTHCTL_EL2 bit fields correctly

2016-11-29 Thread Marc Zyngier
On 28/11/16 19:42, Christoffer Dall wrote: > On Mon, Nov 28, 2016 at 06:39:04PM +, Marc Zyngier wrote: >> On 28/11/16 17:43, Marc Zyngier wrote: >>> Hi Jintack, >>> >>> On 28/11/16 16:46, Jintack Lim wrote: Bit positions of CNTHCTL_EL2 are changing depending on HCR_EL2.E2H bit. EL1PCE

Re: [PATCH] KVM: arm/arm64: Access CNTHCTL_EL2 bit fields correctly

2016-11-29 Thread Marc Zyngier
On 29/11/16 03:28, Jintack Lim wrote: > On Mon, Nov 28, 2016 at 1:39 PM, Marc Zyngier wrote: >> On 28/11/16 17:43, Marc Zyngier wrote: >>> Hi Jintack, > > Hi Marc, > >>> >>> On 28/11/16 16:46, Jintack Lim wrote: Bit positions of CNTHCTL_EL2 are changing depending on HCR_EL2.E2H bit. EL

Re: [PATCH v9 06/11] arm/arm64: vgic: Implement VGICv3 CPU interface access

2016-11-29 Thread Christoffer Dall
On Tue, Nov 29, 2016 at 01:08:26PM +0530, Vijay Kilari wrote: > On Tue, Nov 29, 2016 at 1:09 AM, Christoffer Dall > wrote: > > On Wed, Nov 23, 2016 at 06:31:53PM +0530, vijay.kil...@gmail.com wrote: > >> From: Vijaya Kumar K > >> > >> VGICv3 CPU interface registers are accessed using > >> KVM_DEV