Re: [Libreoffice] [PUSHED] more spelling mistakes, dead code removal for Base

2010-11-09 Thread David Tardon
On Tue, Nov 09, 2010 at 10:24:20PM +, Wols Lists wrote: > Cheers, > Wol Looks fine. Pushed. > From cb03ee788ea81661ae83ae611806c6050d16af57 Mon Sep 17 00:00:00 2001 > -// use keys and indexes for excat postioning Would that mean positioning of a dead cat (aka ex-parrot)? :-D D.

Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM in svx

2010-11-09 Thread David Tardon
On Tue, Nov 09, 2010 at 09:30:22PM +0100, Joost Eekhoorn wrote: > Is it correct to have the RTL_CONSTASCII_USTRINGPARAM directly in the *.hxx > file. > If so, why not do that also at other places? > > MPL 1.1 / GPLv3+ / LGPLv3+ > > Joost Pushed, thanks! D. __

Re: [Libreoffice] High Contrast Cleanup

2010-11-09 Thread Kálmán „KAMI” Szalai
Lovely :o) 2010-11-10 07:30 keltezéssel, Joseph Powers írta: > Ok, I removed high-contrast support from two base classes: SvImpLBox & > SvTreeListBox. And then spent the next two days cleaning up the mess. The > code builds and seems to run fine on my Mac. > > > Joe P > > LGPL 3 if you want. KA

Re: [Libreoffice] [PUSHED] 4 patches of rtl goodness

2010-11-09 Thread David Tardon
On Tue, Nov 09, 2010 at 03:11:40PM -0500, Kevin Hunter wrote: > At 12:44pm -0500 Tue, 09 Nov 2010, Kevin Hunter wrote: > >Here are four more patch conversions from createFromAscii to > >RTL_CONST... applied against: > > > >basebmp/ > >binfilter/ > >bridges/ > >connectivity/ > > I apologize, I temp

Re: [Libreoffice] Export OLE objects as PDF / graphics

2010-11-09 Thread Sebastian Spaeth
On Tue, 09 Nov 2010 22:35:13 +0100, Gert Faller wrote: > The source code is a really big town, I've no map,.. Haha, that describes it pretty much and pretty exactly. Thanks for making me laugh. That should be the slogan on our development wiki. :) Sebastian pgpBnDLtYhVlO.pgp Description: PGP s

Re: [Libreoffice] [PATCH] Renaming extension options consistently

2010-11-09 Thread Sebastian Spaeth
On Wed, 10 Nov 2010 05:29:34 +0100, Jan Holesovsky wrote: > > 1) if the user specifies max-cpus, do we want max-jobs to default to > > max-cpus? Because that does make sense afaict. > > The buildsystem is a bit strange in this regard ;-) There are 2 levels > of what is done in parallel - one on t

[Libreoffice] [PUSHED] Re: [PATCH] solenv/bin/ooinstall and undefined setup_vars array

2010-11-09 Thread Jan Holesovsky
Jan Holesovsky píše v St 10. 11. 2010 v 05:11 +0100: > I have pushed that to master, and when cherry-picking to ...now with the 'pushed' subject line ;-) Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freede

Re: [Libreoffice] [PATCH] Renaming extension options consistently

2010-11-09 Thread Jan Holesovsky
Hi Wol, Wols Lists píše v Pá 05. 11. 2010 v 18:04 +: > On 05/11/10 17:13, Niko Rönkkö wrote: > > dnl > === > > dnl Optional Packages (--with/without-) > > dnl > ===

Re: [Libreoffice] [PATCH] solenv/bin/ooinstall and undefined setup_vars array

2010-11-09 Thread Jan Holesovsky
Hi Hanno, Hanno Meyer-Thurow píše v Ne 07. 11. 2010 v 23:09 +0100: > There is an undefined $setup_vars array used in solenv/bin/ooinstall. > Attached is a patch to use the equvalent values from the global $ENV > array. I have pushed that to master, and when cherry-picking to libreoffice-3-3, I f

Re: [Libreoffice] How to build for 3.3

2010-11-09 Thread Miklos Vajna
On Tue, Nov 09, 2010 at 09:27:22PM +0100, Thorsten Behrens wrote: > yes, your changes are clearly an improvement. Re. master - > bin/transform is indeed gone, maybe rerun autogen? I'd like to have > them on master, too. :) Oh, yes. I forgot to re-run autogen, that fixed the issue. I just tested

Re: [Libreoffice] Styles and Formatting

2010-11-09 Thread jonathon
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/05/2010 01:15 AM, Gert Faller wrote: > 10)I open the dialog in writer --> Hierarchical > 11)I close writer and open it again --> Hierarchical > 12)I close calc and open it again --> All styles > 13)I close both and open calc --> All styles > 14

[Libreoffice] [PATCH] more spelling mistakes, dead code removal for Base

2010-11-09 Thread Wols Lists
Cheers, Wol >From cb03ee788ea81661ae83ae611806c6050d16af57 Mon Sep 17 00:00:00 2001 From: Wol Date: Tue, 9 Nov 2010 22:15:21 + Subject: [PATCH] Spelling mistakes, and deleting unwanted comments and commented code --- dbaccess/source/core/api/BookmarkSet.cxx |1 - dbaccess/sour

Re: [Libreoffice] Styles and Formatting

2010-11-09 Thread Cor Nouws
Hi Gert, Gert Faller wrote (05-11-10 02:15) Selon Cedric Bosdonnat: So Hierarchical as default would not be my choice. Default is more then enough. Hi, I must admit that even if I been using OpenOffice for nearly 10 years, I never A pity you didn't ;-) use that dialog so I've maybe not

Re: [Libreoffice] Export OLE objects as PDF / graphics

2010-11-09 Thread Gert Faller
Selon Caolán McNamara : > It looks good to me anyway. Just need to handle more gracefully hitting > "cancel" IMO and I reckon we could pretty much stuff it in as is. > > C. Hi, yes of course, checks must be added, it's just 'raw code'. Whatever,this function is expected in calc to. I'm coding i

[Libreoffice] [PUSHED] RTL patches for canvas and chart2

2010-11-09 Thread Thorsten Behrens
Kevin Hunter wrote: > My last contribution of the day, with two RTL patches for canvas/ > and chart2/ . > Seems the basebmp parts were already applied - used the canvas ones. Many thanks for the cleanup - as per the discussion around trailing whitespace changes, did not commit those. Cheers, --

Re: [Libreoffice] Export OLE objects as PDF / graphics

2010-11-09 Thread Caolán McNamara
On Mon, 2010-11-08 at 23:46 +0100, Gert Faller wrote: > Hi, > > Following the hints of Michael Meeks in : > 'https://bugs.freedesktop.org/show_bug.cgi?id=30944', here a first try in > writer. > It's 'raw code' : just wondering if it satisfies the required functionality. It looks good to me anyway

[Libreoffice] [PATCH] RTL_CONSTASCII_USTRINGPARAM in svx

2010-11-09 Thread Joost Eekhoorn
Is it correct to have the RTL_CONSTASCII_USTRINGPARAM directly in the *.hxx file. If so, why not do that also at other places? MPL 1.1 / GPLv3+ / LGPLv3+ Joost diff --git a/svx/source/inc/docrecovery.hxx b/svx/source/inc/docrecovery.hxx index 4f1f256..c6e4117 100644 --- a/svx/source/inc/docrecove

Re: [Libreoffice] How to build for 3.3

2010-11-09 Thread Thorsten Behrens
Miklos Vajna wrote: > 2) I'm attaching two patches: > > a) Avoid the usage of git-branch (usual problem: git-branch is a git > porcelain command so its output may change any time without notice). > > b) Don't check if master is checkout out, check if the branch is the > same as the branch of buil

Re: [Libreoffice] 4 patches of rtl goodness

2010-11-09 Thread Kevin Hunter
At 12:44pm -0500 Tue, 09 Nov 2010, Kevin Hunter wrote: Here are four more patch conversions from createFromAscii to RTL_CONST... applied against: basebmp/ binfilter/ bridges/ connectivity/ I apologize, I temporarily forgot about the automatic whitespace handling and flat committed those files

[Libreoffice] 4 patches of rtl goodness

2010-11-09 Thread Kevin Hunter
Hullo List, Here are four more patch conversions from createFromAscii to RTL_CONST... applied against: basebmp/ binfilter/ bridges/ connectivity/ Cheers, Kevin rtl_easy_hack.tbz Description: application/bzip-compressed-tar ___ LibreOffice mailing

[Libreoffice] [PUSHED] Re: [Patch] ure: Remove bogus WITH_CORE debug code which core dumps

2010-11-09 Thread Caolán McNamara
On Mon, 2010-11-08 at 14:59 +0100, Sebastian Spaeth wrote: > There was #ifdef'd test code depending on WITH_CORE being defined (which > is never set in our build system). It is described as test code that > will core dump for sure. So let's remove this and write proper cppunit > tests instead. All

[Libreoffice] [PUSHED] Re: [PATCH] Easy Hacks : RTL_CONSTASCII_USTRINGPARAM in libs-core 4

2010-11-09 Thread Caolán McNamara
On Mon, 2010-11-08 at 23:18 +0100, Gert Faller wrote: > Hi, > > more in libs-core : the xml stuff. Looks good, pushed. Thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/lib

[Libreoffice] [PUSHED] Re: More easy hack RTL goodness

2010-11-09 Thread Caolán McNamara
On Mon, 2010-11-08 at 16:48 -0500, Kevin Hunter wrote: > Hullo again, > > Some more easy hack RTL code. Looks good, pushed. As an aside the "testtools" dir is part of the build and tests the bridges automatically as part of the build. Though only for your own platform of course. C.

[Libreoffice] Updated the pre-commit hook [was: Re: large swathes of commented/#if 0 code removed]

2010-11-09 Thread Jan Holesovsky
Hi, On 2010-11-09 at 10:48 +, Caolán McNamara wrote: > > If it is not desirable, I'll update the hook so that it fixes just the > > lines where the committer introduces the trailing whitespace, and won't > > touch the rest of the whitespace errors - should I? > > Hmm, yeah, I think just stri

Re: [Libreoffice] [PATCH] More URLs to OOo sites

2010-11-09 Thread Thorsten Behrens
Hi Flo, all, recent changes to url strings in LibO, for completeness sake - and no need for any setup here, server-side. Cheers, -- Thorsten From da9762a0da84a061fd2adadfdb51295357d5e270 Mon Sep 17 00:00:00 2001 From: Thorsten Behrens Date: Wed, 3 Nov 2010 11:48:47 +0100 Subject: [PATCH] Changi

Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word

2010-11-09 Thread Noel Power
On Tue, 2010-11-09 at 04:30 -0800, John LeMoyne Castle wrote: > > Noel Power wrote: > > > > I wonder if the recent rebase to OOO330m13 is the culprit, would be > > interesting if you could test against the corresponding oracle dev build > > > Yes, I see that test would be useful. > Not about

[Libreoffice] [PUSHED] Re: [PATCH] Clean up the code in libs-core

2010-11-09 Thread Caolán McNamara
On Tue, 2010-11-09 at 01:48 +0500, Alexander O. Anisimov wrote: > Hi all, > > I have done some clean up the code in libs-core: remove bogus > comments, refresh comments containing a reference to the bug tracker, All good IMO, I like expanding the issue references to the headline of those, much be

[Libreoffice] Pubblicizza - ricerca - inserisci annunci "Gratis"

2010-11-09 Thread Giulia-29
Se non visualizzi correttamente questa email clicca qui Clicca qui per accedere ai servizi finanziariMutui - Prestiti - Leasing - cambializzati - prestiti aziendali - vitalizi - fidejussioni - assistenza alle aziende in crisi - informazioni commerciali - recupero crediti Novità!!! Pubblicizza

Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word

2010-11-09 Thread John LeMoyne Castle
Noel Power wrote: > > I wonder if the recent rebase to OOO330m13 is the culprit, would be > interesting if you could test against the corresponding oracle dev build > Yes, I see that test would be useful. Not about to setup an OOO build, but will consider it if you think that would be useful

Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word

2010-11-09 Thread Noel Power
On Tue, 2010-11-09 at 04:30 -0800, John LeMoyne Castle wrote: > > Noel Power wrote: > > > > I wonder if the recent rebase to OOO330m13 is the culprit, would be > > interesting if you could test against the corresponding oracle dev build > > > Yes, I see that test would be useful. > Not about

[Libreoffice] [PUSHED] Re: easyhack: remove blocks of commented code

2010-11-09 Thread Caolán McNamara
On Mon, 2010-11-08 at 12:50 -0500, Kevin Hunter wrote: > Hi List, > > A patch to remove large blocks of already commented code. Yup, pushed, thanks. Though I dropped the last hunk which for some reason removes the final newline. C. ___ LibreOffice mai

[Libreoffice] bin/g clone now possible

2010-11-09 Thread Jan Holesovsky
Hi, I have updated the bin/g script so that it is now possible to use it for cloning the repos. This might be particularly useful when you want to have your branch in a separate location, but use your main repo as the reference to save your inet traffic. Let's say you have your 'master' repo in

Re: [Libreoffice] [PUSHED] easy hacks, commented code removal

2010-11-09 Thread Kevin Hunter
At 4:03am -0500 Tue, 09 Nov 2010, Sebastian Spaeth wrote: Please make sure to not remove the newlines after the last vi modeline. There were a few of that that I had to fix. Ah, of course. That's my editor doing an automatic job. I'll update the settings for this project. Thanks, mate. Ke

Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word

2010-11-09 Thread Cedric Bosdonnat
Hi guys, I mistakenly pushed Mattias patch this morning... that shouldn't harm, but I though it would be good for you to know it for later investigations. On Sat, 2010-11-06 at 14:14 +1100, Mattias Johnsson wrote: > On 6 November 2010 12:13, John LeMoyne Castle wrote: > > > > Hi all, > > Ok, aft

Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word

2010-11-09 Thread John LeMoyne Castle
Noel Power wrote: > > No, I don't mean setting up an OOO build ;-) but just checking against a > OOO330m13 dev build ( that can downloaded from openoffice.org ) > OIC, I was making it too hard - rooted around at OOo and found the debs... Thanks -- LeMoyne -- View this message in context: h

Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word

2010-11-09 Thread Cedric Bosdonnat
On Fri, 2010-11-05 at 00:38 -0700, John LeMoyne Castle wrote: > Dang, I was hoping it would stop counting at least some punctuation as a > word.(period). Don't know what to say other than test before and after. Just some random thought here: would you be able to write some unit tests for this?

Re: [Libreoffice] easy hack, rtl against basebmp/

2010-11-09 Thread Caolán McNamara
On Mon, 2010-11-08 at 12:47 -0500, Kevin Hunter wrote: > Hi List, > > Here's an RTL patch against basebmp/ . Yup, looks good. Thanks, pushed. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listin

Re: [Libreoffice] large swathes of commented/#if 0 code removed

2010-11-09 Thread Caolán McNamara
On Tue, 2010-11-09 at 02:19 +0100, Jan Holesovsky wrote: > If it is not desirable, I'll update the hook so that it fixes just the > lines where the committer introduces the trailing whitespace, and won't > touch the rest of the whitespace errors - should I? Hmm, yeah, I think just stripping the wh

[Libreoffice] [PUSHED] accessibility easy hack, RTL

2010-11-09 Thread Sebastian Spaeth
On Mon, 08 Nov 2010 12:43:45 -0500, Kevin Hunter wrote: > Hullo List, > > Another RTL_CONST patch, also against accessibility/ . Pushed, thanks Sebastian pgp3oHLdWa5bJ.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.fre

Re: [Libreoffice] [PUSHED] easy hacks, commented code removal

2010-11-09 Thread Sebastian Spaeth
Pushed all patches but #4 which does nothing but removing #--- lines between functions, which *I personally* don't consider buggy. Otherwise mostly good. Please make sure to not remove the newlines after the last vi modeline. There were a few of that that I

Re: [Libreoffice] easy hacks, commented code removal

2010-11-09 Thread Sebastian Spaeth
On Mon, 08 Nov 2010 12:42:24 -0500, Kevin Hunter wrote: > Here's another set of patches. Caolán, I think I've done a little > better on the comments this time, but probably not yet perfect. > > accessibility/ Thanks, I am taking this one. Will review then push as appropriate. Looking good so fa

Re: [Libreoffice] [PUSHED] build.pl dead code, spelling fixes

2010-11-09 Thread David Tardon
On Mon, Nov 08, 2010 at 08:10:51PM -0600, Jordan Ayers wrote: > Miscellaneous cleanup to build.pl. Mostly removal of dead code, with > a few spelling / German->English fixes. > > LGPLv3+/MPL > Pushed, thanks! D. ___ LibreOffice mailing list LibreOffi