[Libreoffice-commits] .: Branch 'feature/pdf-signing' - vcl/source

vcl/source/gdi/pdfwriter_impl.cxx | 11 +++ 1 file changed, 11 insertions(+) New commits: commit 9ba7fda79cd36a20732fee663f52bdb4946cb2cf Author: Gökçen Eraslan Date: Sun Jul 8 09:19:49 2012 +0300 Get der encoded certificate to use in NSS. Change-Id: I01b033b2ec91d973

Change in core[master]: fdo#51179: SearchAscii() is equal to indexOfAsciiL(), not ma...

>From Korrawit Pruegsanusak : Korrawit Pruegsanusak has uploaded a new change for review. Change subject: fdo#51179: SearchAscii() is equal to indexOfAsciiL(), not match() .. fdo#51179: SearchAscii() is equal to indexOfAsciiL()

Change in core[master]: fdo#51179: SearchAscii() is equal to indexOfAsciiL(), not ma...

>From Korrawit Pruegsanusak : Korrawit Pruegsanusak has posted comments on this change. Change subject: fdo#51179: SearchAscii() is equal to indexOfAsciiL(), not match() .. Patch Set 1: I don't know if other filters, apart fr

Bogus call to OUString::matchAsciiL in /framework/source/lomenubar/MenuItemStatusListener.cxx ?

Hi, While looking for usage of OUString::matchAsciiL in the base code, I came across the following which seems odd. At line 60 of /framework/source/lomenubar/MenuItemStatusListener.cxx, we can find : >>> if ((Event.State >>= oULabel) && !oULabel.matchAsciiL ("private:", 8, 0)

Question about calling a method with a default parameter

Hi, Sometimes some methods are declared with some default value(s) As an example, here is the definition of matchAsciiL for OUString > sal_Bool matchAsciiL( const sal_Char* asciiStr, sal_Int32 asciiStrLength, sal_Int32 fromIndex = 0 ) const SAL_THROW(()) > When these functions are

[Libreoffice-commits] .: reportdesign/inc sc/inc sw/source xmloff/source

reportdesign/inc/UndoActions.hxx |1 - sc/inc/dpitemdata.hxx |4 sw/source/core/inc/layouter.hxx|2 -- xmloff/source/chart/SchXMLChartContext.hxx |1 - xmloff/source/text/XMLRedlineExport.hxx|1 - 5 files changed, 9 deletions(

[Libreoffice-commits] .: 3 commits - sfx2/source

sfx2/source/control/thumbnailview.cxx |4 ++-- sfx2/source/doc/templatedlg.cxx |8 ++-- 2 files changed, 8 insertions(+), 4 deletions(-) New commits: commit bdbd2c3057683694a75d9d8f88fc33e7a26c0769 Author: Rafael Dominguez Date: Sat Jul 7 23:56:30 2012 -0430 Hide search

[Libreoffice-commits] .: sfx2/inc

sfx2/inc/sfx2/thumbnailview.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 41c1ecbf0a95a6a18d45ff35c18cd5a516019de0 Author: Rafael Dominguez Date: Sun Jul 8 10:14:35 2012 -0430 Include thumbnailviewitem trying to fix windows tinderboxes. Change-I

Re: Adding Extension for Experimental Thai Spelling

I hope no one minds if I "piggy-back" on this thread. Recently I contributed to the ICU break iterator for Khmer and it was added to ICU 4.8 (I just helped with the dictionary, another volunteer did the code). LibreOffice 3.6 added the updated ICU code and now uses the code to line-break Khmer even

[PATCH] - Report correct test name

Hi, In '\sal\qa\rtl_strings\rtl_OUString.cxx', I think that this one should be 'ctor_005' and not 'ctor_004'. Best regards Christophe JAILLET diff --git a/sal/qa/rtl_strings/rtl_OUString.cxx b/sal/qa/rtl_strings/rtl_OUString.cxx index 8271253..64b9aa1 100644 --- a/sal/qa/rtl_strings/rtl_OUStr

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf2' - sc/source

sc/source/core/tool/formularesult.cxx | 15 --- sc/source/filter/xml/xmlcelli.cxx | 56 +-- sc/source/filter/xml/xmlsubti.cxx | 69 ++ sc/source/filter/xml/xmlsubti.hxx | 43 - 4 files changed, 68 i

[Libreoffice-commits] .: 2 commits - sfx2/inc sfx2/source

sfx2/inc/templatedlg.hxx|2 ++ sfx2/source/doc/templatedlg.cxx | 34 +- sfx2/source/doc/templatedlg.src |4 ++-- 3 files changed, 37 insertions(+), 3 deletions(-) New commits: commit 7f1674d214c1567638412dba89633b5d5f8d4924 Author: Rafael Domingue

Change in core[master]: Implement support for HeaderBar arrow native rendering, add ...

>From Björn Michaelsen : Björn Michaelsen has uploaded a new change for review. Change subject: Implement support for HeaderBar arrow native rendering, add GTK support .. Implement support for HeaderBar arrow native rendering,

Change in core[master]: Implement support for listview headers native render, add GT...

>From Björn Michaelsen : Björn Michaelsen has uploaded a new change for review. Change subject: Implement support for listview headers native render, add GTK implementation .. Implement support for listview headers native rende

Re: [PATCH] Implement support for treeview headers native rendering, add GTK implementation

Hi Ruslan, On Sat, Jul 07, 2012 at 10:06:37PM +0400, Ruslan Kabatsayev wrote: > These two patches implement support for listview headers (aka > HeaderBar) native rendering. > First one makes the "buttons" look natively, and second one makes > arrow showing sort order also look native. > Aside from

[PATCH] - use indexOfAsciiL and avoid static variable

Hi, in 'comphelper\source\misc\logging.cxx' we can read : // (if ::rtl::OUString had an indexOfAscii, we could save those ugly statics ...) Well, it has kind of and indexOfAsciiL can be used if length is provided. This patch is untested, so please check it before applying. Especially, I'

[PATCH] Better center status bar items between separators

Hello, This patch fixes status bar separators position so that status bar items appears better centered between them. As a side effect, it also gives more space for rendering separators for themes which have thicker separators than 2px. Regards, Ruslan 0003-Better-center-status-bar-items-betwee

[Libreoffice-commits] .: sal/qa

sal/qa/rtl_strings/rtl_OUString.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a076603a602cef9ce1fb7ef094fddd05b92cce58 Author: Christophe JAILLET Date: Sun Jul 8 19:34:04 2012 +0200 Report correct test name Change-Id: I8181713f28e500b960b9c3

Re: [PATCH] - Report correct test name

Hi, On Sun, Jul 08, 2012 at 05:59:52PM +0200, Christophe JAILLET wrote: > In '\sal\qa\rtl_strings\rtl_OUString.cxx', I think that this one > should be 'ctor_005' and not 'ctor_004'. Pushed as: http://cgit.freedesktop.org/libreoffice/core/commit/?id=a076603a602cef9ce1fb7ef094fddd05b92cce58 for

[PUSHED] - Report correct test name

please ignore, adjusted mail subject to mark this as PUSHED in the archaic workflow. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] Re: [Review-3-6?] New artwork for 3.6

On Wed, Jul 4, 2012 at 3:34 PM, Stefan Knorr (Astron) wrote: > I have to admit, I was at first also scared of the all-greenness of > the splash that our good G+ circlers [1] chose. We did, among the > design team, discuss the other options, but if we hadn't taken one > from the top three that wou

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf2' - 2 commits - sc/qa sc/source

sc/qa/unit/data/contentCSV/matrix2.csv |2 ++ sc/qa/unit/data/ods/matrix.ods |binary sc/qa/unit/subsequent_filters-test.cxx | 23 ++- sc/source/filter/xml/xmlcelli.cxx | 31 +-- 4 files changed, 41 insertions(+), 15 deletions(-)

Re: Windows tinderboxes unresolved external errors

I fixed it by including the file defining the class ThumbnailViewItem. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source

sc/source/ui/condformat/condformatdlg.cxx | 19 +++ sc/source/ui/src/condformatdlg.src| 10 +- 2 files changed, 16 insertions(+), 13 deletions(-) New commits: commit 1259cee4111a6b8f66d8583166c2ff9f3fc4d80d Author: Andras Timar Date: Sun Jul 8 20:26:38 2012

[Libreoffice-commits] .: sc/source

sc/source/ui/condformat/condformatdlg.cxx | 19 +++ sc/source/ui/src/condformatdlg.src| 10 +- 2 files changed, 16 insertions(+), 13 deletions(-) New commits: commit dd9a9e192e9e7a18f96d9ecff71ac6d5718920ac Author: Andras Timar Date: Sun Jul 8 20:26:38 2012

[Libreoffice-commits] .: Branch 'feature/gsoc-calc-perf2' - 2 commits - sc/qa sc/source

sc/qa/unit/data/contentCSV/matrix2.csv |7 +-- sc/qa/unit/data/ods/matrix.ods |binary sc/source/filter/xml/xmlcelli.cxx |3 --- 3 files changed, 5 insertions(+), 5 deletions(-) New commits: commit 1651e7b7ff0f97bf738bf5b210e1c97e201627a1 Author: Daniel Bankston Date:

Change in core[master]: - fdo#45830 - Language/User Interface: current choice indica...

>From Rob Snelders : Rob Snelders has uploaded a new change for review. Change subject: - fdo#45830 - Language/User Interface: current choice indicated as default .. - fdo#45830 - Language/User Interface: current choice indicat

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source

sc/source/ui/condformat/colorformat.cxx |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit 25bd4f0566e634037ce8d4fb94abe8b351625249 Author: Andras Timar Date: Sun Jul 8 21:42:06 2012 +0200 fix layout issue on Data Bar dialog Change-Id: I6bdc5bbbf5e48b5

[Libreoffice-commits] .: sc/source

sc/source/ui/condformat/colorformat.cxx |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit 9a7e4eac50523df3f24008430340635d7b870328 Author: Andras Timar Date: Sun Jul 8 21:42:06 2012 +0200 fix layout issue on Data Bar dialog Change-Id: I6bdc5bbbf5e48b5

Change in core[master]: Replaced deprecated tools/String with OUString in ScAddInCol

>From Markus Mohrhard : Markus Mohrhard has posted comments on this change. Change subject: Replaced deprecated tools/String with OUString in ScAddInCol .. Patch Set 2: I would prefer that you didn't submit this (7 inline comm

Change in core[master]: Replaced deprecated tools/String with OUString in ScAddInCol

>From Markus Mohrhard : Markus Mohrhard has posted comments on this change. Change subject: Replaced deprecated tools/String with OUString in ScAddInCol .. Patch Set 2: There is no need for a make clean. Just use make sc in th

Change in core[master]: Replaced deprecated String with OUString in sc/../chgtrack

>From Daniel Bankston : Daniel Bankston has posted comments on this change. Change subject: Replaced deprecated String with OUString in sc/../chgtrack .. Patch Set 1: test -- To view, visit https://gerrit.libreoffice.org/263

Re: [ANN] Please use Gerrit from now on for Patch Review

On Mon, Jul 02, 2012 at 06:13:50PM +0200, Lionel Elie Mamane wrote: > On Mon, Jun 18, 2012 at 12:09:49PM +0200, Bjoern Michaelsen wrote: >> gerrit is documented and ready to go. Please use it for code review >> as much as possible now as it simplifies things a lot over manual >> patch fiddling on

Change in core[master]: Replaced deprecated String with OUString in sc/../chgtrack

>From Markus Mohrhard : Markus Mohrhard has posted comments on this change. Change subject: Replaced deprecated String with OUString in sc/../chgtrack .. Patch Set 1: Looks good to me, approved -- To view, visit https://gerrit

diff between patch revisions (was: Please use Gerrit from now on for Patch Review)

On Sun, Jul 08, 2012 at 10:56:55PM +0200, Lionel Elie Mamane wrote: > Now I went to https://gerrit.libreoffice.org/#/c/267/; there are at > this time three patchsets, but it seems there is no easy / convenient > way to see the differences (interdiff) between them. Find the text "Old Version Histor

Re: diff between patch revisions (was: Please use Gerrit from now on for Patch Review)

On Sun, Jul 08, 2012 at 11:17:31PM +0200, Bjoern Michaelsen wrote: > On Sun, Jul 08, 2012 at 10:56:55PM +0200, Lionel Elie Mamane wrote: >> Now I went to https://gerrit.libreoffice.org/#/c/267/; there are at >> this time three patchsets, but it seems there is no easy / convenient >> way to see the

[Libreoffice-commits] .: 2 commits - sd/sdi sd/source svx/AllLangResTarget_svx.mk svx/Library_svx.mk svx/Package_inc.mk svx/inc svx/sdi svx/source

sd/sdi/_drvwsh.sdi |5 sd/source/ui/app/popup2_tmpl.src|1 sd/source/ui/view/drviews2.cxx | 34 +++ sd/source/ui/view/drviewsj.cxx |6 svx/AllLangResTarget_svx.mk |1 svx/Library_svx.mk

Re: Document conversion engine

Hi Michael, nice to ear from someone so "up the ranks" like you.. makes me feel much more important :-) 2012/7/6 Michael Meeks > Hi Flavio, > > On Tue, 2012-07-03 at 11:45 +0100, Flavio Moringa wrote: > > my name is Flávio Moringa, I'm from Portugal and I'm starting my > > Masters Dissertation

Re: Document conversion engine

Hi Robinson, 2012/7/6 Robinson Tryon > On Fri, Jul 6, 2012 at 5:51 AM, Flavio Moringa < > flavio.mori...@caixamagica.pt> wrote: > >> >> I know that you can convert documents through the command line, using >> LibreOffice headless mode, and that can be something that's useful for >> scripting aut

[Libreoffice-commits] .: 2 commits - sc/inc sc/source

sc/inc/attarray.hxx|2 +- sc/inc/chgtrack.hxx|1 - sc/inc/column.hxx |2 +- sc/inc/document.hxx|1 - sc/inc/table.hxx |2 +- sc/source/core/data/attarray.cxx |2 +- sc/source/core/data/colu

[PATCH] Make bottom tabbar items follow native theme

Hello, This patch makes bottom tabbar items (e.g. the ones switching sheets in Calc or similar items in Draw) follow native theme (currently seems only implemented for GTK, but should also be tested with Win32 - most likely there'll need something to change). Screenshots for comparison: before: h

[Libreoffice-commits] .: 2 commits - sc/inc sc/source

sc/inc/attarray.hxx |2 +- sc/inc/column.hxx|2 +- sc/inc/document.hxx |1 + sc/inc/table.hxx |2 +- sc/source/core/data/attarray.cxx |2 +- sc/source/core/data/column2.cxx |4 ++-- sc/source/core/data/document.cxx

Re: [PATCH] Implement support for treeview headers native rendering, add GTK implementation

Hello again, I'm sorry, but the second patch was broken, here's fixed version. Please update the version in gerrit (I haven't yet figured out how to do this myself). Thanks, Ruslan On Sun, Jul 8, 2012 at 8:55 PM, Bjoern Michaelsen wrote: > Hi Ruslan, > > On Sat, Jul 07, 2012 at 10:06:37PM +0400

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source

sc/source/filter/excel/xetable.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c3b6e14db7a8134a49da7bdb12d351cddcc866d5 Author: Markus Mohrhard Date: Mon Jul 9 01:47:21 2012 +0200 performance problem with this commit Change-Id: I59bca684afcc1c51ec

[Libreoffice-commits] .: 5 commits - sfx2/inc sfx2/source

sfx2/inc/sfx2/templatefolderview.hxx |6 ++- sfx2/inc/sfx2/thumbnailview.hxx|2 - sfx2/inc/templatedlg.hxx |2 + sfx2/source/control/templatefolderview.cxx | 28 +++- sfx2/source/control/templatesearchview.cxx |2 - sfx2/source/cont

Re: [PATCH] Implement support for treeview headers native rendering, add GTK implementation

On Mon, Jul 09, 2012 at 03:51:38AM +0400, Ruslan Kabatsayev wrote: > I'm sorry, but the second patch was broken, here's fixed version. > Please update the version in gerrit (I haven't yet figured out how to > do this myself). Done. Its just './logerrit submit' -- gerrit figures out alone that it i