On Sat, Jan 19, 2013 at 09:52:08AM +0100, Alex Thurgood wrote:
> On 01/19/2013 04:40 AM, Lionel Elie Mamane wrote:
>> The central question is: what are the consequences of this code? If it
> I seem to recall that using TINYINT as a boolean field (...)
Well, hmmm, from a "standard SQL" point of v
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/1777
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/77/1777/1
Replace the frequent functioncalls
The function getHorizontalEdge contains more function calls to the
getRowCoun
I'm not sure whether this is an upstream bug or Gentoo-specific, so it
seemed best to talk about it here before I open a bugz report on it.
I have lo 4.0.0.1 on an amd64 Gentoo box.
The UI is, as it should be, in English except that one toolbar in draw,
which identifies itself as Gdmath Addon if
https://bugs.freedesktop.org/show_bug.cgi?id=54157
--- Comment #83 from Joren De Cuyper ---
I nominate "Bug 58978 - [FILEOPEN][FILESAVE]: General Error while
opening/closing .odt files" because of an error message every time you
open/save an ODT file (Mac osx only)
--
You are receiving this mai
https://bugs.freedesktop.org/show_bug.cgi?id=54157
Joren De Cuyper changed:
What|Removed |Added
Depends on||58978
--
You are receiving this mail
vcl/aqua/source/gdi/atsui/salgdi.cxx |2 --
1 file changed, 2 deletions(-)
New commits:
commit dc44862f0e711fe0cf93063f72ebe1dec598d922
Author: Tor Lillqvist
Date: Sun Jan 20 00:47:24 2013 +0200
Fix fallout from my earlier vcl changes today
Change-Id: Iee869d254944383994d9c8d
Hello again,
I found out why agenda templates are duplicated. The reason is we need a
reference template to link the different sections of the template to toggle
their text. The java code is here:
http://opengrok.libreoffice.org/xref/core/wizards/com/sun/star/wizards/text/TextSectionHandler.java#1
cui/AllLangResTarget_cui.mk |1
cui/UI_cui.mk |1
cui/source/dialogs/splitcelldlg.cxx | 57 +++
cui/source/dialogs/splitcelldlg.hrc | 29 ---
cui/source/dialogs/splitcelldlg.src | 118 ---
cui/source/inc/splitcelldlg.hxx | 14 -
cu
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/1776
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/76/1776/1
Update default dictionaries set for Lithuanian (related to fdo#59380)
Change-Id: I42a2032e03035b0e45a800c068879e
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/1775
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/75/1775/1
Add Lithuanian translations of keyboard shortcuts (related to fdo#54165)
Change-Id: I0e9460adeebb2e2a46ca3cd0e68
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/1774
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/74/1774/1
Add Lithuanian translations of keyboard shortcuts (related to fdo#50415)
Change-Id: Ie5df8819c59135625f504f7d5b6
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/1773
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/73/1773/1
Remove some unneeded variables in filter
Change-Id: Ia2963498a197a795155a42b2588f983019d89f35
---
M filter/sourc
solenv/bin/modules/installer/download.pm |5 +
solenv/bin/modules/installer/parameter.pm |2 +-
solenv/bin/modules/installer/simplepackage.pm |6 ++
3 files changed, 8 insertions(+), 5 deletions(-)
New commits:
commit e3dfe8905fc3d7ec1d0dd0fc20ac1189d2636e53
Author: T
Hello,
Here's a problem in stoc/test/testintrosp.cxx, line 182
aRetStr = aRetStr + OUString( OUString(" (Typ: ") ) + xIdlClass->getName() +
OUString(""));
By taking a look at git history, I found that it was:
aRetStr = aRetStr + OUString( OUString(RTL_CONSTASCII_USTRINGPARAM(" (Typ:
")) ) + xIdlC
Hello,
Cppcheck detected this:
ucb/workben/ucb/ucbdemo.cxx
1735syntaxError error Invalid number of character (() when these
macros are
defined: ''.
I fixed parenthesis (there was not just one problem) but I don't know how to
check this since "make ucbdemo" tells:
make: *** No rule to m
Hello,
Cppcheck reported this:
Indeed, we can see this:
109 if (bRO)
110 {
111 nMode = aBuf.st_mode & ~S_IWUSR;
112 nMode = aBuf.st_mode & ~S_IWGRP;
113 nMode = aBuf.st_mode & ~S_IWOTH;
114 }
see
http://opengrok.libreoffice.org/xref/
lotuswordpro/source/filter/lwpborderstuff.cxx | 12
lotuswordpro/source/filter/lwpmargins.hxx |4
oox/source/ppt/conditioncontext.cxx |1 -
oox/source/ppt/layoutfragmenthandler.cxx |1 -
oox/source/ppt/slidefragmenthandler.cxx |1 -
oox/
On Fri, 2013-01-18 at 08:04 -0800, Joel Madero wrote:
> Can someone triage this one? Thanks in advance!
And there has been quit a bit of subsequent discussion.
I wonder just what Lionel was proposing [1] after the announcement [2]
of changed licence for the mariadb / mysql client library. How wo
sw/UI_swriter.mk |1
sw/inc/globals.hrc |3
sw/inc/helpid.h|4
sw/source/ui/inc/outline.hxx |5
sw/source/ui/misc/outline.cxx | 124 +++
sw/source/ui/misc/outli
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/1771
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/71/1771/1
Remove more STRINGPARAM macros from dbaccess
Change-Id: I5a5af27d7c980f6b71011c33531a49a82d79fbc8
---
M dbaccess
On 19/01/13 11:28, Lubos Lunak wrote:
> -Wsign-promo is a rather pointless warning these days (the section in the
> gcc
> manpage is a funny read and not only because it talks about Cfront). I've
> added more overloads to silence it, but I rather wonder why we have this
> explicitly enabled at
sal/inc/rtl/string.hxx | 10 --
sal/inc/rtl/ustring.hxx | 10 --
2 files changed, 16 insertions(+), 4 deletions(-)
New commits:
commit 06e76156d2ea1ce8a112f9e2312d6074478de648
Author: LuboÅ¡ LuÅák
Date: Sat Jan 19 13:54:40 2013 +0100
microoptimization for "" OUStrin
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/1770
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/70/1770/1
resolve fdo#59240 - FORMATTING: Thai number shown as Arabic numerals
Change-Id: Ia0d1089d90a6b2196d45da63afbb7d8
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/1769
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/1769/1
resolve fdo#59240 - FORMATTING: Thai number shown as Arabic numerals
Change-Id: I6123f8924d7502d3b97b3254ce4e5df
src/docrecord.py | 27 +--
src/docstream.py | 23 +++
test/doc/bookmark.doc |binary
test/doc/bookmark.rtf |7 +++
test/doc/test.py | 11 +++
5 files changed, 62 insertions(+), 6 deletions(-)
New commits:
commit 8f7a
Hello
This is a proposal with many goals:
1- lessen configure options
2- consolidate default values locations
3- consolidate data origin
1- This patch will remove
--with-intro*,--with-startcenter*,--with-about-background-svg,--with-flat-logo-svg
and will expand --with-branding to this regard
2-
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/1768
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/68/1768/1
fdo#57950: Remove some chained appends in connectivity and..
... remove some RTL* macros.
Change-Id: I919d17e14
cui/source/inc/backgrnd.hxx |1 -
cui/source/tabpages/backgrnd.cxx |1 -
2 files changed, 2 deletions(-)
New commits:
commit c34cad49fadd376a61904e2201d85fbe908c348b
Author: Stephan Bergmann
Date: Sat Jan 19 12:27:14 2013 +0100
-Werror,-Wunused-private-field
Change-I
sw/UI_swriter.mk |1
sw/inc/chrdlg.hrc |1
sw/inc/globals.hrc|1
sw/inc/helpid.h |1
sw/inc/swabstdlg.hxx |4
sw/source/ui/chrdlg/cha
Hi,
Thank you for your patch! It has been merged to LibreOffice.
If you are interested in details, please visit
https://gerrit.libreoffice.org/1767
Approvals:
Olivier Hallot: Verified; Looks good to me, approved
--
To view, visit https://gerrit.libreoffice.org/1767
To unsubscribe, vis
connectivity/source/commontools/FDatabaseMetaDataResultSetMetaData.cxx | 608
++
1 file changed, 140 insertions(+), 468 deletions(-)
New commits:
commit 494fa01eb08ebb251934fe1a868a702dfa19aca4
Author: Marcos Paulo de Souza
Date: Sat Jan 19 08:55:29 2013 -0200
Remove some RTL_*
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/1767
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/1767/1
Remove some RTL_* macdros from connectivity and..
...also simplify a lot some functions calls.
Change-Id: I0702
On Friday 18 of January 2013, julien2412 wrote:
> Hello,
>
> On pc Debian x86-64 with master sources after having runned "make clean",
> I've got this:
> /home/julien/compile-libreoffice/libo/sal/qa/rtl/strings/test_strings_value
>x.cxx: In instantiation of ‘void testInt() [with T = rtl::OUString]’
vcl/aqua/source/gdi/coretext/salcoretextfontutils.cxx |6 -
vcl/aqua/source/gdi/coretext/salcoretextlayout.cxx| 55 --
vcl/aqua/source/gdi/coretext/salcoretextstyle.cxx | 16 ++---
vcl/aqua/source/gdi/coretext/salgdi.cxx | 30 -
vcl/inc/aqua/
On 18/01/2013 12:01, Caolán McNamara wrote:
On Thu, 2013-01-17 at 13:54 -0800, julien2412 wrote:
What should we do with bRet value, after line 1102?
bRet is supposed to return true if the save succeeded s
a) changing all the bRets after the initial initialization from
bRet = foo
to
bRet&= fo
On 18/01/2013 12:08, Caolán McNamara wrote:
On Thu, 2013-01-17 at 13:43 -0800, julien2412 wrote:
Hello,
Cppcheck reported this:
vcl/source/gdi/pdfwriter_impl.cxx
3203unreadVariable style Variable 'pUnicodes' is assigned a value that is
never used
Can we just remove it or something lackin
sc/source/core/tool/autoform.cxx | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
New commits:
commit c228103ce6a5efe60de553073a9b20d977478bf5
Author: Julien Nabet
Date: Sat Jan 19 10:11:24 2013 +0100
2 small fixes
Variable 'bRet' is reassigned
++it wit
vcl/inc/ios/salcoretextfontutils.hxx| 12 -
vcl/inc/ios/salcoretextstyle.hxx|6
vcl/inc/ios/salgdi.h|2
vcl/ios/source/gdi/salcoretextfontutils.cxx | 228 ++--
vcl/ios/source/gdi/salcoretextlayout.cxx| 81 +-
On 01/19/2013 04:40 AM, Lionel Elie Mamane wrote:
>
> It sets it as *un*signed.
>
Aarghh, yes, that's what I meant to write in my brain, and my fingers
typed otherwise.
> It is exactly the opposite of the capabilities of LibreOffice's
> internal system with 8-bit integers (most notably the "An
vcl/source/gdi/pdfwriter_impl.cxx |3 ---
1 file changed, 3 deletions(-)
New commits:
commit 8a894b4af476641062bf340a2fb802558bf1cbe3
Author: Julien Nabet
Date: Sat Jan 19 09:28:51 2013 +0100
Fix pUnicodes unused
Change-Id: I168c84d6b64fe23c3e93e36aad31f1c74dfd547a
diff --gi
Thank you for the fix Lubos! Building is ok now.
Julien
--
View this message in context:
http://nabble.documentfoundation.org/BUILD-FAILS-DEBUG-MODE-with-test-strings-valuex-cxx-tp4030218p4030308.html
Sent from the Dev mailing list archive at Nabble.com.
___
sc/source/core/data/table2.cxx| 26 ++
sc/source/ui/condformat/condformatdlg.cxx |8
sc/source/ui/condformat/condformatmgr.cxx | 14 +++---
sc/source/ui/view/cellsh1.cxx |5 -
4 files changed, 45 insertions(+), 8 dele
42 matches
Mail list logo