RE: Useless includes (maybe...)

2014-11-07 Thread Juergen Funk Mailinglist
Hi all, what i discuss with Tor i mean the construct (void) bSuccess; assert(bSuccess); is a little bit ugly In assert.h #ifdef NDEBUG #define assert(_Expression) ((void)0) #else Why '((void)0)' better empty or we define this #ifdef NDEBUG #define

Re: Useless includes (maybe...)

2014-11-07 Thread Stephan Bergmann
On 11/07/2014 11:02 AM, Juergen Funk Mailinglist wrote: i mean the construct (void) bSuccess; assert(bSuccess); is a little bit ugly That's a well-known shortcoming of standard C assert, inherited by C++. See

Re: Useless includes (maybe...)

2014-11-06 Thread Tor Lillqvist
I removed hopefully most of those that were truly unused (on any platform): commit 8f266781a6bd6a629bce65c0f613683047c9a794 (*HEAD*, *origin/master*, *origin/HEAD*, *master*) Author: Tor Lillqvist t...@collabora.com Date: Thu Nov 6 12:56:18 2014 +0200 Bin unused include files, thanks to

Re: Useless includes (maybe...)

2014-11-05 Thread Riccardo Magliocchetti
Hi Andrea, Il 05/11/2014 11:37, Andrea Gelmini ha scritto: Hi everybody, and thanks a lot for you work. With an ignorant approach (bash, grep, make friends) I have found Is it the same approach as https://bugs.freedesktop.org/show_bug.cgi?id=42949#c0 ? As you may see later in the