FYI: patch to fix missing quoting

2005-03-15 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Sat, Mar 12, 2005 at 07:07:43PM CET: > * Peter O'Gorman wrote on Thu, Mar 10, 2005 at 03:12:59PM CET: > > > > This looks okay to me, can we have a test too though? > > Yes, I am working on one. First the branch-1-5 backport below. > My question would be whether anyone

Re: patch to fix missing quoting

2005-03-12 Thread Ralf Wildenhues
Hi Per, Peter, * Per Bothner wrote on Thu, Mar 10, 2005 at 06:27:08PM CET: > Ralf Wildenhues wrote: > >Sorry for self-reply. > > > >OK, better patch: does the quoting only in one place, plus complains > >loudly and fails if $libobj contains special characters. > > Works for me. Good. Applied to

Re: patch to fix missing quoting

2005-03-10 Thread Per Bothner
Ralf Wildenhues wrote: Sorry for self-reply. OK, better patch: does the quoting only in one place, plus complains loudly and fails if $libobj contains special characters. Works for me. -- --Per Bothner [EMAIL PROTECTED] http://per.bothner.com/

Re: patch to fix missing quoting

2005-03-10 Thread Peter O'Gorman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Ralf Wildenhues wrote: | | 2005-03-06 Per Bothner <[EMAIL PROTECTED]>, | Ralf Wildenhues <[EMAIL PROTECTED]> | | Allow special characters in source file names. Will break unless | `-o target' is also given, which must not cont

Re: patch to fix missing quoting

2005-03-10 Thread Ralf Wildenhues
Sorry for self-reply. * Ralf Wildenhues wrote on Wed, Mar 09, 2005 at 06:53:07PM CET: > > OK. I've got something half-working here. It allows merely adding > weird characters to the source file names. You absolutely have to > specify a "nice" output name with `-o'. Maybe libtool should refuse

Re: patch to fix missing quoting

2005-03-09 Thread Ralf Wildenhues
Hi Per, * Per Bothner wrote on Mon, Mar 07, 2005 at 08:18:07PM CET: > Ralf Wildenhues wrote: > >Thanks for reporting this. Your patch is not quite correct, as it > >causes the $ in the libobj name to be quoted twice. Thus, the output > >name of the .lo file will be wrong. > > Hm. Yes. OK. I'

Re: patch to fix missing quoting

2005-03-07 Thread Per Bothner
Ralf Wildenhues wrote: Thanks for reporting this. Your patch is not quite correct, as it causes the $ in the libobj name to be quoted twice. Thus, the output name of the .lo file will be wrong. Hm. Yes. Before delving into a better patch: Beware that such file names do not play too well with oth

Re: patch to fix missing quoting

2005-03-07 Thread Ralf Wildenhues
Hi Per, * Per Bothner wrote on Mon, Mar 07, 2005 at 12:02:20AM CET: > The srcname and the target name were not being quoted. > This caused problems with Java, where .class files may > commonly contain '$'. Thanks for reporting this. Your patch is not quite correct, as it causes the $ in the libo

patch to fix missing quoting

2005-03-06 Thread Per Bothner
The srcname and the target name were not being quoted. This caused problems with Java, where .class files may commonly contain '$'. Also note that gcj allows multiple input files compiled to a single .s or .o file: Thus a useful way to compile a bunch of class files is: gcj -c *.class -o package.