Re: [libvirt] libvirt-0.9.3 week freeze, RC1 version to test

2011-06-27 Thread simon jin
于 2011-6-27 23:17, Laine Stump 写道: On 06/27/2011 07:32 AM, Matthias Bolte wrote: 2011/6/27 simon: 于 2011-6-27 13:01, Daniel Veillard 写道: So we are entering the week freeze for the new version 0.9.3 I have made an rc1 tarball available at: ftp://libvirt.org/libvirt/libvirt-0.9.3-rc1.tar.

[libvirt] [Libvirt-test-API][PATCH 6/6] add target_machine variable and login name with root default and password variable into env.cfg

2011-06-27 Thread Guannan.ren
--- env.cfg |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/env.cfg b/env.cfg index e1237de..b5e404a 100644 --- a/env.cfg +++ b/env.cfg @@ -135,3 +135,9 @@ testnic = eth1 # a PCI device to use for attach/detach/reset tests # for example testpci = 00:19.0 testpci =

[libvirt] [Libvirt-test-API][PATCH 4/6] add migrate.py testcases based on Daniel Berrage's migration testing scenarios

2011-06-27 Thread Guannan.ren
--- repos/domain/migrate.py | 335 +++ 1 files changed, 335 insertions(+), 0 deletions(-) create mode 100644 repos/domain/migrate.py diff --git a/repos/domain/migrate.py b/repos/domain/migrate.py new file mode 100644 index 000..3f80bd0 --- /dev/nu

[libvirt] [Libvirt-test-API][PATCH 2/6] add flags option to create.py to support creating domain with running or paused state

2011-06-27 Thread Guannan.ren
--- repos/domain/create.py | 53 --- 1 files changed, 40 insertions(+), 13 deletions(-) diff --git a/repos/domain/create.py b/repos/domain/create.py index 343aba2..a06a2d3 100644 --- a/repos/domain/create.py +++ b/repos/domain/create.py @@ -12,6 +12,7

[libvirt] [Libvirt-test-API][PATCH 1/6] add createWithFlags() API and modify migrate() function to align with libvirt Python migration definition

2011-06-27 Thread Guannan.ren
--- lib/domainAPI.py | 57 -- 1 files changed, 38 insertions(+), 19 deletions(-) diff --git a/lib/domainAPI.py b/lib/domainAPI.py index 0c725f8..5667c20 100644 --- a/lib/domainAPI.py +++ b/lib/domainAPI.py @@ -40,18 +40,6 @@ append_path(result

[libvirt] [Libvirt-test-API][PATCH 3/6] add flags option to start to have domain started with flags support

2011-06-27 Thread Guannan.ren
--- repos/domain/start.py | 32 ++-- 1 files changed, 30 insertions(+), 2 deletions(-) diff --git a/repos/domain/start.py b/repos/domain/start.py index 34906e5..39ac47f 100644 --- a/repos/domain/start.py +++ b/repos/domain/start.py @@ -31,6 +31,9 @@ from lib import d

[libvirt] [Libvirt-test-API][PATCH 5/6] add migration testing configuration file to cases

2011-06-27 Thread Guannan.ren
--- cases/migrate.conf | 97 1 files changed, 97 insertions(+), 0 deletions(-) create mode 100644 cases/migrate.conf diff --git a/cases/migrate.conf b/cases/migrate.conf new file mode 100644 index 000..2d8157a --- /dev/null +++ b/cases/m

[libvirt] [PATCH] save domain status after modifing vcpupin

2011-06-27 Thread Wen Congyang
We should save domain status after modifing vcpupin. If not, we will get wrong vcpupin information after rebooting libvirtd. --- src/qemu/qemu_driver.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 8fcc266..768e0f2

[libvirt] [PATCH] Fix memory leak in virDomainVcpuPinDel()

2011-06-27 Thread Wen Congyang
virDomainVcpuPinDefFree() does not free def->cputune.vcpupin if nvcpupin is 0, and does not set def->cputune.vcpupin to NULL. If we set nvcpupin to 0 but do not free vcpupin, vcpupin will not be freed when vm->def is freed. Use VIR_FREE() instead of virDomainVcpuPinDefFree() to free the memory an

Re: [libvirt] [PATCH] xml: create an RNG file for common types and move some definitions there

2011-06-27 Thread Eric Blake
On 06/26/2011 03:19 AM, Laine Stump wrote: > domain.rng, network.rng, and interface.rng already use a few of the > same types (or in some cases *should* but don't), and an upcoming code > change will have them sharing even more. To prepare for that, this > patch takes those common data type definit

Re: [libvirt] [PATCH 4/4] Cleanup remote protocol definitions

2011-06-27 Thread Eric Blake
On 06/27/2011 08:24 AM, Daniel P. Berrange wrote: > The standard remote protocol for libvirtd no longer needs to > include definitions of the generic message header/error structs > or status codes. This is all defined in the generic RPC protocol > > * src/remote/remote_protocol.x: Remove all RPC m

Re: [libvirt] [PATCH 3/4] Remove obsolete libvirtd mdns code

2011-06-27 Thread Eric Blake
On 06/27/2011 08:24 AM, Daniel P. Berrange wrote: > libvirtd now uses the generic RPC code for MDNS, so its > custom mdns APIs are no longer required > > * daemon/mdns.c, daemon/mdns.h: Removed obsolete files > --- > daemon/mdns.c | 508 >

Re: [libvirt] [PATCH 2/4] Convert libvirtd over to the new RPC handling APIs

2011-06-27 Thread Eric Blake
On 06/27/2011 08:24 AM, Daniel P. Berrange wrote: > This guts the libvirtd daemon, removing all its networking and > RPC handling code. Instead it calls out to the new virServerPtr > APIs for all its RPC & networking work > > As a fallout all libvirtd daemon error reporting now takes place > via t

Re: [libvirt] [PATCH 1/4] Convert the remote driver to new RPC client APIs

2011-06-27 Thread Eric Blake
On 06/27/2011 02:08 PM, Eric Blake wrote: Aargh, I hit send too soon. >> +case trans_ext: { >> +char const *cmd_argv[] = { command, NULL }; >> +if (!(priv->client = virNetClientNewExternal(cmd_argv))) This appears to be the only call to virNetClientNewExternal. And it only p

Re: [libvirt] [PATCH] virsh: add custom readline generator

2011-06-27 Thread Eric Blake
On 06/27/2011 12:06 PM, Michal Privoznik wrote: >> That is, if you have command-based custom generators, then each command >> has to repeat parsing functionality, then call back to common list >> generators; whereas if you have option-based custom generators, then you >> have fewer callbacks becaus

Re: [libvirt] [PATCH] virsh: add custom readline generator

2011-06-27 Thread Michal Privoznik
On 27.06.2011 19:37, Eric Blake wrote: > On 06/24/2011 12:42 AM, Lai Jiangshan wrote: >> Custom readline generator will help for some usecase. > > Indeed, this could be very nice as extended to more commands. > >> >> Also add a custom readline generator for the "help" command. >> >> Signed-off-by

Re: [libvirt] [PATCH] network: add domain to unqalified names define with

2011-06-27 Thread Eric Blake
On 06/24/2011 11:33 PM, Laine Stump wrote: > If a domain name is defined for a network, add the --expand-hosts > option to the dnsmasq commandline. This results in the domain being > added to any hostname that is defined in a dns element and > contains no '.' characters (i.e. it is an "unqualified

Re: [libvirt] regression in finding boot device

2011-06-27 Thread Laine Stump
On 06/27/2011 05:50 AM, Jiri Denemark wrote: On Sat, Jun 25, 2011 at 00:21:29 -0400, Laine Stump wrote: (bootindex was showing up as "1" in the log; not knowing anything about how it worked, I decided to try just changing it to "0". That didn't work. Switching back to the old method *did* work,

Re: [libvirt] [PATCH 0/7] Add support for setting QoS

2011-06-27 Thread Christian Benvenuti (benve)
> -Original Message- > From: Michal Privoznik [mailto:mpriv...@redhat.com] > Sent: Monday, June 27, 2011 8:34 AM > To: Christian Benvenuti (benve) > Cc: Laine Stump; libvir-list@redhat.com > Subject: Re: [libvirt] [PATCH 0/7] Add support for setting QoS > > On 24.06.2011 20:00, Christian B

Re: [libvirt] [PATCH] virsh: add custom readline generator

2011-06-27 Thread Eric Blake
On 06/24/2011 12:42 AM, Lai Jiangshan wrote: > Custom readline generator will help for some usecase. Indeed, this could be very nice as extended to more commands. > > Also add a custom readline generator for the "help" command. > > Signed-off-by: Lai Jiangshan > --- Hmm, this is a new virsh f

[libvirt] shared LVM volume group, should I use it?

2011-06-27 Thread Erik Sjölund
Hi, Assume I want to have the root file system of the virtualization host server in an LVM volume on the local hard drive. Is it ok to have that LVM volume in the same LVM volume group that I will later use as a Storage Pool for libvirt? I already found a question about this: http://serverfault.c

Re: [libvirt] [PATCH] daemon: Dynamically create worker threads when some get stuck

2011-06-27 Thread Michal Privoznik
On 16.06.2011 19:29, Daniel P. Berrange wrote: > On Thu, Jun 16, 2011 at 04:29:55PM +0200, Michal Privoznik wrote: >> Up to now, we've created new worker threads only during new connection. >> This patch monitors worker threads for liveness and dynamically create >> new one if all are stuck, waitin

Re: [libvirt] [PATCH] nwfiler: Return error message about unresolvable variables

2011-06-27 Thread Stefan Berger
On 06/27/2011 11:52 AM, Eric Blake wrote: On 06/27/2011 08:14 AM, Stefan Berger wrote: s/nwfiler/nwfilter/ in the subject virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, strstr(buf, ", ") ? _("Cannot instantiate filter due to unresolvable variables: %s") : _("Cannot in

Re: [libvirt] [PATCH 1/2] Timeout QEMU monitor replies after 30 seconds

2011-06-27 Thread Michal Privoznik
On 24.06.2011 07:19, Daniel Veillard wrote: > On Wed, Jun 22, 2011 at 11:26:27AM -0600, Eric Blake wrote: >> On 06/22/2011 11:05 AM, Jiri Denemark wrote: >>> On Wed, Jun 22, 2011 at 16:47:18 +0100, Daniel P. Berrange wrote: If the QEMU process has been stopped (kill -STOP/gdb), or the QEM

Re: [libvirt] Confusing valgrind error in virDomainLookupByUUIDString or virReportErrorHelper

2011-06-27 Thread Eric Blake
On 06/27/2011 10:32 AM, Richard W.M. Jones wrote: > libvirt-0.9.2-2.fc16.x86_64 fc16 implies rawhide > > Here's the error from valgrind: > > ==24953== Conditional jump or move depends on uninitialised value(s) > ==24953==at 0x3DF68844BB: __GI___strcasecmp_l (strcmp.S:243) > ==24953==by

Re: [libvirt] FreeBSD Port, update to 0.9.2 compile error

2011-06-27 Thread Eric Blake
On 06/27/2011 10:29 AM, Jason Helfman wrote: >>> > another way would be to launch python directly giving the path to >>> the >>> > python script, this is likely to solve the issue there. >> >> That IMHO avoids the problem completely and I doubt anybody would >> complain we should even be able to

Re: [libvirt] [PATCH 2/2] Make monitor timeout configurable

2011-06-27 Thread Eric Blake
On 06/22/2011 09:47 AM, Daniel P. Berrange wrote: > This makes the monitor timeout limit configurable via > the qemu.conf configuration file. > > * src/conf/capabilities.h: Allow private data to be passed to > the virDomainObjPtr private allocation function > * src/libxl/libxl_driver.c, src/lxc/

Re: [libvirt] [PATCH 1/2] Timeout QEMU monitor replies after 30 seconds

2011-06-27 Thread Eric Blake
On 06/22/2011 09:47 AM, Daniel P. Berrange wrote: > If the QEMU process has been stopped (kill -STOP/gdb), or the > QEMU process has live-locked itself, then we will never get a > reply from the monitor. We should not wait forever in this > case, but instead timeout after a reasonable amount of tim

[libvirt] Confusing valgrind error in virDomainLookupByUUIDString or virReportErrorHelper

2011-06-27 Thread Richard W.M. Jones
libvirt-0.9.2-2.fc16.x86_64 Here's the error from valgrind: ==24953== Conditional jump or move depends on uninitialised value(s) ==24953==at 0x3DF68844BB: __GI___strcasecmp_l (strcmp.S:243) ==24953==by 0x3DF68221E1: __gconv_open (gconv_open.c:70) ==24953==by 0x3DF682F3E9: _nl_find_msg

Re: [libvirt] FreeBSD Port, update to 0.9.2 compile error

2011-06-27 Thread Jason Helfman
Hi, On Thu, Jun 09, 2011 at 08:55:01PM +0800, Daniel Veillard thus spake: On Wed, Jun 08, 2011 at 07:44:43AM -0700, Jason Helfman wrote: > On Tue, Jun 07, 2011 at 11:08:02PM -0700, Jason Helfman wrote: >> I found the issue in building was an absolute path for apibuild.py for >> python, that is i

Re: [libvirt] [PATCH 3/3] Add documentation for the seclabel XML element

2011-06-27 Thread Eric Blake
On 06/27/2011 06:20 AM, Daniel P. Berrange wrote: > The domain XML documentation is missing information about the > element used by security drivers > > * formatdomain.html.in: Document > --- > docs/formatdomain.html.in | 76 > + > 1 files changed,

Re: [libvirt] libvirt-0.9.3 week freeze, RC1 version to test

2011-06-27 Thread Zdenek Styblik
On 06/27/11 17:11, Laine Stump wrote: > On 06/27/2011 07:30 AM, Matthias Bolte wrote: >> 2011/6/27 Zdenek Styblik: [...] >>> ~~~ SNIP ~~~ >>> /usr/include/netlink/object.h:58:23: warning: inline function >>> 'nl_object_priv' declared but never defined >>> /usr/include/netlink/object.h:58:23: warnin

Re: [libvirt] [PATCH 2/3] Allow for resource relabelling with static labels

2011-06-27 Thread Eric Blake
On 06/27/2011 06:20 AM, Daniel P. Berrange wrote: > Add a new attribute to the XML to allow resource > relabelling to be enabled with static label usage. > > > system_u:system_r:svirt_t:s0:c392,c662 > > > * docs/schemas/domain.rng: Add relabel attribute Missing docs/formatdomain.html.

Re: [libvirt] [PATCH 1/3] Allow a base label to be specified in dynamic labelling mode

2011-06-27 Thread Eric Blake
On 06/27/2011 06:20 AM, Daniel P. Berrange wrote: > Normally the dynamic labelling mode will always use a base > label of 'svirt_t' for VMs. Introduce a field > in the XML to allow this base label to be changed > > eg > > > system_u:object_r:virt_t:s0 > > > * docs/schemas/domain.r

Re: [libvirt] [PATCH] build: rename Vcpupin to VcpuPin

2011-06-27 Thread Eric Blake
On 06/27/2011 09:44 AM, Daniel P. Berrange wrote: > On Fri, Jun 24, 2011 at 05:16:33PM -0600, Eric Blake wrote: >> We already have a public virDomainPinVcpu, which implies that >> Pin and Vcpu are treated as separate words. Commit e261987c >> introduced virDomainGetVcpupinInfo as the first public

Re: [libvirt] [PATCH] nwfiler: Return error message about unresolvable variables

2011-06-27 Thread Eric Blake
On 06/27/2011 08:14 AM, Stefan Berger wrote: s/nwfiler/nwfilter/ in the subject > This is in response to bugzilla 664629 > > https://bugzilla.redhat.com/show_bug.cgi?id=664629 > > The patch below returns an appropriate error message if the chain of > nwfilters is found to contain unresolvable v

Re: [libvirt] [PATCH] Only include parthelper if built with storage_disk

2011-06-27 Thread Ruben Kerkhof
Hi Eric, On Mon, Jun 27, 2011 at 16:51, Eric Blake wrote: > On 06/26/2011 03:39 AM, Ruben Kerkhof wrote: >> Parthelper is only compiled if both --with-libvirtd >> and --with-storage-disk are set. >> >> Signed-off-by: Ruben Kerkhof >> --- >>  libvirt.spec.in |    3 +++ >>  1 files changed, 3 inse

Re: [libvirt] sysinfo: fix lack of error check in virSysinfoFormat().

2011-06-27 Thread Eric Blake
On 06/27/2011 04:12 AM, Daniel P. Berrange wrote: > On Mon, Jun 27, 2011 at 04:40:56PM +0900, Minoru Usui wrote: >> Fix lack of error check in virSysinfoFormat(). >> >> Signed-off-by: Minoru Usui >> --- >> src/util/sysinfo.c |5 + >> 1 files changed, 5 insertions(+), 0 deletions(-) >> >>

Re: [libvirt] [PATCH] build: rename Vcpupin to VcpuPin

2011-06-27 Thread Daniel P. Berrange
On Fri, Jun 24, 2011 at 05:16:33PM -0600, Eric Blake wrote: > We already have a public virDomainPinVcpu, which implies that > Pin and Vcpu are treated as separate words. Commit e261987c > introduced virDomainGetVcpupinInfo as the first public API > that used Vcpupin, although we had prior internal

Re: [libvirt] sysinfo: cleanup function/struct names.

2011-06-27 Thread Eric Blake
On 06/27/2011 04:12 AM, Daniel P. Berrange wrote: > On Mon, Jun 27, 2011 at 04:39:34PM +0900, Minoru Usui wrote: >> Fix lack of 'virSysinfo' prefix of functions/structs in src/util/sysinfo.[ch] >> >> diff --git a/src/util/sysinfo.c b/src/util/sysinfo.c >> index fab4f06..3ff834e 100644 This paragra

Re: [libvirt] [PATCH 0/7] Add support for setting QoS

2011-06-27 Thread Michal Privoznik
On 24.06.2011 20:00, Christian Benvenuti (benve) wrote: >>> 3) Similarly for macvtap s, will the network-wide bandwidth >>> limiting be applied to the physical ethernet device? This would >>> have the side effect of including host traffic on that interface in >>> the bandwidth totals, but I don't s

Re: [libvirt] libvirt-0.9.3 week freeze, RC1 version to test

2011-06-27 Thread Eric Blake
On 06/27/2011 09:11 AM, Laine Stump wrote: > On 06/27/2011 07:30 AM, Matthias Bolte wrote: >> 2011/6/27 Zdenek Styblik: >>> Reporting Slackware64-13.37: >>> /usr/include/netlink/object.h:58:23: warning: inline function >>> 'nl_object_priv' declared but never defined >>> /usr/include/netlink/object

Re: [libvirt] libvirt-0.9.3 week freeze, RC1 version to test

2011-06-27 Thread Matthias Bolte
2011/6/27 Laine Stump : > On 06/27/2011 07:32 AM, Matthias Bolte wrote: >> >> 2011/6/27 simon: >>> >>> 于 2011-6-27 13:01, Daniel Veillard 写道: >>> >>>   So we are entering the week freeze for the new version 0.9.3 >>> I have made an rc1 tarball available at: >>>    ftp://libvirt.org/libvirt/libvirt-

Re: [libvirt] [PATCH v2] tests: Partly fix networkxml2argvtest being configure result dependent

2011-06-27 Thread Matthias Bolte
2011/6/27 Eric Blake : > On 06/27/2011 09:08 AM, Matthias Bolte wrote: >> Convert networkDnsmasqLeaseFileName to a replaceable function pointer >> that allow the testsuite to use a version of that function that is not >> depending on configure --localstatedir. >> >> This fixes 5 of 6 test failures,

Re: [libvirt] [PATCH] qemu: Remove bogus error codes for NUMA memory tuning

2011-06-27 Thread Osier Yang
于 2011年06月27日 18:18, Daniel P. Berrange 写道: On Mon, Jun 27, 2011 at 02:49:35PM +0800, Osier Yang wrote: This is no code between virSaveLastError and virGetLastError will set an error, remove the bogus codes. --- src/qemu/qemu_process.c | 33 - 1 files changed

Re: [libvirt] [PATCH v2] tests: Partly fix networkxml2argvtest being configure result dependent

2011-06-27 Thread Eric Blake
On 06/27/2011 09:08 AM, Matthias Bolte wrote: > Convert networkDnsmasqLeaseFileName to a replaceable function pointer > that allow the testsuite to use a version of that function that is not > depending on configure --localstatedir. > > This fixes 5 of 6 test failures, when configure --localstated

Re: [libvirt] libvirt-0.9.3 week freeze, RC1 version to test

2011-06-27 Thread Laine Stump
On 06/27/2011 07:32 AM, Matthias Bolte wrote: 2011/6/27 simon: 于 2011-6-27 13:01, Daniel Veillard 写道: So we are entering the week freeze for the new version 0.9.3 I have made an rc1 tarball available at: ftp://libvirt.org/libvirt/libvirt-0.9.3-rc1.tar.gz along with rpms for those interes

Re: [libvirt] libvirt-0.9.3 week freeze, RC1 version to test

2011-06-27 Thread Laine Stump
On 06/27/2011 07:30 AM, Matthias Bolte wrote: 2011/6/27 Zdenek Styblik: Reporting Slackware64-13.37: - --- compilation OK. ~~~ SNIP ~~~ ./configure \ --prefix=/usr/ \ --sysconfdir=/etc/ \ --libdir=/usr/lib${LIBDIRSUFFIX} \ --mandir=/usr/man/ \ --localsta

[libvirt] [PATCH v2] tests: Partly fix networkxml2argvtest being configure result dependent

2011-06-27 Thread Matthias Bolte
Convert networkDnsmasqLeaseFileName to a replaceable function pointer that allow the testsuite to use a version of that function that is not depending on configure --localstatedir. This fixes 5 of 6 test failures, when configure --localstatedir isn't set to /var. --- The last failure is related t

Re: [libvirt] [PATCH] network: fix indentation in networkBuildDnsmasqArgv

2011-06-27 Thread Laine Stump
On 06/27/2011 09:29 AM, Eric Blake wrote: On 06/24/2011 11:33 PM, Laine Stump wrote: This block was inadvertently added with the wrong indentation. --- src/network/bridge_driver.c | 15 +++ 1 files changed, 7 insertions(+), 8 deletions(-) ACK. Pushed, since this changes only

Re: [libvirt] sysinfo: delete unnecessary white space of sysinfo.

2011-06-27 Thread Eric Blake
On 06/27/2011 04:13 AM, Daniel P. Berrange wrote: > On Mon, Jun 27, 2011 at 05:25:17PM +0900, Minoru Usui wrote: >> sysinfo: delete unnecessary white space of sysinfo. >> >> * Add virSkipSpacesBackwards() to src/util/util.[ch] >> * Trim each element and delete null entry of sysinfo by >> virSk

Re: [libvirt] [PATCH] Only include parthelper if built with storage_disk

2011-06-27 Thread Eric Blake
On 06/26/2011 03:39 AM, Ruben Kerkhof wrote: > Parthelper is only compiled if both --with-libvirtd > and --with-storage-disk are set. > > Signed-off-by: Ruben Kerkhof > --- > libvirt.spec.in |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/libvirt.spec.in b/libvir

[libvirt] [PATCH 4/4] Cleanup remote protocol definitions

2011-06-27 Thread Daniel P. Berrange
The standard remote protocol for libvirtd no longer needs to include definitions of the generic message header/error structs or status codes. This is all defined in the generic RPC protocol * src/remote/remote_protocol.x: Remove all RPC message definitions * src/remote/remote_protocol.h, src/remot

[libvirt] [PATCH 3/4] Remove obsolete libvirtd mdns code

2011-06-27 Thread Daniel P. Berrange
libvirtd now uses the generic RPC code for MDNS, so its custom mdns APIs are no longer required * daemon/mdns.c, daemon/mdns.h: Removed obsolete files --- daemon/mdns.c | 508 - daemon/mdns.h | 96 --- 2 files changed, 0 insertion

[libvirt] [PATCH 0/4] Switch over to use the new RPC code

2011-06-27 Thread Daniel P. Berrange
This patch set actually switches the libvirtd daemon and remote driver client code to use the new RPC code. While it has had a fair amount of testing, it has also been rebased many many many times. There are bound to be things in it which break, hopefully not the actual RPC wire data format, but i

Re: [libvirt] [PATCH] tests: Handle networkxml2argvtest being configure --localstatedir dependant

2011-06-27 Thread Matthias Bolte
2011/6/27 Eric Blake : > On 06/25/2011 10:10 AM, Matthias Bolte wrote: >> 2011/6/25 Eric Blake : >>> On 06/25/2011 06:41 AM, Matthias Bolte wrote: networkxml2argvtest indirectly calls networkDnsmasqLeaseFileName that depends on configure --localstatedir. Therefore, the .argv files us

[libvirt] [PATCH] nwfiler: Return error message about unresolvable variables

2011-06-27 Thread Stefan Berger
This is in response to bugzilla 664629 https://bugzilla.redhat.com/show_bug.cgi?id=664629 The patch below returns an appropriate error message if the chain of nwfilters is found to contain unresolvable variables and therefore cannot be instantiated. Example: The following XMl added to a domain:

Re: [libvirt] [PATCH] tests: Handle networkxml2argvtest being configure --localstatedir dependant

2011-06-27 Thread Eric Blake
On 06/25/2011 10:10 AM, Matthias Bolte wrote: > 2011/6/25 Eric Blake : >> On 06/25/2011 06:41 AM, Matthias Bolte wrote: >>> networkxml2argvtest indirectly calls networkDnsmasqLeaseFileName >>> that depends on configure --localstatedir. Therefore, the .argv >>> files used in the test have to be crea

Re: [libvirt] [PATCH] network: fix indentation in networkBuildDnsmasqArgv

2011-06-27 Thread Eric Blake
On 06/24/2011 11:33 PM, Laine Stump wrote: > This block was inadvertently added with the wrong indentation. > --- > src/network/bridge_driver.c | 15 +++ > 1 files changed, 7 insertions(+), 8 deletions(-) ACK. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualiza

[libvirt] [PATCH 2/3] Allow for resource relabelling with static labels

2011-06-27 Thread Daniel P. Berrange
Add a new attribute to the XML to allow resource relabelling to be enabled with static label usage. system_u:system_r:svirt_t:s0:c392,c662 * docs/schemas/domain.rng: Add relabel attribute * src/conf/domain_conf.c, src/conf/domain_conf.h: Parse the 'relabel' attribute * src/qemu/qemu_

[libvirt] [PATCH 3/3] Add documentation for the seclabel XML element

2011-06-27 Thread Daniel P. Berrange
The domain XML documentation is missing information about the element used by security drivers * formatdomain.html.in: Document --- docs/formatdomain.html.in | 76 + 1 files changed, 76 insertions(+), 0 deletions(-) diff --git a/docs/formatdomain.h

[libvirt] [PATCH 0/3] Improve flexibility of SELinux labelling

2011-06-27 Thread Daniel P. Berrange
This patch series adds two new features - The ability to override 'system_u:system_r:svirt_t:s0' from /etc/selinux/targeted/contexts/virtual_domain_context using the guest XML - The ability to use dynamic relabelling of resources, in combo with static VM label assignment. The latter is

[libvirt] [PATCH 1/3] Allow a base label to be specified in dynamic labelling mode

2011-06-27 Thread Daniel P. Berrange
Normally the dynamic labelling mode will always use a base label of 'svirt_t' for VMs. Introduce a field in the XML to allow this base label to be changed eg system_u:object_r:virt_t:s0 * docs/schemas/domain.rng: Add * src/conf/domain_conf.c, src/conf/domain_conf.h: Parsing of

Re: [libvirt] libvirt-0.9.3 week freeze, RC1 version to test

2011-06-27 Thread Matthias Bolte
2011/6/27 simon : > 于 2011-6-27 13:01, Daniel Veillard 写道: > > So we are entering the week freeze for the new version 0.9.3 > I have made an rc1 tarball available at: >ftp://libvirt.org/libvirt/libvirt-0.9.3-rc1.tar.gz > along with rpms for those interested > We pushed a lot of patches in the

Re: [libvirt] libvirt-0.9.3 week freeze, RC1 version to test

2011-06-27 Thread Matthias Bolte
2011/6/27 Zdenek Styblik : > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 06/27/11 07:01, Daniel Veillard wrote: >>   So we are entering the week freeze for the new version 0.9.3 >> I have made an rc1 tarball available at: >>    ftp://libvirt.org/libvirt/libvirt-0.9.3-rc1.tar.gz >> along

Re: [libvirt] libvirt-0.9.3 week freeze, RC1 version to test

2011-06-27 Thread Gerhard Stenzel
On Mon, 2011-06-27 at 13:01 +0800, Daniel Veillard wrote: > So we are entering the week freeze for the new version 0.9.3 > I have made an rc1 tarball available at: >ftp://libvirt.org/libvirt/libvirt-0.9.3-rc1.tar.gz > along with rpms for those interested > We pushed a lot of patches in the last

Re: [libvirt] [PATCH] qemu: Remove bogus error codes for NUMA memory tuning

2011-06-27 Thread Daniel P. Berrange
On Mon, Jun 27, 2011 at 02:49:35PM +0800, Osier Yang wrote: > This is no code between virSaveLastError and virGetLastError will > set an error, remove the bogus codes. > --- > src/qemu/qemu_process.c | 33 - > 1 files changed, 0 insertions(+), 33 deletions(-) > >

Re: [libvirt] sysinfo: delete unnecessary white space of sysinfo.

2011-06-27 Thread Daniel P. Berrange
On Mon, Jun 27, 2011 at 05:25:17PM +0900, Minoru Usui wrote: > sysinfo: delete unnecessary white space of sysinfo. > > * Add virSkipSpacesBackwards() to src/util/util.[ch] > * Trim each element and delete null entry of sysinfo by > virSkipSpacesBackwards(). > > Signed-off-by: Minoru Usui >

Re: [libvirt] sysinfo: cleanup function/struct names.

2011-06-27 Thread Daniel P. Berrange
On Mon, Jun 27, 2011 at 04:39:34PM +0900, Minoru Usui wrote: > Fix lack of 'virSysinfo' prefix of functions/structs in src/util/sysinfo.[ch] > > diff --git a/src/util/sysinfo.c b/src/util/sysinfo.c > index fab4f06..3ff834e 100644 > > Signed-off-by: Minoru Usui > --- > src/util/sysinfo.c | 44

Re: [libvirt] sysinfo: fix lack of error check in virSysinfoFormat().

2011-06-27 Thread Daniel P. Berrange
On Mon, Jun 27, 2011 at 04:40:56PM +0900, Minoru Usui wrote: > Fix lack of error check in virSysinfoFormat(). > > Signed-off-by: Minoru Usui > --- > src/util/sysinfo.c |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/src/util/sysinfo.c b/src/util/sysinfo.c > ind

Re: [libvirt] [PATCH 1/3 V3] lib: add virtkey

2011-06-27 Thread Lai Jiangshan
On 06/24/2011 09:18 PM, Daniel P. Berrange wrote: > On Fri, Jun 24, 2011 at 02:33:29PM +0800, Lai Jiangshan wrote: >> Add virtkey lib for usage-improvment and keycode translating. >> Add 4 internal API for the aim >> >> const char *virKeycodeSetName(virKeycodeSet codeset); >> virKeycodeSet virParse

Re: [libvirt] regression in finding boot device

2011-06-27 Thread Jiri Denemark
On Sat, Jun 25, 2011 at 00:21:29 -0400, Laine Stump wrote: > (bootindex was showing up as "1" in the log; not knowing anything about > how it worked, I decided to try just changing it to "0". That didn't > work. Switching back to the old method *did* work, though.) > > This system is running qe

[libvirt] [PATCH] qemu: Fix update device for CURRENT + FORCE flags

2011-06-27 Thread Jiri Denemark
When CURRENT and FORCE flags were used together, UpdateDeviceFlags did nothing because it failed to transform CURRENT into either LIVE or CONFIG. --- src/qemu/qemu_driver.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.

[libvirt] sysinfo: delete unnecessary white space of sysinfo.

2011-06-27 Thread Minoru Usui
sysinfo: delete unnecessary white space of sysinfo. * Add virSkipSpacesBackwards() to src/util/util.[ch] * Trim each element and delete null entry of sysinfo by virSkipSpacesBackwards(). Signed-off-by: Minoru Usui --- src/util/sysinfo.c | 34 +- src/util/u

Re: [libvirt] [PATCH] build: rename Vcpupin to VcpuPin

2011-06-27 Thread Taku Izumi
On Sat, 25 Jun 2011 09:51:17 -0400 Laine Stump wrote: > On 06/24/2011 07:16 PM, Eric Blake wrote: > > We already have a public virDomainPinVcpu, which implies that > > Pin and Vcpu are treated as separate words. Commit e261987c > > introduced virDomainGetVcpupinInfo as the first public API > > t

[libvirt] sysinfo: fix lack of error check in virSysinfoFormat().

2011-06-27 Thread Minoru Usui
Fix lack of error check in virSysinfoFormat(). Signed-off-by: Minoru Usui --- src/util/sysinfo.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/src/util/sysinfo.c b/src/util/sysinfo.c index 31ebdc2..bff1cb8 100644 --- a/src/util/sysinfo.c +++ b/src/util/sysinfo.c @@

[libvirt] sysinfo: cleanup function/struct names.

2011-06-27 Thread Minoru Usui
Fix lack of 'virSysinfo' prefix of functions/structs in src/util/sysinfo.[ch] diff --git a/src/util/sysinfo.c b/src/util/sysinfo.c index fab4f06..3ff834e 100644 Signed-off-by: Minoru Usui --- src/util/sysinfo.c | 44 src/util/sysinfo.h | 16 +

Re: [libvirt] libvirt-0.9.3 week freeze, RC1 version to test

2011-06-27 Thread simon
? 2011-6-27 13:01, Daniel Veillard ??: So we are entering the week freeze for the new version 0.9.3 I have made an rc1 tarball available at: ftp://libvirt.org/libvirt/libvirt-0.9.3-rc1.tar.gz along with rpms for those interested We pushed a lot of patches in the last few days, we know ther