[libvirt] [PATCH] schedinfo: update man page about virsh schedinfo command

2011-08-25 Thread Taku Izumi
This patch updates the man page about virsh schedinfo command. - fix typo: 1844674407370955 -> 18446744073709551 - describe the value 0 of vcpu_period and vcpu_quota parameters Signd-off-by: Taku Izumi --- tools/virsh.pod |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Index:

Re: [libvirt] problem of escaped scancodes

2011-08-25 Thread KAMEZAWA Hiroyuki
On Thu, 25 Aug 2011 17:51:49 +0100 "Daniel P. Berrange" wrote: > On Thu, Aug 25, 2011 at 10:25:57AM +0900, KAMEZAWA Hiroyuki wrote: > > On Tue, 23 Aug 2011 14:54:11 +0100 > > "Daniel P. Berrange" wrote: > > > > > No, we just need to switch to use the correct scancode set. > > > > > > The orig

[libvirt] [BUGFIX][PATCH] remove saved garbages after persistent migration

2011-08-25 Thread KAMEZAWA Hiroyuki
>From e1e8d5ceb4a9f7c59e20dfb8c168b781435c1613 Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki Date: Fri, 26 Aug 2011 12:08:11 +0900 Subject: [PATCH] Fix persistent migration config save When a user migrates a domain by command as libvirt saves vm's domain XML config in destination host after m

Re: [libvirt] XML files

2011-08-25 Thread Derek
Thanks Richard, It was the libvirt version. Upgraded the package using squeeze-backports in debian and it worked without any changes. Cheers, Derek On 25/08/2011, at 1:41 AM, Richard W.M. Jones wrote: > On Wed, Aug 24, 2011 at 04:02:45PM +1200, Derek wrote: >> Unfortunately the changes I make

Re: [libvirt] [libvirt-virshcmdref 01/14] update documentation for command attach-device

2011-08-25 Thread Hu Tao
On Thu, Aug 25, 2011 at 12:20:59PM -0600, Eric Blake wrote: > On 08/25/2011 02:14 AM, Hu Tao wrote: > >--- > > source/attach-device.xml | 143 > > -- > > 1 files changed, 137 insertions(+), 6 deletions(-) > > > >diff --git a/source/attach-device.xml b/

Re: [libvirt] [libvirt-virshcmdref 02/14] update documentation for command detach-device

2011-08-25 Thread Hu Tao
On Thu, Aug 25, 2011 at 12:21:08PM -0600, Eric Blake wrote: > On 08/25/2011 02:14 AM, Hu Tao wrote: > >--- > > source/detach-device.xml | 124 > > -- > > 1 files changed, 120 insertions(+), 4 deletions(-) > > > >diff --git a/source/detach-device.xml b/

Re: [libvirt] [libvirt-virshcmdref 05/14] update documentation for command attach-interface

2011-08-25 Thread Hu Tao
On Thu, Aug 25, 2011 at 04:18:38PM -0400, Laine Stump wrote: > On 08/25/2011 04:14 AM, Hu Tao wrote: > >--- > > source/attach-interface.xml | 180 > > ++- > > 1 files changed, 176 insertions(+), 4 deletions(-) > > > >diff --git a/source/attach-interface.xm

[libvirt] [PATCH 2/3] virt-manager: Add redirected devices details

2011-08-25 Thread Marc-André Lureau
--- src/virtManager/details.py | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/virtManager/details.py b/src/virtManager/details.py index fd6cc3a..f928a42 100644 --- a/src/virtManager/details.py +++ b/src/virtManager/details.py @@ -186,6 +186,7 @@ def build_

[libvirt] [PATCH 3/4] Add --usbredir server:port device

2011-08-25 Thread Marc-André Lureau
--- man/en/virt-install.1 | 18 +++ man/en/virt-install.pod.in| 20 tests/clitest.py | 24 +++ virt-install |1 + virtinst/VirtualHostDevice.py | 65 + virtinst/__init__.p

[libvirt] [PATCH 3/3] virt-manager: Learn to add USB redirection devices

2011-08-25 Thread Marc-André Lureau
--- src/virtManager/addhardware.py | 35 +++- src/vmm-add-hardware.glade | 208 +++- 2 files changed, 237 insertions(+), 6 deletions(-) diff --git a/src/virtManager/addhardware.py b/src/virtManager/addhardware.py index b846170..33badb3 100644 --- a/s

[libvirt] [PATCH 0/4] python-virtinst USB improvements

2011-08-25 Thread Marc-André Lureau
Hi, Here are a few patches that go with the libvirt series to improve USB support. It adds --controller and --usbredir, as well as providing some new API for virt-manager. The last patch default USB controller to ich9/usb2 on Windows 7 guest. More OS probably support it, since it's been around si

[libvirt] [PATCH 2/4] Add advanced --controller support, augmenting VirtualController

2011-08-25 Thread Marc-André Lureau
This allow support for USB companion controllers and such. See man/en/virt-install.pod.in doc. We may want to add too a simpler --controller ich9-with-companions, or just --controller usb2. --- man/en/virt-clone.1 |6 ++- man/en/virt-image.1

[libvirt] [v2 11/13] qemu: Don't append 0 at usb id, so that it is compatible with legacy -usb

2011-08-25 Thread Marc-André Lureau
QEMU uses USB bus name "usb.0" when using the legacy -usb argument. If we want to allow USB devices to specify their addresses with legacy -usb, we should either in case of legacy bus name drop the 0 from the address bus, or just drop the 0 from device id. This patch does the later. Another soluti

[libvirt] [PATCH 1/3] virt-manager: Add controller model in details

2011-08-25 Thread Marc-André Lureau
--- src/virtManager/details.py |5 + src/vmm-details.glade | 29 + 2 files changed, 34 insertions(+), 0 deletions(-) diff --git a/src/virtManager/details.py b/src/virtManager/details.py index 1fb7d3a..fd6cc3a 100644 --- a/src/virtManager/details.py +++ b

[libvirt] [PATCH 4/4] RFC: Default to ICH9 USB2 controller for Win7

2011-08-25 Thread Marc-André Lureau
We may want to add more guests, though I don't know exactly which version supports it. So this patch is a proof-of-concept/idea. --- virtinst/Guest.py | 26 ++ virtinst/osdict.py |3 +++ virtinst/support.py |6 ++ 3 files changed, 35 insertions(+), 0 deleti

[libvirt] [v2 13/13] Add usb-redir device

2011-08-25 Thread Marc-André Lureau
Fixed since v1: - avoid setup/restore security contexts - some hotplug code improvements, although the lack of dynamic chardev limits the utility of this code for now --- docs/formatdomain.html.in | 15 - docs/schemas/domain.rng| 66 ++

[libvirt] [v2 12/13] Add a usb1 & usb2 qemuxml2argv test

2011-08-25 Thread Marc-André Lureau
--- tests/qemuxml2argvdata/qemuxml2argv-usb1-usb2.args | 15 tests/qemuxml2argvdata/qemuxml2argv-usb1-usb2.xml | 74 tests/qemuxml2argvtest.c |4 + 3 files changed, 93 insertions(+), 0 deletions(-) create mode 100644 tests/qemuxml2argvd

[libvirt] [v2 08/13] Add USB hub device

2011-08-25 Thread Marc-André Lureau
--- docs/formatdomain.html.in| 27 docs/schemas/domain.rng | 13 ++ src/conf/domain_conf.c | 157 +- src/conf/domain_conf.h | 20 +++ src/libvirt_private.syms

[libvirt] [PATCH 1/4] Fix typo s/type/managed

2011-08-25 Thread Marc-André Lureau
--- virtinst/VirtualHostDevice.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/virtinst/VirtualHostDevice.py b/virtinst/VirtualHostDevice.py index d0c1544..2175266 100644 --- a/virtinst/VirtualHostDevice.py +++ b/virtinst/VirtualHostDevice.py @@ -120,7 +120,7 @@ class

[libvirt] [v2 09/13] Modify USB port to be defined as a port path

2011-08-25 Thread Marc-André Lureau
So that devices can be attached to hubs. Example, to attach to first port of a usb-hub on port 1. --- docs/schemas/domain.rng| 11 +-- src/conf/domain_conf.c | 24 ++- src/

[libvirt] [v2 10/13] qemu: don't reserve slot 1 if a PIIX3 USB controller is defined there

2011-08-25 Thread Marc-André Lureau
Changes sinces v1: - apply only to piix3 - check if piix3 controller is on correct address, or report error --- src/qemu/qemu_command.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index aea5bcc..a9dc541 100644

[libvirt] [v2 07/13] Add USB companion controllers support

2011-08-25 Thread Marc-André Lureau
Companion controllers take an extra 'master' attribute to associate them. Changes since v1: - use the same bus index for companion controllers - removed the master bus attribute, redundant with controller index --- docs/formatdomain.html.in | 22 docs/schem

[libvirt] [v2 06/13] USB devices gain a new USB address child element

2011-08-25 Thread Marc-André Lureau
--- docs/schemas/domain.rng| 14 + src/conf/domain_conf.c | 62 +++- src/conf/domain_conf.h | 10 +++ src/qemu/qemu_command.c| 40 ++--- src/qemu/qemu

[libvirt] [v2 02/13] Split virDomainControllerModel to virDomainControllerModelSCSI

2011-08-25 Thread Marc-André Lureau
--- src/conf/domain_conf.c | 26 +++--- src/conf/domain_conf.h | 18 ++ src/esx/esx_driver.c |8 src/libvirt_private.syms |4 ++-- src/vmx/vmx.c| 32 tests/xml2vmxtest.c |2 +-

[libvirt] [v2 03/13] Add USB controller models

2011-08-25 Thread Marc-André Lureau
Changes since v1: - Added pci-ohci --- docs/schemas/domain.rng |9 + src/conf/domain_conf.c | 11 +++ src/conf/domain_conf.h | 13 + src/libvirt_private.syms |2 ++ 4 files changed, 35 insertions(+), 0 deletions(-) diff --git a/docs/schemas/domain.rng

[libvirt] [v2 05/13] USB controller can have a PCI address child element

2011-08-25 Thread Marc-André Lureau
--- .../qemuxml2argv-usb-ich9-ehci-addr.args |1 + .../qemuxml2argv-usb-ich9-ehci-addr.xml| 18 ++ tests/qemuxml2argvtest.c |3 +++ 3 files changed, 22 insertions(+), 0 deletions(-) create mode 100644 tests/qemuxml2argvdata

[libvirt] [v2 01/13] Add various USB devices QEMU_CAPS

2011-08-25 Thread Marc-André Lureau
Changes since v1: - added pci-ohci - removed extra ich9 companions that came with ich9-ehci --- src/qemu/qemu_capabilities.c | 25 + src/qemu/qemu_capabilities.h |8 tests/qemuhelptest.c | 14 +++--- 3 files changed, 44 insertions(+), 3 dele

[libvirt] [v2 00/13] various USB support improvements

2011-08-25 Thread Marc-André Lureau
Hola, This is the second version of the patch set which should address most of the comments I recieved. It should be good enough to let virt-manager & co support USB2 & usb-redirection. Some of the auto-assign of USB addresses etc.. are leftover for future improvements. It should not introduce re

[libvirt] [v2 04/13] Add a new controller type 'usb' with optionnal 'model'

2011-08-25 Thread Marc-André Lureau
The model by default is piix3-uchi. Example: --- docs/formatdomain.html.in | 17 ++- docs/schemas/domain.rng|1 + src/conf/domain_conf.c |7 +- src/conf/domain_conf.h |1 +

Re: [libvirt] [PATCHv3 06/43] snapshot: track current snapshot across restarts

2011-08-25 Thread Eric Blake
On 08/24/2011 10:26 AM, Daniel P. Berrange wrote: On Wed, Aug 24, 2011 at 09:22:23AM -0600, Eric Blake wrote: Audit all changes to the qemu vm->current_snapshot, and make them update the saved xml file for both the previous and the new snapshot, so that there is always at most one snapshot with

Re: [libvirt] [libvirt-virshcmdref 05/14] update documentation for command attach-interface

2011-08-25 Thread Laine Stump
On 08/25/2011 04:14 AM, Hu Tao wrote: --- source/attach-interface.xml | 180 ++- 1 files changed, 176 insertions(+), 4 deletions(-) diff --git a/source/attach-interface.xml b/source/attach-interface.xml + +--script +script + + + script use

Re: [libvirt] [PATCHv3 04/43] snapshot: don't leak resources on qemu snapshot failure

2011-08-25 Thread Eric Blake
On 08/24/2011 10:11 AM, Daniel P. Berrange wrote: On Wed, Aug 24, 2011 at 09:22:21AM -0600, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=727709 mentions that if qemu fails to create the snapshot (such as what happens on Fedora 15 qemu, which has qmp but where savevm is only in h

Re: [libvirt] [libvirt-virshcmdref 14/14] update documentation for command inject-nmi

2011-08-25 Thread Eric Blake
On 08/25/2011 02:15 AM, Hu Tao wrote: --- common.sh |3 ++- source/inject-nmi.xml | 43 +++ 2 files changed, 45 insertions(+), 1 deletions(-) create mode 100644 source/inject-nmi.xml diff --git a/common.sh b/common.sh index 51dc3e1.

Re: [libvirt] [libvirt-virshcmdref 13/14] update documentation for command sendkey

2011-08-25 Thread Eric Blake
On 08/25/2011 02:15 AM, Hu Tao wrote: --- common.sh |2 +- source/send-key.xml | 80 +++ 2 files changed, 81 insertions(+), 1 deletions(-) create mode 100644 source/send-key.xml diff --git a/common.sh b/common.sh index 13e8995

Re: [libvirt] [libvirt-virshcmdref 12/14] update documentation for command memtune

2011-08-25 Thread Eric Blake
On 08/25/2011 02:15 AM, Hu Tao wrote: --- source/memtune.xml | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/source/memtune.xml b/source/memtune.xml index 9dbce75..dd7038c 100644 --- a/source/memtune.xml +++ b/source/memtune.xml ACK and pus

Re: [libvirt] [libvirt-virshcmdref 11/14] update documentation for command schedinfo

2011-08-25 Thread Eric Blake
On 08/25/2011 02:15 AM, Hu Tao wrote: --- source/schedinfo.xml | 76 - 1 files changed, 74 insertions(+), 2 deletions(-) diff --git a/source/schedinfo.xml b/source/schedinfo.xml index 58855a8..f5e5b3e 100644 --- a/source/schedinfo.xml +++ b/so

Re: [libvirt] [libvirt-virshcmdref 10/14] update documentation for command setmaxmem

2011-08-25 Thread Eric Blake
On 08/25/2011 02:15 AM, Hu Tao wrote: --- source/setmaxmem.xml | 50 ++ 1 files changed, 46 insertions(+), 4 deletions(-) diff --git a/source/setmaxmem.xml b/source/setmaxmem.xml index 2c17559..e35c025 100644 --- a/source/setmaxmem.xml +++ b/s

Re: [libvirt] [libvirt-virshcmdref 09/14] update documentation for command setmem

2011-08-25 Thread Eric Blake
On 08/25/2011 02:15 AM, Hu Tao wrote: --- source/setmem.xml | 49 ++--- 1 files changed, 46 insertions(+), 3 deletions(-) diff --git a/source/setmem.xml b/source/setmem.xml index bfdbfec..d7c7154 100644 --- a/source/setmem.xml +++ b/source/setmem.

Re: [libvirt] [libvirt-virshcmdref 07/14] update documentation for command vcpupin

2011-08-25 Thread Eric Blake
On 08/25/2011 02:15 AM, Hu Tao wrote: --- source/vcpupin.xml | 112 ++-- 1 files changed, 108 insertions(+), 4 deletions(-) diff --git a/source/vcpupin.xml b/source/vcpupin.xml index 77ef7d3..48a06b5 100644 --- a/source/vcpupin.xml +++ b/source

Re: [libvirt] [PATCH] Do not try to cancel non-existent migration on source

2011-08-25 Thread Eric Blake
On 08/25/2011 01:03 PM, Jiri Denemark wrote: On Tue, Aug 16, 2011 at 21:39:41 +0200, Jiri Denemark wrote: On Tue, Aug 16, 2011 at 08:33:04 -0600, Eric Blake wrote: On 08/16/2011 04:44 AM, Jiri Denemark wrote: If migration failed on source daemon, the migration is automatically canceled by the

Re: [libvirt] [libvirt-virshcmdref 08/14] update documentation for command vcpuinfo

2011-08-25 Thread Eric Blake
On 08/25/2011 02:15 AM, Hu Tao wrote: --- source/vcpuinfo.xml | 39 +++ 1 files changed, 35 insertions(+), 4 deletions(-) diff --git a/source/vcpuinfo.xml b/source/vcpuinfo.xml index e8748f0..09b2024 100644 --- a/source/vcpuinfo.xml +++ b/source/vcpuinfo.

Re: [libvirt] [PATCH 1/2] qemu: avoid dead store in doPeer2PeerMigrate3

2011-08-25 Thread Eric Blake
On 08/16/2011 03:24 AM, Alex Jia wrote: * src/qemu/qemu_migration.c: avoid dead 'ret' assignment and silence clang warning. Detected by ccc-analyzer: CC libvirt_driver_qemu_la-qemu_migration.lo qemu/qemu_migration.c:2046:5: warning: Value stored to 'ret' is never read ret = qemuM

Re: [libvirt] [PATCH v2] qemu: Correctly label migration TCP socket passed to qemu

2011-08-25 Thread Jiri Denemark
On Thu, Aug 25, 2011 at 18:16:17 +0200, Jiri Denemark wrote: > --- > Notes: > Version 2: > - use virSecurityManagerSetProcessFDLabel instead of > virSecurityManagerSetImageFDLabel since the correct label for > TCP sockets appears to be svirt_t and not svirt_image_t Apparently t

Re: [libvirt] [PATCH] Do not try to cancel non-existent migration on source

2011-08-25 Thread Jiri Denemark
On Tue, Aug 16, 2011 at 21:39:41 +0200, Jiri Denemark wrote: > On Tue, Aug 16, 2011 at 08:33:04 -0600, Eric Blake wrote: > > On 08/16/2011 04:44 AM, Jiri Denemark wrote: > > > If migration failed on source daemon, the migration is automatically > > > canceled by the daemon itself. Thus we don't nee

Re: [libvirt] [libvirt-virshcmdref 06/14] update documentation for command detach-interface

2011-08-25 Thread Eric Blake
On 08/25/2011 02:14 AM, Hu Tao wrote: --- source/detach-interface.xml | 65 +-- 1 files changed, 62 insertions(+), 3 deletions(-) ACK and pushed. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

Re: [libvirt] [libvirt-virshcmdref 05/14] update documentation for command attach-interface

2011-08-25 Thread Eric Blake
On 08/25/2011 02:14 AM, Hu Tao wrote: --- source/attach-interface.xml | 180 ++- 1 files changed, 176 insertions(+), 4 deletions(-) ACK and pushed. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

Re: [libvirt] [libvirt-virshcmdref 04/14] update documentation for command blkiotune

2011-08-25 Thread Eric Blake
On 08/25/2011 02:14 AM, Hu Tao wrote: --- common.sh|2 +- source/blkiotune.xml | 85 ++ 2 files changed, 86 insertions(+), 1 deletions(-) create mode 100644 source/blkiotune.xml diff --git a/common.sh b/common.sh index f48ea

Re: [libvirt] [libvirt-virshcmdref 03/14] update documentation for command autostart

2011-08-25 Thread Eric Blake
On 08/25/2011 02:14 AM, Hu Tao wrote: --- source/autostart.xml | 51 +++-- 1 files changed, 48 insertions(+), 3 deletions(-) diff --git a/source/autostart.xml b/source/autostart.xml index 60c0edc..e9ad738 100644 --- a/source/autostart.xml +++ b/so

Re: [libvirt] [libvirt-virshcmdref 02/14] update documentation for command detach-device

2011-08-25 Thread Eric Blake
On 08/25/2011 02:14 AM, Hu Tao wrote: --- source/detach-device.xml | 124 -- 1 files changed, 120 insertions(+), 4 deletions(-) diff --git a/source/detach-device.xml b/source/detach-device.xml index 0475e19..85ab17b 100644 --- a/source/detach-devic

Re: [libvirt] [libvirt-virshcmdref 01/14] update documentation for command attach-device

2011-08-25 Thread Eric Blake
On 08/25/2011 02:14 AM, Hu Tao wrote: --- source/attach-device.xml | 143 -- 1 files changed, 137 insertions(+), 6 deletions(-) diff --git a/source/attach-device.xml b/source/attach-device.xml index efa46f0..18e3262 100644 --- a/source/attach-devic

Re: [libvirt] [PATCH 2/2] Detect errors from the 'sendkey' command

2011-08-25 Thread Eric Blake
On 08/25/2011 10:49 AM, Daniel P. Berrange wrote: From: "Daniel P. Berrange" On success, the 'sendkey' command does not return any data, so any data in the reply should be considered to be an error message * src/qemu/qemu_monitor_text.c: Treat non-"" reply data as an error message for 'sendk

Re: [libvirt] [PATCH 1/2] Fix keymap used to talk with QEMU

2011-08-25 Thread Eric Blake
On 08/25/2011 10:49 AM, Daniel P. Berrange wrote: From: "Daniel P. Berrange" The QEMU 'sendkey' command expects keys to be encoded in the same way as the RFB extended keycode set. Specfically it wants extended s/Specfically/Specifically/ keys to have the high bit of the first byte set, while

[libvirt] [PATCH 2/2] Detect errors from the 'sendkey' command

2011-08-25 Thread Daniel P. Berrange
From: "Daniel P. Berrange" On success, the 'sendkey' command does not return any data, so any data in the reply should be considered to be an error message * src/qemu/qemu_monitor_text.c: Treat non-"" reply data as an error message for 'sendkey' command --- src/qemu/qemu_monitor_text.c | 15

Re: [libvirt] problem of escaped scancodes

2011-08-25 Thread Daniel P. Berrange
On Thu, Aug 25, 2011 at 10:25:57AM +0900, KAMEZAWA Hiroyuki wrote: > On Tue, 23 Aug 2011 14:54:11 +0100 > "Daniel P. Berrange" wrote: > > > No, we just need to switch to use the correct scancode set. > > > > The original keymap-gen.pl script in GTK-VNC has code for auto-generating > > the RFB s

[libvirt] [PATCH 1/2] Fix keymap used to talk with QEMU

2011-08-25 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The QEMU 'sendkey' command expects keys to be encoded in the same way as the RFB extended keycode set. Specfically it wants extended keys to have the high bit of the first byte set, while the Linux XT KBD driver codeset uses the low bit of the second byte. To deal with

[libvirt] [PATCH v2] qemu: Correctly label migration TCP socket passed to qemu

2011-08-25 Thread Jiri Denemark
--- Notes: Version 2: - use virSecurityManagerSetProcessFDLabel instead of virSecurityManagerSetImageFDLabel since the correct label for TCP sockets appears to be svirt_t and not svirt_image_t src/qemu/qemu_migration.c |9 ++--- 1 files changed, 6 insertions(+), 3 dele

Re: [libvirt] [PATCH] rpc: ensure the value of nrequests for client not to be negative

2011-08-25 Thread Guannan Ren
On 08/25/2011 11:36 PM, Daniel P. Berrange wrote: On Thu, Aug 25, 2011 at 10:07:36PM +0800, Guannan Ren wrote: The value of nrequests should always be zero or positive but in the case of stream, when error occurrs, it could be negative and makes the client socket fd neither writable nor readable

Re: [libvirt] [PATCH] qemu: Correctly label migration TCP socket passed to qemu

2011-08-25 Thread Daniel P. Berrange
On Thu, Aug 25, 2011 at 12:35:57PM +0200, Jiri Denemark wrote: > --- > src/qemu/qemu_migration.c |9 ++--- > 1 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c > index a84faf6..d787a09 100644 > --- a/src/qemu/qemu_migrat

Re: [libvirt] [PATCH] rpc: ensure the value of nrequests for client not to be negative

2011-08-25 Thread Daniel P. Berrange
On Thu, Aug 25, 2011 at 10:07:36PM +0800, Guannan Ren wrote: > The value of nrequests should always be zero or positive > but in the case of stream, when error occurrs, it could be negative > and makes the client socket fd neither writable nor readable. The > case will lead to hang on libvirt clien

[libvirt] [PATCH] rpc: ensure the value of nrequests for client not to be negative

2011-08-25 Thread Guannan Ren
The value of nrequests should always be zero or positive but in the case of stream, when error occurrs, it could be negative and makes the client socket fd neither writable nor readable. The case will lead to hang on libvirt client side. This patch aim to fix the problem. --- src/rpc/virnetserverc

Re: [libvirt] [PATCH 1/3 v2] daemon: Create priority workers pool

2011-08-25 Thread Daniel P. Berrange
On Tue, Aug 23, 2011 at 08:22:01PM +0200, Michal Privoznik wrote: > This patch annotates APIs with low or high priority. > In low set MUST be all APIs which might eventually access monitor > (and thus block indefinitely). Other APIs may be marked as high > priority. However, some must be (e.g. doma

Re: [libvirt] [PATCH] qemu: Correctly label migration TCP socket passed to qemu

2011-08-25 Thread Eric Blake
On 08/25/2011 08:30 AM, Jiri Denemark wrote: -VIR_FORCE_CLOSE(spec->dest.fd.qemu); Unconditional, changed to... +if (virSecurityManagerSetImageFDLabel(driver->securityManager, vm, + spec->dest.fd.qemu) == 0) { +ret = qem

Re: [libvirt] [PATCH 3/3 v2] qemu: Deal with stucked qemu on daemon startup

2011-08-25 Thread Daniel P. Berrange
On Tue, Aug 23, 2011 at 08:22:18PM +0200, Michal Privoznik wrote: > If libvirt daemon gets restarted and there is (at least) one > unresponsive qemu, the startup procedure hangs up. This patch creates > one thread per vm in which we try to reconnect to monitor. Therefore, > blocking in one thread w

Re: [libvirt] [PATCH] qemu: Correctly label migration TCP socket passed to qemu

2011-08-25 Thread Jiri Denemark
On Thu, Aug 25, 2011 at 08:16:58 -0600, Eric Blake wrote: > On 08/25/2011 04:35 AM, Jiri Denemark wrote: > > --- > > src/qemu/qemu_migration.c |9 ++--- > > 1 files changed, 6 insertions(+), 3 deletions(-) > > > > diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c > > ind

Re: [libvirt] [PATCH 1/3] daemon: Create priority workers pool

2011-08-25 Thread Daniel P. Berrange
On Wed, Aug 24, 2011 at 10:12:36PM +0100, Daniel P. Berrange wrote: > On Tue, Aug 23, 2011 at 05:53:35PM +0200, Michal Privoznik wrote: > > On 23.08.2011 14:23, Daniel P. Berrange wrote: > > > On Tue, Aug 16, 2011 at 06:39:10PM +0200, Michal Privoznik wrote: > > >> diff --git a/src/util/threadpool.

Re: [libvirt] [PATCH] qemu: Correctly label migration TCP socket passed to qemu

2011-08-25 Thread Eric Blake
On 08/25/2011 04:35 AM, Jiri Denemark wrote: --- src/qemu/qemu_migration.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index a84faf6..d787a09 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_mi

Re: [libvirt] [PATCH v2] remote: Refuse connecting to remote socket

2011-08-25 Thread Eric Blake
On 08/25/2011 02:04 AM, Michal Privoznik wrote: Then again, remoteError already automatically adds the function name (since it is a macro that includes __func__), so your repeat of the name is redundant. Also, why not list the parsed server, in case it helps the user: remoteError(VIR_ERR_INVALI

Re: [libvirt] Notes from the KVM Forum relevant to libvirt

2011-08-25 Thread Daniel P. Berrange
On Thu, Aug 25, 2011 at 08:58:27AM -0500, Serge E. Hallyn wrote: > Quoting Stefan Hajnoczi (stefa...@gmail.com): > > On Thu, Aug 25, 2011 at 11:03 AM, Daniel P. Berrange > > wrote: > > > On Thu, Aug 25, 2011 at 10:10:27AM +0100, Stefan Hajnoczi wrote: > > >> On Wed, Aug 24, 2011 at 3:46 PM, Daniel

Re: [libvirt] RFCv2: virDomainSnapshotCreateXML enhancements

2011-08-25 Thread Eric Blake
On 08/25/2011 05:54 AM, Stefan Hajnoczi wrote: On Tue, Aug 23, 2011 at 4:47 PM, Eric Blake wrote: On 08/23/2011 09:35 AM, Stefan Hajnoczi wrote: On Tue, Aug 23, 2011 at 4:18 PM, Eric Blakewrote: On 08/23/2011 09:12 AM, Stefan Hajnoczi wrote: The kinds of apps I am thinking about cann

Re: [libvirt] Notes from the KVM Forum relevant to libvirt

2011-08-25 Thread Serge E. Hallyn
Quoting Stefan Hajnoczi (stefa...@gmail.com): > On Thu, Aug 25, 2011 at 11:03 AM, Daniel P. Berrange > wrote: > > On Thu, Aug 25, 2011 at 10:10:27AM +0100, Stefan Hajnoczi wrote: > >> On Wed, Aug 24, 2011 at 3:46 PM, Daniel P. Berrange > >> wrote: > >> > On Wed, Aug 24, 2011 at 03:20:57PM +0100,

Re: [libvirt] RFCv2: virDomainSnapshotCreateXML enhancements

2011-08-25 Thread Stefan Hajnoczi
On Tue, Aug 23, 2011 at 4:47 PM, Eric Blake wrote: > On 08/23/2011 09:35 AM, Stefan Hajnoczi wrote: >> >> On Tue, Aug 23, 2011 at 4:18 PM, Eric Blake  wrote: >>> >>> On 08/23/2011 09:12 AM, Stefan Hajnoczi wrote: >>  The >> kinds of apps I am thinking about cannot make use of this API. > > What so

[libvirt] [test-API][PATCH v2] Add ownership_test.py test case

2011-08-25 Thread Wayne Sun
* Save a domain to a file, check the ownership of the file after save and restore operation --- repos/domain/ownership_test.py | 302 1 files changed, 302 insertions(+), 0 deletions(-) create mode 100644 repos/domain/ownership_test.py diff --git a/

Re: [libvirt] [PATCH] Fix command test wrt gnutls initialize & fix debugging

2011-08-25 Thread Eric Blake
On 08/25/2011 05:08 AM, Daniel P. Berrange wrote: From: "Daniel P. Berrange" The VIR_TEST_DEBUG and VIR_TEST_VERBOSE env vars did not work because we replaced 'environ' with 'newenv'. Simply calling virTestGetDebug/Verbose() before replacing the 'environ' ensures we have processed the env variab

[libvirt] [PATCH] Fix command test wrt gnutls initialize & fix debugging

2011-08-25 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The VIR_TEST_DEBUG and VIR_TEST_VERBOSE env vars did not work because we replaced 'environ' with 'newenv'. Simply calling virTestGetDebug/Verbose() before replacing the 'environ' ensures we have processed the env variables. The gnutls initialization code opens /dev/ura

Re: [libvirt] [PATCH] qemu: Correctly label migration TCP socket passed to qemu

2011-08-25 Thread Daniel Veillard
On Thu, Aug 25, 2011 at 12:35:57PM +0200, Jiri Denemark wrote: > --- > src/qemu/qemu_migration.c |9 ++--- > 1 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c > index a84faf6..d787a09 100644 > --- a/src/qemu/qemu_migrat

[libvirt] [PATCH] qemu: Correctly label migration TCP socket passed to qemu

2011-08-25 Thread Jiri Denemark
--- src/qemu/qemu_migration.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index a84faf6..d787a09 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -1484,9 +1484,12 @@ qemuMigrationRun

Re: [libvirt] Notes from the KVM Forum relevant to libvirt

2011-08-25 Thread Stefan Hajnoczi
On Thu, Aug 25, 2011 at 11:03 AM, Daniel P. Berrange wrote: > On Thu, Aug 25, 2011 at 10:10:27AM +0100, Stefan Hajnoczi wrote: >> On Wed, Aug 24, 2011 at 3:46 PM, Daniel P. Berrange >> wrote: >> > On Wed, Aug 24, 2011 at 03:20:57PM +0100, Stefan Hajnoczi wrote: >> >> On Tue, Aug 23, 2011 at 4:31

[libvirt] ALERT Virtualization Automatic Builder

2011-08-25 Thread berrange
Overall status: failed Start date: Thu Aug 25 2011 Start time: 11:05:02 UTC / 07:05:02 EDT Build counter: 1314270302 Build timestamp: 1314270302 URL: http://builder.virt-tools.org/index.html Module: libvirt Status: failed URL: http://builder.virt-tools.org/module-libvirt.html -- libvir-list mai

Re: [libvirt] Notes from the KVM Forum relevant to libvirt

2011-08-25 Thread Daniel P. Berrange
On Thu, Aug 25, 2011 at 10:10:27AM +0100, Stefan Hajnoczi wrote: > On Wed, Aug 24, 2011 at 3:46 PM, Daniel P. Berrange > wrote: > > On Wed, Aug 24, 2011 at 03:20:57PM +0100, Stefan Hajnoczi wrote: > >> On Tue, Aug 23, 2011 at 4:31 PM, Daniel P. Berrange > >> wrote: > >> > On Tue, Aug 23, 2011 a

Re: [libvirt] Notes from the KVM Forum relevant to libvirt

2011-08-25 Thread Stefan Hajnoczi
On Wed, Aug 24, 2011 at 3:46 PM, Daniel P. Berrange wrote: > On Wed, Aug 24, 2011 at 03:20:57PM +0100, Stefan Hajnoczi wrote: >> On Tue, Aug 23, 2011 at 4:31 PM, Daniel P. Berrange >> wrote: >> > On Tue, Aug 23, 2011 at 04:24:46PM +0100, Stefan Hajnoczi wrote: >> >> On Tue, Aug 23, 2011 at 12:15

[libvirt] [libvirt-virshcmdref 11/14] update documentation for command schedinfo

2011-08-25 Thread Hu Tao
--- source/schedinfo.xml | 76 - 1 files changed, 74 insertions(+), 2 deletions(-) diff --git a/source/schedinfo.xml b/source/schedinfo.xml index 58855a8..f5e5b3e 100644 --- a/source/schedinfo.xml +++ b/source/schedinfo.xml @@ -9,13 +9,85 @@

[libvirt] [libvirt-virshcmdref 02/14] update documentation for command detach-device

2011-08-25 Thread Hu Tao
--- source/detach-device.xml | 124 -- 1 files changed, 120 insertions(+), 4 deletions(-) diff --git a/source/detach-device.xml b/source/detach-device.xml index 0475e19..85ab17b 100644 --- a/source/detach-device.xml +++ b/source/detach-device.xml @@ -9

[libvirt] [libvirt-virshcmdref 13/14] update documentation for command sendkey

2011-08-25 Thread Hu Tao
--- common.sh |2 +- source/send-key.xml | 80 +++ 2 files changed, 81 insertions(+), 1 deletions(-) create mode 100644 source/send-key.xml diff --git a/common.sh b/common.sh index 13e8995..51dc3e1 100755 --- a/common.sh +++ b/commo

[libvirt] [libvirt-virshcmdref 14/14] update documentation for command inject-nmi

2011-08-25 Thread Hu Tao
--- common.sh |3 ++- source/inject-nmi.xml | 43 +++ 2 files changed, 45 insertions(+), 1 deletions(-) create mode 100644 source/inject-nmi.xml diff --git a/common.sh b/common.sh index 51dc3e1..5db5ecb 100755 --- a/common.sh +++ b/common

[libvirt] [libvirt-virshcmdref 08/14] update documentation for command vcpuinfo

2011-08-25 Thread Hu Tao
--- source/vcpuinfo.xml | 39 +++ 1 files changed, 35 insertions(+), 4 deletions(-) diff --git a/source/vcpuinfo.xml b/source/vcpuinfo.xml index e8748f0..09b2024 100644 --- a/source/vcpuinfo.xml +++ b/source/vcpuinfo.xml @@ -5,20 +5,51 @@ - R

[libvirt] [libvirt-virshcmdref 10/14] update documentation for command setmaxmem

2011-08-25 Thread Hu Tao
--- source/setmaxmem.xml | 50 ++ 1 files changed, 46 insertions(+), 4 deletions(-) diff --git a/source/setmaxmem.xml b/source/setmaxmem.xml index 2c17559..e35c025 100644 --- a/source/setmaxmem.xml +++ b/source/setmaxmem.xml @@ -9,16 +9,58 @@

[libvirt] [libvirt-virshcmdref 01/14] update documentation for command attach-device

2011-08-25 Thread Hu Tao
--- source/attach-device.xml | 143 -- 1 files changed, 137 insertions(+), 6 deletions(-) diff --git a/source/attach-device.xml b/source/attach-device.xml index efa46f0..18e3262 100644 --- a/source/attach-device.xml +++ b/source/attach-device.xml @@ -5

[libvirt] [libvirt-virshcmdref 04/14] update documentation for command blkiotune

2011-08-25 Thread Hu Tao
--- common.sh|2 +- source/blkiotune.xml | 85 ++ 2 files changed, 86 insertions(+), 1 deletions(-) create mode 100644 source/blkiotune.xml diff --git a/common.sh b/common.sh index f48ea40..13e8995 100755 --- a/common.sh +++ b/com

[libvirt] [libvirt-virshcmdref 12/14] update documentation for command memtune

2011-08-25 Thread Hu Tao
--- source/memtune.xml | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/source/memtune.xml b/source/memtune.xml index 9dbce75..dd7038c 100644 --- a/source/memtune.xml +++ b/source/memtune.xml @@ -90,6 +90,33 @@ + + --confi

[libvirt] [libvirt-virshcmdref 09/14] update documentation for command setmem

2011-08-25 Thread Hu Tao
--- source/setmem.xml | 49 ++--- 1 files changed, 46 insertions(+), 3 deletions(-) diff --git a/source/setmem.xml b/source/setmem.xml index bfdbfec..d7c7154 100644 --- a/source/setmem.xml +++ b/source/setmem.xml @@ -9,16 +9,59 @@ - +

[libvirt] [libvirt-virshcmdref 07/14] update documentation for command vcpupin

2011-08-25 Thread Hu Tao
--- source/vcpupin.xml | 112 ++-- 1 files changed, 108 insertions(+), 4 deletions(-) diff --git a/source/vcpupin.xml b/source/vcpupin.xml index 77ef7d3..48a06b5 100644 --- a/source/vcpupin.xml +++ b/source/vcpupin.xml @@ -5,20 +5,124 @@

[libvirt] [libvirt-virshcmdref 05/14] update documentation for command attach-interface

2011-08-25 Thread Hu Tao
--- source/attach-interface.xml | 180 ++- 1 files changed, 176 insertions(+), 4 deletions(-) diff --git a/source/attach-interface.xml b/source/attach-interface.xml index 199bf98..cc5d9ad 100644 --- a/source/attach-interface.xml +++ b/source/attach-interfa

[libvirt] [libvirt-virshcmdref 03/14] update documentation for command autostart

2011-08-25 Thread Hu Tao
--- source/autostart.xml | 51 +++-- 1 files changed, 48 insertions(+), 3 deletions(-) diff --git a/source/autostart.xml b/source/autostart.xml index 60c0edc..e9ad738 100644 --- a/source/autostart.xml +++ b/source/autostart.xml @@ -10,16 +10,61 @@

[libvirt] [libvirt-virshcmdref 06/14] update documentation for command detach-interface

2011-08-25 Thread Hu Tao
--- source/detach-interface.xml | 65 +-- 1 files changed, 62 insertions(+), 3 deletions(-) diff --git a/source/detach-interface.xml b/source/detach-interface.xml index 7786fcb..f995c49 100644 --- a/source/detach-interface.xml +++ b/source/detach-interfac

Re: [libvirt] [PATCH v2] remote: Refuse connecting to remote socket

2011-08-25 Thread Michal Privoznik
On 24.08.2011 18:01, Eric Blake wrote: > On 08/24/2011 03:41 AM, Michal Privoznik wrote: >> If users wants to connect to remote unix socket, e.g. >> 'qemu+unix:///system' currently the part is ignored, >> ending up connecting to localhost. Connecting to remote socket is not >> supported and user s