[libvirt] [PATCH]lxc: improve readability of lxcContainer[Send|Waitfor]Continue

2013-10-16 Thread Chen Hanxiao
From: Chen Hanxiao chenhanx...@cn.fujitsu.com Currently, lxcContainer[Send|Waitfor]Continue only tell us 'fd', but we had to deal with the interaction between lxc_[container|controller|process]. This patch adds parameters to identify the caller. Signed-off-by: Chen Hanxiao

Re: [libvirt] [PATCHv2 15/23] qemu: Clean up check of maximum cpu count supported by a machine type

2013-10-16 Thread Peter Krempa
On 10/15/13 15:33, Daniel P. Berrange wrote: On Tue, Oct 15, 2013 at 02:30:44PM +0200, Peter Krempa wrote: Reword the error message and change formating to avoid exceeding 80 columns of text. --- src/qemu/qemu_process.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) ...

Re: [libvirt] [libvirt-glib PATCH] Add filterref and filterref parameter support.

2013-10-16 Thread Christophe Fergeau
On Tue, Oct 15, 2013 at 12:05:02PM -0700, Ian Main wrote: This patch adds support for setting filterref's on interfaces. Also supported are parameters to the filterref's. This mostly looks good, some comments below. Signed-off-by: Ian Main im...@redhat.com --- examples/config-demo.py

Re: [libvirt] [PATCHv2 16/23] cpu: Export few x86-specific APIs

2013-10-16 Thread Peter Krempa
On 10/15/13 15:37, Daniel P. Berrange wrote: On Tue, Oct 15, 2013 at 02:30:45PM +0200, Peter Krempa wrote: From: Jiri Denemark jdene...@redhat.com This makes virCPUx86DataAddCPUID, virCPUx86DataFree, and virCPUx86MakeData available for direct usage outside of cpu driver. Presumably these

Re: [libvirt] [PATCH] storage: document existing pools

2013-10-16 Thread Ján Tomko
On 10/16/2013 01:18 AM, Eric Blake wrote: We forgot to document several pool types. Furthermore, the RNG grammar did not allow arbitrary interleaving, which makes it harder than necessary to create a new pool from XML. * docs/formatstorage.html.in: Add docs for scsi, mpath, rbd, and

[libvirt] [PATCH 1/6 v2] Add virFileIsMountPoint function

2013-10-16 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Add a function for efficiently checking if a path is a filesystem mount point. NB will not work for bind mounts, only true filesystem mounts. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/libvirt_private.syms | 1 +

Re: [libvirt] [PATCH 6/6] Skip any files which are not mounted on the host

2013-10-16 Thread Daniel P. Berrange
On Tue, Oct 08, 2013 at 09:24:50PM -0600, Eric Blake wrote: On 10/07/2013 07:06 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Currently the LXC container tries to skip selinux/securityfs mounts if the directory does not exist in the filesystem, or if

Re: [libvirt] [PATCH] build: use the gnulib version of the .m4 files when present

2013-10-16 Thread Giuseppe Scrivano
Giuseppe Scrivano gscri...@redhat.com writes: prevent aclocal to prefer .m4 files under m4/ to the version provided by gnulib. I have noticed this after './configure --help' gave me two different versions of --enable-threads. This was caused by aclocal that preferred the version of lock.m4

[libvirt] [PATCH v2] Introduce new OOM testing support

2013-10-16 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The previous OOM testing support would re-run the entire main method each iteration, failing a different malloc each time. When a test suite has 'n' allocations, the number of repeats requires is (n * (n + 1) ) / 2. This gets very large, very

[libvirt] [PATCH] qemu: Fix the wrong logic of building cmd line for volume type disk

2013-10-16 Thread Osier Yang
It builds a libiscsi uri if the volume type is file and disk-auth.username is specified, but I even see no reason to build the libiscsi uri for a file type volume, and the logic to check whether disk-auth.username is specified is also beyond understanding. It produces unexpected result like

Re: [libvirt] [PATCH] build: use the gnulib version of the .m4 files when present

2013-10-16 Thread Daniel P. Berrange
On Mon, Oct 07, 2013 at 11:44:45PM +0200, Giuseppe Scrivano wrote: prevent aclocal to prefer .m4 files under m4/ to the version provided by gnulib. I have noticed this after './configure --help' gave me two different versions of --enable-threads. This was caused by aclocal that preferred

Re: [libvirt] [PATCH] qemu: Fix the wrong logic of building cmd line for volume type disk

2013-10-16 Thread Daniel P. Berrange
On Wed, Oct 16, 2013 at 08:18:28PM +0800, Osier Yang wrote: It builds a libiscsi uri if the volume type is file and disk-auth.username is specified, but I even see no reason to build the libiscsi uri for a file type volume, and the logic to check whether disk-auth.username is specified is also

Re: [libvirt] [PATCH v2] rpc: Correct the wrong payload size checking

2013-10-16 Thread Daniel P. Berrange
On Tue, Oct 15, 2013 at 11:15:32PM +0800, Osier Yang wrote: ... /* Size of message length field. Not counted in VIR_NET_MESSAGE_MAX * and VIR_NET_MESSAGE_INITIAL. */ const VIR_NET_MESSAGE_LEN_MAX = 4; /... However, msg-bufferLength includes the length word. The wrong checking was

Re: [libvirt] [PATCH v2] rpc: Correct the wrong payload size checking

2013-10-16 Thread Osier Yang
On 16/10/13 20:31, Daniel P. Berrange wrote: On Tue, Oct 15, 2013 at 11:15:32PM +0800, Osier Yang wrote: ... /* Size of message length field. Not counted in VIR_NET_MESSAGE_MAX * and VIR_NET_MESSAGE_INITIAL. */ const VIR_NET_MESSAGE_LEN_MAX = 4; /... However, msg-bufferLength includes the

Re: [libvirt] [PATCH] build: use the gnulib version of the .m4 files when present

2013-10-16 Thread Giuseppe Scrivano
Daniel P. Berrange berra...@redhat.com writes: and looking at what is run by autogen.sh with strace, it seems to use 'aclocal -I m4 -I gnulib/m4'. So this bootstrap.conf ACLOCAL setting doesn't appear to have any effect. thanks to have checked it. It seems that using directly the bootstrap

[libvirt] [PATCH] remote-driver: Fix 'leav' typo in comment

2013-10-16 Thread Christophe Fergeau
--- Pushed under the trivial rule. src/remote/remote_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 96ccb99..87ef5a9 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -3721,7

Re: [libvirt] PATCH: better error checking for LOCAL_PEERCRED

2013-10-16 Thread Brian Candler
On 15/10/2013 12:16, Daniel P. Berrange wrote: Unfortunately your patch does not apply since your mail client has messed up line wrapping. Also there have been conflicting changes to the code since your patch. I would fix it myself, but I don't have ability to compile test code on BSD platforms.

Re: [libvirt] [PATCH] storage: document existing pools

2013-10-16 Thread Eric Blake
On 10/16/2013 05:03 AM, Ján Tomko wrote: On 10/16/2013 01:18 AM, Eric Blake wrote: We forgot to document several pool types. Furthermore, the RNG grammar did not allow arbitrary interleaving, which makes it harder than necessary to create a new pool from XML. * docs/formatstorage.html.in:

Re: [libvirt] [PATCH] build: use the gnulib version of the .m4 files when present

2013-10-16 Thread Eric Blake
On 10/16/2013 07:38 AM, Giuseppe Scrivano wrote: Daniel P. Berrange berra...@redhat.com writes: and looking at what is run by autogen.sh with strace, it seems to use 'aclocal -I m4 -I gnulib/m4'. So this bootstrap.conf ACLOCAL setting doesn't appear to have any effect. thanks to have

Re: [libvirt] [PATCH] build: use the gnulib version of the .m4 files when present

2013-10-16 Thread Eric Blake
On 10/07/2013 03:44 PM, Giuseppe Scrivano wrote: prevent aclocal to prefer .m4 files under m4/ to the version provided by gnulib. s/to prefer/from preferring/; s/to the/over the/ I have noticed this after './configure --help' gave me two different versions of --enable-threads. This was

[libvirt] [PATCH]virsh: fix a typo in virsh-domain

2013-10-16 Thread Chen Hanxiao
From: Chen Hanxiao chenhanx...@cn.fujitsu.com s/it's/its Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- tools/virsh-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 6d241db..9017cac 100644 ---

Re: [libvirt] Migration issue php-libvirt

2013-10-16 Thread Umar Draz
HI, I am using KVM Br. Umar On Tue, Oct 15, 2013 at 4:11 PM, Daniel P. Berrange berra...@redhat.comwrote: On Sun, Oct 13, 2013 at 03:20:31PM +0500, Umar Draz wrote: Hi All I am trying to migrate offline domain on other URI but its not working due to this error Failure!Libvirt

[libvirt] [PATCH]virsh: improve usability of '--print-xml' flag for attach-disk command

2013-10-16 Thread Chen Hanxiao
From: Chen Hanxiao chenhanx...@cn.fujitsu.com '--print-xml' option is very useful for doing some test. But we had to specify a real domain for it. This patch could enable us to specify a fake domain when using --print-xml option. Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com ---