Re: [libvirt] [PATCH] storage: fix memory leak with encrypted images

2014-06-09 Thread Jim Fehlig
Eric Blake wrote: > Jim Fehlig reported a regression found by libvirt-TCK tests: > > >> ~ # perl /usr/share/libvirt-tck/tests/qemu/100-disk-encryption.t >> > ... > >> ok 4 - defined persistent domain config >> # Starting inactive domain config >> libvirt error code: 1, message: internal

[libvirt] [PATCH v3] QEMU: parse '-device vfio-pci' and '-device pci-assign'

2014-06-09 Thread Olivia Yin
Signed-off-by: Olivia Yin Signed-off-by: Laine Stump Modify the existing function qemuParseCommandLinePCI(), which works with -pcidevice, to support for "-device pci-assign" and "-device pci-assign". Change test cases 'hostdev-vfio' and 'hostdev-pci-address-device' to validate the new function

Re: [libvirt] [patch v2 1/1] manual: Add virsh manual about specified migration host

2014-06-09 Thread Yasunori Goto
Chen-san, Looks good to me. Thanks, > the 'migration_host' description maybe have a bit of difficulty to > understand for user, so add this manual for them. > > Signed-off-by: Chen Fan > --- > tools/virsh.pod | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git

Re: [libvirt] [PATCH] SELinux: don't silently fail when no label is present

2014-06-09 Thread Eric Blake
On 06/09/2014 08:30 AM, Ján Tomko wrote: > This fixes startup of a domain with: > > on a host with selinux and dac drivers and > security_default_confined = 0 > > https://bugzilla.redhat.com/show_bug.cgi?id=1105939 > --- > src/security/security_selinux.c | 98 > -

[libvirt] [PATCH] storage: fix memory leak with encrypted images

2014-06-09 Thread Eric Blake
Jim Fehlig reported a regression found by libvirt-TCK tests: > ~ # perl /usr/share/libvirt-tck/tests/qemu/100-disk-encryption.t ... > ok 4 - defined persistent domain config > # Starting inactive domain config > libvirt error code: 1, message: internal error: unable to execute QEMU command > 'cont

[libvirt] [PATCH] SELinux: don't silently fail when no label is present

2014-06-09 Thread Ján Tomko
This fixes startup of a domain with: on a host with selinux and dac drivers and security_default_confined = 0 https://bugzilla.redhat.com/show_bug.cgi?id=1105939 --- src/security/security_selinux.c | 98 - 1 file changed, 29 insertions(+), 69 deletions(-)

[libvirt] QMP fallback race in libvirt

2014-06-09 Thread Ron
Hi, Eric asked me to move this here from #virt so it doesn't get forgotten. I hit a weird bug in a new install of libvirt on Debian Jessie this week where a vm could not be configured to use any CPU type except passthrough. After much digging and headscratching, the immediate cause for that tur

Re: [libvirt] [PATCHv3 07/36] storage: Switch metadata crawler to use storage driver to get unique path

2014-06-09 Thread Roman Bogorodskiy
Peter Krempa wrote: > On 06/07/14 20:35, Roman Bogorodskiy wrote: > > Peter Krempa wrote: > > > >> Use the virStorageFileGetUniqueIdentifier() function to get a unique > >> identifier regardless of the target storage type instead of relying on > >> canonicalize_path(). > >> > >> A new functio

Re: [libvirt] [PATCH RFC] network: Bring netdevs online later

2014-06-09 Thread Laine Stump
On 06/04/2014 05:55 PM, Matthew Rosato wrote: > Defer MAC registration until net devices are actually going > to be used by the guest. This patch does so by setting the > devices online just before starting guest CPUs. > > This approach is an alternative to my previously proposed > 'network: Defer

[libvirt] [PATCH] test: add user_xattr check for securityselinuxlabeltest

2014-06-09 Thread Jincheng Miao
libvirt unit test used setxattr with "user.libvirt.selinux" name to emulate setfilecon of selinux. But for some old kernel filesystem (like 2.6.32-431.el6.x86_64), if the filesystem is not mounted with user_xattr flag, the setxattr with "user.libvirt.selinux" will fail. So adding testUserXattrEnab

Re: [libvirt] [PATCH] libxl: support interface type=network

2014-06-09 Thread Laine Stump
On 06/07/2014 12:30 AM, Jim Fehlig wrote: > Add support for in the libxl driver. > > Signed-off-by: Jim Fehlig > --- > src/libxl/libxl_conf.c | 41 +++-- > 1 file changed, 39 insertions(+), 2 deletions(-) > > diff --git a/src/libxl/libxl_conf.c b/src/libxl/lib

Re: [libvirt] [PATCH 0/3] patches necessary to make the "parse vfio in commandline" work

2014-06-09 Thread Laine Stump
On 06/06/2014 04:54 PM, Laine Stump wrote: > Patches 1/3 and 2/3 are prerequisites the the patch that started this > thread. Patch 3/3 should be squashed into the original patch. > > I also noticed that the original patch causes all unrecognized > "-device" options to now be ignored rather than bei

Re: [libvirt] [PATCH 0/3] patches necessary to make the "parse vfio in commandline" work

2014-06-09 Thread Laine Stump
On 06/06/2014 05:32 PM, Eric Blake wrote: > On 06/06/2014 07:54 AM, Laine Stump wrote: >> Patches 1/3 and 2/3 are prerequisites the the patch that started this >> thread. Patch 3/3 should be squashed into the original patch. >> >> I also noticed that the original patch causes all unrecognized >> "-

Re: [libvirt] [PATCHv2] QEMU: Modify qemuParseCommandLinePCI() to parsee '-device vfio-pci'

2014-06-09 Thread Laine Stump
On 06/09/2014 10:26 AM, Olivia Yin wrote: > Signed-off-by: Olivia Yin > > Modify qemuParseCommandLinePCI() to support parsing '-device > vfio-pci,host=bus:slot.func'. > Add test case 'hostdev-vfio' into qemuargv2xmltest to validate this function. > > The case related to QEMU_CAPS_HOST_PCI_MULTIDO

[libvirt] [PATCH] qemu: parse -device virtio-balloon

2014-06-09 Thread Laine Stump
There are no options to parse here, and all three possible device names have the same prefix ("virtio-balloon" with "-ccw", "-pci", or "-device" appended), so it is fairly simple. qemuParseCommandLineString() previously would always add a to every result (the comments erroneously say that it is a

[libvirt] [patch v2 1/1] manual: Add virsh manual about specified migration host

2014-06-09 Thread Chen Fan
the 'migration_host' description maybe have a bit of difficulty to understand for user, so add this manual for them. Signed-off-by: Chen Fan --- tools/virsh.pod | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 02671b4..7b302

Re: [libvirt] [PATCH] vmware: make version parsing more robust

2014-06-09 Thread Jean-Baptiste Rouault
On Monday 28 April 2014 13:46:54 Ján Tomko wrote: > On 04/09/2014 11:59 AM, Jean-Baptiste Rouault wrote: > > Since commit d69415d4, vmware version is parsed from both stdout and > > stderr. This patch makes version parsing work even if there is garbage > > (libvirt debug messages for example) in th

Re: [libvirt] [PATCH] parallels: Avoid possible leak of "cpu" from parallelsBuildCapabilities

2014-06-09 Thread Peter Krempa
On 06/09/14 09:43, Martin Kletzander wrote: > On Mon, Jun 09, 2014 at 09:39:44AM +0200, Peter Krempa wrote: >> 4d06af97d38c3648937eb8f732704379b3cd9e59 introduced a possible memory >> leak of the memory allocated into the "cpu" pointer in >> parallelsBuildCapabilities in the case "nodeGetInfo()" wo

Re: [libvirt] [PATCHv3 07/36] storage: Switch metadata crawler to use storage driver to get unique path

2014-06-09 Thread Peter Krempa
On 06/07/14 20:35, Roman Bogorodskiy wrote: > Peter Krempa wrote: > >> Use the virStorageFileGetUniqueIdentifier() function to get a unique >> identifier regardless of the target storage type instead of relying on >> canonicalize_path(). >> >> A new function that checks whether we support a give

Re: [libvirt] [Qemu-devel] Question about how to distinguish a usb device in usb pass-through feature

2014-06-09 Thread Gonglei (Arei)
Hi, Qemu has supported 3rd method for USB passthrough except two ways that you have pointed: hostbus+hostport -- match for a specific physical port in the host, any device which is plugged in there gets passed to the guest. The method can resolve your all problems. AFAICT, libvirt do not suppo

Re: [libvirt] [PATCH] m4: bhyve: Fix check for the required bhyve programs

2014-06-09 Thread Peter Krempa
On 06/06/14 17:58, Eric Blake wrote: > On 06/06/2014 09:27 AM, Peter Krempa wrote: >> bhyveload and bhyvectl wouldn't be checked otherwise as the configure >> script wouldn't execute one of the tests: >> >> checking for bhyve... /usr/local/sbin/bhyve >> checking for bhyvectl... /usr/local/sbin/bhyv

Re: [libvirt] [PATCH] parallels: Avoid possible leak of "cpu" from parallelsBuildCapabilities

2014-06-09 Thread Martin Kletzander
On Mon, Jun 09, 2014 at 09:39:44AM +0200, Peter Krempa wrote: 4d06af97d38c3648937eb8f732704379b3cd9e59 introduced a possible memory leak of the memory allocated into the "cpu" pointer in parallelsBuildCapabilities in the case "nodeGetInfo()" would fail right after the allocation. Rearrange the co

[libvirt] [PATCH] parallels: Avoid possible leak of "cpu" from parallelsBuildCapabilities

2014-06-09 Thread Peter Krempa
4d06af97d38c3648937eb8f732704379b3cd9e59 introduced a possible memory leak of the memory allocated into the "cpu" pointer in parallelsBuildCapabilities in the case "nodeGetInfo()" would fail right after the allocation. Rearrange the code to avoid the possibility of the leak. Found by Coverity. ---

[libvirt] [PATCHv2] QEMU: Modify qemuParseCommandLinePCI() to parsee '-device vfio-pci'

2014-06-09 Thread Olivia Yin
Signed-off-by: Olivia Yin Modify qemuParseCommandLinePCI() to support parsing '-device vfio-pci,host=bus:slot.func'. Add test case 'hostdev-vfio' into qemuargv2xmltest to validate this function. The case related to QEMU_CAPS_HOST_PCI_MULTIDOMAIN which uses '-device vfio-pci,host=domain:bus:slot