Re: [libvirt] [PATCH V2] virpci: support driver_override sysfs interface

2016-08-30 Thread Laine Stump
On 08/01/2016 11:36 PM, Jim Fehlig wrote: libvirt uses the new_id PCI sysfs interface to bind a PCI stub driver to a PCI device. The new_id interface is known to be buggy and racey, hence a more deterministic interface was introduced in the 3.12 kernel: driver_override. For more details see http

[libvirt] [PATCH] util: hostcpu: improve CPU freq code for FreeBSD

2016-08-30 Thread Roman Bogorodskiy
Current implementation uses the dev.cpu.0.freq sysctl that is provided by the cpufreq(4) framework and returns the actual CPU frequency. However, there are environment where it's not available, e.g. when running nested in KVM. In this case fall back to hw.clockrate that reports CPU frequency at the

Re: [libvirt] [PATCH 41/41] Move CMT feature filtering to QEMU driver

2016-08-30 Thread John Ferlan
On 08/12/2016 09:33 AM, Jiri Denemark wrote: > It really doesn't belong to the generic CPU driver. > > Signed-off-by: Jiri Denemark > --- > src/cpu/cpu_x86.c| 16 ++-- > src/qemu/qemu_capabilities.c | 16 +++- > 2 files changed, 17 insertions(+), 15 deletion

Re: [libvirt] [PATCH 32/41] cpu: Make x86ModelFromCPU a bit smarter

2016-08-30 Thread John Ferlan
On 08/12/2016 09:33 AM, Jiri Denemark wrote: > x86ModelFromCPU is used to provide CPUID data for features matching > @policy. This patch allows callers to set @policy to -1 to get combined > CPUID for all CPU features (including those implicitly provided a CPU > model) specified in CPU def. > >

Re: [libvirt] [PATCH 40/41] qemu: Update guest CPU def in live XML

2016-08-30 Thread John Ferlan
On 08/12/2016 09:33 AM, Jiri Denemark wrote: > Storing the updated CPU definition in the live domain definition saves > us from having to update it over and over when we need it. Not to > mention that we will soon further update the CPU definition according to > QEMU once it's started. > > A hig

Re: [libvirt] [PATCH 39/41] cpu: Rework cpuCompare* APIs

2016-08-30 Thread John Ferlan
On 08/12/2016 09:33 AM, Jiri Denemark wrote: > Both cpuCompare* APIs are renamed to virCPUCompare*. And they should now > work for any guest CPU definition, i.e., even for host-passthrough > (trivial) and host-model CPUs. The implementation in x86 driver is > enhanced to provide a hint about -noT

Re: [libvirt] [PATCH 38/41] cpu: Rework cpuHasFeature

2016-08-30 Thread John Ferlan
On 08/12/2016 09:33 AM, Jiri Denemark wrote: > The function is renamed to virCPUDataCheckFeature and another function > (virCPUCheckFeature) which works on CPU definition rather than raw CPU > data is introduced. > > Signed-off-by: Jiri Denemark > --- > src/cpu/cpu.c | 55 > ++

Re: [libvirt] [PATCH 35/41] cpu: Rework cpuUpdate

2016-08-30 Thread John Ferlan
On 08/12/2016 09:33 AM, Jiri Denemark wrote: > The reworked API is now called virCPUUpdate and it should change the > provided CPU definition into a one which can be consumed by QEMU command s/by/by the/ > line builder: > > - host-passthrough remains unchanged > - host-model is turned

[libvirt] libvirt-2.2.0 Release Candidate 2 is out

2016-08-30 Thread Daniel Veillard
It's tagged in git, with signed tarball and rpms at the usual place: ftp://libvirt.org/libvirt/ but it looks broken to me, if I use virt manager and try to start a guest it fails to render the grapical display of the guest. Need to kill virt-manager as it blocks and become irresponsive, th

Re: [libvirt] [PATCH] libxl: advertise support for migration V3

2016-08-30 Thread Joao Martins
On 08/30/2016 06:21 PM, Jim Fehlig wrote: > On 08/30/2016 08:45 AM, Joao Martins wrote: >> On 08/29/2016 06:20 PM, Jim Fehlig wrote: >>> The libxl driver has long supported migration V3 but has never >>> indicated so in the connectSupportsFeature API. >> Hmm, but IIRC it was only since "recent" co

Re: [libvirt] [PATCH] libxl: advertise support for migration V3

2016-08-30 Thread Jim Fehlig
On 08/30/2016 12:52 AM, Cedric Bosdonnat wrote: > On Mon, 2016-08-29 at 11:20 -0600, Jim Fehlig wrote: >> The libxl driver has long supported migration V3 but has never >> indicated so in the connectSupportsFeature API. As a result, apps >> such as virt-manager that use the more generic virDomainMi

Re: [libvirt] [PATCH] libxl: advertise support for migration V3

2016-08-30 Thread Jim Fehlig
On 08/30/2016 08:45 AM, Joao Martins wrote: > On 08/29/2016 06:20 PM, Jim Fehlig wrote: >> The libxl driver has long supported migration V3 but has never >> indicated so in the connectSupportsFeature API. > Hmm, but IIRC it was only since "recent" commit 8db77b3 right? The libxl driver has suppor

Re: [libvirt] [PATCH v7 0/4] Add Mediated device support

2016-08-30 Thread Alex Williamson
Hi folks, At KVM Forum we had a BoF session primarily around the mediated device sysfs interface. I'd like to share what I think we agreed on and the "problem areas" that still need some work so we can get the thoughts and ideas from those who weren't able to attend. DanPB expressed some concern

Re: [libvirt] [PATCH] libxl: add memory attach support

2016-08-30 Thread Joao Martins
Hey! On 08/30/2016 11:00 AM, Bob Liu wrote: > Support for VIR_DOMAIN_DEVICE_MEMORY on domainAttachDeviceFlags API in libxl > driver, using libxl_set_memory_target in xen libxl. > > With "virsh attach-device" command we can then hotplug memory to a domain: > > > 128 > 0 >

Re: [libvirt] [PATCH 30/41] qemu: Introduce virQEMUCapsIsCPUModeSupported

2016-08-30 Thread John Ferlan
On 08/12/2016 09:33 AM, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_capabilities.c | 55 > ++-- > src/qemu/qemu_capabilities.h | 4 > 2 files changed, 47 insertions(+), 12 deletions(-) > So another 10 down almost 75%

Re: [libvirt] [PATCH 28/41] Show host model in domain capabilities

2016-08-30 Thread John Ferlan
On 08/12/2016 09:33 AM, Jiri Denemark wrote: > The domain capabilities XML is capable of showing whether each guest CPU > mode is supported or not with a possibility to provide additional > details. This patch enhances host-model capability to advertise the > exact CPU model which will be used as

Re: [libvirt] [PATCH] libxl: advertise support for migration V3

2016-08-30 Thread Joao Martins
On 08/29/2016 06:20 PM, Jim Fehlig wrote: > The libxl driver has long supported migration V3 but has never > indicated so in the connectSupportsFeature API. Hmm, but IIRC it was only since "recent" commit 8db77b3 right? Or rather Nikolay's reworking top-level migration code, which effectively wo

Re: [libvirt] [PATCH 27/41] cpu: Drop false support for ARM cpu-model

2016-08-30 Thread John Ferlan
On 08/12/2016 09:33 AM, Jiri Denemark wrote: > The ARM CPU driver wrongly reported host CPU model as "host", which made > host-model to be just an alias for host-passthrough. Let's drop this > insanity. > > Signed-off-by: Jiri Denemark > --- > src/cpu/cpu_arm.c | 34 ++-

Re: [libvirt] [PATCH 26/41] qemu: Store host-model CPU in qemu capabilities

2016-08-30 Thread John Ferlan
On 08/12/2016 09:33 AM, Jiri Denemark wrote: > Host capabilities provide libvirt's view of the host CPU, but for a > useful support for host-model CPUs we really need a hypervisor's view of > the CPU. And since the view can be differ with emulator, qemu > capabilities is the best place to store t

Re: [libvirt] [PATCH 25/41] conf: Introduce virCPUDefCopyModelFilter

2016-08-30 Thread John Ferlan
On 08/12/2016 09:33 AM, Jiri Denemark wrote: > The function filters all CPU features through a given callback while > copying CPU model related parts of a CPU definition. > > Signed-off-by: Jiri Denemark > --- > src/conf/cpu_conf.c | 31 --- > src/conf/cpu_conf

Re: [libvirt] [PATCH 24/41] conf: Introduce virCPUDefMoveModel

2016-08-30 Thread John Ferlan
On 08/12/2016 09:33 AM, Jiri Denemark wrote: > The function moves CPU model related parts from one CPU definition to > another. It can be used to avoid unnecessary copies from a temporary CPU > definitions which will be freed anyway. > > Signed-off-by: Jiri Denemark > --- > src/conf/cpu_conf.c

Re: [libvirt] [PATCH 23/41] conf: Introduce virCPUDefCopyWithoutModel

2016-08-30 Thread John Ferlan
On 08/12/2016 09:33 AM, Jiri Denemark wrote: > Useful for copying a CPU definition without model related parts (i.e., > without model name, feature list, vendor). > > Signed-off-by: Jiri Denemark > --- > src/conf/cpu_conf.c | 16 +++- > src/conf/cpu_conf.h | 3 +++ > src

Re: [libvirt] [PATCH v5 0/8] perf: add more perf events support

2016-08-30 Thread John Ferlan
On 08/29/2016 10:00 PM, Ren, Qiaowei wrote: > Hi John, > > How about this patch series? > I made adjustments to your series, but I also made tweaks and those needed to be OK'd/checked by someone such as you Go back to the v4 series and read my comment. In particular from review of patch

[libvirt] [PATCH] libxl: add memory attach support

2016-08-30 Thread Bob Liu
Support for VIR_DOMAIN_DEVICE_MEMORY on domainAttachDeviceFlags API in libxl driver, using libxl_set_memory_target in xen libxl. With "virsh attach-device" command we can then hotplug memory to a domain: 128 0 $ virsh attach-device domain_name this.xml --live Signed-o

Re: [libvirt] Virtqueue size exceeded error when resuming VM

2016-08-30 Thread Moshe Levi
It seem that on Ubuntu they reverted the patch See https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1612089 I tested on Ubuntu with 14.04 and it working ii ipxe-qemu 1.0.0+git-2013.c3d1e78-2ubuntu1.1 all PXE boot firmware - ROM images for qemu ii

[libvirt] [PATCH] docs: Add missing / to closing tag

2016-08-30 Thread Christophe Fergeau
The iothread example for virtio-scsi should be rather than for the XML to be valid. --- I've already pushed this under the docs/trivial rule. Christophe docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.