Re: [libvirt] [PATCH 2/3] Add virBufferEscapeShell

2011-10-13 Thread Guido Günther
On Thu, Oct 13, 2011 at 03:25:10PM -0600, Eric Blake wrote: > On 10/13/2011 03:02 PM, Guido Günther wrote: > >On Wed, Oct 12, 2011 at 05:16:35PM -0600, Eric Blake wrote: > >>On 10/12/2011 04:39 PM, Guido Günther wrote: > >>>Escape strings so they're safe to pass to the shell. Based on glib's > >>>g

Re: [libvirt] [PATCH 2/3] Add virBufferEscapeShell

2011-10-13 Thread Eric Blake
On 10/13/2011 03:02 PM, Guido Günther wrote: On Wed, Oct 12, 2011 at 05:16:35PM -0600, Eric Blake wrote: On 10/12/2011 04:39 PM, Guido Günther wrote: Escape strings so they're safe to pass to the shell. Based on glib's g_quote_string. Is this still true, or does it now resemble more what I di

Re: [libvirt] [PATCH 2/3] Add virBufferEscapeShell

2011-10-13 Thread Guido Günther
On Wed, Oct 12, 2011 at 05:16:35PM -0600, Eric Blake wrote: > On 10/12/2011 04:39 PM, Guido Günther wrote: > >Escape strings so they're safe to pass to the shell. Based on glib's > >g_quote_string. > > Is this still true, or does it now resemble more what I did > (independently from g_quote_string

Re: [libvirt] [PATCH 2/3] Add virBufferEscapeShell

2011-10-12 Thread Philipp Hahn
Hello, I have a De-Ja-Vu: On Thursday 13 October 2011 01:16:35 Eric Blake wrote: > On 10/12/2011 04:39 PM, Guido Günther wrote: > > Escape strings so they're safe to pass to the shell. Based on glib's > > g_quote_string. We already have a escape-for-shell function: please have a look at src/qem

Re: [libvirt] [PATCH 2/3] Add virBufferEscapeShell

2011-10-12 Thread Eric Blake
On 10/12/2011 04:39 PM, Guido Günther wrote: Escape strings so they're safe to pass to the shell. Based on glib's g_quote_string. Is this still true, or does it now resemble more what I did (independently from g_quote_string) in tools/virsh.c cmdEcho? --- src/libvirt_private.syms |1 +

[libvirt] [PATCH 2/3] Add virBufferEscapeShell

2011-10-12 Thread Guido Günther
Escape strings so they're safe to pass to the shell. Based on glib's g_quote_string. --- src/libvirt_private.syms |1 + src/util/buf.c | 54 ++ src/util/buf.h |1 + 3 files changed, 56 insertions(+), 0 deletions(-) diff --g