Re: [libvirt] [PATCH v4 1/8] vsh: Enforce checking for missing help string

2016-09-20 Thread Erik Skultety
On 20/09/16 14:43, Ján Tomko wrote: > On Mon, Sep 19, 2016 at 03:00:26PM +0200, Erik Skultety wrote: >> The intention is to move vshCmddefCheckInternals out of >> vshCmddefOptParse to >> our test suite. First step to do that is to enforce checking for an >> existing >> help string (that also means

Re: [libvirt] [PATCH v4 1/8] vsh: Enforce checking for missing help string

2016-09-20 Thread Ján Tomko
On Mon, Sep 19, 2016 at 03:00:26PM +0200, Erik Skultety wrote: The intention is to move vshCmddefCheckInternals out of vshCmddefOptParse to our test suite. First step to do that is to enforce checking for an existing help string (that also means it's non-empty) in a command because a command with

[libvirt] [PATCH v4 1/8] vsh: Enforce checking for missing help string

2016-09-19 Thread Erik Skultety
The intention is to move vshCmddefCheckInternals out of vshCmddefOptParse to our test suite. First step to do that is to enforce checking for an existing help string (that also means it's non-empty) in a command because a command without a help is not much of a use. Signed-off-by: Erik Skultety -