[libvirt] [PATCHv2] qemu: don't leak vm on failure

2013-09-06 Thread Eric Blake
Failure to attach to a domain during 'virsh qemu-attach' left the list of domains in an odd state: $ virsh qemu-attach 4176 error: An error occurred, but the cause is unknown $ virsh list --all IdName State 2

Re: [libvirt] [PATCHv2] qemu: don't leak vm on failure

2013-09-06 Thread Eric Blake
On 09/06/2013 11:55 AM, Eric Blake wrote: > Failure to attach to a domain during 'virsh qemu-attach' left > the list of domains in an odd state: > > $ virsh qemu-attach 4176 > error: An error occurred, but the cause is unknown > > -endjob: > if (qemuDomainObjEndJob(driver, vm) == 0) { >

Re: [libvirt] [PATCHv2] qemu: don't leak vm on failure

2013-09-08 Thread Osier Yang
On 07/09/13 01:55, Eric Blake wrote: Failure to attach to a domain during 'virsh qemu-attach' left the list of domains in an odd state: $ virsh qemu-attach 4176 error: An error occurred, but the cause is unknown $ virsh list --all IdName State ---

Re: [libvirt] [PATCHv2] qemu: don't leak vm on failure

2013-09-09 Thread Eric Blake
On 09/08/2013 08:29 AM, Osier Yang wrote: > On 07/09/13 01:55, Eric Blake wrote: >> Failure to attach to a domain during 'virsh qemu-attach' left >> the list of domains in an odd state: >> >> $ virsh qemu-attach 4176 >> error: An error occurred, but the cause is unknown >> >> >> * src/qemu/qemu_dr