Re: [libvirt] [PATCH] qemuDomainDetachDeviceConfig: Don't free device from @dev

2018-06-17 Thread Ján Tomko
On Fri, Jun 15, 2018 at 04:20:41PM +0200, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1591561 For reasons I don't understand my original patch of 75f0fd51124 freed not only the chardev from domain but also the one from passed virDomainDeviceDefPtr. This caused no troubles

[libvirt] [PATCH] qemuDomainDetachDeviceConfig: Don't free device from @dev

2018-06-15 Thread Michal Privoznik
https://bugzilla.redhat.com/show_bug.cgi?id=1591561 For reasons I don't understand my original patch of 75f0fd51124 freed not only the chardev from domain but also the one from passed virDomainDeviceDefPtr. This caused no troubles until now, because those two pointers were separate, but after I've