Re: [libvirt] [PATCH] virsh: fixed handling of targetless disks (e.g. empty CDROM) in 'domblkinfo' cmd

2019-10-04 Thread Pavel Mores
On Thu, Oct 03, 2019 at 06:25:40PM +0200, Ján Tomko wrote: > On Thu, Oct 03, 2019 at 02:45:36PM +0200, Pavel Mores wrote: > > On Thu, Oct 03, 2019 at 01:09:55PM +0200, Pavel Mores wrote: > > > On Thu, Oct 03, 2019 at 11:54:44AM +0200, Ján Tomko wrote: > > > > On Wed, Oct 02, 2019 at 04:21:52PM

Re: [libvirt] [PATCH] virsh: fixed handling of targetless disks (e.g. empty CDROM) in 'domblkinfo' cmd

2019-10-03 Thread Ján Tomko
On Thu, Oct 03, 2019 at 02:45:36PM +0200, Pavel Mores wrote: On Thu, Oct 03, 2019 at 01:09:55PM +0200, Pavel Mores wrote: On Thu, Oct 03, 2019 at 11:54:44AM +0200, Ján Tomko wrote: > On Wed, Oct 02, 2019 at 04:21:52PM +0200, Pavel Mores wrote: > > On Wed, Oct 02, 2019 at 08:34:10AM -0300,

Re: [libvirt] [PATCH] virsh: fixed handling of targetless disks (e.g. empty CDROM) in 'domblkinfo' cmd

2019-10-03 Thread Pavel Mores
On Thu, Oct 03, 2019 at 01:09:55PM +0200, Pavel Mores wrote: > On Thu, Oct 03, 2019 at 11:54:44AM +0200, Ján Tomko wrote: > > On Wed, Oct 02, 2019 at 04:21:52PM +0200, Pavel Mores wrote: > > > On Wed, Oct 02, 2019 at 08:34:10AM -0300, Daniel Henrique Barboza wrote: > > > > > > > > > > > > On

Re: [libvirt] [PATCH] virsh: fixed handling of targetless disks (e.g. empty CDROM) in 'domblkinfo' cmd

2019-10-03 Thread Pavel Mores
On Thu, Oct 03, 2019 at 11:54:44AM +0200, Ján Tomko wrote: > On Wed, Oct 02, 2019 at 04:21:52PM +0200, Pavel Mores wrote: > > On Wed, Oct 02, 2019 at 08:34:10AM -0300, Daniel Henrique Barboza wrote: > > > > > > > > > On 10/1/19 11:45 AM, Pavel Mores wrote: > > > > virDomainGetBlockInfo() returns

Re: [libvirt] [PATCH] virsh: fixed handling of targetless disks (e.g. empty CDROM) in 'domblkinfo' cmd

2019-10-03 Thread Ján Tomko
On Wed, Oct 02, 2019 at 04:21:52PM +0200, Pavel Mores wrote: On Wed, Oct 02, 2019 at 08:34:10AM -0300, Daniel Henrique Barboza wrote: On 10/1/19 11:45 AM, Pavel Mores wrote: > virDomainGetBlockInfo() returns error if called on a disk with no target > (a targetless disk might be a removable

Re: [libvirt] [PATCH] virsh: fixed handling of targetless disks (e.g. empty CDROM) in 'domblkinfo' cmd

2019-10-02 Thread Pavel Mores
On Wed, Oct 02, 2019 at 08:34:10AM -0300, Daniel Henrique Barboza wrote: > > > On 10/1/19 11:45 AM, Pavel Mores wrote: > > virDomainGetBlockInfo() returns error if called on a disk with no target > > (a targetless disk might be a removable media drive with no media in it, > > for instance an

Re: [libvirt] [PATCH] virsh: fixed handling of targetless disks (e.g. empty CDROM) in 'domblkinfo' cmd

2019-10-02 Thread Ján Tomko
On Wed, Oct 02, 2019 at 02:11:39PM +0200, Pavel Mores wrote: On Wed, Oct 02, 2019 at 01:15:12PM +0200, Ján Tomko wrote: Real estate in the commit message summary is precious, so the e.g. part belongs in the commit message. Right. Also, (unless some strange usage sneaked into our XML),

Re: [libvirt] [PATCH] virsh: fixed handling of targetless disks (e.g. empty CDROM) in 'domblkinfo' cmd

2019-10-02 Thread Pavel Mores
On Wed, Oct 02, 2019 at 01:15:12PM +0200, Ján Tomko wrote: > Real estate in the commit message summary is precious, so the e.g. > part belongs in the commit message. Right. > Also, (unless some strange usage sneaked into our XML), deals > with the host-side where says how the device appears in

Re: [libvirt] [PATCH] virsh: fixed handling of targetless disks (e.g. empty CDROM) in 'domblkinfo' cmd

2019-10-02 Thread Daniel Henrique Barboza
On 10/1/19 11:45 AM, Pavel Mores wrote: virDomainGetBlockInfo() returns error if called on a disk with no target (a targetless disk might be a removable media drive with no media in it, for instance an empty CDROM drive). So far this caused the virsh domblkinfo --all command to abort and

Re: [libvirt] [PATCH] virsh: fixed handling of targetless disks (e.g. empty CDROM) in 'domblkinfo' cmd

2019-10-02 Thread Ján Tomko
Real estate in the commit message summary is precious, so the e.g. part belongs in the commit message. Also, (unless some strange usage sneaked into our XML), deals with the host-side where says how the device appears in the guest, so 'targetless' is wrong here. On Tue, Oct 01, 2019 at

[libvirt] [PATCH] virsh: fixed handling of targetless disks (e.g. empty CDROM) in 'domblkinfo' cmd

2019-10-01 Thread Pavel Mores
virDomainGetBlockInfo() returns error if called on a disk with no target (a targetless disk might be a removable media drive with no media in it, for instance an empty CDROM drive). So far this caused the virsh domblkinfo --all command to abort and ignore any remaining (not yet displayed) disk