[libvirt] [PATCH] Explicitly link virfirewalltest and virsystemdtest against dbus

2014-05-03 Thread Guido Günther
This fixes link failures like: CCLD virfirewalltest /usr/bin/ld: virfirewalltest-virfirewalltest.o: undefined reference to symbol 'dbus_message_iter_init_append' --- tests/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.am b/tests/Makef

[libvirt] [PATCH] qemuxml2argvtest: Don't use privilged mode upfront

2014-05-03 Thread Guido Günther
When building packages in a clean chroot the QEMU_USER and QEMU_GROUP don't exist making VirQemuDriverConfigNew fail with privileged=true. Avoid that by not requiring priviliged mode upfront but setting it later so we skip the user/group existence check. This solution was suggested by Daniel P. B

Re: [libvirt] [PATCH] Explicitly link virfirewalltest and virsystemdtest against dbus

2014-05-03 Thread Guido Günther
On Sat, May 03, 2014 at 07:39:03AM -0600, Eric Blake wrote: > On 05/03/2014 06:16 AM, Guido Günther wrote: > > This fixes link failures like: > > > > CCLD virfirewalltest > > /usr/bin/ld: virfirewalltest-virfirewalltest.o: undefined reference to > > symb

Re: [libvirt] [PATCH] qemuxml2argvtest: Don't use privilged mode upfront

2014-05-03 Thread Guido Günther
On Sat, May 03, 2014 at 07:39:40AM -0600, Eric Blake wrote: > On 05/03/2014 06:16 AM, Guido Günther wrote: > > When building packages in a clean chroot the QEMU_USER and QEMU_GROUP > > don't exist making VirQemuDriverConfigNew fail with privileged=true. > > >

Re: [libvirt] [PATCH 1/5] virerror: Fix an error message typo

2014-05-04 Thread Guido Günther
On Sat, May 03, 2014 at 03:59:38PM -0400, Cole Robinson wrote: > --- > src/util/virerror.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/util/virerror.h b/src/util/virerror.h > index 2de04f4..fe0e15e 100644 > --- a/src/util/virerror.h > +++ b/src/util/virerror.h > @

Re: [libvirt] [PATCH 2/5] virerror: Fix incorrect use of RaiseErrorFull

2014-05-04 Thread Guido Günther
On Sat, May 03, 2014 at 03:59:39PM -0400, Cole Robinson wrote: > RaiseErrorFull does not prepend the static error code string (like > INVALID_ARG yields "invalid arg: %(msg)s"). We should be using > ReportErrorHelper. > > The generated error objects are slightly different, by not storing the > inv

Re: [libvirt] [PATCH 3/5] virdbus: Make virDBusCall static

2014-05-04 Thread Guido Günther
On Sat, May 03, 2014 at 03:59:40PM -0400, Cole Robinson wrote: > --- > src/libvirt_private.syms | 1 - > src/util/virdbus.c | 19 +-- > src/util/virdbus.h | 4 > 3 files changed, 5 insertions(+), 19 deletions(-) > > diff --git a/src/libvirt_private.syms b/src/li

Re: [libvirt] Build failed in Jenkins: libvirt-syntax-check #2465

2014-07-08 Thread Guido Günther
On Tue, Jul 08, 2014 at 03:49:02PM +0200, Jenkins CI wrote: > 0.43 prohibit_empty_lines_at_EOF > prohibit_error_without_use > grep: write error > grep: write error > /bin/sed: couldn't write 25 items to stdout: Broken pipe I've disabled notifications to the list until I'm clear what the problem is

[libvirt] [PATCH] qemu: remove capabilities.monitor.sock when done

2014-09-25 Thread Guido Günther
Prompted by http://bugs.debian.org/761131 --- src/qemu/qemu_capabilities.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 49f5f75..dca00b2 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -330

[libvirt] [PATCH] qemu: use systemd's TerminateMachine to kill all processes

2014-09-25 Thread Guido Günther
If we don't properly clean up all processes in the machine-.scope systemd won't remove the cgroup and subsequent vm starts fail with 'CreateMachine: File exists' Additional processes can e.g. be added via echo $PID > /sys/fs/cgroup/systemd/machine.slice/machine-${VMNAME}.scope/tasks but the

Re: [libvirt] [PATCH] qemu: remove capabilities.monitor.sock when done

2014-09-26 Thread Guido Günther
On Thu, Sep 25, 2014 at 11:12:57AM +0200, Jiri Denemark wrote: > On Thu, Sep 25, 2014 at 10:47:55 +0200, Guido Günther wrote: > > Prompted by > > > >http://bugs.debian.org/761131 > > --- > > src/qemu/qemu_capabilities.c | 1 + > > 1 file changed, 1 inse

Re: [libvirt] CreateMachine: Input/output error

2014-09-26 Thread Guido Günther
On Fri, Sep 26, 2014 at 10:06:39AM +0200, Richard Weinberger wrote: > Hi! > > Sometimes libvirt (1.2.7) becomes unable to start any container. > Logs show only: > error : virDBusCall:1429 : error from service: CreateMachine: Input/output > error > It looks like dbus_connection_send_with_reply_and

Re: [libvirt] CreateMachine: Input/output error

2014-09-27 Thread Guido Günther
On Sat, Sep 27, 2014 at 12:04:50AM +0200, Richard Weinberger wrote: > Am 26.09.2014 19:40, schrieb Guido Günther: > > On Fri, Sep 26, 2014 at 10:06:39AM +0200, Richard Weinberger wrote: > >> Hi! > >> > >> Sometimes libvirt (1.2.7) becomes unable to star

[libvirt] [PATCH] Make editor used for 'virsh edit' configurable

2014-09-28 Thread Guido Günther
Debian wants to use 'sensible-editor' instead of vi other distros might want to use other defaults. This avoids distro specific patches. --- configure.ac | 9 + tools/virsh.c | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 0062d5d..

Re: [libvirt] W/ commit 9e159b5: error from service: CreateMachine: Machine 'qemu-foo' already exists

2014-09-28 Thread Guido Günther
On Sat, Sep 27, 2014 at 08:29:28PM +0530, Kashyap Chamarthy wrote: > On Fedora 20 with: > > libvirt RPMs built from git commit: > 9e159b521dbf18c6da6976e54e29c8553f831eb6 > qemu-2.1.1-1.fc22.x86_64 > > Just start a guest: > - > $ virsh start ostack-controller > error: Failed to start

Re: [libvirt] W/ commit 9e159b5: error from service: CreateMachine: Machine 'qemu-foo' already exists

2014-09-28 Thread Guido Günther
On Mon, Sep 29, 2014 at 07:12:29AM +0530, Kashyap Chamarthy wrote: > Applied it: > > $ git log | head -5 > commit da0a33c3f286ff69b910bc2a84e9ec3a844e3ce8 > Author: Guido Günther > Date: Thu Sep 25 14:30:42 2014 +0200 > > qemu: use syste

Re: [libvirt] W/ commit 9e159b5: error from service: CreateMachine: Machine 'qemu-foo' already exists

2014-09-29 Thread Guido Günther
On Mon, Sep 29, 2014 at 02:48:34PM +0530, Kashyap Chamarthy wrote: > On Mon, Sep 29, 2014 at 08:17:11AM +0200, Guido Günther wrote: > > On Mon, Sep 29, 2014 at 07:12:29AM +0530, Kashyap Chamarthy wrote: > > > Applied it: > > > > > >

Re: [libvirt] [PATCH] qemu: use systemd's TerminateMachine to kill all processes

2014-09-30 Thread Guido Günther
On Tue, Sep 30, 2014 at 03:22:41PM +0100, Daniel P. Berrange wrote: > On Tue, Sep 30, 2014 at 10:10:51AM -0400, Cole Robinson wrote: > > On 09/25/2014 08:30 AM, Guido Günther wrote: > > > If we don't properly clean up all processes in the > > > machine-.scope sys

Re: [libvirt] Availability of Release Candidate 2 of libvirt-1.2.9

2014-09-30 Thread Guido Günther
On Mon, Sep 29, 2014 at 09:35:59PM +0800, Daniel Veillard wrote: > I have tagged the release candidate 2 for libvirt-1.2.9 in git, > and pushed signed tarballs and rpms to the usual place: > ftp://libvirt.org/libvirt/ > > So unfortuntely this was too early to try to fix Christophe's > repo

Re: [libvirt] [PATCH] qemu: use systemd's TerminateMachine to kill all processes

2014-09-30 Thread Guido Günther
On Tue, Sep 30, 2014 at 03:44:41PM +0100, Daniel P. Berrange wrote: > On Tue, Sep 30, 2014 at 10:43:47AM -0400, Cole Robinson wrote: > > On 09/30/2014 10:25 AM, Guido Günther wrote: > > > On Tue, Sep 30, 2014 at 03:22:41PM +0100, Daniel P. Berrange wrote: > > >> On T

Re: [libvirt] [Question] capabilities.pidfile is left behind while starting and stopping libvirtd repeatly

2014-09-30 Thread Guido Günther
e: > > commit 9e159b521dbf18c6da6976e54e29c8553f831eb6 > Author: Guido Günther > Date: Thu Sep 25 10:30:58 2014 +0200 > >qemu: remove capabilities.monitor.sock when done > This one removes the monitor socket, not the pidfile since I didn't see that one lingering

Re: [libvirt] [PATCH] Make editor used for 'virsh edit' configurable

2014-10-01 Thread Guido Günther
On Mon, Sep 29, 2014 at 09:47:08AM +0200, Martin Kletzander wrote: > On Sun, Sep 28, 2014 at 10:35:52AM +0200, Guido Günther wrote: > >Debian wants to use 'sensible-editor' instead of vi other distros might > >want to use other defaults. This avoids distro specific patche

Re: [libvirt] [PATCH] qemu: use systemd's TerminateMachine to kill all processes

2014-10-01 Thread Guido Günther
On Tue, Sep 30, 2014 at 03:22:41PM +0100, Daniel P. Berrange wrote: > On Tue, Sep 30, 2014 at 10:10:51AM -0400, Cole Robinson wrote: > > On 09/25/2014 08:30 AM, Guido Günther wrote: > > > If we don't properly clean up all processes in the > > > machine-.scope sys

[libvirt] [PATCH] define NTF_{SELF,MASTER} if undefined

2014-12-08 Thread Guido Günther
Older kernel headers lack this definition (e.g. Debian Wheezy's 3.2) --- src/util/virnetdevbridge.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/util/virnetdevbridge.c b/src/util/virnetdevbridge.c index 73ec40b..d92a9de 100644 --- a/src/util/virnetdevbridge.c +++ b/src/util/vir

Re: [libvirt] [PATCH] define NTF_{SELF,MASTER} if undefined

2014-12-09 Thread Guido Günther
On Tue, Dec 09, 2014 at 10:31:48AM +0100, Jiri Denemark wrote: > On Tue, Dec 09, 2014 at 10:17:20 +0100, Martin Kletzander wrote: > > On Tue, Dec 09, 2014 at 07:56:34AM +0100, Guido Günther wrote: > > >Older kernel headers lack this definition (e.g. Debian Wheezy's 3.2)

[libvirt] [PATCH] Drop hle feature for Haswell CPUs

2014-12-16 Thread Guido Günther
The intel-microcode 3.20140913.1 update disables TSX-NI (transactional memory instructions). When a server running libvirt is rebooted with this update, libvirt no longer considers the machine to have a Haswell CPU: # virsh capabilities | grep -A1 'x86_64' x86_64 SandyBridge Since Intel

Re: [libvirt] [PATCH] Drop hle feature for Haswell CPUs

2014-12-16 Thread Guido Günther
On Tue, Dec 16, 2014 at 12:40:26PM +, Daniel P. Berrange wrote: > On Tue, Dec 16, 2014 at 01:33:15PM +0100, Guido Günther wrote: > > The intel-microcode 3.20140913.1 update disables TSX-NI (transactional > > memory instructions). When a server running libvirt is rebooted with

Re: [libvirt] [PATCH] avoid using deprecated udev logging functions

2014-12-16 Thread Guido Günther
On Mon, Dec 15, 2014 at 03:33:13PM +, Daniel P. Berrange wrote: > In systemd >= 218, the udev_set_log_fn method has been marked > deprecated and turned into a no-op. Nothing in the udev client > library will print to stderr by default anymore, so we can > just stop installing a logging hook for

Re: [libvirt] [PATCH] avoid using deprecated udev logging functions

2014-12-16 Thread Guido Günther
On Tue, Dec 16, 2014 at 03:28:33PM -0700, Eric Blake wrote: > On 12/16/2014 03:08 PM, Guido Günther wrote: > > On Mon, Dec 15, 2014 at 03:33:13PM +, Daniel P. Berrange wrote: > >> In systemd >= 218, the udev_set_log_fn method has been marked > >> deprecated and t

Re: [libvirt] [PATCH] Drop hle feature for Haswell CPUs

2014-12-19 Thread Guido Günther
On Tue, Dec 16, 2014 at 02:47:24PM +, Daniel P. Berrange wrote: > On Tue, Dec 16, 2014 at 03:37:06PM +0100, Guido Günther wrote: > > On Tue, Dec 16, 2014 at 12:40:26PM +, Daniel P. Berrange wrote: > > > On Tue, Dec 16, 2014 at 01:33:15PM +0100, Guido Günther wrote:

[libvirt] [PATCH 1/2] lxc: Move setting ifname_guest_actual to virLXCSetupInterfaces

2014-12-19 Thread Guido Günther
so it applies to interfaces of type 'direct' too. Reported and patch provided by Bastian Blank at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=769600 --- src/lxc/lxc_process.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_pr

[libvirt] [PATCH 2/2] lxc: Don't crash on NULL ifname_guest_actual

2014-12-19 Thread Guido Günther
Reported and patch provided by Bastian Blank at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=769600 --- src/lxc/lxc_container.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index 1b9e2f2..f986f71 100644 --- a/src/lx

Re: [libvirt] [PATCH for 1.3.3 0/3] qemu: Regenerate per-domain paths on restart

2016-04-04 Thread Guido Günther
On Sun, Apr 03, 2016 at 10:23:20PM +0200, Martin Kletzander wrote: > We forgot to clean up after the domain is torn down. And because they > are kept, we don't regenerate them upn another start and because of > that they contain old IDs in them. > > Again, the series is structured as with the pre

Re: [libvirt] [PATCH] Link xen driver against libxl

2016-04-05 Thread Guido Günther
On Thu, Mar 31, 2016 at 05:01:49PM +0200, Guido Günther wrote: > to avoid the test failure > > 7) Test driver "xen" ... 2016-03-31 12:53:26.950+: 22430: debug : > virDriverLoadModule:54 : Module load xen > 2016-03-31 12:53:26.950+: 22430: error : virDriverLoa

Re: [libvirt] [PATCH] Link xen driver against libxl

2016-04-05 Thread Guido Günther
On Tue, Apr 05, 2016 at 01:16:27PM +0200, Jiri Denemark wrote: > On Thu, Mar 31, 2016 at 17:01:49 +0200, Guido Günther wrote: > > to avoid the test failure > > > > 7) Test driver "xen" ... 2016-03-31 12:53:26.950+: 22430: debug : > > virDriverLoadModule

Re: [libvirt] [PATCH] Link xen driver against libxl

2016-04-06 Thread Guido Günther
On Wed, Apr 06, 2016 at 09:53:06AM +0200, Jiri Denemark wrote: > On Tue, Apr 05, 2016 at 18:16:29 +0200, Guido Günther wrote: > > >From 4e302ea482d58c5ae034f85ea27d0318cb0b59c5 Mon Sep 17 00:00:00 2001 > > Message-Id: > > <4e302ea482d58c5ae034f85ea27d0318cb0b59c5.145

Re: [libvirt] [PATCH] virt-aa-helper: disallow VNC socket read permissions

2016-04-08 Thread Guido Günther
On Fri, Apr 08, 2016 at 09:01:33AM -0400, Cole Robinson wrote: > From: Simon Arlott > > The VM does not need read permission for its own VNC socket to create(), > bind(), accept() connections or to receive(), send(), etc. on connections. > > https://bugzilla.redhat.com/show_bug.cgi?id=1312573 >

Re: [libvirt] [PATCH] qemu: Label master key file

2016-04-15 Thread Guido Günther
On Thu, Apr 14, 2016 at 09:04:31AM +0200, Martin Kletzander wrote: > On Wed, Apr 13, 2016 at 07:58:06PM -0400, Cole Robinson wrote: > >On 04/13/2016 11:56 AM, Cole Robinson wrote: > >>On 04/13/2016 11:17 AM, Martin Kletzander wrote: > >>>When creating the master key, we used mode 0600 (which we sho

[libvirt] [libvirt-sandbox PATCH] virt-sandbox: document how to pass arguments to commands

2016-04-15 Thread Guido Günther
The example was already correct but the synopsis didn't mention '--' is required. --- bin/virt-sandbox.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bin/virt-sandbox.c b/bin/virt-sandbox.c index 9495e85..d6a441c 100644 --- a/bin/virt-sandbox.c +++ b/bin/virt-sandbox.c @@

Re: [libvirt] [libvirt-sandbox PATCH] virt-sandbox: document how to pass arguments to commands

2016-04-17 Thread Guido Günther
On Fri, Apr 15, 2016 at 10:00:46AM +0100, Daniel P. Berrange wrote: > On Fri, Apr 15, 2016 at 10:45:14AM +0200, Guido Günther wrote: > > The example was already correct but the synopsis didn't mention '--' is > > required. > > --- > > bin/virt-sandbox.c

Re: [libvirt] Entering freeze for libvirt-1.3.4

2016-04-27 Thread Guido Günther
On Wed, Apr 27, 2016 at 10:52:35AM +0800, Daniel Veillard wrote: > We are in freeze ! I tagged the release candidate 1 in git and > pushed signed tarball and rpms to the usual place: > >ftp://libvirt.org/libvirt/ > > > that looks fine with my very limited testing, but that's likely > not

Re: [libvirt] Entering freeze for libvirt-1.3.4

2016-04-27 Thread Guido Günther
On Wed, Apr 27, 2016 at 10:10:47PM +0800, Daniel Veillard wrote: > On Wed, Apr 27, 2016 at 03:37:47PM +0200, Guido Günther wrote: > > On Wed, Apr 27, 2016 at 10:52:35AM +0800, Daniel Veillard wrote: > > > We are in freeze ! I tagged the release candidate 1 in git and > >

Re: [libvirt] [PATCH] Look in Debian's multiarch libs too

2012-09-13 Thread Guido Günther
On Thu, Sep 13, 2012 at 02:35:03PM +0200, =?UTF-8?q?Guido=20G=C3=BCnther?= wrote: > I checked for libnetcf.so which is in /usr/lib/ but not for libnl1 which > is already in a multiarch directory (`/usr/lib/i386-linux-gnu/libnl.so). > So this fixes it: > > configure.ac |2 +- > 1 file changed

Re: [libvirt] [PATCH] Look in Debian's multiarch libs too

2012-09-13 Thread Guido Günther
On Thu, Sep 13, 2012 at 10:46:30AM -0600, Eric Blake wrote: > On 09/13/2012 09:36 AM, Guido Günther wrote: > > On Thu, Sep 13, 2012 at 02:35:03PM +0200, =?UTF-8?q?Guido=20G=C3=BCnther?= > > wrote: > >> I checked for libnetcf.so which is in /usr/lib/ but not for libnl1 wh

[libvirt] [PATCH] Adhere to copyright_address check

2012-09-18 Thread Guido Günther
to fix "make syntax-check" Found by http://honk.sigxcpu.org:8001/job/libvirt-syntax-check/ --- run.in |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/run.in b/run.in index 7700e52..83c1785 100644 --- a/run.in +++ b/run.in @@ -13,8 +13,7 @@ # GNU General Public License fo

[libvirt] [PATCH] Properly parse (unsigned) long long

2012-10-12 Thread Guido Günther
This fixes problems on platforms where sizeof(long) != sizeof(long long) like ia32. --- Cheers, -- Guido python/generator.py |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/python/generator.py b/python/generator.py index a98a894..1ef76e1 100755 --- a/python/generator.

Re: [libvirt] [PATCH] Properly parse (unsigned) long long

2012-10-12 Thread Guido Günther
On Fri, Oct 12, 2012 at 05:42:06PM -0600, Eric Blake wrote: > On 10/12/2012 05:15 PM, Guido Günther wrote: > > This fixes problems on platforms where sizeof(long) != sizeof(long long) > > like ia32. > > > > --- > > Cheers, > > -- Guido > > >

[libvirt] [PATCH] Fix tab vs space

2012-10-15 Thread Guido Günther
I've pushed that one already under the build breaker rule: that broke "make syntax-check" found by http://honk.sigxcpu.org:8001/job/libvirt-syntax-check/157/ Pushed under the build breaker rule. --- src/qemu/qemu_driver.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sr

[libvirt] [PATCH] Avoid straying

2012-10-15 Thread Guido Günther
by using the same condition as for the . Fixes "make check" found by http://honk.sigxcpu.org:8001/job/libvirt-check/160/ --- src/conf/domain_conf.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index cb80f09..83d7742

[libvirt] [PATCH] qemu: Don't fail without emulatorpin or cpumask

2012-10-18 Thread Guido Günther
This unbreaks qemu:///session that got broken by ba63d8f7d843461f77a8206c1ef9da38388713e5. --- src/qemu/qemu_process.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index e08ec67..293ffe9 100644 --- a/src/qemu/qemu_proc

[libvirt] [PATCH] qemu: Set arch to i686 if qemu-system-i386 is found

2012-10-18 Thread Guido Günther
If we can't probe the architecture from QMP we parse the architecture from the qemu binaries name. This results in the architecture being i386 instead of i686 which then results in QEMU_CAPS_PCI_MULTIBUS being unset which gives a broken qemu command line. This probably didn't show up earlier since

Re: [libvirt] [PATCH] qemu: Don't fail without emulatorpin or cpumask

2012-10-18 Thread Guido Günther
On Thu, Oct 18, 2012 at 04:35:31PM -0600, Eric Blake wrote: > On 10/18/2012 04:32 PM, Guido Günther wrote: > > This unbreaks qemu:///session that got broken by > > > > ba63d8f7d843461f77a8206c1ef9da38388713e5. > > --- > > src/qemu/qemu_process.c |4 +++-

Re: [libvirt] [PATCH] qemu: Set arch to i686 if qemu-system-i386 is found

2012-10-18 Thread Guido Günther
On Thu, Oct 18, 2012 at 09:34:17PM -0600, Eric Blake wrote: > On 10/18/2012 05:24 PM, Guido Günther wrote: > > If we can't probe the architecture from QMP we parse the architecture > > from the qemu binaries name. This results in the architecture being i386 > > instead

[libvirt] [libvirt-tck PATCH] Debian calls mkisofs genisoimage

2012-10-20 Thread Guido Günther
so check for that too when generating the iso. --- lib/Sys/Virt/TCK/NetworkHelpers.pm |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/Sys/Virt/TCK/NetworkHelpers.pm b/lib/Sys/Virt/TCK/NetworkHelpers.pm index f7f6d70..5e1bac1 100644 --- a/lib/Sys/Virt/TCK/NetworkHelpe

[libvirt] [libvirt-tck PATCH] Add missing %end to kickstart file

2012-10-20 Thread Guido Günther
--- conf/ks.cfg |1 + 1 file changed, 1 insertion(+) diff --git a/conf/ks.cfg b/conf/ks.cfg index 27e50e4..de82a26 100644 --- a/conf/ks.cfg +++ b/conf/ks.cfg @@ -27,3 +27,4 @@ poweroff @base @core @hardware-support +%end -- 1.7.10.4 -- libvir-list mailing list libvir-list@redhat.com http

Re: [libvirt] [libvirt-tck PATCH] Add missing %end to kickstart file

2012-10-21 Thread Guido Günther
On Sat, Oct 20, 2012 at 02:21:18PM -0600, Eric Blake wrote: > On 10/20/2012 02:08 PM, Guido Günther wrote: > > --- > > conf/ks.cfg |1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/conf/ks.cfg b/conf/ks.cfg > > index 27e50e4..de82a26 1006

[libvirt] [libvirt-tck PATCH] Use recent Fedora version

2012-10-21 Thread Guido Günther
F12 isn't available on standard mirrors anymore. --- conf/ks.cfg |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/conf/ks.cfg b/conf/ks.cfg index de82a26..b6269e9 100644 --- a/conf/ks.cfg +++ b/conf/ks.cfg @@ -1,6 +1,6 @@ install text -url --url=http://ftp-stud.hs-esslinge

Re: [libvirt] [libvirt-tck PATCH] Debian calls mkisofs genisoimage

2012-10-21 Thread Guido Günther
On Sat, Oct 20, 2012 at 10:37:50AM -0600, Eric Blake wrote: > On 10/20/2012 02:26 AM, Guido Günther wrote: > > so check for that too when generating the iso. > > --- > > lib/Sys/Virt/TCK/NetworkHelpers.pm |4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-

Re: [libvirt] [libvirt-tck PATCH] Use recent Fedora version

2012-10-21 Thread Guido Günther
On Sun, Oct 21, 2012 at 12:52:58PM +0200, Peter Krempa wrote: > On 10/21/12 12:28, Guido Günther wrote: > >F12 isn't available on standard mirrors anymore. > >--- > > conf/ks.cfg |2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > ACK Pus

Re: [libvirt] [libvirt-tck PATCH] Add missing %end to kickstart file

2012-10-22 Thread Guido Günther
On Mon, Oct 22, 2012 at 09:24:27AM -0600, Eric Blake wrote: > On 10/21/2012 04:15 AM, Guido Günther wrote: > > On Sat, Oct 20, 2012 at 02:21:18PM -0600, Eric Blake wrote: > >> On 10/20/2012 02:08 PM, Guido Günther wrote: > >>> --- > >>> conf/ks.cfg |

Re: [libvirt] Entering freeze for libvirt-1.0.0 release

2012-10-25 Thread Guido Günther
On Wed, Oct 24, 2012 at 12:14:26PM +0800, Daniel Veillard wrote: > As scheduled, we are entering freeze for 1.0.0, yay ! > I have tagged the git tree and pushed libvirt-1.0.0-rc1.tar.gz release > candidate 1 to the ftp (along with rpms): > ftp://libvirt.org/libvirt/ > > Due to the slightly hi

[libvirt] [PATCH] Create temporary dir for socket

2012-10-29 Thread Guido Günther
to avoid ENAMETOOLONG: https://buildd.debian.org/status/fetch.php?pkg=libvirt&arch=amd64&ver=1.0.0~rc1-1&stamp=1351453521 --- tests/qemumonitortestutils.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/tests/qemumonitortestutils.c b/tests/qemumonitor

Re: [libvirt] Availability of Release Candidate 2 for 1.0.0

2012-10-30 Thread Guido Günther
On Mon, Oct 29, 2012 at 11:19:38AM +0800, Daniel Veillard wrote: > The tree is now tagged (v1.0.0-rc2) and the tarball (and rpms) are > available at the usual place: > > ftp://libvirt.org/libvirt/ > > It seems to work correctly with my limited testing, but please give > it a try, and let's f

Re: [libvirt] [PATCH] Create temporary dir for socket

2012-10-30 Thread Guido Günther
On Tue, Oct 30, 2012 at 07:08:36AM -0600, Eric Blake wrote: > On 10/29/2012 06:05 AM, Guido Günther wrote: > > to avoid ENAMETOOLONG: > > > > https://buildd.debian.org/status/fetch.php?pkg=libvirt&arch=amd64&ver=1.0.0~rc1-1&stamp=1351453521 > > --- &

[libvirt] [PATCH] Fix "virsh create" example

2012-11-07 Thread Guido Günther
We require a file and don't accept standard input: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=692322 --- tools/virsh.pod |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 0808d72..0984e6e 100644 --- a/tools/virsh.pod +++ b/tools/v

Re: [libvirt] [PATCH] Fix "virsh create" example

2012-11-07 Thread Guido Günther
On Wed, Nov 07, 2012 at 02:46:24PM -0700, Eric Blake wrote: > On 11/07/2012 02:16 PM, Guido Günther wrote: > > We require a file and don't accept standard input: > > > > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=692322 > > --- > > tools/virsh.pod |

Re: [libvirt] Expose virDomainGetAutostart through virsh?

2012-11-08 Thread Guido Günther
On Thu, Nov 08, 2012 at 03:42:49PM +0100, Daniel P. Berrange wrote: > On Thu, Nov 08, 2012 at 03:41:12PM +0100, Peter Krempa wrote: > > On 11/08/12 15:13, Daniel P. Berrange wrote: > > >On Wed, Nov 07, 2012 at 11:32:22AM +0100, Peter Krempa wrote: > > >>On 11/07/12 11:04, Ruben Kerkhof wrote: > > >

Re: [libvirt] [PATCH 1/6] v6-6: put dnsmasq parameters into a file

2012-11-09 Thread Guido Günther
On Thu, Nov 08, 2012 at 04:13:41PM -0500, Gene Czarcinski wrote: > This patch changes how parameters are passed to dnsmasq. Instead of > being on the command line, the parameters are put into a file (one > parameter per line) and a commandline --conf-file= specifies the > location of the file. Th

Re: [libvirt] [PATCH 1/6] v6-6: put dnsmasq parameters into a file

2012-11-11 Thread Guido Günther
On Fri, Nov 09, 2012 at 08:39:46AM -0500, Gene Czarcinski wrote: > On 11/09/2012 07:36 AM, Guido Günther wrote: > >On Thu, Nov 08, 2012 at 04:13:41PM -0500, Gene Czarcinski wrote: > >>>This patch changes how parameters are passed to dnsmasq. Instead of > >>&

[libvirt] Is DBus a hard dependency

2012-11-24 Thread Guido Günther
Hi, currently running libvirtd without DBus fails due to: error : nwfilterDriverStartup:208 : DBus matches could not be installed. Disabling nwfilter driver error : virDBusGetSystemBus:77 : internal error Unable to get DBus system bus connection: Failed to connect to socket /var/run/dbus/system_

Re: [libvirt] [PATCHv2 1/5] Add virDomainGetHostname

2012-07-20 Thread Guido Günther
On Wed, Jul 18, 2012 at 09:19:05PM +0100, Daniel P. Berrange wrote: > On Sun, Jul 15, 2012 at 11:45:05PM +0200, Guido Günther wrote: > > to query a guests's hostname. Containers like LXC and OpenVZ allow to > > set a hostname different from the hosts name and QEMU's gues

Re: [libvirt] [PATCH] build: commit to 0.10.0 release naming

2012-08-01 Thread Guido Günther
On Wed, Aug 01, 2012 at 11:00:35AM -0600, Eric Blake wrote: > With 0.10.0-rc0 out the door, we are committed to the next version > number. > > * src/libvirt_public.syms (LIBVIRT_0.9.14): Rename... > (LIBVIRT_0.10.0): ...to this. > * docs/formatdomain.html.in: Fix fallout. > * src/openvz/openvz_dri

Re: [libvirt] [PATCH 03/48] list: Define new API virStorageListALlStoragePools

2012-08-07 Thread Guido Günther
On Fri, Aug 03, 2012 at 11:48:06PM +0800, Osier Yang wrote: > This introduces a new API to list the storage pool objects, > 4 groups of flags are provided to filter the returned pools: Typo on the subject: capital all in virStorageListALlStoragePools ^ Cheers, --

[libvirt] [PATCH] Don't require gawk for a simple print expression

2012-08-28 Thread Guido Günther
Fedora uses gawk as awk so there's no change and in behavior while Debian/Ubuntu use mawk by default. This was reported by Luca Capello in http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=636712 --- src/nwfilter/nwfilter_ebiptables_driver.c | 12 ++-- 1 file changed, 6 insertions(+), 6

Re: [libvirt] Release of libvirt-0.10.0

2012-08-29 Thread Guido Günther
le (Thomas Woerner) > - network: make network driver vlan-aware (Laine Stump) > - esx: Implement network driver (Matthias Bolte) > - driver for parallels hypervisor (Dmitry Guryanov) > - Various LXC improvements (Daniel P. Berrange) > - Add virDomainGetHostname (Guido Günther) > > Docum

Re: [libvirt] Release of libvirt-0.10.0

2012-08-29 Thread Guido Günther
On Wed, Aug 29, 2012 at 11:24:08AM +0200, Michal Privoznik wrote: > On 29.08.2012 09:15, Guido Günther wrote: > > On Wed, Aug 29, 2012 at 01:26:54PM +0800, Daniel Veillard wrote: > >> As planned, I tagged the release this morning and pushed the builds > >> at t

Re: [libvirt] Release of libvirt-0.10.0

2012-08-30 Thread Guido Günther
3246a4a. > > The DAC security driver needs special handling and extra parameters and > can't just be added to regular security drivers. I cherry-picked the later one and the domains start now. Thanks! Domain XML attached. Cheers, -- Guido > > > > On 08/29/2012

Re: [libvirt] Heads up 0.10.1 release on Friday

2012-08-30 Thread Guido Günther
On Wed, Aug 29, 2012 at 11:19:42PM +0800, Daniel Veillard wrote: > I was a bit afraid of the .0 effect on release name, but we really > have a number of problem with 0.10.0 that ought to be fixed in a > "brown paper bag" release. I would urge people to report and try to > fix the problem being ra

Re: [libvirt] Heads up 0.10.1 release on Friday

2012-09-02 Thread Guido Günther
On Fri, Aug 31, 2012 at 02:36:07PM +0800, Daniel Veillard wrote: > On Thu, Aug 30, 2012 at 08:44:57PM +0200, Guido Günther wrote: > > On Wed, Aug 29, 2012 at 11:19:42PM +0800, Daniel Veillard wrote: > > > I was a bit afraid of the .0 effect on release name, but we really >

Re: [libvirt] [PATCHv2] build: force libnl1 if netcf also used libnl1

2012-09-13 Thread Guido Günther
On Wed, Sep 12, 2012 at 03:40:15PM -0600, Eric Blake wrote: > On 09/12/2012 01:14 PM, Laine Stump wrote: > > On 09/10/2012 06:14 PM, Eric Blake wrote: > >> Recent spec file changes ensure that in distro situations, netcf > >> and libvirt will link against the same libnl in order to avoid > >> dumpi

Re: [libvirt] question about the commands: domhostname and hostname

2012-09-13 Thread Guido Günther
On Wed, Sep 12, 2012 at 08:40:12AM +0200, Martin Kletzander wrote: > On 09/12/2012 07:59 AM, Li Zhang wrote: > > Sorry for wrong subject prefix of my mail, correct it. -:) > > > > The [libvirt] tag in the prefix is done automatically, you don't have to > do that ;) > > > On Wed, Sep 12, 2012 at

Re: [libvirt] [PATCHv2] build: force libnl1 if netcf also used libnl1

2012-09-13 Thread Guido Günther
On Thu, Sep 13, 2012 at 03:19:40PM +0800, Osier Yang wrote: > On 2012年09月13日 15:15, Guido Günther wrote: > >On Wed, Sep 12, 2012 at 03:40:15PM -0600, Eric Blake wrote: > >>On 09/12/2012 01:14 PM, Laine Stump wrote: > >>>On 09/10/2012 06:14 PM, Eric Blake wrote:

[libvirt] [PATCH] apparmor: Allow to run pygrup

2019-08-21 Thread Guido Günther
Debian has pygrub in /usr/lib/xen-*/bin/pygrub Allow it to be run. --- I'm open to making this more broad since it seems /usr/{lib,lib64}/xen/bin/* Ux, serves a similar purpose. Cheers, -- Guido src/security/apparmor/usr.sbin.libvirtd | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [libvirt] [PATCH] apparmor: add rules to use qemu_bridge_helper

2018-04-15 Thread Guido Günther
# For communication/control from libvirtd > + unix (send, receive) type=stream addr=none > peer=(label=/usr/sbin/libvirtd), > + signal (receive) set=("term") peer=/usr/sbin/libvirtd, > + > /dev/net/tun rw, > /etc/qemu/** r, > owner @{PROC}/*/status r, Reviewed-by: Guido Günther > -- > 2.7.4 > -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] Cosmetics: Remove semicolons

2013-02-06 Thread Guido Günther
It's Python, not C --- python/libvirt-override.py |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/python/libvirt-override.py b/python/libvirt-override.py index 8427eab..82d7dcb 100644 --- a/python/libvirt-override.py +++ b/python/libvirt-override.py @@ -107,9 +107,9

Re: [libvirt] [PATCH] Cosmetics: Remove semicolons

2013-02-06 Thread Guido Günther
On Wed, Feb 06, 2013 at 01:26:14PM -0700, Eric Blake wrote: > On 02/06/2013 01:07 PM, Guido Günther wrote: > > It's Python, not C > > --- > > python/libvirt-override.py |8 > > 1 file changed, 4 insertions(+), 4 deletions(-) > > ACK. Pushed. Th

[libvirt] [PATCH 1/2] Remove more trailing semicolons in Python files

2013-02-07 Thread Guido Günther
--- docs/apibuild.py | 56 docs/index.py | 32 ++--- examples/domain-events/events-python/event-test.py | 24 ++-- python/generator.py| 146 ++-- python/libvirt-ov

[libvirt] [PATCH 2/2] Add syntax-check to make sure Python files don't contain trailing semicolon

2013-02-07 Thread Guido Günther
We allow for a trailing semicolon in full line comments since docs/index.py has some SQL statements in it. --- cfg.mk |7 +++ 1 file changed, 7 insertions(+) diff --git a/cfg.mk b/cfg.mk index 2dfde01..b92ae85 100644 --- a/cfg.mk +++ b/cfg.mk @@ -702,6 +702,13 @@ sc_require_enum_last_mark

Re: [libvirt] [PATCH 2/2] Add syntax-check to make sure Python files don't contain trailing semicolon

2013-02-07 Thread Guido Günther
On Thu, Feb 07, 2013 at 12:39:07PM +, Daniel P. Berrange wrote: > On Thu, Feb 07, 2013 at 09:23:01AM +0100, Guido Günther wrote: > > We allow for a trailing semicolon in full line comments since > > docs/index.py has some SQL statements in it. > > --- > > cfg.mk

[libvirt] [PATCH] Check if classes are derived from object

2013-02-11 Thread Guido Günther
This makes sure we don't regress to old style classes --- Just a minor addition that came up while verifying if the corresponding Debian bug is fixed. python/sanitytest.py | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/python/sanitytest.py b/py

Re: [libvirt] [PATCH] Check if classes are derived from object

2013-02-11 Thread Guido Günther
On Mon, Feb 11, 2013 at 04:24:15PM +, Daniel P. Berrange wrote: > On Mon, Feb 11, 2013 at 05:20:31PM +0100, Guido Günther wrote: > > This makes sure we don't regress to old style classes > > --- > > Just a minor addition that came up while verifying if the correspondi

[libvirt] [PATCH] Avoid cast to unit64_t on 32bit platform

2013-02-11 Thread Guido Günther
Fixes compilation on 32bit platforms: xen/xen_hypervisor.c: In function 'virXen_setvcpumap': xen/xen_hypervisor.c:1785:35: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] xen/xen_hypervisor.c:1785:22: error: cast to pointer from integer of different size [-Wer

[libvirt] [PATCH] qemu: pass "-1" as uid/gid for unprivileged qemu

2013-02-17 Thread Guido Günther
so we don't try to change uid/git to 0 when probing capabilities. --- On Fri, Feb 15, 2013 at 11:20:17PM -0600, Doug Goldstein wrote: > The following error bisect's down to this commit when running out of > my local checkout for testing. > > 2013-02-16 05:16:55.102+: 29992: error : virCommand

Re: [libvirt] [PATCHv2 13/15] util: virSetUIDGIDWithCaps - change uid while keeping caps

2013-02-18 Thread Guido Günther
On Sat, Feb 16, 2013 at 05:53:05PM -0500, Laine Stump wrote: > On 02/16/2013 12:20 AM, Doug Goldstein wrote: > > On Tue, Feb 12, 2013 at 2:15 PM, Laine Stump wrote: > >> Normally when a process' uid is changed to non-0, all the capabilities > >> bits are cleared, even those explicitly set with cal

[libvirt] [PATCH] Hook log the exit status of the hook not 256

2013-02-24 Thread Guido Günther
Adjust the docs accordingly. See http://bugs.debian.org/701570. --- docs/hooks.html.in |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/hooks.html.in b/docs/hooks.html.in index 5f9963d..b75fbeb 100644 --- a/docs/hooks.html.in +++ b/docs/hooks.html.in @@ -239,13 +239

Re: [libvirt] [PATCHv2 0/5] Add API to allow TCP connection tunelling

2013-02-25 Thread Guido Günther
Hi Peter, On Mon, Dec 10, 2012 at 09:29:39AM +0100, Peter Krempa wrote: > This series adds ability for the qemu driver to tunnel connections to TCP > ports from the host. This is useful for enabling remote VNC/SPICE sessions > without the need to configure SSH tunnels or portforwards and without th

Re: [libvirt] [PATCH] Hook log the exit status of the hook not 256

2013-03-01 Thread Guido Günther
On Sun, Feb 24, 2013 at 08:05:30PM +0100, Guido Günther wrote: > Adjust the docs accordingly. See http://bugs.debian.org/701570. Ping? > --- > docs/hooks.html.in |5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/docs/hooks.html.in b/docs/hoo

[libvirt] [PATCH] lxc: include sys/{types,stat}.h

2013-03-08 Thread Guido Günther
This fixes the build on Debian Wheezy which otherwise fails with: CC libvirt_driver_lxc_impl_la-lxc_process.lo lxc/lxc_process.c: In function 'virLXCProcessGetNsInode': lxc/lxc_process.c:648:5: error: implicit declaration of function 'stat' [-Werror=implicit-function-declaration] lxc/

Re: [libvirt] [PATCH] lxc: include sys/{types,stat}.h

2013-03-08 Thread Guido Günther
On Fri, Mar 08, 2013 at 11:02:47AM -0700, Eric Blake wrote: > On 03/08/2013 09:40 AM, Guido Günther wrote: > > This fixes the build on Debian Wheezy which otherwise fails with: > > > > CC libvirt_driver_lxc_impl_la-lxc_process.lo > > lxc/lxc_process.c: In functi

[libvirt] [PATCH] Convert HAVE_SELINUX to WITH_SELINUX

2013-03-09 Thread Guido Günther
these were missed by 63f18f378693cac6b6e33f4a8c15c20cb191c7c8 --- src/lxc/lxc_container.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index 7ec67f4..4d09791 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_conta

<    1   2   3   4   5   6   7   8   9   10   >