[libvirt PATCH v2 03/10] virNWFilterCreateVarsFrom: Remove superfluous `goto`s

Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- tests/nwfilterxml2firewalltest.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tests/nwfilterxml2firewalltest.c b/tests/nwfilterxml2firewalltest.c index 26d4a936ad..bdfe858185 100644 --- a/tests

[libvirt PATCH v2 08/10] qemuMonitorGetMemoryDeviceInfo: Assign hash table only on success

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index a2df1a6ec3..9b1a3ec3eb 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -4214,6

[libvirt PATCH v2 10/10] qemuMonitorGetMemoryDeviceInfo: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/qemu/qemu_monitor.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 0b5da8b71f..f66a3457c1 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu

[libvirt PATCH v2 07/10] iptablesPrivateChainCreate: Remove superfluous `goto`s

Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/util/viriptables.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/util/viriptables.c b/src/util/viriptables.c index 847af9b9d7..721e1eeae7 100644 --- a/src/util/viriptables.c +++ b/src/util

[libvirt PATCH v2 01/10] virNWFilterCreateVarsFrom: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- tests/nwfilterxml2firewalltest.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/nwfilterxml2firewalltest.c b/tests/nwfilterxml2firewalltest.c index 6709cc15fd..3b7190b5cd 100644 --- a/tests/nwfilterxml2firewalltest.c +++ b

[libvirt PATCH v2 09/10] qemuMonitorGetMemoryDeviceInfo: Use automatic memory management

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 9b1a3ec3eb..0b5da8b71f 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -4214,7 +4214,7

[libvirt PATCH 02/10] virNWFilterParseParamAttributes: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/conf/nwfilter_params.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/conf/nwfilter_params.c b/src/conf/nwfilter_params.c index aeed0cff1f..c94e9679f8 100644 --- a/src/conf/nwfilter_params.c +++ b/src/conf/nwfilter_params.c @@ -702,8 +702,6

[libvirt PATCH 00/10] virHashNew refactorings - part V

"virHashNew" cannot return NULL, yet we check for NULL in various places. See https://listman.redhat.com/archives/libvir-list/2021-July/msg00074.html. Tim Wiederhake (10): conf: Add AUTOPTR_CLEANUP_FUNC for virNWFilterVarValue virNWFilterParseParamAttributes: `virHashNew` cannot r

[libvirt PATCH 01/10] conf: Add AUTOPTR_CLEANUP_FUNC for virNWFilterVarValue

Signed-off-by: Tim Wiederhake --- src/conf/nwfilter_params.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/conf/nwfilter_params.h b/src/conf/nwfilter_params.h index d11b533958..f9f7f68ff3 100644 --- a/src/conf/nwfilter_params.h +++ b/src/conf/nwfilter_params.h @@ -51,6 +51,8

[libvirt PATCH 03/10] virNWFilterParseParamAttributes: Iterate over "element" children

"xmlNextElementSibling()" skips attribute nodes, making the explicit check for the type of `cur` redundant. This prepares for the removal of this check in the next commit. Signed-off-by: Tim Wiederhake --- src/conf/nwfilter_params.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[libvirt PATCH 04/10] virNWFilterParseParamAttributes: Remove tautological `if`

`cur` is guaranteed to be of type `XML_ELEMENT_NODE` by using `xmlFirstElementChild()` and `xmlNextElementSibling()`. Signed-off-by: Tim Wiederhake --- src/conf/nwfilter_params.c | 57 +++--- 1 file changed, 28 insertions(+), 29 deletions(-) diff --git a/src

[libvirt PATCH 06/10] virNWFilterParseParamAttributes: Simplify loop body

Signed-off-by: Tim Wiederhake --- src/conf/nwfilter_params.c | 36 +++- 1 file changed, 15 insertions(+), 21 deletions(-) diff --git a/src/conf/nwfilter_params.c b/src/conf/nwfilter_params.c index 0b1676e25f..63ab7e7150 100644 --- a/src/conf/nwfilter_params.c

[libvirt PATCH 05/10] virNWFilterParseParamAttributes: Use automatic memory management

Signed-off-by: Tim Wiederhake --- src/conf/nwfilter_params.c | 22 ++ 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/src/conf/nwfilter_params.c b/src/conf/nwfilter_params.c index 0b967e1194..0b1676e25f 100644 --- a/src/conf/nwfilter_params.c +++ b/src/conf

[libvirt PATCH 07/10] virNWFilterParseParamAttributes: Remove superfluous `goto`s

Signed-off-by: Tim Wiederhake --- src/conf/nwfilter_params.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/conf/nwfilter_params.c b/src/conf/nwfilter_params.c index 63ab7e7150..35ea0256c3 100644 --- a/src/conf/nwfilter_params.c +++ b/src/conf

[libvirt PATCH 08/10] virNWFilterDoInstantiate: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/nwfilter/nwfilter_gentech_driver.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/nwfilter/nwfilter_gentech_driver.c b/src/nwfilter/nwfilter_gentech_driver.c index 8aa1db23d3..114c1cef4f 100644 --- a/src/nwfilter/nwfilter_gentech_driver.c +++ b

[libvirt PATCH 09/10] virNWFilterIPAddrMapInit: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/conf/nwfilter_ipaddrmap.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/conf/nwfilter_ipaddrmap.c b/src/conf/nwfilter_ipaddrmap.c index d6facd749e..bc21c80536 100644 --- a/src/conf/nwfilter_ipaddrmap.c +++ b/src/conf/nwfilter_ipaddrmap.c

[libvirt PATCH 10/10] virNWFilterLearnInit: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/nwfilter/nwfilter_learnipaddr.c | 8 1 file changed, 8 deletions(-) diff --git a/src/nwfilter/nwfilter_learnipaddr.c b/src/nwfilter/nwfilter_learnipaddr.c index 907e4b2513..2177c5540b 100644 --- a/src/nwfilter/nwfilter_learnipaddr.c +++ b/src

[libvirt PATCH] AUTHORS: Add myself to the list of commiters

Signed-off-by: Tim Wiederhake --- AUTHORS.rst.in | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS.rst.in b/AUTHORS.rst.in index a580359c0e..e8a560b780 100644 --- a/AUTHORS.rst.in +++ b/AUTHORS.rst.in @@ -31,6 +31,7 @@ The primary maintainers and people with commit access rights

[libvirt PATCH 01/10] qemuStateInitialize: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index df44c3fbd0..521063d438 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -753,8 +753,7

[libvirt PATCH 02/10] qemuMonitorGetPRManagerInfo: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index f66a3457c1..940eeab9a8 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -4522,8 +4522,7

[libvirt PATCH 03/10] qemuMonitorGetPRManagerInfo: Use automatic memory management

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 940eeab9a8..36b1f15c7d 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -4516,21 +4516,18

[libvirt PATCH 06/10] qemuMonitorJSONGetAllBlockJobInfo: Use automatic memory management

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor_json.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 472308e1d3..59c5eedb0a 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu

[libvirt PATCH 04/10] qemuMonitorGetPRManagerInfo: Remove superfluous `goto`s

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 36b1f15c7d..b06c842a7a 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -4515,7

[libvirt PATCH 05/10] qemuMonitorJSONGetAllBlockJobInfo: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor_json.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 22339d..472308e1d3 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu

[libvirt PATCH 07/10] qemuMonitorJSONGetAllBlockJobInfo: Remove superfluous `goto`s

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor_json.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 59c5eedb0a..7e53e0ce84 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu

[libvirt PATCH 08/10] testQemuGetLatestCaps: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- tests/testutilsqemu.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c index be576037e2..72c0b1857b 100644 --- a/tests/testutilsqemu.c +++ b/tests/testutilsqemu.c @@ -585,12 +585,9

[libvirt PATCH 10/10] testQemuGetLatestCaps: Remove superfluous `goto`s

Signed-off-by: Tim Wiederhake --- tests/testutilsqemu.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c index 72b53096d9..fab676c070 100644 --- a/tests/testutilsqemu.c +++ b/tests/testutilsqemu.c @@ -594,7 +594,7

[libvirt PATCH 00/10] virHashNew refactorings - part VI

"virHashNew" cannot return NULL, yet we check for NULL in various places. See https://listman.redhat.com/archives/libvir-list/2021-July/msg00074.html. Tim Wiederhake (10): qemuStateInitialize: `virHashNew` cannot return NULL qemuMonitorGetPRManagerInfo: `virHashNew` cannot r

[libvirt PATCH 09/10] testQemuGetLatestCaps: Use automatic memory management

Signed-off-by: Tim Wiederhake --- tests/testutilsqemu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c index 72c0b1857b..72b53096d9 100644 --- a/tests/testutilsqemu.c +++ b/tests/testutilsqemu.c @@ -585,7 +585,7

Re: [libvirt PATCH 00/10] virHashNew refactorings - part VI

On Mon, 2021-07-19 at 14:08 +0200, Peter Krempa wrote: > On Mon, Jul 19, 2021 at 11:55:44 +0200, Tim Wiederhake wrote: > > "virHashNew" cannot return NULL, yet we check for NULL in various > > places. > > > > See > > https://listman.redhat.com/a

Re: [PATCH] meson: disable bogus warnings from sanitizers on Fedora

*/ >   | ^ > cc1: all warnings being treated as errors > > The code is correct, and this only happens when building at -O2. > > The docs for -Warray-bounds say that a value of "2" is known to > be liable to generate false positives. Rather than d

[libvirt PATCH] virIdentityEnsureSystemToken: Fix error message

This appears to be a copy-paste mistake from the check directly above. Signed-off-by: Tim Wiederhake --- src/util/viridentity.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/viridentity.c b/src/util/viridentity.c index eb77f69e2e..c18326c8cb 100644 --- a/src/util

[libvirt PATCH 0/4] CI: Fail tests on UBSAN findings

fail the tests in the CI, if it detects undefined behaviour. See https://listman.redhat.com/archives/libvir-list/2021-June/msg00341.html for background on the change to virFileReadLimFD usage. Tim Wiederhake (4): virfile: Move max file size macro virfile: Use VIR_MAX_FILE_LEN instead of

[libvirt PATCH 1/4] virfile: Move max file size macro

The next commit will use this macro outside the apparmor context. Signed-off-by: Tim Wiederhake --- src/security/security_apparmor.c | 4 ++-- src/security/security_apparmor.h | 1 - src/security/virt-aa-helper.c| 10 +- src/util/virfile.h | 3 +++ 4 files changed

[libvirt PATCH 2/4] virfile: Use VIR_MAX_FILE_LEN instead of INT_MAX to limit file size

The use of INT_MAX as maximum file length is problematic for reasons discussed in the next commit. Signed-off-by: Tim Wiederhake --- tests/networkxml2firewalltest.c | 2 +- tests/testutils.c | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/tests

[libvirt PATCH 4/4] ci: Halt on sanitizer errors

-by: Tim Wiederhake --- .gitlab-ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 3cb6ff5e6b..4757139fa9 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -89,6 +89,8 @@ stages: - meson build --werror -Ddocs=disabled -Db_lundef=false

[libvirt PATCH 3/4] virFileReadLimFD: Limit maximum file size to INT_MAX - 1

virFileReadLimFD error out if the maximum file size is INT_MAX to prevent the reintroduction of this issue. Signed-off-by: Tim Wiederhake --- src/util/virfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index 723e1ca6e5

Re: [libvirt PATCH 00/10] virHashNew refactorings - part V

ping On Wed, 2021-07-14 at 11:44 +0200, Tim Wiederhake wrote: > "virHashNew" cannot return NULL, yet we check for NULL in various > places. > > See > https://listman.redhat.com/archives/libvir-list/2021-July/msg00074.html > . > > Tim Wiederhake (10): >

[libvirt PATCH 00/38] virHashNew refactorings - part VII

"virHashNew" cannot return NULL, yet we check for NULL in various places. See https://listman.redhat.com/archives/libvir-list/2021-July/msg00074.html. Not split up further as per https://listman.redhat.com/archives/libvir-list/2021-July/msg00575.html Tim Wied

[libvirt PATCH 01/38] virSystemdActivationNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/util/virsystemd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/virsystemd.c b/src/util/virsystemd.c index 96f81cd3fa..6417dc6ea7 100644 --- a/src/util/virsystemd.c +++ b/src/util/virsystemd.c @@ -964,8 +964,7

[libvirt PATCH 04/38] virNWFilterCreateVarsFrom: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/nwfilter/nwfilter_gentech_driver.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/nwfilter/nwfilter_gentech_driver.c b/src/nwfilter/nwfilter_gentech_driver.c index da4f71daf1..dbb6b1f80e 100644 --- a/src/nwfilter/nwfilter_gentech_driver.c +++ b

[libvirt PATCH 03/38] virSystemdActivationNew: Remove superfluous `goto`s

Signed-off-by: Tim Wiederhake --- src/util/virsystemd.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/util/virsystemd.c b/src/util/virsystemd.c index f90c17e767..99c92b6f52 100644 --- a/src/util/virsystemd.c +++ b/src/util/virsystemd.c @@ -968,17 +968,14

[libvirt PATCH 05/38] virNWFilterCreateVarsFrom: Use automatic memory management

Signed-off-by: Tim Wiederhake --- src/nwfilter/nwfilter_gentech_driver.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/nwfilter/nwfilter_gentech_driver.c b/src/nwfilter/nwfilter_gentech_driver.c index dbb6b1f80e..d17be401e6 100644 --- a/src/nwfilter

[libvirt PATCH 02/38] virSystemdActivationNew: Use automatic memory management

Signed-off-by: Tim Wiederhake --- src/util/virsystemd.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/util/virsystemd.c b/src/util/virsystemd.c index 6417dc6ea7..f90c17e767 100644 --- a/src/util/virsystemd.c +++ b/src/util/virsystemd.c @@ -958,11 +958,10

[libvirt PATCH 08/38] ebiptablesApplyNewRules: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/nwfilter/nwfilter_ebiptables_driver.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/nwfilter/nwfilter_ebiptables_driver.c b/src/nwfilter/nwfilter_ebiptables_driver.c index 345562bab6..ec17d43c4e 100644 --- a/src/nwfilter

[libvirt PATCH 06/38] virNWFilterCreateVarsFrom: Remove superfluous `goto`s

Signed-off-by: Tim Wiederhake --- src/nwfilter/nwfilter_gentech_driver.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/nwfilter/nwfilter_gentech_driver.c b/src/nwfilter/nwfilter_gentech_driver.c index d17be401e6..a425285e8c 100644 --- a/src/nwfilter

[libvirt PATCH 07/38] virNWFilterRuleDefToRuleInst: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/nwfilter/nwfilter_gentech_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/nwfilter/nwfilter_gentech_driver.c b/src/nwfilter/nwfilter_gentech_driver.c index a425285e8c..f98af5d513 100644 --- a/src/nwfilter

[libvirt PATCH 12/38] qemuBlockNodeNamesDetect: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_block.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index 6627d044cd..2815eb54fa 100644 --- a/src/qemu/qemu_block.c +++ b/src/qemu/qemu_block.c @@ -365,10 +365,7

[libvirt PATCH 10/38] qemusecuritymock: init_hash: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- tests/qemusecuritymock.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/tests/qemusecuritymock.c b/tests/qemusecuritymock.c index 5daf27ccd7..87aadf564e 100644 --- a/tests/qemusecuritymock.c +++ b/tests/qemusecuritymock.c

[libvirt PATCH 13/38] qemuBlockNodeNameGetBackingChain: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_block.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index 2815eb54fa..8150241015 100644 --- a/src/qemu/qemu_block.c +++ b/src/qemu/qemu_block.c @@ -231,22 +231,16

[libvirt PATCH 15/38] qemuInteropFetchConfigs: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_interop_config.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_interop_config.c b/src/qemu/qemu_interop_config.c index ea2afcc070..848e8f7381 100644 --- a/src/qemu/qemu_interop_config.c +++ b/src/qemu

[libvirt PATCH 14/38] qemuDomainObjPrivateAlloc: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_domain.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index ac1d8ef151..b919da6eab 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -1788,8 +1788,7

[libvirt PATCH 16/38] virChrdevAlloc: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/conf/virchrdev.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/conf/virchrdev.c b/src/conf/virchrdev.c index 91f2b5a233..5d6de68427 100644 --- a/src/conf/virchrdev.c +++ b/src/conf/virchrdev.c @@ -265,13 +265,9 @@ virChrdevs

[libvirt PATCH 17/38] virCloseCallbacksNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/hypervisor/virclosecallbacks.c | 4 1 file changed, 4 deletions(-) diff --git a/src/hypervisor/virclosecallbacks.c b/src/hypervisor/virclosecallbacks.c index b9d4940b60..2578a71f03 100644 --- a/src/hypervisor/virclosecallbacks.c +++ b/src/hypervisor

[libvirt PATCH 18/38] virDomainCCWAddressSetCreate: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/conf/domain_addr.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c index f011721beb..53b39923e8 100644 --- a/src/conf/domain_addr.c +++ b/src/conf/domain_addr.c @@ -1388,8 +1388,7

[libvirt PATCH 19/38] virDomainDefBootOrderPostParse: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index e05ea9ba88..6937863db7 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -5924,10 +5924,7

[libvirt PATCH 22/38] virDomainObjListNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/conf/virdomainobjlist.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/conf/virdomainobjlist.c b/src/conf/virdomainobjlist.c index 5f9fd9aabc..43d09692a9 100644 --- a/src/conf/virdomainobjlist.c +++ b/src/conf

[libvirt PATCH 20/38] virDomainDefValidateAliases: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/conf/domain_validate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index df2ab47361..aab377fbbd 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c

[libvirt PATCH 21/38] virDomainMomentObjListNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/conf/virdomainmomentobjlist.c | 4 1 file changed, 4 deletions(-) diff --git a/src/conf/virdomainmomentobjlist.c b/src/conf/virdomainmomentobjlist.c index c0896685a9..17b9c16ae7 100644 --- a/src/conf/virdomainmomentobjlist.c +++ b/src/conf

[libvirt PATCH 23/38] virFileCacheNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/util/virfilecache.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/util/virfilecache.c b/src/util/virfilecache.c index 2f55deefb6..64348dc1e6 100644 --- a/src/util/virfilecache.c +++ b/src/util/virfilecache.c @@ -242,8 +242,7

[libvirt PATCH 24/38] virHashAtomicNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/util/virhash.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/util/virhash.c b/src/util/virhash.c index d2b591c0b7..a9996c9fc0 100644 --- a/src/util/virhash.c +++ b/src/util/virhash.c @@ -102,10 +102,7 @@ virHashAtomicNew

[libvirt PATCH 26/38] virLockDaemonNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/locking/lock_daemon.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/locking/lock_daemon.c b/src/locking/lock_daemon.c index 05fc68dc54..f5e5375e80 100644 --- a/src/locking/lock_daemon.c +++ b/src/locking/lock_daemon.c @@ -153,8

[libvirt PATCH 25/38] virInterfaceObjListNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/conf/virinterfaceobj.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/conf/virinterfaceobj.c b/src/conf/virinterfaceobj.c index c8fda4990f..a73208f1fc 100644 --- a/src/conf/virinterfaceobj.c +++ b/src/conf/virinterfaceobj.c

[libvirt PATCH 27/38] virLockDaemonNewPostExecRestart: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/locking/lock_daemon.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/locking/lock_daemon.c b/src/locking/lock_daemon.c index f5e5375e80..fa08acbc76 100644 --- a/src/locking/lock_daemon.c +++ b/src/locking/lock_daemon.c @@ -211,8

[libvirt PATCH 29/38] virLockSpaceNewPostExecRestart: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/util/virlockspace.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/virlockspace.c b/src/util/virlockspace.c index edf2ec907f..0c4beaf9fe 100644 --- a/src/util/virlockspace.c +++ b/src/util/virlockspace.c @@ -293,8 +293,7

[libvirt PATCH 31/38] virNetworkObjListNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/conf/virnetworkobj.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/conf/virnetworkobj.c b/src/conf/virnetworkobj.c index 341d6b4292..66f916c749 100644 --- a/src/conf/virnetworkobj.c +++ b/src/conf/virnetworkobj.c @@ -350,10

[libvirt PATCH 33/38] virNodeDeviceObjListNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/conf/virnodedeviceobj.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/conf/virnodedeviceobj.c b/src/conf/virnodedeviceobj.c index b213592b56..e8f6792138 100644 --- a/src/conf/virnodedeviceobj.c +++ b/src/conf/virnodedeviceobj.c

[libvirt PATCH 34/38] virQEMUCapsProbeQMPHostCPU: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_capabilities.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 6cea8c2eca..3804687080 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu

[libvirt PATCH 35/38] virSecuritySELinuxLXCInitialize: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/security/security_selinux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index 0c2cf1d1c7..0bff9b7bae 100644 --- a/src/security/security_selinux.c +++ b/src/security

[libvirt PATCH 37/38] virStoragePoolObjListNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/conf/virstorageobj.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/conf/virstorageobj.c b/src/conf/virstorageobj.c index 24957d6012..6c8a06e8bc 100644 --- a/src/conf/virstorageobj.c +++ b/src/conf/virstorageobj.c @@ -401,12

[libvirt PATCH 38/38] virStorageVolObjListNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/conf/virstorageobj.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/conf/virstorageobj.c b/src/conf/virstorageobj.c index 6c8a06e8bc..2b6932d7e5 100644 --- a/src/conf/virstorageobj.c +++ b/src/conf/virstorageobj.c @@ -170,12

[libvirt PATCH 32/38] virNetworkObjNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/conf/virnetworkobj.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/conf/virnetworkobj.c b/src/conf/virnetworkobj.c index 66f916c749..ea021892c7 100644 --- a/src/conf/virnetworkobj.c +++ b/src/conf/virnetworkobj.c @@ -118,8 +118,7

[libvirt PATCH 09/38] hypervCreateEmbeddedParam: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/hyperv/hyperv_wmi.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index b113283aeb..dc2c6471ab 100644 --- a/src/hyperv/hyperv_wmi.c +++ b/src/hyperv/hyperv_wmi.c @@ -275,7 +275,7

[libvirt PATCH 30/38] virNetDaemonNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/rpc/virnetdaemon.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/rpc/virnetdaemon.c b/src/rpc/virnetdaemon.c index 1a17753f42..b6f3233f64 100644 --- a/src/rpc/virnetdaemon.c +++ b/src/rpc/virnetdaemon.c @@ -141,8 +141,7

[libvirt PATCH 36/38] virSecuritySELinuxQEMUInitialize: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/security/security_selinux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index 0bff9b7bae..5f98d4d47a 100644 --- a/src/security/security_selinux.c +++ b/src/security

[libvirt PATCH 28/38] virLockSpaceNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/util/virlockspace.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/virlockspace.c b/src/util/virlockspace.c index 9986d8df41..edf2ec907f 100644 --- a/src/util/virlockspace.c +++ b/src/util/virlockspace.c @@ -247,8 +247,7

[libvirt PATCH 11/38] libxlLoggerNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/libxl/libxl_logger.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/libxl/libxl_logger.c b/src/libxl/libxl_logger.c index 0807383d39..f7b5c8ee16 100644 --- a/src/libxl/libxl_logger.c +++ b/src/libxl/libxl_logger.c @@ -149,9 +149,7

Re: [libvirt PATCH 4/4] ci: Halt on sanitizer errors

On Wed, 2021-07-21 at 06:56 -0700, Andrea Bolognani wrote: > On Wed, Jul 21, 2021 at 03:08:02PM +0200, Peter Krempa wrote: > > On Wed, Jul 21, 2021 at 14:46:43 +0200, Tim Wiederhake wrote: > > > +++ b/.gitlab-ci.yml > > > @@ -89,6 +89,8 @@ stages: > > > -

[libvirt PATCH v2 1/2] virFileReadLimFD: Cast maxlen to size_t before adding

If the function is called with maxlen equal to `INT_MAX`, adding one will trigger a signed integer overflow. Signed-off-by: Tim Wiederhake --- src/util/virfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index 723e1ca6e5

[libvirt PATCH v2 0/2] Fail tests on UBSAN findings

V1: https://listman.redhat.com/archives/libvir-list/2021-July/msg00592.html Changes since V1: Simplified series by using the approach mentioned in https://listman.redhat.com/archives/libvir-list/2021-June/msg00358.html Tim Wiederhake (2): virFileReadLimFD: Cast maxlen to size_t before adding

[libvirt PATCH v2 2/2] ci: Halt on sanitizer errors

-by: Tim Wiederhake --- .gitlab-ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 3cb6ff5e6b..4757139fa9 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -89,6 +89,8 @@ stages: - meson build --werror -Ddocs=disabled -Db_lundef=false

Re: [PATCH 0/7] Various fixes

 src/qemu/qemu_block.c  |  8 ++ >  src/qemu/qemu_domain.c | 57 ++-- > -- >  src/util/virhash.h |  2 +- >  6 files changed, 39 insertions(+), 61 deletions(-) > LGTM. Series: Reviewed-by: Tim Wiederhake

[libvirt PATCH 0/3] virHashNew refactorings - part VIII

e_t` typed variables. Tim Wiederhake (3): virLockSpaceNewPostExecRestart: `virHashNew` cannot return NULL WIP virStoragePoolObjListNew: `virHashNew` cannot return NULL virNWFilterParseParamAttributes: Simplify loop src/conf/nwfilter_params.c | 7 ++- src/conf/virstorageobj.c | 7 ++-

[libvirt PATCH 1/3] virLockSpaceNewPostExecRestart: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/util/virlockspace.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/virlockspace.c b/src/util/virlockspace.c index edf2ec907f..46bd922f35 100644 --- a/src/util/virlockspace.c +++ b/src/util/virlockspace.c @@ -293,8 +293,7

[libvirt PATCH 3/3] virNWFilterParseParamAttributes: Simplify loop

Signed-off-by: Tim Wiederhake --- src/conf/nwfilter_params.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/conf/nwfilter_params.c b/src/conf/nwfilter_params.c index 35ea0256c3..ca7b62874c 100644 --- a/src/conf/nwfilter_params.c +++ b/src/conf/nwfilter_params.c

[libvirt PATCH 2/3] WIP virStoragePoolObjListNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/conf/virstorageobj.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/conf/virstorageobj.c b/src/conf/virstorageobj.c index 32ed55ff8b..18a7718de9 100644 --- a/src/conf/virstorageobj.c +++ b/src/conf/virstorageobj.c @@ -398,11

[libvirt PATCH] docs: Fix two spelling mistakes

Signed-off-by: Tim Wiederhake --- docs/kbase/qemu-core-dump.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/kbase/qemu-core-dump.rst b/docs/kbase/qemu-core-dump.rst index 44fd40fc52..5c3781cf90 100644 --- a/docs/kbase/qemu-core-dump.rst +++ b/docs/kbase/qemu-core

Re: [libvirt PATCH 3/3] virNWFilterParseParamAttributes: Simplify loop

ping On Fri, 2021-07-23 at 11:56 +0200, Tim Wiederhake wrote: > Signed-off-by: Tim Wiederhake > --- >  src/conf/nwfilter_params.c | 7 ++- >  1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/src/conf/nwfilter_params.c b/src/conf/nwfilter_params.c

[libvirt PATCH 3/7] qemuxml2argvtest: Unlock virDomainObj before disposal

virDomainObj contains a mutex. Destroying a locked mutex results in undefined behavior. Signed-off-by: Tim Wiederhake --- tests/qemuxml2argvtest.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index

[libvirt PATCH 6/7] virMutex*: Warn on error

`pthread_mutex_destroy`, `pthread_mutex_lock` and `pthread_mutex_unlock` return an error code that is currently ignored. Add debug information if one of these operations failed, e.g. when there is an attempt to destroy a still locked mutex or unlock and already unlocked mutex. Signed-off-by: Tim

[libvirt PATCH 0/7] Fix some mutex related issues

es of this type are introduced. Patches 1, 2, 3, and 4 fix the issues, patches 5, 6, and 7 add the checks. See https://gitlab.com/twiederh/libvirt/-/pipelines/348505233 and https://gitlab.com/twiederh/libvirt/-/pipelines/348505233 (only patches 5, 6, and 7). Regards, Tim Tim Wiederhake (7): test

[libvirt PATCH 1/7] tests: qemuMonitorTestFree: Unlock virDomainObj before freeing

virDomainObj contains a mutex. Destroying a locked mutex results in undefined behavior. Signed-off-by: Tim Wiederhake --- tests/qemumonitortestutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemumonitortestutils.c b/tests/qemumonitortestutils.c index 143dd954e6

[libvirt PATCH 2/7] qemusecuritytest: Unlock virDomainObj before disposal

virDomainObj contains a mutex. Destroying a locked mutex results in undefined behavior. Signed-off-by: Tim Wiederhake --- tests/qemusecuritytest.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qemusecuritytest.c b/tests/qemusecuritytest.c index a7e87fdf8f

[libvirt PATCH 4/7] qemuhotplugtest: Lock reused virDomainObj

If the previous test had `keep == 1` set, this function inherits its (unlocked) virDomainObj. Signed-off-by: Tim Wiederhake --- tests/qemuhotplugtest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c index 57d76845c6..d8d6a3a226 100644 --- a

[libvirt PATCH 5/7] Meson: Define "DYNAMIC_ANALYSIS" if built with sanitizers enabled

in gcc (see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60512) gcc, depending on the version, defines "__SANITIZE_ADDRESS__ 1" if compiled with the address sanitizer enabled. No similar macro is defined for the undefined behavior sanitizer. Instead, let meson set this symbol. Signed-of

[libvirt PATCH 0/3] Add script to sync from QEMU i386 cpu models

This hopefully makes synchronization with QEMU faster and less error prone. Patch #3 showcases the changes to the cpu models the script suggests for qemu 8d90bfc5c31ad60f6049dd39be636b06bc00b652. Tim Wiederhake (3): cpu_map: Unify apostrophe and quotation mark usage cpu_map: Add script to

[libvirt PATCH 3/3] [DONTMERGE] Sample output of new sync script

Do not merge this commit. This commit contains the changes that would be suggested by the cpu_map sync script (see last commit): ./sync_qemu_i386.py ~/git/qemu/target/i386/cpu.c . Note: * Some models have "signature" / "vendor" added. * Models with multiple "signature"s lose all but one. * Com

[libvirt PATCH 2/3] cpu_map: Add script to sync from QEMU i386 cpu models

information that cannot be generated from the QEMU data, preventing fully automated usage. The output should nevertheless be helpful for a human in determining potentially interesting changes. Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_i386.py | 361 ++ 1

[libvirt PATCH v2 2/3] cpu_map: Add script to sync from QEMU i386 cpu models

information that cannot be generated from the QEMU data, preventing fully automated usage. The output should nevertheless be helpful for a human in determining potentially interesting changes. Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_i386.py | 361 ++ 1

[libvirt PATCH v2 3/3] [DONTMERGE] Sample output of new sync script

Do not merge this commit. This commit contains the changes that would be suggested by the cpu_map sync script (see last commit): ./sync_qemu_i386.py ~/git/qemu/target/i386/cpu.c . Note: * Some models have "signature" / "vendor" added. * Models with multiple "signature"s lose all but one. * Com

<    1   2   3   4   5   6   7   8   9   10   >