Re: Fixes segfault in beam quanting. (issue4339047)

2011-04-03 Thread Han-Wen Nienhuys
On Mon, Apr 4, 2011 at 12:43 AM, Werner LEMBERG wrote: >> This basically dereferences an (almost) null pointer.  Possibly, >> this crashes neatly in debug mode (I'm not sure).  The SCM_CDR() >> variant will surely crash with segmentation fault. > > There is a misunderstanding.  I was rather talki

Re: website build notes

2011-04-03 Thread Graham Percival
On Sun, Apr 03, 2011 at 09:51:21PM -0600, Colin Campbell wrote: > Something seems to have choked in build-notes.itexi, Graham. > Specifically, the node on Website build no longer produces an html > file. Wow, this one really went through the cracks! - a normal makeinfo was fine, because the secon

Re: website build notes

2011-04-03 Thread Colin Campbell
On 11-04-03 12:06 PM, Graham Percival wrote: On Sun, Apr 03, 2011 at 11:35:09AM +0100, Phil Holmes wrote: Just about to look. I sent this patch to James a couple of times last week, but he didn't acknowledge it. hmm, that doesn't sound good. Anyway, thanks, pushed. Cheers, - Graham Somethin

Re: Fixes segfault in beam quanting. (issue4339047)

2011-04-03 Thread Werner LEMBERG
>>> The worst which can happen is that a value is incorrectly >>> type-cast which leads to either a null dereference or some other >>> type assertion. >> >> Could you give a Scheme example for that, please? > > Typical examples: > > * scm_cdr(SCM_EOL) > > This basically dereferences an (almost) nu

Re: Fixes segfault in beam quanting. (issue4339047)

2011-04-03 Thread Han-Wen Nienhuys
On Mon, Apr 4, 2011 at 12:22 AM, Werner LEMBERG wrote: > >> LilyPond exposes large parts of the internal implementation through >> the Scheme interface, and that has as a side-effect that there are >> many ways for users to break lilypond.  This is unlikely to lead to >> arbitrary behavior, as Gui

Re: Fixes segfault in beam quanting. (issue4339047)

2011-04-03 Thread Graham Percival
On Mon, Apr 04, 2011 at 05:22:28AM +0200, Werner LEMBERG wrote: > > > I don't think it is productive to try to systematically plug all > > these errors; at best, you'll replace a bunch of segmentation faults > > with just as unhelpful assertion failures. > > I definitely prefer assertions to segf

Re: Fixes segfault in beam quanting. (issue4339047)

2011-04-03 Thread Werner LEMBERG
> LilyPond exposes large parts of the internal implementation through > the Scheme interface, and that has as a side-effect that there are > many ways for users to break lilypond. This is unlikely to lead to > arbitrary behavior, as Guile values themselves themselves are type > tagged. The worst

Re: Fixes segfault in beam quanting. (issue4339047)

2011-04-03 Thread Han-Wen Nienhuys
On Sun, Apr 3, 2011 at 3:17 PM, Werner LEMBERG wrote: >>> I do.  Any user program *must not* produce a segfault IMHO if fed >>> with user data, regardless of its origin. >> >> It it possible to make guile crash? > > Maybe.  However, with `crash' I mean that lilypond aborts with a > segfault or som

PATCHES: 48-hour notice for hyphens and grace notes in lyrics

2011-04-03 Thread Graham Percival
Wed, 02:00. Suppress continuing LyricHyphen under grace note at start of line http://codereview.appspot.com/4313047/ Search of context hierarchy for voice for lyrics is made optional http://code.google.com/p/lilypond/issues/detail?id=1579 Cheers, - Graham ___

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-04-03 Thread percival . music . ca
This patch loses flags! is that deliberate?! stem-tremolo.ly flags-default.ly beam-collision-beamcount.ly ... etc... Have you tried a regtest comparison? Please read this: http://lilypond.org/doc/v2.13/Documentation/contributor/regtest-comparison and let me know if you need help with any

Re: Fixes segfault in beam quanting. (issue4339047)

2011-04-03 Thread Trevor Daniels
m...@apollinemike.com wrote Sunday, April 03, 2011 7:31 PM I'll chime in here and say that I am still for applying my patch to beam quanting as a general fix. I agree that refining how stems meet up w/ noteheads is a better solution, but I think the bigger problem lies in the fact that beam

Re: Fixes segfault in beam quanting. (issue4339047)

2011-04-03 Thread m...@apollinemike.com
On Apr 3, 2011, at 2:17 PM, Werner LEMBERG wrote: > >>> I do. Any user program *must not* produce a segfault IMHO if fed >>> with user data, regardless of its origin. >> >> It it possible to make guile crash? > > Maybe. However, with `crash' I mean that lilypond aborts with a > segfault or so

Re: Fixes segfault in beam quanting. (issue4339047)

2011-04-03 Thread Werner LEMBERG
>> I do. Any user program *must not* produce a segfault IMHO if fed >> with user data, regardless of its origin. > > It it possible to make guile crash? Maybe. However, with `crash' I mean that lilypond aborts with a segfault or something similar. It's quite easy to write an endless loop or t

Re: website build notes

2011-04-03 Thread Graham Percival
On Sun, Apr 03, 2011 at 11:35:09AM +0100, Phil Holmes wrote: > Just about to look. I sent this patch to James a couple of times > last week, but he didn't acknowledge it. hmm, that doesn't sound good. Anyway, thanks, pushed. Cheers, - Graham ___ lily

Re: Fixes segfault in beam quanting. (issue4339047)

2011-04-03 Thread Graham Percival
On Sun, Apr 03, 2011 at 08:16:12AM +0200, Werner LEMBERG wrote: > > > (lily segfaults all the time when I accidentally feed her a PDF file > > instead of a .ly file, but I don't consider this to be a bug) > > I do. Any user program *must not* produce a segfault IMHO if fed with > user data, rega

Re: improvement(s) on LSR 445

2011-04-03 Thread Gilles THIBAULT
is it possible to only copy notes, i.e. pitches and durations, excluding Fingering, stroke fingers and string numbers? 2 solutions : 1- You filter the music. Here is an example of filtered music %%% deleteDynamics = #(define-music-function (parser location music) (ly:m

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-04-03 Thread mtsolo
Hey all, I don't have time for a few days to check this out in depth, but it definitely deserves to be read over & commented upon. Please review it if you can! Cheers, Mike http://codereview.appspot.com/4312057/ ___ lilypond-devel mailing list lilyp

Re: website build notes

2011-04-03 Thread Phil Holmes
Just about to look. I sent this patch to James a couple of times last week, but he didn't acknowledge it. -- Phil Holmes - Original Message - From: "Graham Percival" To: "Colin Campbell" ; "Phil Holmes" Cc: Sent: Friday, April 01, 2011 6:36 PM Subject: website build notes I've

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-04-03 Thread lemniskata . bernoullego
New patch set uploaded. After a week of trying, there is probably nothing more that i can do. The code works, but could be easily improved by someone skillful. Any comments and help are welcome. cheers, Janek http://codereview.appspot.com/4312057/ __