I've done two regtest checks, and it all seems fine, so I've pushed it.
http://codereview.appspot.com/3858041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Any other comments about this? I'm aware of some discussion here about
get_parent:
http://lists.gnu.org/archive/html/lilypond-devel/2011-01/msg00057.html
http://lists.gnu.org/archive/html/lilypond-devel/2011-01/msg00055.html
is this a reason not to accept the patch as it currently stands? As fa
I've fixed the problems Neil identified in the regtest, but it's still
setting the parent twice, and I'm aware that there's still discussion
between Joe and Matthias about this patch.
I'm mainly putting this on reitveld in case people want to discuss it by
adding comments to places, rather than e
LGTM, but I'd rather we didn't set the parent twice (at least in the
default case where BreakAlignment is acknowledged; obviously once the
engraver's moved, this acknowledger never gets called).
Cheers,
Neil
http://codereview.appspot.com/3858041/diff/3001/input/regression/metronome-multimeasu
Reviewers: ,
Message:
Fixes a segfault, passes the regtest comparison, code by Matthias
Kilian.
Description:
Fix 1464 (segfault with R1 and metronome)
This code came from Mathias Kilian.
Please review this at http://codereview.appspot.com/3858041/
Affected files:
A input/regression/metronom