Issue 2445: Add measure counter to LilyPond (issue 6730044)

Reviewers: , Message: Please review. Thanks! -David Description: Issue 2445: Add measure counter to LilyPond This patch allows the user to number groups of successive measures, which is useful as an aid to the performer in keeping track of repetitions. There is no requirement that the counted

Re: Issue 2445: Add measure counter to LilyPond (issue 6730044)

I found some ambiguities in descriptions. Janek http://codereview.appspot.com/6730044/diff/10001/input/regression/measure-counter-broken.ly File input/regression/measure-counter-broken.ly (right): http://codereview.appspot.com/6730044/diff/10001/input/regression/measure-counter-broken.ly#newco

Re: Issue 2445: Add measure counter to LilyPond (issue 6730044)

Thanks for your review, Janek! https://codereview.appspot.com/6730044/diff/10001/input/regression/measure-counter-broken.ly File input/regression/measure-counter-broken.ly (right): https://codereview.appspot.com/6730044/diff/10001/input/regression/measure-counter-broken.ly#newcode6 input/regres

Re: Issue 2445: Add measure counter to LilyPond (issue 6730044)

much clearer now, thanks! LGTM Janek https://codereview.appspot.com/6730044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 2445: Add measure counter to LilyPond (issue 6730044)

I've opened http://code.google.com/p/lilypond/issues/detail?id=2924 for the Documentation in the NR https://codereview.appspot.com/6730044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 2445: Add measure counter to LilyPond (issue 6730044)

Also, should we include Measure_counter_engraver in the Staff context by default? (it'd make documenting it simpler in the @lilypond if nothing else :) ) https://codereview.appspot.com/6730044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Issue 2445: Add measure counter to LilyPond (issue 6730044)

On Wed, Oct 24, 2012 at 4:10 PM, wrote: > Also, should we include > > Measure_counter_engraver > > in the Staff context by default? > > (it'd make documenting it simpler in the @lilypond if nothing else :) ) +1 from me :) Janek ___ lilypond-devel mail

Re: Issue 2445: Add measure counter to LilyPond (issue 6730044)

On 2012/10/24 20:28:36, janek wrote: On Wed, Oct 24, 2012 at 4:10 PM, wrote: > Also, should we include > > Measure_counter_engraver > > in the Staff context by default? > > (it'd make documenting it simpler in the @lilypond if nothing else :) ) +1 from me :) Janek

Re: Issue 2445: Add measure counter to LilyPond (issue 6730044)

Please make the indicated convert-ly-like changes. Thanks! http://codereview.appspot.com/6730044/diff/32001/input/regression/measure-counter.ly File input/regression/measure-counter.ly (right): http://codereview.appspot.com/6730044/diff/32001/input/regression/measure-counter.ly#newcode20 input

Re: Issue 2445: Add measure counter to LilyPond (issue 6730044)

http://codereview.appspot.com/6730044/diff/32001/input/regression/measure-counter.ly File input/regression/measure-counter.ly (right): http://codereview.appspot.com/6730044/diff/32001/input/regression/measure-counter.ly#newcode1 input/regression/measure-counter.ly:1: \version "2.17.5" Oops: also

Re: Issue 2445: Add measure counter to LilyPond (issue 6730044)

David, I don't mind making the changes, but I'm running into some problems. I used git pull -r before making a patch set and uploading to rietveld, but looking over the patch set there I see that other changes have found their way in--including your check-grob-path function. I'm probably making

Re: Issue 2445: Add measure counter to LilyPond (issue 6730044)

On 2012/10/31 11:41:19, david.nalesnik wrote: David, I don't mind making the changes, but I'm running into some problems. I used git pull -r before making a patch set and uploading to rietveld, but looking over the patch set there I see that other changes have found their way in--includin

Re: Issue 2445: Add measure counter to LilyPond (issue 6730044)

Thank you--I am a bit worried! Speaking of "patch," when I run git format-patch I get six separate patches. Is there any way to compress them into one so this is more convenient for you? -David https://codereview.appspot.com/6730044/ ___ lilypond-de

Re: Issue 2445: Add measure counter to LilyPond (issue 6730044)

http://codereview.appspot.com/6730044/diff/40002/ly/engraver-init.ly File ly/engraver-init.ly (right): http://codereview.appspot.com/6730044/diff/40002/ly/engraver-init.ly#newcode88 ly/engraver-init.ly:88: \consists "Footnote_engraver" Any idea where this line is from? It just appears in the la

Re: Issue 2445: Add measure counter to LilyPond (issue 6730044)

On 2012/10/31 11:55:12, david.nalesnik wrote: Thank you--I am a bit worried! Speaking of "patch," when I run git format-patch I get six separate patches. Is there any way to compress them into one so this is more convenient for you? -David Try if you can git send-email to work for you.