Re: Creates a Flag grob. (issue 4922042)

2011-08-27 Thread mtsolo
Pushed as f0978ed121192fee9bdf2453a325d98693148acf. Cheers, MS http://codereview.appspot.com/4922042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Creates a Flag grob. (issue 4922042)

2011-08-25 Thread Mike Solomon
On Aug 25, 2011, at 9:08 PM, Mike Solomon wrote: > On Aug 25, 2011, at 3:17 PM, Han-Wen Nienhuys wrote: > >> On Thu, Aug 25, 2011 at 7:03 AM, Mike Solomon wrote: >> >>> I have verified via pacifier prints that the pure heights of the flag are >>> being taken from the stencil function and are g

Re: Creates a Flag grob. (issue 4922042)

2011-08-25 Thread Mike Solomon
On Aug 25, 2011, at 3:17 PM, Han-Wen Nienhuys wrote: > On Thu, Aug 25, 2011 at 7:03 AM, Mike Solomon wrote: > >> I have verified via pacifier prints that the pure heights of the flag are >> being taken from the stencil function and are going into the spacing engine >> in separation-item.cc. H

Re: Creates a Flag grob. (issue 4922042)

2011-08-25 Thread Han-Wen Nienhuys
On Thu, Aug 25, 2011 at 7:03 AM, Mike Solomon wrote: > I have verified via pacifier prints that the pure heights of the flag are > being taken from the stencil function and are going into the spacing engine > in separation-item.cc.  However, in theory, this patch should have null > effect on t

Re: Creates a Flag grob. (issue 4922042)

2011-08-25 Thread Mike Solomon
On Aug 25, 2011, at 12:03 PM, Mike Solomon wrote: > On Aug 24, 2011, at 11:53 PM, n.putt...@gmail.com wrote: > >> > > Thanks for your suggestions Neil! > > I'm holding off on pushing the patch because I have noticed a spacing > discrepancy in a few regtests. See the attached, where "old" is

Re: Creates a Flag grob. (issue 4922042)

2011-08-24 Thread n . puttock
http://codereview.appspot.com/4922042/diff/17001/lily/flag.cc File lily/flag.cc (right): http://codereview.appspot.com/4922042/diff/17001/lily/flag.cc#newcode147 lily/flag.cc:147: "what style of flag glyph is typeset on a" " what http://codereview.appspot.com/4922042/diff/17001/lily/flag.cc#new

Re: Creates a Flag grob. (issue 4922042)

2011-08-22 Thread mtsolo
On 2011/08/22 12:52:05, hanwenn wrote: On Mon, Aug 22, 2011 at 7:20 AM, Mike Solomon wrote: > http://codereview.appspot.com/4922042/diff/1/scm/define-grob-properties.scm#newcode276 > scm/define-grob-properties.scm:276: (flag-style ,symbol? "A symbol > determining wh

Re: Creates a Flag grob. (issue 4922042)

2011-08-22 Thread Han-Wen Nienhuys
On Mon, Aug 22, 2011 at 7:20 AM, Mike Solomon wrote: > http://codereview.appspot.com/4922042/diff/1/scm/define-grob-properties.scm#newcode276 > scm/define-grob-properties.scm:276: (flag-style ,symbol? "A symbol > determining what style of flag > rename to style? Unfortunately, then we don't have

Re: Creates a Flag grob. (issue 4922042)

2011-08-22 Thread Mike Solomon
On Aug 22, 2011, at 12:06 PM, reinhold.kainho...@gmail.com wrote: > > http://codereview.appspot.com/4922042/diff/1/input/regression/color.ly > File input/regression/color.ly (right): > > http://codereview.appspot.com/4922042/diff/1/input/regression/color.ly#newcode24 > input/regression/color.ly:

Re: Creates a Flag grob. (issue 4922042)

2011-08-22 Thread reinhold . kainhofer
http://codereview.appspot.com/4922042/diff/1/input/regression/color.ly File input/regression/color.ly (right): http://codereview.appspot.com/4922042/diff/1/input/regression/color.ly#newcode24 input/regression/color.ly:24: \override Flag #'color = #blue Why don't you choose a different color to c

Re: Creates a Flag grob. (issue 4922042)

2011-08-22 Thread Reinhold Kainhofer
Am Monday, 22. August 2011, 08:16:47 schrieb mts...@gmail.com: > I'm a fan of this. git blame already shows who did what (that said, I > was git blaming the other day and a lot of things show up as Graham > Percival because of the great indenting push of 2011 - is there a way to > see multiple lay

Re: Creates a Flag grob. (issue 4922042)

2011-08-21 Thread mtsolo
On 2011/08/22 01:56:23, hanwenn wrote: quick remarks - Why are the flags called "maybe"flags in the engraver? Because we don't know if they are for-real flags until auto beaming has finished doing its thing (and all of the flags with beams are killed). I can change it to flags_ or flags_to_m

Re: Creates a Flag grob. (issue 4922042)

2011-08-21 Thread Han-Wen Nienhuys
quick remarks - Why are the flags called "maybe"flags in the engraver? - Currently, the stem already does width/2 X-offset, can't you piggyback on that? - You're copying me and jan's name in the header. If anythingn, you should probably put your own. (we could consider just using "The lilypond au