Daniel Lezcano wrote:
>
> On 01/10/2013 11:33 PM, amit daniel kachhap wrote:
> > On Thu, Jan 10, 2013 at 1:32 PM, Daniel Lezcano
> wrote:
> >> On 01/10/2013 09:07 PM, amit daniel kachhap wrote:
> >>> Hi Daniel,
> >>
> >> Hi Amit Daniel,
> >>
> >>> This hotplug noifiers looks fine. I suppose it sh
Brown
Thanks for testing, applied this series.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman
int ret;
>
> - memcpy(s3c64xx_cpuidle_driver.states, s3c64xx_cpuidle_set,
> -sizeof(s3c64xx_cpuidle_set));
> cpuidle_register_driver(&s3c64xx_cpuidle_driver);
>
> ret = cpuidle_register_device(&s3c64xx_cpuidle_device);
> --
> 1.7.5.4
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
e.
>
Basically, looks ok to me.
> I don't have this board, I was not able to test these patches.
>
Mark, could you please check this patches on your board?
Now, my smdk6410 has some problem to test this :(
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solut
?
you might want to include the maintainer
Kukjin Kim
and the samsung list
linux-samsung-...@vger.kernel.org
into your recipients
Also the original author (me).
Oh, ok. I thought I did it, sorry.
Heiko, thanks :-)
Daniel, could you please re-submit this series with adding me and
Daniel Lezcano wrote:
>
> On 05/09/2012 01:53 PM, Kukjin Kim wrote:
> > amit kachhap wrote:
> >>
> >> Hi Mr Kukjin,
> >>
> >> Any comment or update about this patch?
> >>
> > I'm not sure we don't need to check the idle_ti
amit kachhap wrote:
>
> Hi Mr Kukjin,
>
> Any comment or update about this patch?
>
I'm not sure we don't need to check the idle_time?
Others, looks ok to me.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electro
On 02/29/12 21:15, Kukjin Kim wrote:
Tushar Behera wrote:
[...]
Acked-by: Jingoo Han
OK, I will apply this with Sylwester's 'reviewed-by' I looked at
before.
Thanks. Do you want me rebase this patch on your latest for-next and
resend?
Thanks but I can do it.
BTW,
Tushar Behera wrote:
>
> Hi Kukjin,
>
Tushar, please don't top-post.
> On 03/01/2012 09:36 AM, Kukjin Kim wrote:
> > Jingoo Han wrote:
> >>
> >> Hi Tushar,
> >>
> >
> > (please don't top-post)
> >
> >>> -Or
; Acked-by: Jingoo Han
>
OK, I will apply this with Sylwester's 'reviewed-by' I looked at before.
BTW, Tushar, what's the [1/3] and [3/3] in this series? If they are still
needed now, could you please re-send? Maybe I missed.
Thanks.
Best regards,
Kgene.
--
K
Amit Kachhap wrote:
>
> Hi kukjin Kim,
>
Hi,
> I was on travel for elc and linaro conferences so little late for
> replying. Thanks for testing these patches.
> I just submitted the V6 series of the cpuidle patchset. I rebased it
> against the 3.3-rc4 kernel version.
Amit Kachhap wrote:
>
> Hi Amit Kucheria,
>
Hi all,
(Cc'ed Jaecheol Lee and Jongpill Lee)
> I have asked the samsung maintainer(Kukjin Kim) to queue this patch set 1
> month back. But seems like it is not present.
>
If it works fine, then I'm apply this series.
B
stable now, do you think these these
> patches can merged in this 3.3 merge window? Kindly let me know your
> opinion.
>
This conflicts with local common.[ch] working for ARM restart. Please wait
until after the merge window for this patches.
Thanks.
Best regards,
Kgene.
--
Kukjin K
> + .vidcon1= VIDCON1_INV_HSYNC | VIDCON1_INV_VSYNC |
> + VIDCON1_INV_VCLK,
> .setup_gpio = exynos4_fimd0_gpio_setup_24bpp,
> };
>
> --
> 1.7.4.1
OK, will apply this.
And I will review 1/3 and 2/3 patches soon.
Thanks.
Best r
Sangwook Lee wrote:
>
> This patch enables Bluetooth support on ORIGEN board.
>
> Signed-off-by: Sangwook
Maybe should be 'Signed-off-by: Sangwook Lee '?
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsun
by: Jingoo Han
>
OK, will apply.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
> Thanks.
>
> Best regards,
> Jingoo Han
> > ---
> >
> > This patch are based Kukjin's for-next branch a
k", &clk_pdma1),
> + CLKDEV_INIT("dma-pl330.2", "apb_pclk", &clk_mdma1),
> };
>
> static int xtal_rate;
> --
> 1.7.4.1
Looks ok to me, will apply.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
I think, this patch can be sent to upstream via slave-dma tree and second one
via Samsung tree separately and you can add my and Boojin Kim's ack(actually,
she replied) on this when you apply.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Sams
anged, 1 insertions(+), 6 deletions(-)
>
> --
> 1.7.4.1
No, the clock can be different for each board even though current value is
same. So it should being at the each board file.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Elect
Sangwook Lee wrote:
>
> sdhci-s3c updates pm_caps from platform data for SDIO PM.
>
> Signed-off-by: Sangwook Lee
Acked-by: Kukjin Kim
Hi Chris,
Could you please pick this up in your tree for v3.3?
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Deve
+68,7 @@ enum clk_types {
> struct s3c_sdhci_platdata {
> unsigned intmax_width;
> unsigned inthost_caps;
> + unsigned intpm_caps;
> enum cd_types cd_type;
> enum clk_types clk_type;
>
> --
> 1.7.4.1
Hi Sangwook,
I thi
(2), S3C_GPIO_PULL_NONE);
> +}
> +
> static void s5p_tv_setup(void)
> {
> /* Direct HPD to HDMI chip */
> @@ -687,6 +717,8 @@ static void __init origen_machine_init(void)
> s5p_device_mfc.dev.parent = &exynos4_device_pd[PD_MFC].dev;
>
> samsung_bl_set(&origen_bl_g
Kukjin Kim wrote:
>
> Grant Likely wrote:
> >
> > On Mon, Oct 03, 2011 at 08:59:19AM +0530, Tushar Behera wrote:
> > > In drivers/gpio/gpio-samsung.c, there are certain structures
> > > and functions which are not getting used if the particular
> > >
report about it
Try make KALLSYMS_EXTRA_PASS=1 as a workaround
make: *** [vmlinux] Error 1
And it seems due to add condition around the 'static unsigned
s3c24xx_gpio_getcfg_abank()'.
I need to check it in detail and if any problems, let you know.
Best regards,
Kgene.
--
Kukjin Kim , Senior E
tatic inline void s3c_pm_saved_gpios(void)
> {
> /* nothing here yet */
> }
> +
> +#endif /* __ASM_ARCH_PM_CORE_H */
> --
> 1.7.4.1
OK, will apply.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
___
ons = ARRAY_SIZE(origen_gpio_keys_table),
> +};
> +
> +static struct platform_device origen_device_gpiokeys = {
> + .name = "gpio-keys",
> + .dev = {
> + .platform_data = &origen_gpio_keys_data,
> + },
> +};
> +
> static struct platform_devic
ing a verbatim EDID block.
> >
> > Would it be not better (and way more flexible) to do the same here,
> > now that ARM has device tree support?
> >
> Thanks for your suggestions.
>
> Currently work for enabling device tree support for EXYNOS4 based
> machine i
if (power)
ret = gpio_request_one(EXYNOS4_GPE3(4), GPIOF_OUT_INIT_HIGH,
"GPE3_4");
else
ret = gpio_request_one(EXYNOS4_GPE3(4), GPIOF_OUT_INIT_LOW,
"GPE3_4");
if (ret)
pr_err("failed to request gpio for LCD po
.refresh= 60,
We don't need to add '.refresh' here because its default value is 60.
> + },
> + .max_bpp= 32,
> + .default_bpp= 24,
> +};
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Develop
-
> exynos4/mach-smdk4212.c
> index 3479a93..8c41ae1 100644
> --- a/arch/arm/mach-exynos4/mach-smdk4212.c
> +++ b/arch/arm/mach-exynos4/mach-smdk4212.c
> @@ -284,7 +284,7 @@ static void __init smdk4212_machine_init(void)
>
> MACHINE_START(SMDK4212, "SMDK4212")
>
Please adding me in Cc for Samsung stuff...
> By the way, does anybody have L2C-310 errata list? Is double linefill
> actually safe to use in r3p0?
>
No. it is _not_ safe on EXYNOS4210.
Since L2C-310 ERRTA, current EXYNOS4210 cannot enable double linefill feature
and as Siarhei
Kukjin Kim wrote:
>
> Sachin Kamat wrote:
> >
> > Signed-off-by: Bhuvana Kakunoori
> > Signed-off-by: Pankaj Dubey
> > Signed-off-by: Sachin Kamat
> > ---
> > arch/arm/mach-exynos4/Kconfig |2 ++
> > arch/arm/mach-exynos4/mach
Tushar Behera wrote:
>
> On Wednesday 31 August 2011 06:31 AM, Kukjin Kim wrote:
> > Tushar Behera wrote:
> >>
> >> Platform data for SDHCI controller on ORIGEN board is missing the
> >> support for 8-bit bus width. The platform data is extended i
t; - clk_put(otg_clk);
> + clk_put(usbhost_clk);
> return err;
> }
>
> @@ -117,10 +162,18 @@ int s5p_usb_phy_exit(struct platform_device *pdev,
int
> type)
>
HOST_PHY_ENABLE,
> + writel(readl(S5P_USBHOST_PHY_CONTROL) &
> ~S5P_USBHOST_PHY_ENABLE,
> S5P_USBHOST_PHY_CONTROL);
>
> - clk_disable(otg_clk);
> - clk_put(otg_clk);
> -
> - return 0;
> -}
> -
> -int s5p_usb_phy_i
gt; static void __init origen_map_io(void)
> --
> 1.7.4.1
Hi Sachin,
Hmm, do you _really_ use this feature on ORIGEN board now?
As I know, the EXYNOS System MMU driver will be changed like a form of omap
and msm soon maybe it's within 1 or 2 weeks. So if this is not required on
ORIGEN
gt; --
> 1.7.4.1
Hi Tushar,
I wonder the bus width of SDHCI controller can be changed manually on ORIGEN
like SMDK board.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
_platdata(&origen_hsmmc2_pdata);
> platform_add_devices(origen_devices, ARRAY_SIZE(origen_devices));
> +
> + samsung_bl_set(&origen_bl_gpio_info, &origen_bl_data);
> }
>
> MACHINE_START(ORIGEN, "ORIGEN")
> --
> 1.7.4.1
OK, will apply.
Thanks.
Bes
en_hsmmc2_pdata
> __initdata = {
> };
>
> static struct platform_device *origen_devices[] __initdata = {
> + &s5p_device_fimc0,
> + &s5p_device_fimc1,
> + &s5p_device_fimc2,
> + &s5p_device_fimc3,
> &s3c_device_hsmmc2,
> &s3c_dev
= EXYNOS4_GPK2(2),
> - .ext_cd_gpio_invert = 1,
> + .cd_type= S3C_SDHCI_CD_INTERNAL,
> .clk_type = S3C_SDHCI_CLK_DIV_EXTERNAL,
> };
>
> --
> 1.7.4.1
OK, will apply.
Thanks.
Best regards
> platform_add_devices(origen_devices, ARRAY_SIZE(origen_devices));
> }
>
> --
> 1.7.4.1
OK, will apply.
If you don't mind, I will add comments the reason of the ordering when I
apply this.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
_set_platdata(&origen_hsmmc2_pdata);
> +
> + origen_ehci_init();
> + clk_xusbxti.rate = 2400;
> +
> platform_add_devices(origen_devices, ARRAY_SIZE(origen_devices));
> }
>
> --
> 1.7.4.1
OK, will apply with re-ordering as per my comments.
Tha
0_devices));
> s5p_device_mfc.dev.parent = &exynos4_device_pd[PD_MFC].dev;
> }
> --
> 1.7.4.1
(Cc'ed Jingoo Han)
Well, this is same with Jingoo's patch on smdkc210 which has been submitted
at 12th Aug.
I requested to him to re-work this on smdkv310 on his patch ju
+270,5 @@ MACHINE_START(SMDKV310, "SMDKV310")
> .map_io = smdkv310_map_io,
> .init_machine = smdkv310_machine_init,
> .timer = &exynos4_timer,
> + .reserve= &smdkv310_reserve,
> MACHINE_END
> --
> 1.7.4.1
OK, applied.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
s5p_init_io(NULL, 0, S5P_VA_CHIPID);
> + s3c24xx_init_clocks(2400);
> + s3c24xx_init_uarts(origen_uartcfgs, ARRAY_SIZE(origen_uartcfgs));
> +}
> +
> +static void __init origen_machine_init(void)
> +{
> + s3c_sdhci2_set_platdata(&origen_hsmmc2_pdata);
> + platf
eeds to detect interrupt which can be a wakeup source via GIC before
calling WFI.
Seems there is no problem but I think that can be a hole during very short
time...
So is it needed to disable GIC after saving context?
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution D
later.
Tushar, you don't need to re-submit this for removing white space :)
But as you know, please make sure that your patch has no problem with
checkpatch.pl before submitting.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Sams
DKV310 can support it by jumper setting.
I mean it can be modified according to each board's situation for mass
production and we don't need this for SMDK in mainline now.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronic
Thomas Abraham wrote:
>
> Fix incorrect conditional execution of ldr instructions in
> addruart macro.
>
Oops :(
Ok, will apply:)
As a note, I found same patch with this in your previous patches.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Deve
Amit Daniel Kachhap wrote:
>
> Hi Mr Kim,
>
> Thanks for your comments. Please see the inline comments below.
>
Hi Amit,
I didn't get your updated patch, but it was small things.
So I applied this in my tree for this merge window.
Thanks.
Best regards,
Kgene.
--
Kukjin K
e/plat/clock.h
> index 0fbcd0e..9a82b88 100644
> --- a/arch/arm/plat-samsung/include/plat/clock.h
> +++ b/arch/arm/plat-samsung/include/plat/clock.h
> @@ -47,6 +47,9 @@ struct clk {
>
> struct clk_ops *ops;
> int (*enable)(struct clk *, int enable);
> +#if defined(CONFIG_PM_DEBUG) && defined(CONFIG_DEBUG_FS)
> + struct dentry *dent; /* For visible tree hierarchy */
> +#endif
> };
>
> /* other clocks which may be registered by board support */
> --
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
BUG_FS) */
> +
> diff --git a/arch/arm/plat-samsung/include/plat/clock.h b/arch/arm/plat-
> samsung/include/plat/clock.h
> index 0fbcd0e..f6180ab 100644
> --- a/arch/arm/plat-samsung/include/plat/clock.h
> +++ b/arch/arm/plat-samsung/include/plat/clock.h
> @@ -47,6 +47,9 @@ struct clk
52 matches
Mail list logo
