Re: [PATCH 1/5] mmc: msm: consolidate ifdefs for BUSCLK_PWRSAVE

2010-12-20 Thread Daniel Walker
On Mon, 2010-12-20 at 15:42 -0800, David Brown wrote: > On Mon, Dec 20, 2010 at 03:39:10PM -0800, Daniel Walker wrote: > > > I this feature even used? It looks like some kind debug feature. > > > > Yeah it's used, it's default on.. > > What I meant was "is there any reason to be able to turn thi

Re: [PATCH 1/5] mmc: msm: consolidate ifdefs for BUSCLK_PWRSAVE

2010-12-20 Thread David Brown
On Mon, Dec 20, 2010 at 03:39:10PM -0800, Daniel Walker wrote: > > I this feature even used? It looks like some kind debug feature. > > Yeah it's used, it's default on.. What I meant was "is there any reason to be able to turn this off." It looks like something that would be used during developm

Re: [PATCH 1/5] mmc: msm: consolidate ifdefs for BUSCLK_PWRSAVE

2010-12-20 Thread Daniel Walker
On Mon, 2010-12-20 at 15:35 -0800, David Brown wrote: > On Mon, Dec 20, 2010 at 03:16:47PM -0800, Daniel Walker wrote: > > > It's cleaner to have ifdef's consolidated in one specific > > area. This change pulls adds one ifdef which will swap > > out of the function with a stub function if the ifde

Re: [PATCH 1/5] mmc: msm: consolidate ifdefs for BUSCLK_PWRSAVE

2010-12-20 Thread David Brown
On Mon, Dec 20, 2010 at 03:16:47PM -0800, Daniel Walker wrote: > It's cleaner to have ifdef's consolidated in one specific > area. This change pulls adds one ifdef which will swap > out of the function with a stub function if the ifdef is > false. It also changes the define from #if checks to #if

[PATCH 1/5] mmc: msm: consolidate ifdefs for BUSCLK_PWRSAVE

2010-12-20 Thread Daniel Walker
It's cleaner to have ifdef's consolidated in one specific area. This change pulls adds one ifdef which will swap out of the function with a stub function if the ifdef is false. Signed-off-by: Daniel Walker --- drivers/mmc/host/msm_sdcc.c | 24 +--- 1 files changed, 13 inser