Re: [PATCH 00/15 v2] xfstests: new btrfs stress test cases

2014-09-08 Thread Dave Chinner
olume-remount > 068: replace-scrub > 069: replace-defrag > 070: replace-remount > 071: scrub-defrag > 072: scrub-remount > 073: defrag-remount Can I get some reviews for btrfs people for this series, please? Cheers, Dave. -- Dave Chinner da

Re: ext4 vs btrfs performance on SSD array

2014-09-01 Thread Dave Chinner
xt4 and XFS are doing is doing 128k IOs because that's the default block device readahead size. 'blockdev --setra 1024 /dev/sdd' before mounting the filesystem will probably fix it. -Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line &quo

Re: [PATCH 00/15] xfstests: new btrfs stress test cases

2014-08-21 Thread Dave Chinner
erent combo in 3.17 and yet another in 3.18. But from a reporting point of view, all we see is that a single test failed, rather than being able to see that there were three separate problems and that btrfs_op_scrub() was the common factor in all three failures. It's trivial to write this as

Re: [PATCH 01/15] btrfs: new test to run btrfs balance and subvolume test simultaneously

2014-08-21 Thread Dave Chinner
On Thu, Aug 21, 2014 at 05:15:01PM +0800, Qu Wenruo wrote: > > Original Message > Subject: Re: [PATCH 01/15] btrfs: new test to run btrfs balance and > subvolume test simultaneously > From: Dave Chinner > To: Qu Wenruo > Date: 2014年08月21日 17:01 > >On

Re: [PATCH 01/15] btrfs: new test to run btrfs balance and subvolume test simultaneously

2014-08-21 Thread Dave Chinner
+"-m raid6 -d raid6" > >+) > I wonder should we add the mkfs options there. > Since xfstests already use environment MKFS_OPTIONS to do mkfs, > if really need to test all mkfs options, IMO it is better to change > MKFS_OPTIONS on each test round. Hmmm - I you didn't

Re: [PATCH] xfstest: add tests/btrfs/059 to test seed operations

2014-08-20 Thread Dave Chinner
t into 5 tests using shared infrastructure. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] common: get fs type again using device canonical name in _fs_type

2014-08-01 Thread Dave Chinner
On Fri, Aug 01, 2014 at 01:02:58PM +0800, Eryu Guan wrote: > On Fri, Aug 01, 2014 at 02:49:10PM +1000, Dave Chinner wrote: > > On Fri, Aug 01, 2014 at 12:02:41PM +0800, Eryu Guan wrote: > > > On Fri, Aug 01, 2014 at 10:21:59AM +1000, Dave Chinner wrote: > > > > On T

Re: [PATCH v2] common: get fs type again using device canonical name in _fs_type

2014-07-31 Thread Dave Chinner
On Fri, Aug 01, 2014 at 12:02:41PM +0800, Eryu Guan wrote: > On Fri, Aug 01, 2014 at 10:21:59AM +1000, Dave Chinner wrote: > > On Thu, Jul 31, 2014 at 06:52:37PM +0800, Eryu Guan wrote: > > > When testing with lvm, a previous btrfsck run could change df output > &g

Re: [PATCH] Remove certain calls for releasing page cache

2014-07-30 Thread Dave Airlie
On 31 July 2014 12:05, Nick Krause wrote: > On Wed, Jul 30, 2014 at 7:30 PM, Dave Airlie wrote: >>> This patch removes the lines for releasing the page cache in certain >>> files as this may aid in perfomance with writes in the compression >>> rountines of btrfs. P

Re: [PATCH] Remove certain calls for releasing page cache

2014-07-30 Thread Dave Airlie
this, and keep on trucking just like you ignored the other messages from Stephen before. But if you want to work on the kernel, this isn't the way to do it, and nobody will ever take a patch from you seriously if you continue in this fashion. Dave. -- To unsubscribe from this list: send the li

Re: btrfs kernel workqueues performance regression

2014-07-22 Thread Dave Chinner
[k] queue_write_lock_slowpath + 1.91% [kernel] [k] _raw_spin_unlock_irq + 0.85% [kernel] [k] __do_softirq + 0.45% [kernel] [k] do_raw_read_lock + 0.43% [kernel] [k] do_raw_read_unlock + 0.42% [kernel] [k] btrfs_search_slot + 0.40% [kernel] [k] do_raw_spin_lock + 0.35% [k

Re: [PATCH] xfstests/btrfs: add test for quota groups and drop snapshot

2014-07-10 Thread Dave Chinner
On Thu, Jul 10, 2014 at 10:36:14AM -0700, Mark Fasheh wrote: > Hey Dave, thanks for the patch review! Pretty much all of what you wrote > sounds good to me, there's just one or two items I wanted to clarify - those > comments are inline. Thanks again, > > On Thu, Jul 10, 2014

Re: [PATCH] xfstests/btrfs: add test for quota groups and drop snapshot

2014-07-09 Thread Dave Chinner
bvolume '/xfstest2/snap1' The scratch mountpoint output is what requires filtering - it's different for everyone, and so needs to anonymised to SCRATCH_MNT > diff --git a/tests/btrfs/group b/tests/btrfs/group > index 2da7127..ebc38c5 100644 > --- a/tests/btrfs/group >

Re: [PATCH] generic/017: skip invalid block sizes for btrfs

2014-06-23 Thread Dave Chinner
options than fail due to incompatible configuration. It makes maintenance of the tests much easier because we don't have to declare and maintain the supported list of user options for every test. Either the test works for all configurations (i.e. whatever the user sets in MKFS/MOU

Re: [systemd-devel] Slow startup of systemd-journal on BTRFS

2014-06-18 Thread Dave Chinner
ng to invoke here, and a suggestion what we should do instead > to cover this usecase... fallocate() of 8MB should be more than sufficient for non-COW filesystems - 1MB would be enough to prevent performance degradation due to fragmentation in most cases. The current problems seem to be with the wa

Re: [PATCH v3] xfstests/btrfs: add qgroup rescan stress test

2014-06-18 Thread Dave Chinner
On Wed, Jun 18, 2014 at 04:36:22PM +0800, Wang Shilong wrote: > Hello Josef, > > The lastest Qgroup code still break this test sometimes. > > Ps: this test seems not merging into xfstests. Then repost it to fste...@vger.kernel.org. Sometimes patches get missed... Cheers,

Re: R: Re: Slow startup of systemd-journal on BTRFS

2014-06-12 Thread Dave Chinner
one was complaining about... > Why? Because btrfs data blocks are 4 KiB. With COW, the effect for > either 4 byte or 8 MiB file allocations is going to end up being the > same, forcing (repeated until full) rewrite of each 4 KiB block into its > own extent. And that's now a

Re: Slow startup of systemd-journal on BTRFS

2014-06-11 Thread Dave Chinner
On Thu, Jun 12, 2014 at 11:21:04AM +1000, Dave Chinner wrote: > On Wed, Jun 11, 2014 at 11:28:54PM +0200, Goffredo Baroncelli wrote: > > Hi all, > > > > I would like to share a my experience about a slowness of systemd when used > > on BTRFS. > > > >

Re: Slow startup of systemd-journal on BTRFS

2014-06-11 Thread Dave Chinner
ss.sgi.com/archives/xfs/2014-03/msg00322.html IIRC, the systemd developers consider this a filesystem problem and so refused to change the systemd code to be nice to the filesystem allocators, even though they don't actually need to use fallocate... Cheers, Dave. -- Dave Chinne

Re: [PATCH v2] xfstests: add test for btrfs clone + fsync durability

2014-06-09 Thread Dave Chinner
-c "fsync" \ > + -c "pwrite -S 0x02 -b 8192 8192 8192" \ > + -c "fsync" \ > + -c "pwrite -S 0x04 -b 8192 24576 8192" \ > + -c "fsync" \ > +

Re: [PATCH v5] xfstests: add test for btrfs cloning with file holes

2014-06-09 Thread Dave Chinner
erbose and hard to read. This: # Create a file with 4 extents and 1 hole, all with a size of 8Kb each. $XFS_IO_PROG -fs \ -c "pwrite -S 0x01 -b 8192 0 8192" \ -c "pwrite -S 0x02 -b 8192 8192 8192" \ -c "pwrite -S 0x04 -b 8192 24576 8192" \ -c "pwrite -S 0x05 -b 8192 32768 8192" \ $SCRATCH_MNT/foo | _filter_xfs_io # Clone destination file, 1 extent of 96kb. $XFS_IO_PROG -fs -c "pwrite -S 0xff -b 98304 0 98304" \ $SCRATCH_MNT/bar | _filter_xfs_io is much more compact and far easier to read. It's also the same style as many of the other tests use for compound operations like this. Other than that the test look sgood. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] btrfs: add regression test for remount with thread_pool resized

2014-06-09 Thread Dave Chinner
/btrfs/055.out > @@ -0,0 +1 @@ > +QA output created by 055 > diff --git a/tests/btrfs/group b/tests/btrfs/group > index b668485..2c10c5b 100644 > --- a/tests/btrfs/group > +++ b/tests/btrfs/group > @@ -57,3 +57,4 @@ > 052 auto quick > 053 auto quick > 054 auto quick > +055

Re: [RFC 00/32] making inode time stamps y2038 ready

2014-06-03 Thread Dave Chinner
me representation, and the kernel to be independent of the physical filesystem time encoding Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More ma

[ANNOUNCE] xfstests: master branch updated to 45d1fac

2014-05-26 Thread Dave Chinner
reate mode 100755 tests/generic/027 create mode 100644 tests/generic/027.out -- Dave Chinner da...@fromorbit.com signature.asc Description: Digital signature

Re: [ANNOUNCE] xfstests: new mailing list

2014-05-19 Thread Dave Chinner
On Mon, May 19, 2014 at 07:55:41AM -0700, Christoph Hellwig wrote: > On Sat, May 17, 2014 at 08:19:30AM +1000, Dave Chinner wrote: > > Renaming the test suite take a lot more work - .e.g renaming/moving > > source trees and a fixing all the documentation that points to it... &g

Re: [ANNOUNCE] xfstests: new mailing list

2014-05-16 Thread Dave Chinner
different from the project it is for is stupid. Either > rename the test suite, or use the same name for the mailing list. Renaming the test suite take a lot more work - .e.g renaming/moving source trees and a fixing all the documentation that points to it... So, small steps. Cheers, Dav

[ANNOUNCE] xfstests: new mailing list

2014-05-15 Thread Dave Chinner
ng so through marc.info), but that should be set up real soon. I'll still be listening in on the XFS list for xfstests patches, bug reports and questions, so don't worry if you forget this new list exists... :) Cheers, Dave. -- Dave Chinner da...@fromorbit.com signature.asc Descr

[ANNOUNCE] xfstests: master branch updated to 10fd79a

2014-05-12 Thread Dave Chinner
de 100755 tests/xfs/013 create mode 100644 tests/xfs/013.out -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] xfstests: fix flink test

2014-05-07 Thread Dave Chinner
e checks that result in the same error, why not just: - echo $testio | grep -q "not found" && \ + echo $testio | egrep -q 'not found|invalid option' && \ _notrun "xfs_io $command support is missing" Cheers, Dave. -- Dave Chinne

[ANNOUNCE] xfstests: master branch updated to ce0aa2b

2014-04-27 Thread Dave Chinner
next update. The new head of the master branch is commit: ce0aa2b common: Use _require_xfs_io_command() instead of helpers New Commits: Dave Chinner (6): [31a50c7] generic/204: tweak reserve pool size [ca93123] generic: cleanup space after test in TESTDIR [9d7807d] xfs: remove

Re: [PATCH] xfstests: btrfs, test send's ability to punch holes and prealloc extents

2014-04-16 Thread Dave Chinner
On Wed, Apr 16, 2014 at 03:39:18PM +0100, Filipe David Manana wrote: > On Wed, Apr 16, 2014 at 1:23 AM, Dave Chinner wrote: > > On Tue, Apr 15, 2014 at 05:43:21PM +0100, Filipe David Borba Manana wrote: > >> This test verifies that after an incremental btrfs send the replica

Re: [PATCH] xfstests: btrfs, add test for btrfs properties

2014-04-15 Thread Dave Chinner
s=$RESULT_DIR/$seq > +echo "QA output created by $seq" > + > +here="`pwd`" > +tmp=/tmp/$$ > + > +status=1 # failure is the default! > +trap "_cleanup; exit \$status" 0 1 2 3 15 > + > +send_files_dir=$TEST_DIR/btrfs-test-$seq You should define t

Re: [PATCH] xfstests: btrfs, test send's ability to punch holes and prealloc extents

2014-04-15 Thread Dave Chinner
ested here in prealloc extents that lie beyond > +# the file's size. > +$XFS_IO_PROG -r -c "fiemap -l" $SCRATCH_MNT/mysnap2/foo | _filter_scratch Same here. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[ANNOUNCE] xfstests: master branch updated to 8874560

2014-04-13 Thread Dave Chinner
On Mon, Apr 14, 2014 at 10:49:38AM +1000, Dave Chinner wrote: > Hi folks, > > The xfstests repository at git://oss.sgi.com/xfs/cmds/xfstests has > just been updated. Patches often get missed, so please check if your > outstanding patches were in this update. If they have not been i

[ANNOUNCE] xfstests: master branch updated to 249cc51

2014-04-13 Thread Dave Chinner
00755 tests/generic/025 create mode 100644 tests/generic/025.out mode change 100644 => 100755 tests/generic/311 -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More major

[ANNOUNCE] xfstests: master branch updated to 610e44c

2014-04-08 Thread Dave Chinner
(+), 16 deletions(-) -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [ANNOUNCE] xfstests: updated to cf1ed54

2014-04-07 Thread Dave Chinner
On Fri, Apr 04, 2014 at 02:07:16PM +0100, Filipe David Manana wrote: > On Fri, Apr 4, 2014 at 10:03 AM, Dave Chinner wrote: > > Hi folks, > > > > The xfstests repository at git://oss.sgi.com/xfs/cmds/xfstests has > > just been updated. Patches often get miss

Re: [ANNOUNCE] xfstests: updated to cf1ed54

2014-04-04 Thread Dave Chinner
On Fri, Apr 04, 2014 at 02:07:16PM +0100, Filipe David Manana wrote: > On Fri, Apr 4, 2014 at 10:03 AM, Dave Chinner wrote: > > Hi folks, > > > > The xfstests repository at git://oss.sgi.com/xfs/cmds/xfstests has > > just been updated. Patches often get miss

[ANNOUNCE] xfstests: updated to cf1ed54

2014-04-04 Thread Dave Chinner
} (97%) rename tests/{shared/002 => generic/022} (93%) mode change 100644 => 100755 rename tests/{shared/002.out => generic/022.out} (97%) delete mode 100644 tests/shared/005.out create mode 100755 tests/shared/006 create mode 100644 tests/shared/006.out create mode 100755 tests/xfs

[ANNOUNCE] xfstests: master branch updated to 3948694

2014-03-12 Thread Dave Chinner
next update. I know I skipped a couple of posted tests because they hadn't obviously been reviewed and I didn't know what the status of them was, so reposts (and reviews!) would be appreciated. The new head of the master branch is commit: 3948694 xfs/300: fix golden output New Comm

Re: [PATCH v2 3/3] xfstests/btrfs: add stress test for btrfs quota operations

2014-03-12 Thread Dave Chinner
scratch_mkfs_sized $MKFS_SIZE +run_check _scratch_mount + > > +_quota_enabled_background & +run_check $FSSTRESS_PROG -d > > $SCRATCH_MNT -w -p 5 -n 1000 \ +$FSSTRESS_AVOID + +run_check > > _scratch_unmount +_check_scratch_fs + > > You should probably be doing some

Re: BUG: >16TB Btrfs volumes are mountable on 32 bit kernels

2014-02-27 Thread Dave Chinner
mp;m=6eUt5RgBggFh930oFrH19iR4z%2BFVzT%2F0%2F4dYPt3g48U%3D%0A&s=5ac126734d7fa1d3238ab09a2ddc021a8dcc8fff7b022560a4d068be2de37c00 > > > > > > > > I think this is due to the kernel page cache address space being > > 16TB limited on 32-bit kernels, as mentioned by D

Re: Help with space

2014-02-27 Thread Dave Chinner
On Thu, Feb 27, 2014 at 05:27:48PM -0700, Chris Murphy wrote: > > On Feb 27, 2014, at 5:12 PM, Dave Chinner > wrote: > > > On Thu, Feb 27, 2014 at 02:11:19PM -0700, Chris Murphy wrote: > >> > >> On Feb 27, 2014, at 1:49 PM, otakujunct...@gmail.com wrote: &g

Re: Help with space

2014-02-27 Thread Dave Chinner
INT_MAX || sbp->sb_rblocks > INT_MAX) { 205 cmn_err(CE_WARN, 206 "XFS: File systems greater than 1TB not supported on this system.\n"); 207 return XFS_ERROR(E2BIG); 208 } 209 #endif (http://oss.sgi.com/cgi-bin/gitweb.cgi?p=archive/xfs-import.git;a=blob;f=f

Re: [PATCH v2] xfstests: add test for btrfs-progs restore feature

2014-02-25 Thread Dave Chinner
On Tue, Feb 25, 2014 at 10:34:07PM +, Filipe David Manana wrote: > On Tue, Feb 25, 2014 at 10:11 PM, Dave Chinner wrote: > > On Tue, Feb 25, 2014 at 09:02:43PM +, Filipe David Manana wrote: > >> On Tue, Feb 25, 2014 at 7:54 PM, Dave Chinner wrote: > >> >

Re: [PATCH v2] xfstests: add test for btrfs-progs restore feature

2014-02-25 Thread Dave Chinner
On Tue, Feb 25, 2014 at 09:02:43PM +, Filipe David Manana wrote: > On Tue, Feb 25, 2014 at 7:54 PM, Dave Chinner wrote: > > On Tue, Feb 25, 2014 at 06:44:08PM +, Filipe David Borba Manana wrote: > >> This is a regression test to verify that the restore feature of btrfs-

Re: [PATCH v2] xfstests: add test for btrfs-progs restore feature

2014-02-25 Thread Dave Chinner
f filesystem at all. It's also wrong to use $tmp like this > +} > + > +mkdir $tmp > +echo "Testing restore of file compressed with lzo" > +test_btrfs_restore "lzo" > +echo "Testing restore of file compressed with zlib" > +test_btrfs_r

Re: [PATCH] xfstests: add function _require_fssum()

2014-02-24 Thread Dave Chinner
On Mon, Feb 24, 2014 at 11:08:27PM +, Filipe David Manana wrote: > On Mon, Feb 24, 2014 at 10:22 PM, Dave Chinner wrote: > > On Mon, Feb 24, 2014 at 01:22:36PM +, Filipe David Manana wrote: > >> On Mon, Feb 24, 2014 at 12:23 PM, Dave Chinner wrote: > >> >&g

Re: [PATCH] xfstests: add function _require_fssum()

2014-02-24 Thread Dave Chinner
On Mon, Feb 24, 2014 at 01:22:36PM +, Filipe David Manana wrote: > On Mon, Feb 24, 2014 at 12:23 PM, Dave Chinner wrote: > > On Mon, Feb 24, 2014 at 11:56:23AM +, Filipe David Borba Manana wrote: > >> To avoid repeating detection of fssum presence in many btrfs tests, as

Re: [PATCH] xfstests: add function _require_fssum()

2014-02-24 Thread Dave Chinner
On Mon, Feb 24, 2014 at 11:56:23AM +, Filipe David Borba Manana wrote: > To avoid repeating detection of fssum presence in many btrfs tests, as > suggested by Dave Chinner. > > Signed-off-by: Filipe David Borba Manana > --- > common/rc |7 +++ > t

Re: [PATCH] xfstests: add test btrfs/042 for btrfs incremental send

2014-02-23 Thread Dave Chinner
H_MNT/mysnap1 2>> $seqres.full > + > +_run_btrfs_util_prog receive $SCRATCH_MNT -f $tmp/2.snap > +run_check $FSSUM_PROG -r $tmp/2.fssum $SCRATCH_MNT/mysnap2 2>> $seqres.full And the redirection I'm happy to see you write your tests consistently, Filipe :) Cheers, Dav

Re: [PATCH] xfstests: add test for btrfs send issuing premature rmdir operations

2014-02-23 Thread Dave Chinner
rog receive $SCRATCH_MNT -f $tmp/1.snap > +run_check $FSSUM_PROG -r $tmp/1.fssum $SCRATCH_MNT/mysnap1 2>> $seqres.full > + > +_run_btrfs_util_prog receive $SCRATCH_MNT -f $tmp/2.snap > +run_check $FSSUM_PROG -r $tmp/2.fssum $SCRATCH_MNT/mysnap2 2>> $seqres.full Hasn't ru

Re: Hard drive hangs after excessive I/O

2014-02-21 Thread Dave
he VMs, my machine is still in this state that causes IO to periodically hang. -- -=[dave]=- Entropy isn't what it used to be. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Hard drive hangs after excessive I/O

2014-02-21 Thread Dave
begin the concurrent installations again. This time I see the IO spurts that I described in my first email; that is, drive thrashes for a while, then hangs for a couple minutes... repeat until host reboot. -- -=[dave]=- Entropy isn't what it used to be. -- To unsubscribe from this list: s

Hard drive hangs after excessive I/O

2014-02-21 Thread Dave
h: touch winxp.img chattr +C winxp.img fallocate -l20G winxp.img I'm actually quite pleased with VM performance on top of btrfs (until the above problem starts occurring). -- -=[dave]=- Entropy isn't what it used to be. -- To unsubscribe from this list: send the line "unsubscribe linu

Re: [PATCH 1/3] xfstests/btrfs: add qgroup rescan stress test

2014-02-17 Thread Dave Chinner
/null > + > +run_check $BTRFS_UTIL_PROG quota enable $SCRATCH_MNT > +run_check $BTRFS_UTIL_PROG quota rescan -w $SCRATCH_MNT "run_check considered harmful." http://oss.sgi.com/archives/xfs/2014-02/msg00482.html Once I've committed Filipe's run_btrfs_util_prog, can you update this series to remove all the unnecessary run_check calls and repost? Thanks! Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] xfstests: test for atime-related mount options

2014-02-17 Thread Dave Chinner
s a _require_scratch call in there, so it's all good. ;) Thanks Koen! > Thanks! > > Reviewed-by: Eric Sandeen And thanks for the reivew, Eric ;) Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the

Re: [PATCH v3] xfstests: Btrfs: add test for large metadata blocks

2014-02-16 Thread Dave Chinner
On Tue, Feb 11, 2014 at 08:01:08PM +0100, Koen De Wit wrote: > On 02/10/2014 11:04 PM, Dave Chinner wrote: > >On Mon, Feb 10, 2014 at 10:39:22PM +0100, Koen De Wit wrote: > >>+ > >>+_test_illegal_leafsize() { > >>+_scratch_mkfs -l $1 >>$seqres.fu

Re: [PATCH] xfstests: add regression test for btrfs incremental send

2014-02-16 Thread Dave Chinner
On Mon, Feb 17, 2014 at 01:36:02AM +, Filipe David Manana wrote: > On Monday, February 17, 2014, Dave Chinner wrote: > > > On Mon, Feb 17, 2014 at 12:20:38AM +, Filipe David Borba Manana wrote: > > > Test for a btrfs incremental send issue where we end up sending a &

Re: [PATCH v3] xfstests: add regression test for btrfs incremental send

2014-02-16 Thread Dave Chinner
x27; > hole punch implementation leaving hole file extent items when we punch > beyond the file's current size. > V3: Filter xfs_io output and make less use of the run_check function, as > suggested by Dave Chinner. Awesome. Thanks for the quick turn around

Re: [PATCH v2] xfstests: add regression test for btrfs incremental send

2014-02-16 Thread Dave Chinner
On Sun, Feb 16, 2014 at 11:43:17PM +, Filipe David Manana wrote: > On Sun, Feb 16, 2014 at 11:08 PM, Dave Chinner wrote: > > On Sat, Feb 15, 2014 at 03:36:13PM +, Filipe David Borba Manana wrote: > >> Test for a btrfs incremental send issue where we end up sending a >

Re: [PATCH v2] xfstests: add regression test for btrfs incremental send

2014-02-16 Thread Dave Chinner
1" \ > + $SCRATCH_MNT/foo I'm getting to the point where I'm starting to consider "run_check" as being harmful I know you are trying to work around the fact that the btrfs progs commands have inconsistent output and so are difficult to match. However, given that

Re: [PATCH] xfstests: test for atime-related mount options

2014-02-15 Thread Dave Chinner
On Fri, Feb 14, 2014 at 09:02:08PM -0600, Eric Sandeen wrote: > On 2/14/14, 7:39 PM, Dave Chinner wrote: > > On Fri, Feb 14, 2014 at 05:48:59PM -0600, Eric Sandeen wrote: > >> On 2/14/14, 4:24 PM, Dave Chinner wrote: > >>> On Fri, Feb 14, 2014 at 10:41:16AM -0600, E

Re: [PATCH] xfstests: test for atime-related mount options

2014-02-14 Thread Dave Chinner
On Fri, Feb 14, 2014 at 05:48:59PM -0600, Eric Sandeen wrote: > On 2/14/14, 4:24 PM, Dave Chinner wrote: > > On Fri, Feb 14, 2014 at 10:41:16AM -0600, Eric Sandeen wrote: > >> On 2/14/14, 10:39 AM, David Sterba wrote: > >>> On Thu, Feb 13, 2014 at 10:42:55AM -0600, Er

Re: [PATCH] xfstests: test for atime-related mount options

2014-02-14 Thread Dave Chinner
have their own engineers and QE to make sure the upstream code works correctly when they backport it. xfstests is no different. ;) IOWs, if someone wants to run a modern test suite on a 7 year old distro, then they need to make sure that the test suite does the right thing for their distro. We'

Re: [3.14-rc1] BUG: soft lockup - CPU#1 stuck for 22s with 255 GiB BTRFS with only 6 GiB free

2014-02-11 Thread Dave
g code? I had two separate machines that exhibited similar symptoms. Chris's for-linus branch has a fix for this which solved my problems: https://git.kernel.org/cgit/linux/kernel/git/mason/linux-btrfs.git/commit/?h=for-linus&id=27a377db745ed4d11b3b9b340756857cb8dde07f -- -=[dave]=- Entrop

Re: [PATCH v3] xfstests: Btrfs: add test for large metadata blocks

2014-02-10 Thread Dave Chinner
1 >>$seqres.full 2>&1 > +[ $? -ne 0 ] || _fail "'$1' is an illegal value for the" \ > +"leafsize option, mkfs should have failed." > +} You just re-implemented run_check Cheers, Dave. -- Dave Chinner da...@fromorb

Re: [PATCH] xfstests: btrfs/004: fix to make test really work

2014-02-10 Thread Dave Chinner
locksize, "#", '\ > '$length * $blocksize, "#", $logical * $blocksize, " "' Oh, boy, who allowed that mess to pass review? Please format this in a readable manner while you are changing it. FILEFRAG_FILTER=' if (/blocks of (\d+) bytes/

Re: [PATCH] xfstests: Btrfs: add test for large metadata blocks

2014-02-09 Thread Dave Chinner
On Sat, Feb 08, 2014 at 09:30:51AM +0100, Koen De Wit wrote: > On 02/07/2014 11:49 PM, Dave Chinner wrote: > >On Fri, Feb 07, 2014 at 06:14:45PM +0100, Koen De Wit wrote: > > echo -n "$xattr_value" | md5sum > > ${ATTR_PROG} -Lq -s attr_$char -V $xattr_value

Re: [PATCH] xfstests: Btrfs: add test for large metadata blocks

2014-02-07 Thread Dave Chinner
IOWs, the ATTR_PROG failure message should be in the golden output file and you don't have to do anything else to detect a pass/fail condition. > +_scratch_unmount > + > +# Some illegal leafsizes > + > +_scratch_mkfs -l 0 2>> $seqres.full > +echo $? Same again - you

Re: [PATCH v3] Btrfs: add regression test for running snapshot and send concurrently

2014-02-06 Thread Dave Chinner
On Fri, Feb 07, 2014 at 12:18:31PM +0800, Wang Shilong wrote: > > Hi Dave, > > > On Fri, Feb 07, 2014 at 12:10:08AM +0800, Wang Shilong wrote: > >> +$BTRFS_UTIL_PROG subvolume snapshot -r $SCRATCH_MNT \ > >> + $SCRATCH_MNT/snap_1 >> $seq

Re: [PATCH] Btrfs: add regression test for running snapshot and send concurrently

2014-02-06 Thread Dave Chinner
On Thu, Feb 06, 2014 at 09:12:51PM +0800, Wang Shilong wrote: > Hi Dave, > > > On Mon, Feb 03, 2014 at 11:22:36PM +0800, Wang Shilong wrote: > >> From: Wang Shilong > >> > >> Btrfs would fail to send if snapshot run concurrently, this test is

Re: [PATCH v2 3/3] btrfs/035: add new clone overwrite regression test

2014-02-06 Thread Dave Chinner
; Not exactly what I intended. If echo fails, it will output some kind of error message, and that will cause the golden image mismatch. Otherwise the test looks good. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-b

Re: [PATCH v3] Btrfs: add regression test for running snapshot and send concurrently

2014-02-06 Thread Dave Chinner
or. That's the whole point of using golden images for capturing errors - you don't need to capture return values from binaries and it guarantees that users are informed about failures through error messages. IOWs: $BTRFS_UTIL_PROG send $SCRATCH_MNT/snap_1 | _btrfs_send_filter is wh

Re: [PATCH 2/2] btrfs/035: add new clone overwrite regression test

2014-02-05 Thread Dave Chinner
> +echo "attempting ioctl (src.clone1 src)" > +$CLONER_PROG -s 0 -d 0 -l ${snap_src_sz} \ > + $SCRATCH_MNT/src.clone1 $SCRATCH_MNT/src || _fail "ioctl failed" And to do that here, you probably need to add perror() output to the cloner program when it detects an error.

Re: [PATCH 1/2] btrfs: add small program for clone testing

2014-02-05 Thread Dave Chinner
On Wed, Feb 05, 2014 at 12:16:48PM +0100, David Disseldorp wrote: > The cloner program is capable of cloning files using the BTRFS_IOC_CLONE > and BTRFS_IOC_CLONE_RANGE ioctls. > > Signed-off-by: David Disseldorp Hi Dave - long time since I've seen your head pop up arou

Re: [PATCH] Btrfs: add regression test for running snapshot and send concurrently

2014-02-03 Thread Dave Chinner
wait $pid call is made. If $pid doesn't exist at this time because it has completed, wait will return 127 and the test will fail Also, why would a failure to send result in meaingful information in dmesg? Shouldn't the userspace command output information to tell you why there was a

[ANNOUCE] xfstests: updated to ad969ca

2014-02-02 Thread Dave Chinner
/btrfs/032.out create mode 100755 tests/btrfs/033 create mode 100644 tests/btrfs/033.out -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.

Re: [PATCH] xfstests: more tests for test case btrfs/030

2014-02-02 Thread Dave Chinner
On Sun, Feb 02, 2014 at 10:08:06PM +, Filipe David Manana wrote: > On Sun, Feb 2, 2014 at 9:57 PM, Dave Chinner wrote: > > On Sat, Feb 01, 2014 at 02:05:32AM +, Filipe David Borba Manana wrote: > >> This change adds some new tests for btrfs' incremental send feat

Re: [PATCH] xfstests: more tests for test case btrfs/030

2014-02-02 Thread Dave Chinner
the rule of thumb is that once a test is "done" we don't go back and modify it in significant ways - we write a new unit test that covers the new/extended functionality. Redundancy in unit tests is not a bad thing... Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscr

[ANNOUNCE] xfstests updated to 197f773

2014-01-23 Thread Dave Chinner
next update. The new head of the master branch is commit: 197f773 xfstests: define $seqres in btrfs/026-029 New Commits: Dave Chinner (7): [ea0b6eb] xfs: test scratch device mkfs features [b9b5d74] xfs: New _require_* tests for CRC enabled filesystems [86e91cc] xfs: add fsstress

[ANNOUNCE] xfstests updated to 3099791

2014-01-19 Thread Dave Chinner
| 7 tests/xfs/group | 2 + 38 files changed, 937 insertions(+), 51 deletions(-) -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More maj

Re: [PATCH] xfstests: Add pairing mount options test

2014-01-13 Thread Dave Chinner
On Mon, Jan 13, 2014 at 12:00:26PM +0800, Qu Wenruo wrote: > On Mon, 13 Jan 2014 14:26:50 +1100, Dave Chinner wrote: > >On Mon, Jan 13, 2014 at 10:26:05AM +0800, Qu Wenruo wrote: > >>On mon, 13 Jan 2014 12:52:39 +1100, Dave Chinner wrote: > >>>On Sun, Jan 12, 2014 at

Re: [PATCH] xfstests: Add pairing mount options test

2014-01-12 Thread Dave Chinner
On Mon, Jan 13, 2014 at 10:26:05AM +0800, Qu Wenruo wrote: > On mon, 13 Jan 2014 12:52:39 +1100, Dave Chinner wrote: > >On Sun, Jan 12, 2014 at 07:35:44PM -0600, Eric Sandeen wrote: > >>I won't say no to this, but it seems to be of somewhat limited use. > >What h

Re: [PATCH] xfstests: kill lib/random.c

2014-01-12 Thread Dave Chinner
le. Come to find out we are > > >>>>>>> overloading > > >>>>>>> random() with our own custom horribleness for some unknown reason. > > >>>>>>> So nuke the > > >>>>>>> damn thing fro

Re: [PATCH] xfstests: Add pairing mount options test

2014-01-12 Thread Dave Chinner
r words, all this does is test that an option flag was set or unset in > the superblock, but it doesn't really test whether the option has been > properly set up (or torn down) as a result. > > I won't say no to this, but it seems to be of somewhat limited use. What happens

Re: btrfs raid1 and btrfs raid10 arrays NOT REDUNDANT

2014-01-03 Thread Dave
set. As an IT director though, I'd never subject my company to these rigors. If Btrfs on mdraid isn't an acceptable solution for you, then ZFS is the only responsible alternative. -- -=[dave]=- Entropy isn't what it used to be. -- To unsubscribe from this list: send the line "

Status of raid5/6 in 2014?

2014-01-03 Thread Dave
it would appear the developers are largely silent. Parity based raid would be a powerful addition the the Btrfs feature stack and it's the feature I most anxiously await. Are there any milestones planned for 2014? Keep up the good work... -- -=[dave]=- Entropy isn't what it used to b

Re: [PATCH 1/3] Btrfs: introduce lock_ref/unlock_ref

2013-12-18 Thread Dave Chinner
d_state); > +int unlock_ref(struct btrfs_fs_info *fs_info, u64 root_objectid, u64 bytenr, > +u64 num_bytes, int for_cow, > +struct btrfs_block_group_cache *block_group, > +struct extent_state **cached_state); Please namespace these - they are far to

Re: [PATCH 2/4 v3] fiemap: add EXTENT_DATA_COMPRESSED flag

2013-12-12 Thread Dave Chinner
On Thu, Dec 12, 2013 at 05:02:57PM -0700, Andreas Dilger wrote: > On Dec 12, 2013, at 4:24 PM, Dave Chinner wrote: > > On Thu, Dec 12, 2013 at 04:25:59PM +0100, David Sterba wrote: > >> This flag was not accepted when fiemap was proposed [2] due to lack of > >>

Re: [PATCH 2/4 v3] fiemap: add EXTENT_DATA_COMPRESSED flag

2013-12-12 Thread Dave Chinner
emap { > * Sets EXTENT_UNKNOWN. */ > #define FIEMAP_EXTENT_ENCODED0x0008 /* Data can not be > read > * while fs is unmounted */ > +#define FIEMAP_EXTENT_DATA_COMPRESSED0x000

[ANNOUNCE] xfstests: tree updated to 0a7f216b

2013-12-02 Thread Dave Chinner
s to around 24-48 hours after the patch has been reviewed. I don't want reviewed patches to sit around for weeks before they are committed, so please ping the patch if it's been reviewed and not committed after a couple of days. Thanks all, Dave. Anand Jain (1): * [ed14876] b

Re: [PATCH 14/18] xfs: use generic posix ACL infrastructure

2013-12-02 Thread Dave Chinner
On Sun, Dec 01, 2013 at 03:59:17AM -0800, Christoph Hellwig wrote: > Also create inodes with the proper mode instead of fixing it up later. > > Signed-off-by: Christoph Hellwig Nice cleanup work, Christoph. Reviewed-by: Dave Chinner -- Dave Chinner da...@fromorbit.com -- To unsubsc

Re: [Jfs-discussion] [PATCH 15/18] jfs: use generic posix ACL infrastructure

2013-12-02 Thread Dave Kleikamp
On 12/01/2013 05:59 AM, Christoph Hellwig wrote: > Copy the scheme I introduced to btrfs many years ago to only use the > xattr handler for ACLs, but pass plain attrs straight through. Looks good. > > Signed-off-by: Christoph Hellwig Reviewed-by: Dave Kleikamp > ---

Re: missing /sbin/fsck.btrfs

2013-12-01 Thread Dave Chinner
On Tue, Nov 26, 2013 at 08:06:36PM -0700, Chris Murphy wrote: > > On Nov 26, 2013, at 5:51 PM, Dave Chinner > wrote: > > > On Mon, Nov 25, 2013 at 11:40:49PM -0700, Chris Murphy wrote: > >> Hi, > >> > >> Is there supposed to be an /sbin/fsc

Re: [PATCH v3] xfstests,btrfs: add wrong compress type regression test

2013-11-26 Thread Dave Chinner
Looks good now. Reviewed-by: Dave Chinner -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: missing /sbin/fsck.btrfs

2013-11-26 Thread Dave Chinner
devices took a long time to instantiate (e.g. SAN, iscsi and other remote devices) and the 'device exists' check prevents /etc/fstab trying to mount the filesystems before they are present and then throwing a hissy fit Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To uns

Re: [PATCH v2] xfstests,btrfs: add wrong compress type regression test

2013-11-25 Thread Dave Chinner
--- > Changlog v1 -> v2: > - address the commit from Dave Chinner. Testing every change before posting them for review is a good habit to develop. This: > + $XFS_IO_PROG -f -c "pwrite 0 1M" -c sync $work_file | _filter_xfs_io will dump this: wrote 1048576/1048576 bytes

Re: [PATCH] xfstests,btrfs: add wrong compress type regression test

2013-11-25 Thread Dave Chinner
etection and reporting, just like for touch and chattr __workout() { work_file="$SCRATCH_MNT/tmpfile" touch $work_file chattr =c $work_file $XFS_IO_PROG -f -c "pwrite 0 1M" -c sync $work_file | _filter_xfs_io } > +echo "*** test

Re: [PATCH v2] xfstests: add regression test for running btrfs balance and defrag concurrently

2013-10-30 Thread Dave Chinner
t; \ $SCRATCH_MNT/foo-$j | _filter_xfs_io > +done > + > +sync Why do direct IO if you then run sync? If you are trying to fragment the file, then please add a comment that you are doing a backwards write to fragment it and how it interacts with the "touch loop&quo

<    1   2   3   4   5   6   7   8   >