Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA

2015-06-24 Thread Javier Martinez Canillas
Hello Paul, On Thu, Jun 25, 2015 at 2:00 AM, Paul Gortmaker wrote: > [Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA] On > 22/06/2015 (Mon 15:59) Herbert Xu wrote: > >> On Mon, Jun 22, 2015 at 09:23:36AM +0200, Boris Brezillon wrote: >> > Hi Herbert, >> > >> > On Sun, 21 Jun 20

Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA

2015-06-24 Thread Paul Gortmaker
[Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA] On 22/06/2015 (Mon 15:59) Herbert Xu wrote: > On Mon, Jun 22, 2015 at 09:23:36AM +0200, Boris Brezillon wrote: > > Hi Herbert, > > > > On Sun, 21 Jun 2015 16:27:17 +0800 > > Herbert Xu wrote: > > > > > On Sun, Jun 21, 2015 at 1

[PATCH] keys: Use non-conflicting variable name

2015-06-24 Thread Guenter Roeck
arm64:allmodconfig fails to build as follows. In file included from include/acpi/platform/aclinux.h:74:0, from include/acpi/platform/acenv.h:173, from include/acpi/acpi.h:56, from include/linux/acpi.h:37, from ./arch/arm64/include

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

2015-06-24 Thread Vinod Koul
On Mon, Jun 22, 2015 at 02:31:00PM +0300, Peter Ujfalusi wrote: > On 06/12/2015 03:58 PM, Vinod Koul wrote: > > Sorry this slipped thru > > I was away for a week anyways ;) > > > Thinking about it again, I think we should coverge to two APIs and mark the > > legacy depracuated and look to convert

[PATCH v2] crypto: testmgr - don't print info about missing test for gcm-aes-aesni

2015-06-24 Thread Tadeusz Struk
Don't print info about missing test for the internal helper __driver-gcm-aes-aesni changes in v2: - marked test as fips allowed Signed-off-by: Tadeusz Struk --- crypto/testmgr.c |4 1 file changed, 4 insertions(+) diff --git a/crypto/testmgr.c b/crypto/testmgr.c index 975e1ea..d0a42b

Re: [PATCH] crypto: testmgr - don't print info about missing test for gcm-aes-aesni

2015-06-24 Thread Tadeusz Struk
Hi Stephan, On 06/24/2015 07:44 AM, Stephan Mueller wrote: >> }, { >> >+ .alg = "__driver-gcm-aes-aesni", >> >+ .test = alg_test_null, > Wouldn't fips_allowed = 1 be needed here? Yes, you are right. I will send a v2 soon. -- To unsubscribe from this list: send the line "un

Re: [PATCH] crypto: testmgr - don't print info about missing test for gcm-aes-aesni

2015-06-24 Thread Stephan Mueller
Am Mittwoch, 24. Juni 2015, 07:14:22 schrieb Tadeusz Struk: Hi Tadeusz, >Don't print info about missing test for the internal >helper __driver-gcm-aes-aesni > >Signed-off-by: Tadeusz Struk >--- > crypto/testmgr.c |3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/crypto/testmgr.c b/cry

[PATCH] crypto: testmgr - don't print info about missing test for gcm-aes-aesni

2015-06-24 Thread Tadeusz Struk
Don't print info about missing test for the internal helper __driver-gcm-aes-aesni Signed-off-by: Tadeusz Struk --- crypto/testmgr.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/crypto/testmgr.c b/crypto/testmgr.c index 975e1ea..ad4c3e3 100644 --- a/crypto/testmgr.c +++ b/crypto/tes

[PATCH] crypto: aesni - fix failing setkey for rfc4106-gcm-aesni

2015-06-24 Thread Tadeusz Struk
rfc4106(gcm(aes)) uses cbc(aes) to generate hash key. cbc(aes) needs chainiv, but the chainiv gets initialized after aesni_intel when both are statically linked so the setkey fails. This patch forces aesni_intel to be initialized after chainiv. Signed-off-by: Tadeusz Struk --- arch/x86/crypto/ae

Re: Crypto Update for 4.2

2015-06-24 Thread Herbert Xu
On Tue, Jun 23, 2015 at 07:11:19PM -0700, Linus Torvalds wrote: > On Mon, Jun 22, 2015 at 1:44 AM, Herbert Xu > wrote: > > > > Here is the crypto update for 4.2: > > Hmm. I noticed a new annoyance: > > I get this at bootup: > > [ +0.001504] alg: No test for __gcm-aes-aesni (__driver-gcm-aes

Re: [PATCH] crypto-jitterentropy: Delete unnecessary checks before the function call "kzfree"

2015-06-24 Thread Dan Carpenter
Ah. I should have read the whole thread. I sort of assumed we were just adding abstractions for the fun of it (because I have worked in staging for too long). regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@

Re: [PATCH] random: add random_initialized command line param

2015-06-24 Thread Pavel Machek
On Tue 2015-06-23 23:47:33, Stephan Mueller wrote: > Am Dienstag, 23. Juni 2015, 22:44:11 schrieb Pavel Machek: > > Hi Pavel, > > > On Mon 2015-05-18 18:25:25, Stephan Mueller wrote: > > > Make the threshold at which the output entropy pools are considered to > > > be initialized configurable via

Re: [PATCH] crypto-jitterentropy: Delete unnecessary checks before the function call "kzfree"

2015-06-24 Thread Stephan Mueller
Am Mittwoch, 24. Juni 2015, 10:48:19 schrieb Dan Carpenter: Hi Dan, >The other NULL assignment isn't useful either. Also If >"entropy_collector" is NULL then we would oops calling >kzfree(entropy_collector->mem); > ^^ >Dereference. > >I don't understand the patch that y

Re: [PATCH] crypto-jitterentropy: Delete unnecessary checks before the function call "kzfree"

2015-06-24 Thread Dan Carpenter
The other NULL assignment isn't useful either. Also If "entropy_collector" is NULL then we would oops calling kzfree(entropy_collector->mem); ^^ Dereference. I don't understand the patch that you sent. We shouldn't be introducing jent_zalloc() or jent_zfree(). Why are