Stefan Wahren writes:
> Adopt the SPDX license identifier headers to ease license compliance
> management. While we are at this fix the comment style, too.
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
Wei Yongjun writes:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
Stefan Wahren writes:
> Hi Florian,
>
>> Florian Fainelli hat am 8. November 2017 um 01:44
>> geschrieben:
>>
>>
>> The interrupt masking done for Northstart Plus and Northstar (BCM5301X)
>> is moved from being a function pointer mapped to of_device_id::data into
>> a proper part of the hwrng
hes 9, 11, 12 are:
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
> @@ -88,6 +97,9 @@ static void bcm2835_rng_cleanup(struct hwrng *rng)
>
> /* disable rng hardware */
> __raw_writel(0, priv->base + RNG_CTRL);
> +
> + if (!IS_ERR(priv->clk))
> + clk_disable_unprepare(priv->clk);
Same. With those conditionals dropped,
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
ms need it. Looks like a fine refactor, though:
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
Florian Fainelli writes:
> Now that we have moved the RNG disabling into a hwrng::cleanup callback,
> we can use the device managed registration operation and remove our
> remove callback since it won't do anything necessary.
3-5 are:
Reviewed-by: Eric Anholt
signature.asc
De
}
> - bcm2835_rng_ops.priv = (unsigned long)rng_base;
> +
> + priv->rng.name = "bcm2835-rng";
Looks like an unintentional change from the previous "bcm2835" here?
Other than that, 1-2 are:
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
Florian Fainelli writes:
> In preparation for allowing BCM63xx to use this driver, we abstract I/O
> accessors such that we can easily change those later on.
>
> Signed-off-by: Florian Fainelli
> ---
> drivers/char/hw_random/bcm2835-rng.c | 27 +++
> 1 file changed, 19 i
Florian Fainelli writes:
> bcm2835-rng is now capable of supporting the BCM63xx hardware, so remove
> the driver which duplicates the same functionality.
>
> Signed-off-by: Florian Fainelli
> ---
> drivers/char/hw_random/Kconfig | 13 ---
> drivers/char/hw_random/Makefile | 1 -
>
Arvind Yadav writes:
> Check return value of of_iomap and handle errors correctly.
>
> Signed-off-by: Arvind Yadav
Acked-by: Eric Anholt
signature.asc
Description: PGP signature
Yendapally Reddy Dhananjaya Reddy
writes:
> Document the bindings used by Northstar Plus(NSP) SoC random number
> generator.
>
> Signed-off-by: Yendapally Reddy Dhananjaya Reddy
>
Acked-by: Eric Anholt
signature.asc
Description: PGP signature
eanup: here and in the return statement, drop the extra
parenthesis.
Functionality-wise, this patch looks great to me, and should make the
driver more efficient. With at least the binary operators change done,
it will be:
Reviewed-by: Eric Anholt
Thanks!
signature.asc
Description: PGP signature
, even though the firmware has presumably been setting it for us
already.
However, this patch is still correct and I'm fine with it, so it's:
Acked-by: Eric Anholt
signature.asc
Description: PGP signature
15 matches
Mail list logo
