> -Original Message-
> From: Markus Elfring [mailto:markus.elfr...@web.de]
> Sent: Tuesday, December 26, 2023 6:12 PM
> To: kernel test robot ; virtualizat...@lists.linux.dev;
> linux-crypto@vger.kernel.org; kernel-janit...@vger.kernel.org; David S. Miller
> ; Gongle
Signed-off-by: wangyangxin
Signed-off-by: Gonglei
---
drivers/crypto/virtio/virtio_crypto_common.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/crypto/virtio/virtio_crypto_common.h
b/drivers/crypto/virtio/virtio_crypto_common.h
index 7059bbe5a2eb..f0340bb7a
From: wangyangxin
The scheduled tasklet needs to be executed on device remove.
Fixes: fed93fb62e05 ("crypto: virtio - Handle dataq logic with tasklet")
Signed-off-by: wangyangxin
Signed-off-by: Gonglei
---
drivers/crypto/virtio/virtio_crypto_core.c | 3 +++
1 file changed, 3
From: wangyangxin
This serie wait for tasklet to complete on device remove and fix gcc check
warnings.
wangyangxin (2):
crypto: virtio-crypto: Wait for tasklet to complete on device remove
crypto: virtio-crypto: Fix gcc check warnings
drivers/crypto/virtio/virtio_crypto_common.h | 5 ++---
> -Original Message-
> From: Herbert Xu [mailto:herb...@gondor.apana.org.au]
> Sent: Friday, December 8, 2023 11:28 AM
> To: Gonglei (Arei)
> Cc: linux-crypto@vger.kernel.org; Michael S. Tsirkin ; Jason
> Wang ; virtualizat...@lists.linux-foundation.org;
> linux-k
ned-off-by: wangyangxin
Signed-off-by: Gonglei
---
v2: calling tasklet_kill() in virtcrypto_remove(), thanks for MST.
drivers/crypto/virtio/virtio_crypto_common.h | 2 ++
drivers/crypto/virtio/virtio_crypto_core.c | 26 --
2 files changed, 18 insertions(+), 10 deletion
Hi Herbert,
> -Original Message-
> From: Herbert Xu [mailto:herb...@gondor.apana.org.au]
> Sent: Friday, December 1, 2023 6:11 PM
> To: Gonglei (Arei)
> Cc: linux-crypto@vger.kernel.org; pa...@linux.ibm.com; m...@redhat.com;
> jasow...@redhat.com; virtuali
> -Original Message-
> From: Michael S. Tsirkin [mailto:m...@redhat.com]
> Sent: Friday, December 1, 2023 10:51 PM
> To: Gonglei (Arei)
> Cc: Herbert Xu ; linux-crypto@vger.kernel.org;
> Halil Pasic ; Jason Wang ;
> virtualizat...@lists.linux-foun
ned-off-by: wangyangxin
Signed-off-by: Gonglei
---
drivers/crypto/virtio/virtio_crypto_common.h | 2 ++
drivers/crypto/virtio/virtio_crypto_core.c | 23 +--
2 files changed, 15 insertions(+), 10 deletions(-)
diff --git a/drivers/crypto/virtio/virtio_crypto_common.h
b/driv
> -Original Message-
> From: Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
> Sent: Tuesday, May 26, 2020 11:20 AM
> To: linux-crypto@vger.kernel.org
> Cc: Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
> ; LABBE Corentin ; Gonglei
>
> -Original Message-
> From: linux-crypto-ow...@vger.kernel.org
> [mailto:linux-crypto-ow...@vger.kernel.org] On Behalf Of Caleb Raitto
> Sent: Friday, August 10, 2018 9:18 AM
> To: herb...@gondor.apana.org.au; m...@redhat.com; da...@davemloft.net
> Cc: Gong
> -Original Message-
> From: Caleb Raitto [mailto:caleb.rai...@gmail.com]
> Sent: Friday, August 10, 2018 8:29 AM
> To: herb...@gondor.apana.org.au; m...@redhat.com; da...@davemloft.net
> Cc: Gonglei (Arei) ; jasow...@redhat.com;
> net...@vger.kernel.org; linux-cryp
; drivers/virtio/virtio_input.c | 3 +--
> include/linux/virtio_config.h | 9 +
> net/vmw_vsock/virtio_transport.c | 6 +++---
> 12 files changed, 24 insertions(+), 23 deletions(-)
>
Acked-by: Gonglei
> diff --git a/drivers/block/virt
tions but lower than the hardware ones.
Suggested-by: Christian Borntraeger
Signed-off-by: Gonglei
Acked-by: Christian Borntraeger
---
v2:
fix three typos. [Christian]
---
drivers/crypto/virtio/virtio_crypto_algs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/driver
>
> From: Christian Borntraeger [mailto:borntrae...@de.ibm.com]
> Sent: Friday, January 13, 2017 4:28 PM
> To: Gonglei (Arei); virtualizat...@lists.linux-foundation.org;
> linux-crypto@vger.kernel.org; linux-ker...@vger.kernel.org
> Cc: m...@redhat.com; herb...@gondor.apana.or
tions but lower than the hardware ones.
Suggested-by: Christian Borntraeger
Signed-off-by: Gonglei
---
drivers/crypto/virtio/virtio_crypto_algs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/virtio/virtio_crypto_algs.c
b/drivers/crypto/virtio/virtio_cryp
>
> On Thu, Jan 12, 2017 at 03:10:25PM +0100, Christian Borntraeger wrote:
> > On 01/10/2017 01:56 PM, Christian Borntraeger wrote:
> > > On 01/10/2017 01:36 PM, Gonglei (Arei) wrote:
> > >> Hi,
> > >>
> >
Hi,
>
> On 12/15/2016 03:03 AM, Gonglei wrote:
> [...]
> > +
> > +static struct crypto_alg virtio_crypto_algs[] = { {
> > + .cra_name = "cbc(aes)",
> > + .cra_driver_name = "virtio_crypto_aes_cbc",
> > + .cra_priority = 501,
>
ta virtqueue so that we can use the capability of
multiple data queues in future.
Cc: Baolin Wang
Cc: Herbert Xu
Cc: Michael S. Tsirkin
Signed-off-by: Gonglei
---
drivers/crypto/virtio/Kconfig| 1 +
drivers/crypto/virtio/virtio_crypto_algs.c | 52 ---
d
Hi Michael,
>
> >
> >
> > > Subject: RE: [Qemu-devel] [PATCH v7 1/1] crypto: add virtio-crypto driver
> > >
> > > On Thursday, December 15, 2016 8:45 AM, Gonglei (Arei) Wrote:
> > > < > > diff --git a/drivers/crypto/v
virtio-crypto device, please see:
http://qemu-project.org/Features/VirtioCrypto
CC: Michael S. Tsirkin
CC: Cornelia Huck
CC: Stefan Hajnoczi
CC: Herbert Xu
CC: Halil Pasic
CC: David S. Miller
CC: Zeng Xin
Signed-off-by: Gonglei
---
MAINTAINERS | 9
troduces the little edian functions for VIRTIO_1 devices in patch 1.
Gonglei (1):
crypto: add virtio-crypto driver
MAINTAINERS | 9 +
drivers/crypto/Kconfig | 2 +
drivers/crypto/Makefile | 1 +
drivers/crypto/vi
Regards,
-Gonglei
> -Original Message-
> From: Zeng, Xin [mailto:xin.z...@intel.com]
> Sent: Thursday, December 15, 2016 8:59 AM
> To: Gonglei (Arei); Halil Pasic; linux-ker...@vger.kernel.org;
> qemu-de...@nongnu.org; virtio-...@lists.oasis-open.org;
> virtuali
>
>
> On 12/14/2016 12:50 PM, Gonglei wrote:
> > diff --git a/drivers/crypto/virtio/virtio_crypto_core.c
> b/drivers/crypto/virtio/virtio_crypto_core.c
> > new file mode 100644
> > index 000..c0854a1
> > --- /dev/null
> > +++ b/drivers/crypto/virt
virtio-crypto device, please see:
http://qemu-project.org/Features/VirtioCrypto
CC: Michael S. Tsirkin
CC: Cornelia Huck
CC: Stefan Hajnoczi
CC: Herbert Xu
CC: Halil Pasic
CC: David S. Miller
CC: Zeng Xin
Signed-off-by: Gonglei
---
MAINTAINERS | 9
- stop doing DMA from the stack, CONFIG_VMAP_STACK=y [Salvatore]
- convert __virtio32/64 to __le32/64 in virtio_crypto.h
- remove VIRTIO_CRYPTO_S_STARTED based on the lastest virtio crypto spec.
- introduces the little edian functions for VIRTIO_1 devices in patch 1.
Hi,
>
> Subject: Re: [PATCH v6 2/2] crypto: add virtio-crypto driver
>
>
>
> On 12/12/2016 11:05 PM, Michael S. Tsirkin wrote:
> > On Mon, Dec 12, 2016 at 06:54:07PM +0800, Herbert Xu wrote:
> >> On Mon, Dec 12, 2016 at 06:25:12AM +, Gonglei (Arei) w
>
> Subject: Re: [PATCH v6 2/2] crypto: add virtio-crypto driver
>
> On Mon, Dec 12, 2016 at 06:54:07PM +0800, Herbert Xu wrote:
> > On Mon, Dec 12, 2016 at 06:25:12AM +, Gonglei (Arei) wrote:
> > > Hi, Michael & Herbert
> > >
> > > Because th
4.10 merge window timing from Linus
https://lkml.org/lkml/2016/12/7/506
Dec 23rd is the deadline for 4.10 merge window.
Regards,
-Gonglei
> -Original Message-
> From: Gonglei (Arei)
> Sent: Thursday, December 08, 2016 12:37 PM
> Subject: [PATCH v6 2/2] crypto: add virtio-crypto
Regards,
-Gonglei
> -Original Message-
> From: linux-crypto-ow...@vger.kernel.org
> [mailto:linux-crypto-ow...@vger.kernel.org] On Behalf Of Sam Ravnborg
> Sent: Saturday, December 10, 2016 5:59 AM
> To: Gonglei (Arei)
> Cc: linux-ker...@vger.kernel.org; qem
virtio-crypto device, please see:
http://qemu-project.org/Features/VirtioCrypto
CC: Michael S. Tsirkin
CC: Cornelia Huck
CC: Stefan Hajnoczi
CC: Herbert Xu
CC: Halil Pasic
CC: David S. Miller
CC: Zeng Xin
Signed-off-by: Gonglei
---
MAINTAINERS | 9
ta.h in topology_64.h.
Cc: Sam Ravnborg
Cc: David S. Miller
Cc: sparcli...@vger.kernel.org
Suggested-by: Sam Ravnborg
Signed-off-by: Gonglei
---
arch/sparc/include/asm/topology_64.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/sparc/include/asm/topology_64.h
b/arch/sparc/include/as
[Salvatore]
- convert __virtio32/64 to __le32/64 in virtio_crypto.h
- remove VIRTIO_CRYPTO_S_STARTED based on the lastest virtio crypto spec.
- introduces the little edian functions for VIRTIO_1 devices in patch 1.
Gonglei (2):
sparc: fix a building error reported by kb
Hi Sam,
>
> Subject: Re: [PATCH v5 1/1] crypto: add virtio-crypto driver
>
> On Mon, Dec 05, 2016 at 03:12:52AM +0000, Gonglei (Arei) wrote:
> > I don't think the root cause of those warnings are introduced by
> > virtio-crypto
> driver.
> >
> > W
>
> Subject: Re: [PATCH v5 1/1] crypto: add virtio-crypto driver
>
> On Tue, Dec 06, 2016 at 09:01:49AM +0000, Gonglei (Arei) wrote:
> >
> > Would you please review and/or ack the virtio_crypto_algs.c?
> > It is the realization of specified algs based on Linux Cr
Hi Herbert,
Would you please review and/or ack the virtio_crypto_algs.c?
It is the realization of specified algs based on Linux Crypto Framework.
Thanks!
Regards,
-Gonglei
> -Original Message-
> From: Gonglei (Arei)
> Sent: Thursday, December 01, 2016 8:39 PM
> T
I don't think the root cause of those warnings are introduced by virtio-crypto
driver.
What's your opinion? Sam and David?
Thanks,
-Gonglei
> -Original Message-
> From: kbuild test robot [mailto:l...@intel.com]
> Sent: Sunday, December 04, 2016 10:40 AM
> Subj
virtio-crypto device, please see:
http://qemu-project.org/Features/VirtioCrypto
CC: Michael S. Tsirkin
CC: Cornelia Huck
CC: Stefan Hajnoczi
CC: Herbert Xu
CC: Halil Pasic
CC: David S. Miller
CC: Zeng Xin
Signed-off-by: Gonglei
---
MAINTAINERS | 9
>
> On Thu, Dec 01, 2016 at 02:27:19AM +, Gonglei (Arei) wrote:
> > > On Tue, Nov 29, 2016 at 08:48:14PM +0800, Gonglei wrote:
> > > > diff --git a/drivers/crypto/virtio/virtio_crypto_algs.c
> > > b/drivers/crypto/virtio/virtio_crypto_algs.c
> > >
to guys can mainly focus on this file.
v2:
- stop doing DMA from the stack, CONFIG_VMAP_STACK=y [Salvatore]
- convert __virtio32/64 to __le32/64 in virtio_crypto.h
- remove VIRTIO_CRYPTO_S_STARTED based on the lastest virtio crypto spec.
- introduces the little edian functions for VIRTIO_1 de
>
> Subject: Re: [PATCH v4 1/1] crypto: add virtio-crypto driver
>
> On Thu, Dec 01, 2016 at 02:27:19AM +0000, Gonglei (Arei) wrote:
> > > On Tue, Nov 29, 2016 at 08:48:14PM +0800, Gonglei wrote:
> > > > +static int virtio_crypto_alg_ablkcipher_init_sessio
Hi Stefan,
>
> On Tue, Nov 29, 2016 at 08:48:14PM +0800, Gonglei wrote:
> > diff --git a/drivers/crypto/virtio/virtio_crypto_algs.c
> b/drivers/crypto/virtio/virtio_crypto_algs.c
> > new file mode 100644
> > index 000..08b077f
> > --- /dev/nul
- remove VIRTIO_CRYPTO_S_STARTED based on the lastest virtio crypto spec.
- introduces the little edian functions for VIRTIO_1 devices in patch 1.
Gonglei (1):
crypto: add virtio-crypto driver
MAINTAINERS | 9 +
drivers/crypto/Kconfig
virtio-crypto device, please see:
http://qemu-project.org/Features/VirtioCrypto
CC: Michael S. Tsirkin
CC: Cornelia Huck
CC: Stefan Hajnoczi
CC: Herbert Xu
CC: Halil Pasic
CC: David S. Miller
CC: Zeng Xin
Signed-off-by: Gonglei
---
MAINTAINERS | 9
>
> Subject: Re: [virtio-dev] Re: [PATCH v3] crypto: add virtio-crypto driver
>
> On Tue, 29 Nov 2016 01:37:44 +0000
> "Gonglei (Arei)" wrote:
>
> > > On Mon, 28 Nov 2016 20:08:23 +0800
> > > Gonglei wrote:
> > >
> > > >
>
> > On Tue, Nov 29, 2016 at 08:22:58AM +, Gonglei (Arei) wrote:
> > > Hi,
> > >
> > > > > > > +source "drivers/crypto/virtio/Kconfig"
> > > > > > > +
> > > > > > > endif # CRYPTO_HW
>
>
> On Tue, Nov 29, 2016 at 08:22:58AM +, Gonglei (Arei) wrote:
> > Hi,
> >
> > > > > > +source "drivers/crypto/virtio/Kconfig"
> > > > > > +
> > > > > > endif # CRYPTO_HW
> > > > > > diff
it doesn't work because virtio_crypto.c isn't compiled.
# insmod virtio_crypto.ko
insmod: ERROR: could not insert module virtio_crypto.ko: Unknown symbol in
module
# dmesg
[74339.311801] virtio_crypto: Unknown symbol virtqueue_is_broken (err 0)
[74339.311816] virtio_crypto: Unknown symbo
> > multiple crypto devices (e.g. with different capabilities)?
> >
> Actually there is a simple schedule algorithms in virtcrypto_get_dev_node(),
> which return the device used fewest on the node.
>
> If we don't find a device in the node, select the first on as defaul
time (except where noted).
*
* Returns false if kick failed, otherwise true.
*/
bool virtqueue_kick(struct virtqueue *vq)
{
if (virtqueue_kick_prepare(vq))
return virtqueue_notify(vq);
return true;
}
If virtqueue_kick_prepare return ture, then notify which c
Hi Michael and Stefan,
>
> Subject: Re: [PATCH v3] crypto: add virtio-crypto driver
>
> On Mon, Nov 28, 2016 at 04:20:55PM +, Stefan Hajnoczi wrote:
> > On Mon, Nov 28, 2016 at 08:08:23PM +0800, Gonglei wrote:
> > > This patch introduces virtio-crypto driver for Li
>
> Subject: [virtio-dev] Re: [PATCH v3] crypto: add virtio-crypto driver
>
> On Mon, 28 Nov 2016 20:08:23 +0800
> Gonglei wrote:
>
> > +static int virtcrypto_update_status(struct virtio_crypto *vcrypto)
> > +{
> > + u32 status;
> > + int err
virtio-crypto device, please see:
http://qemu-project.org/Features/VirtioCrypto
CC: Michael S. Tsirkin
CC: Cornelia Huck
CC: Stefan Hajnoczi
CC: Herbert Xu
CC: Halil Pasic
CC: David S. Miller
CC: Zeng Xin
Signed-off-by: Gonglei
---
MAINTAINERS | 9
o guys can mainly focus on this file.
v2:
- stop doing DMA from the stack, CONFIG_VMAP_STACK=y [Salvatore]
- convert __virtio32/64 to __le32/64 in virtio_crypto.h
- remove VIRTIO_CRYPTO_S_STARTED based on the lastest virtio crypto spec.
- introduces the little edian functions for VIRTIO_1 devic
>
> From: Michael S. Tsirkin [mailto:m...@redhat.com]
> Sent: Monday, November 28, 2016 1:09 PM
> To: Gonglei (Arei)
> Subject: Re: [virtio-dev] Re: [PATCH v2 2/2] crypto: add virtio-crypto driver
>
> On Mon, Nov 28, 2016 at 04:47:21AM +, Gonglei (Arei) wrote:
> &g
Hi Michael,
>
> Subject: [virtio-dev] Re: [PATCH v2 2/2] crypto: add virtio-crypto driver
>
> On Tue, Nov 22, 2016 at 04:10:23PM +0800, Gonglei wrote:
> > This patch introduces virtio-crypto driver for Linux Kernel.
> >
> > The virtio crypto device is a virtual cryp
>
> Subject: Re: [virtio-dev] Re: [PATCH v2 1/2] virtio: introduce little edian
> functions for virtio_cread/write# family
>
> On Mon, Nov 28, 2016 at 04:34:56AM +0200, Michael S. Tsirkin wrote:
> > On Mon, Nov 28, 2016 at 01:56:04AM +, Gonglei (Arei) wr
>
> Subject: Re: [virtio-dev] Re: [PATCH v2 1/2] virtio: introduce little edian
> functions for virtio_cread/write# family
>
> On Mon, Nov 28, 2016 at 01:56:04AM +, Gonglei (Arei) wrote:
> > Hi Michael,
> >
> > Thanks for your feedback firstly!
> >
>
Hi Michael,
Thanks for your feedback firstly!
> -Original Message-
> From: virtio-...@lists.oasis-open.org [mailto:virtio-...@lists.oasis-open.org]
> On Behalf Of Michael S. Tsirkin
> Sent: Sunday, November 27, 2016 11:33 AM
> To: Gonglei (Arei)
> Subject: [virtio-dev]
Hi,
> -Original Message-
> From: Gonglei (Arei)
> Sent: Tuesday, November 22, 2016 4:10 PM
> To: linux-ker...@vger.kernel.org; qemu-de...@nongnu.org;
> virtio-...@lists.oasis-open.org; virtualizat...@lists.linux-foundation.org;
> linux-crypto@vger.kernel.org
> S
IO_1 devices in patch 1.
Gonglei (2):
virtio: introduce little edian functions for virtio_cread/write#
family
crypto: add virtio-crypto driver
MAINTAINERS | 8 +
drivers/crypto/Kconfig | 2 +
drivers/crypto/Makefile
Virtio modern devices are always little edian, let's introduce
the LE functions for read/write configuration space for
virtio modern devices, which avoid complaint by Sparse when
we use the virtio_creaed/virtio_cwrite in VIRTIO_1 devices.
Signed-off-by: Gonglei
---
include/linux/virtio_con
virtio-crypto device, please see:
http://qemu-project.org/Features/VirtioCrypto
CC: Michael S. Tsirkin
CC: Cornelia Huck
CC: Stefan Hajnoczi
CC: Herbert Xu
CC: Halil Pasic
CC: David S. Miller
CC: Zeng Xin
Signed-off-by: Gonglei
---
MAINTAINERS | 8
Hi Michael,
May I should convert all __virtio32/64 to le32/64 in virtio_crypto.h ?
> +#define VIRTIO_CRYPTO_OPCODE(service, op) (((service) << 8) | (op))
> +
> +struct virtio_crypto_ctrl_header {
> +#define VIRTIO_CRYPTO_CIPHER_CREATE_SESSION \
> +VIRTIO_CRYPTO_OPCODE(VIRTIO_CR
virtio-crypto device, please see:
http://qemu-project.org/Features/VirtioCrypto
CC: Michael S. Tsirkin
CC: Cornelia Huck
CC: Stefan Hajnoczi
CC: Herbert Xu
CC: Halil Pasic
CC: David S. Miller
CC: Zeng Xin
Signed-off-by: Gonglei
---
MAINTAINERS | 8
65 matches
Mail list logo
