Re: [PATCH] crypto: AF_ALG - remove locking in async callback

2017-11-06 Thread Herbert Xu
On Tue, Nov 07, 2017 at 07:19:32AM +0100, Stephan Müller wrote: > > Where I am not fully sure is whether af_alg_async_cb is called in any case. > I.e. when we invoke an AIO operation with a cipher that completes > synchronously (e.g. AES-NI), is this callback triggered? It's the same with any o

Re: [PATCH] crypto: AF_ALG - remove locking in async callback

2017-11-06 Thread Stephan Müller
Am Dienstag, 7. November 2017, 06:22:35 CET schrieb Herbert Xu: Hi Herbert, > On Mon, Nov 06, 2017 at 05:06:09PM +0100, Stephan Mueller wrote: > > Am Freitag, 3. November 2017, 14:20:16 CET schrieb Herbert Xu: > > > Are you sure about that? In particular is the callback function still > > > sane

Re: [PATCH] crypto: AF_ALG - remove locking in async callback

2017-11-06 Thread Herbert Xu
On Mon, Nov 06, 2017 at 05:06:09PM +0100, Stephan Mueller wrote: > Am Freitag, 3. November 2017, 14:20:16 CET schrieb Herbert Xu: > > > Are you sure about that? In particular is the callback function still > > sane without the socket lock if a concurrent recvmsg/sendmsg call is > > made? > > I rev

Re: [PATCH] crypto: AF_ALG - remove locking in async callback

2017-11-06 Thread Stephan Mueller
Am Freitag, 3. November 2017, 14:20:16 CET schrieb Herbert Xu: Hi Herbert, > > > > The code paths protected by the socket-lock do not use or modify the > > socket in a non-atomic fashion. The actions pertaining the socket do not > > even need to be handled as an atomic operation. Thus, the socke

Re: [PATCH] crypto: AF_ALG - remove locking in async callback

2017-11-03 Thread Stephan Mueller
Am Freitag, 3. November 2017, 14:20:16 CET schrieb Herbert Xu: Hi Herbert, > On Sun, Oct 29, 2017 at 09:39:30PM +0100, Stephan Müller wrote: > > Am Mittwoch, 25. Oktober 2017, 17:26:31 CET schrieb Romain Izard: > > > > Hi Romain, > > > > the patch below should cover the issue you see. Would you

Re: [PATCH] crypto: AF_ALG - remove locking in async callback

2017-11-03 Thread Herbert Xu
On Sun, Oct 29, 2017 at 09:39:30PM +0100, Stephan Müller wrote: > Am Mittwoch, 25. Oktober 2017, 17:26:31 CET schrieb Romain Izard: > > Hi Romain, > > the patch below should cover the issue you see. Would you mind testing it? > > Thanks > Stephan > > ---8<--- > > The code paths protected by th

Re: [PATCH] crypto: AF_ALG - remove locking in async callback

2017-10-30 Thread Romain Izard
2017-10-29 21:39 GMT+01:00 Stephan Müller : > Am Mittwoch, 25. Oktober 2017, 17:26:31 CET schrieb Romain Izard: > > Hi Romain, > > the patch below should cover the issue you see. Would you mind testing it? > > Thanks > Stephan > > ---8<--- > > The code paths protected by the socket-lock do not use

[PATCH] crypto: AF_ALG - remove locking in async callback

2017-10-29 Thread Stephan Müller
Am Mittwoch, 25. Oktober 2017, 17:26:31 CET schrieb Romain Izard: Hi Romain, the patch below should cover the issue you see. Would you mind testing it? Thanks Stephan ---8<--- The code paths protected by the socket-lock do not use or modify the socket in a non-atomic fashion. The actions perta