Re: [PATCH v3 12/18] crypto: switch af_alg_make_sg() to iov_iter

2015-02-09 Thread Al Viro
On Mon, Feb 09, 2015 at 02:59:40PM +0100, Stephan Mueller wrote: > Am Mittwoch, 4. Februar 2015, 06:40:03 schrieb Al Viro: > > Hi Al, > > > From: Al Viro > > > > With that, all ->sendmsg() instances are converted to iov_iter primitives > > and are agnostic wrt the kind of iov_iter they are work

Re: [PATCH v3 12/18] crypto: switch af_alg_make_sg() to iov_iter

2015-02-09 Thread Al Viro
On Mon, Feb 09, 2015 at 02:33:48PM +0100, Stephan Mueller wrote: > > > > -int af_alg_make_sg(struct af_alg_sgl *sgl, void __user *addr, int len, > > - int write) > > +int af_alg_make_sg(struct af_alg_sgl *sgl, struct iov_iter *iter, int len) > > Shouldn't len be size_t? iov_iter_get_

Re: [PATCH v3 12/18] crypto: switch af_alg_make_sg() to iov_iter

2015-02-09 Thread Stephan Mueller
Am Mittwoch, 4. Februar 2015, 06:40:03 schrieb Al Viro: Hi Al, > From: Al Viro > > With that, all ->sendmsg() instances are converted to iov_iter primitives > and are agnostic wrt the kind of iov_iter they are working with. > So's the last remaining ->recvmsg() instance that wasn't kind-agnosti

Re: [PATCH v3 12/18] crypto: switch af_alg_make_sg() to iov_iter

2015-02-09 Thread Stephan Mueller
Am Mittwoch, 4. Februar 2015, 06:40:03 schrieb Al Viro: Hi Al, > From: Al Viro > > With that, all ->sendmsg() instances are converted to iov_iter primitives > and are agnostic wrt the kind of iov_iter they are working with. > So's the last remaining ->recvmsg() instance that wasn't kind-agnosti

[PATCH v3 12/18] crypto: switch af_alg_make_sg() to iov_iter

2015-02-03 Thread Al Viro
From: Al Viro With that, all ->sendmsg() instances are converted to iov_iter primitives and are agnostic wrt the kind of iov_iter they are working with. So's the last remaining ->recvmsg() instance that wasn't kind-agnostic yet. All ->sendmsg() and ->recvmsg() advance ->msg_iter by the amount act