Re: [patch] crypto: omap-sham - potential Oops on error in probe

2016-05-19 Thread Herbert Xu
On Wed, May 18, 2016 at 01:39:05PM +0300, Dan Carpenter wrote: > This if statement is reversed so we end up either leaking or Oopsing on > error. > > Fixes: dbe246209bc1 ('crypto: omap-sham - Use dma_request_chan() for > requesting DMA channel') > Signed-off-by: Dan Carpenter Patch applied. Th

Re: [patch] crypto: omap-sham - potential Oops on error in probe

2016-05-18 Thread Peter Ujfalusi
On 05/18/16 14:44, Dan Carpenter wrote: > On Wed, May 18, 2016 at 01:42:36PM +0300, Peter Ujfalusi wrote: >> On 05/18/16 13:39, Dan Carpenter wrote: >>> This if statement is reversed so we end up either leaking or Oopsing on >>> error. >> >> Oops, sorry for that. >> Probably the other omap-* crypto

Re: [patch] crypto: omap-sham - potential Oops on error in probe

2016-05-18 Thread Dan Carpenter
On Wed, May 18, 2016 at 01:42:36PM +0300, Peter Ujfalusi wrote: > On 05/18/16 13:39, Dan Carpenter wrote: > > This if statement is reversed so we end up either leaking or Oopsing on > > error. > > Oops, sorry for that. > Probably the other omap-* crypto drivers have the same issue? Can you send a

Re: [patch] crypto: omap-sham - potential Oops on error in probe

2016-05-18 Thread Peter Ujfalusi
On 05/18/16 13:39, Dan Carpenter wrote: > This if statement is reversed so we end up either leaking or Oopsing on > error. Oops, sorry for that. Probably the other omap-* crypto drivers have the same issue? Can you send a patch for them or should I do it? Acked-by: Peter Ujfalusi > Fixes: dbe24

[patch] crypto: omap-sham - potential Oops on error in probe

2016-05-18 Thread Dan Carpenter
This if statement is reversed so we end up either leaking or Oopsing on error. Fixes: dbe246209bc1 ('crypto: omap-sham - Use dma_request_chan() for requesting DMA channel') Signed-off-by: Dan Carpenter diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c index 6eefaa2..63464e8 1