[PATCH] crypto: replace FSF address with web source in license notices

2017-11-14 Thread Martin Kepplinger
A few years ago the FSF moved and "59 Temple Place" is wrong. Having this still in our source files feels old and unmaintained. Let's take the license statement serious and not confuse users. As https://www.gnu.org/licenses/gpl-howto.html suggests, we replace the postal address with "

Re: [PATCH 07/24] staging: ccree: remove unneeded cast

2017-11-14 Thread Gilad Ben-Yossef
On Mon, Nov 13, 2017 at 5:41 PM, Joe Perches wrote: > > On Mon, 2017-11-13 at 14:45 +, Gilad Ben-Yossef wrote: > > Remove uneeded cast from writel_relaxed parameter. > [] > > diff --git a/drivers/staging/ccree/ssi_request_mgr.c > > b/drivers/staging/ccree/ssi_request_mgr.c > [] > > @@ -167,13

Re: [PATCH 00/24] staging: ccree: more cleanup patches

2017-11-14 Thread Gilad Ben-Yossef
On Mon, Nov 13, 2017 at 8:33 PM, Dan Carpenter wrote: > These cleanups look nice. Thanks. > > I hope you do a mass remove of likely/unlikely in a patch soon. > Whenever, I see one of those in a + line I always have to remind myself > that you're planning to do it in a later patch. > So, a questi

Re: [PATCH 00/24] staging: ccree: more cleanup patches

2017-11-14 Thread Dan Carpenter
On Tue, Nov 14, 2017 at 11:33:20AM +0200, Gilad Ben-Yossef wrote: > On Mon, Nov 13, 2017 at 8:33 PM, Dan Carpenter > wrote: > > These cleanups look nice. Thanks. > > > > I hope you do a mass remove of likely/unlikely in a patch soon. > > Whenever, I see one of those in a + line I always have to

Re: [PATCH 1/2] crypto: tcrypt - fix S/G table for test_aead_speed()

2017-11-14 Thread Horia Geantă
On 11/13/2017 8:24 PM, Tudor Ambarus wrote: > Hi, > > On 10/10/2017 01:21 PM, Robert Baronescu wrote: >> In case buffer length is a multiple of PAGE_SIZE, >> the S/G table is incorrectly generated. >> Fix this by handling buflen = k * PAGE_SIZE separately. >> >> Signed-off-by: Robert Baronescu >>

Re: [PATCH 1/2] crypto: tcrypt - fix S/G table for test_aead_speed()

2017-11-14 Thread Horia Geantă
On 11/13/2017 8:28 PM, Tudor Ambarus wrote: > Hi, > > On 11/12/2017 06:26 PM, Horia Geantă wrote: > >> -sg[0] - (1 entry) reserved for associated data, filled outside >> sg_init_aead() > > Let's fill the sg[0] with aad inside sg_init_aead()! > This could be done, however I would not mix fixes w

Re: [PATCH 1/2] crypto: tcrypt - fix S/G table for test_aead_speed()

2017-11-14 Thread Herbert Xu
On Sun, Nov 12, 2017 at 04:26:39PM +, Horia Geantă wrote: > > SG table always has 1 entry more than what's needed strictly for input data. > > Let's say buflen = npo * PAGE_SIZE. > SG table generated by the code will have npo + 1 entries: > -sg[0] - (1 entry) reserved for associated data, fill

Re: [1/2] crypto/nx: Use percpu send window for NX requests

2017-11-14 Thread Michael Ellerman
On Mon, 2017-09-25 at 06:43:02 UTC, Haren Myneni wrote: > [PATCH 1/2] crypto/nx: Use percpu send window for NX requests > > For P9 NX, the send window is opened for each crypto session and closed > upon free. But VAS supports 64K windows per chip for all coprocessors > including in user space supp

[PATCH] crypto/nx: fix spelling mistake: "availavle" -> "available"

2017-11-14 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in pr_err error message text Signed-off-by: Colin Ian King --- drivers/crypto/nx/nx-842-powernv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/nx/nx-842-powernv.c b/drivers/crypto/nx/nx-842-powernv.c in

Re: [PATCH] crypto/nx: fix spelling mistake: "availavle" -> "available"

2017-11-14 Thread Julia Lawall
On Tue, 14 Nov 2017, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in pr_err error message text > > Signed-off-by: Colin Ian King > --- > drivers/crypto/nx/nx-842-powernv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/crypto/n

[PATCH][V2] crypto/nx: fix spelling mistake: "availavle" -> "available"

2017-11-14 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in pr_err error message text. Also fix spelling mistake in proceeding comment. Signed-off-by: Colin Ian King --- drivers/crypto/nx/nx-842-powernv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/nx/nx-

Re: [PATCH] crypto/nx: fix spelling mistake: "availavle" -> "available"

2017-11-14 Thread Colin Ian King
On 14/11/17 13:45, Julia Lawall wrote: > > > On Tue, 14 Nov 2017, Colin King wrote: > >> From: Colin Ian King >> >> Trivial fix to spelling mistake in pr_err error message text >> >> Signed-off-by: Colin Ian King >> --- >> drivers/crypto/nx/nx-842-powernv.c | 2 +- >> 1 file changed, 1 insert

Re: [PATCH v3] tpm: use struct tpm_chip for tpm_chip_find_get()

2017-11-14 Thread Jarkko Sakkinen
On Sun, Nov 12, 2017 at 10:53:35AM +0530, PrasannaKumar Muralidharan wrote: > Did basic check on tpm rng patch, it works fine. As it depends on this > patch this should be working fine too. > > Tested-by: PrasannaKumar Muralidharan > > Regards, > PrasannaKumar Thank you. /Jarkko

Re: [PATCH v2] tpm: Move Linux RNG connection to hwrng

2017-11-14 Thread Jarkko Sakkinen
On Tue, Nov 07, 2017 at 09:04:04AM -0700, Jason Gunthorpe wrote: > On Tue, Nov 07, 2017 at 08:50:44AM +0530, PrasannaKumar Muralidharan wrote: > > > I am assuming you are talking about the following patches - using > > struct tpm_chip instead of chip number and this patch. > > yes > > > I won't

[PATCH] crypto: tcrypt - set assoc in sg_init_aead()

2017-11-14 Thread Tudor Ambarus
Results better code readability. Signed-off-by: Tudor Ambarus --- Should be applied after: crypto: tcrypt - fix S/G table for test_aead_speed() crypto/tcrypt.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c index 3ced1b

Re: [PATCH][V2] crypto/nx: fix spelling mistake: "availavle" -> "available"

2017-11-14 Thread Haren Myneni
Sorry for my mistake. Thanks. Acked-by: Haren Myneni On 11/14/2017 06:32 AM, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in pr_err error message text. Also > fix spelling mistake in proceeding comment. > > Signed-off-by: Colin Ian King > --- > drivers/cryp

Re: [PATCH][V2] crypto/nx: fix spelling mistake: "availavle" -> "available"

2017-11-14 Thread Gabriel Paubert
On Tue, Nov 14, 2017 at 02:32:17PM +, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in pr_err error message text. Also > fix spelling mistake in proceeding comment. s/proceeding/preceding/ ? > > Signed-off-by: Colin Ian King > --- > drivers/crypto/nx/nx-842

Re: [PATCH 00/24] staging: ccree: more cleanup patches

2017-11-14 Thread Gilad Ben-Yossef
On Tue, Nov 14, 2017 at 11:48 AM, Dan Carpenter wrote: > On Tue, Nov 14, 2017 at 11:33:20AM +0200, Gilad Ben-Yossef wrote: >> On Mon, Nov 13, 2017 at 8:33 PM, Dan Carpenter >> wrote: >> > These cleanups look nice. Thanks. >> > >> > I hope you do a mass remove of likely/unlikely in a patch soon.