[PATCH] mm/maccess.c: Fix up kernel doc notation

2017-02-16 Thread Stephen Boyd
One argument was incorrect, two functions weren't showing the brief description, and the docs for strncpy_from_unsafe() had a colon attached to it. Fix it up. Cc: Signed-off-by: Stephen Boyd --- mm/maccess.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [PATCH v5 5/9] coresight: use const for device_node structures

2017-04-04 Thread Stephen Boyd
On 03/26, Leo Yan wrote: > Almost low level functions from open firmware have used const to > qualify device_node structures, so add const for device_node > parameters in of_coresight related functions. > > Signed-off-by: Leo Yan > --- Reviewed-by: Stephen Boyd -- Qualcomm

Re: [PATCH v5 7/9] clk: hi6220: add debug APB clock

2017-04-04 Thread Stephen Boyd
On 03/26, Leo Yan wrote: > The debug APB clock is absent in hi6220 driver, so this patch is to add > support for it. > > Signed-off-by: Leo Yan > --- Applied to clk-next. I suspect we don't need a topic branch for the DT header because arm-soc won't be taking the dts side of the changes? -- Qu

[PATCH] of: Document exactly what of_find_node_by_name() puts

2017-11-10 Thread Stephen Boyd
It isn't clear if this function of_node_put()s the 'from' argument, or the node it finds in the search. Clearly indicate which variable is touched. Signed-off-by: Stephen Boyd --- drivers/of/base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/b

Re: [PATCH] of: Document exactly what of_find_node_by_name() puts

2017-11-16 Thread Stephen Boyd
On 11/10, Randy Dunlap wrote: > On 11/10/2017 05:45 PM, Stephen Boyd wrote: > > It isn't clear if this function of_node_put()s the 'from' > > argument, or the node it finds in the search. Clearly indicate > > which variable is touched. > > > > Sign

[PATCHv2] of: Document exactly what of_find_node_by_name() puts

2017-11-17 Thread Stephen Boyd
It isn't clear if this function of_node_put()s the 'from' argument, or the node it searches. Clearly indicate which variable is touched. Fold in some more fixes from Randy too because we're in the area. Cc: Randy Dunlap Signed-off-by: Stephen Boyd --- Changes from v1: * F

Re: [PATCH v5 05/46] pwm: introduce the pwm_args concept

2016-03-30 Thread Stephen Boyd
On 03/30, Boris Brezillon wrote: > @@ -74,6 +74,23 @@ enum pwm_polarity { > PWM_POLARITY_INVERSED, > }; > > +/** > + * struct pwm_args - PWM arguments > + * @period: reference period > + * @polarity: reference polarity > + * > + * This structure describe board-dependent arguments attached

Re: [PATCH v5 07/46] clk: pwm: use pwm_get_args() where appropriate

2016-03-30 Thread Stephen Boyd
gt; config and not the current state. > > This is part of the rework allowing the PWM framework to support > hardware readout and expose real PWM state even when the PWM has > just been requested (before the user calls pwm_config/enable/disable()). > > Signed-off-by: Boris Brez

Re: [PATCH v5 34/46] clk: pwm: switch to the atomic API

2016-03-30 Thread Stephen Boyd
On 03/30, Boris Brezillon wrote: > diff --git a/drivers/clk/clk-pwm.c b/drivers/clk/clk-pwm.c > index ebcd738..49ec5b1 100644 > --- a/drivers/clk/clk-pwm.c > +++ b/drivers/clk/clk-pwm.c > @@ -28,15 +28,29 @@ static inline struct clk_pwm *to_clk_pwm(struct clk_hw > *hw) > static int clk_pwm_prepar

Re: [PATCH v8 01/26] dt-bindings: ingenic: Add DT bindings for TCU clocks

2018-12-17 Thread Stephen Boyd
Quoting Paul Cercueil (2018-12-12 14:08:56) > This header provides clock numbers for the ingenic,tcu > DT binding. > > Signed-off-by: Paul Cercueil > Reviewed-by: Rob Herring > --- Acked-by: Stephen Boyd

Re: [PATCH 0/6] Coordinated Clks

2018-12-20 Thread Stephen Boyd
Quoting Derek Basehore (2018-10-23 18:31:26) > Here's the first set of patches that I'm working on for the Common > Clk Framework. Part of this patch series adds a new clk op, > pre_rate_req. This is designed to replace the clk notifier approach > that many clk drivers use right now to setup alt pa

Re: [PATCH v8 05/26] clocksource: Add driver for the Ingenic JZ47xx OST

2019-01-24 Thread Stephen Boyd
Quoting Guenter Roeck (2019-01-23 10:01:55) > On Wed, Jan 23, 2019 at 02:25:53PM -0300, Paul Cercueil wrote: > > Hi, > > > > Le mer. 23 janv. 2019 à 11:31, Guenter Roeck a écrit > > : > > >On 1/23/19 4:58 AM, Mathieu Malaterre wrote: > > >>On Wed, Dec 12, 2018 at 11:09 PM Paul Cercueil > > >>

Re: [PATCH v8 05/26] clocksource: Add driver for the Ingenic JZ47xx OST

2019-01-24 Thread Stephen Boyd
Quoting Paul Cercueil (2019-01-24 12:46:28) > > > Le jeu. 24 janv. 2019 à 16:28, Stephen Boyd a > écrit : > > Quoting Guenter Roeck (2019-01-23 10:01:55) > >> On Wed, Jan 23, 2019 at 02:25:53PM -0300, Paul Cercueil wrote: > >> > Hi, > >> &

Re: [PATCH v7 0/3] clk: clkdev add managed lookup registrations

2019-01-31 Thread Stephen Boyd
Quoting Russell King - ARM Linux admin (2019-01-31 07:21:47) > On Thu, Jan 31, 2019 at 03:24:52PM +0200, Matti Vaittinen wrote: > > Hello All, > > > > On Fri, Dec 07, 2018 at 01:09:00PM +0200, Matti Vaittinen wrote: > > > Series adds managed clkdev lookup interfaces and cleans few drivers > > > >

Re: [PATCH v7 1/3] clkdev: add managed clkdev lookup registration

2019-02-06 Thread Stephen Boyd
Quoting Matti Vaittinen (2018-12-07 03:09:39) > Clkdev registration lacks of managed registration functions and it > seems few drivers do not drop clkdev lookups at exit. Add > devm_clk_hw_register_clkdev and devm_clk_release_clkdev to ease lookup > releasing at exit. > > Signed-off-by: Matti Vait

Re: [PATCH v7 2/3] clk: clk-max77686: Clean clkdev lookup leak and use devm

2019-02-06 Thread Stephen Boyd
Quoting Matti Vaittinen (2018-12-07 03:10:15) > clk-max77686 never clean clkdev lookup at remove. This can cause > oops if clk-max77686 is removed and inserted again. Fix leak by > using new devm clkdev lookup registration. Simplify also error > path by using new devm_of_clk_add_hw_provider. > > S

Re: [PATCH v7 3/3] clk: clk-st: avoid clkdev lookup leak at remove

2019-02-06 Thread Stephen Boyd
Quoting Matti Vaittinen (2018-12-07 03:10:51) > Use devm based clkdev lookup registration to avoid leaking lookup > structures. > > Signed-off-by: Matti Vaittinen > --- Applied to clk-next

Re: [PATCH v8 05/26] clocksource: Add driver for the Ingenic JZ47xx OST

2019-02-25 Thread Stephen Boyd
Quoting Paul Cercueil (2019-02-22 19:17:25) > Hi, > > Anything new on this? It still happens on 5.0-rc7. > It probes with late_initcall, and not with device_initcall. > I have no clue what's going on. > I'm not sure what's going on either. You'll probably have to debug when the device is created

Re: [PATCH v9 14/27] pwm: jz4740: Improve algorithm of clock calculation

2019-02-28 Thread Stephen Boyd
Quoting Paul Cercueil (2019-02-22 17:17:58) > Bump. > > What should I do here? > I thought I replied to the list but maybe it got rejected because my MUA is currently failing hard at sending 8-bit mails without using quoted printable. Let me remove all non-ascii characters from this mail! If so

Re: [PATCH v2 1/6] clk: Remove recursion in clk_core_{prepare,enable}()

2019-03-05 Thread Stephen Boyd
Quoting Derek Basehore (2019-03-04 20:49:31) > From: Stephen Boyd > > Enabling and preparing clocks can be written quite naturally with > recursion. We start at some point in the tree and recurse up the > tree to find the oldest parent clk that needs to be enabled or > prepar

Re: [PATCH v4 01/18] kunit: test: add KUnit test runner core

2019-05-16 Thread Stephen Boyd
Quoting Brendan Higgins (2019-05-14 15:16:54) > diff --git a/include/kunit/test.h b/include/kunit/test.h > new file mode 100644 > index 0..e682ea0e1f9a5 > --- /dev/null > +++ b/include/kunit/test.h > @@ -0,0 +1,162 @@ [..] > +/** > + * struct kunit - represents a running instance of a t

Re: [PATCH v4 02/18] kunit: test: add test resource management API

2019-05-16 Thread Stephen Boyd
Quoting Brendan Higgins (2019-05-14 15:16:55) > diff --git a/kunit/test.c b/kunit/test.c > index 86f65ba2bcf92..a15e6f8c41582 100644 > --- a/kunit/test.c > +++ b/kunit/test.c [..] > + > +void *kunit_kmalloc(struct kunit *test, size_t size, gfp_t gfp) > +{ > + struct kunit_kmalloc_params param

Re: [PATCH v4 03/18] kunit: test: add string_stream a std::stream like string builder

2019-05-17 Thread Stephen Boyd
Quoting Brendan Higgins (2019-05-14 15:16:56) > A number of test features need to do pretty complicated string printing > where it may not be possible to rely on a single preallocated string > with parameters. > > So provide a library for constructing the string as you go similar to > C++'s std::s

Re: [PATCH v4 04/18] kunit: test: add kunit_stream a std::stream like logger

2019-05-17 Thread Stephen Boyd
Quoting Brendan Higgins (2019-05-14 15:16:57) > diff --git a/kunit/kunit-stream.c b/kunit/kunit-stream.c > new file mode 100644 > index 0..1884f1b550888 > --- /dev/null > +++ b/kunit/kunit-stream.c > @@ -0,0 +1,152 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * C++ stream style s

Re: [PATCH v4 17/18] kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec()

2019-05-17 Thread Stephen Boyd
Quoting Brendan Higgins (2019-05-14 15:17:10) > diff --git a/kernel/sysctl-test.c b/kernel/sysctl-test.c > new file mode 100644 > index 0..fe0f2bae66085 > --- /dev/null > +++ b/kernel/sysctl-test.c > @@ -0,0 +1,293 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * KUnit test of proc

Re: [PATCH v4 01/18] kunit: test: add KUnit test runner core

2019-05-17 Thread Stephen Boyd
Quoting Brendan Higgins (2019-05-14 15:16:54) > diff --git a/include/kunit/test.h b/include/kunit/test.h > new file mode 100644 > index 0..e682ea0e1f9a5 > --- /dev/null > +++ b/include/kunit/test.h > @@ -0,0 +1,162 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Base unit test

Re: [PATCH v12 05/13] clk: ingenic: Add driver for the TCU clocks

2019-06-07 Thread Stephen Boyd
Quoting Paul Cercueil (2019-05-21 07:51:33) > diff --git a/drivers/clk/ingenic/Kconfig b/drivers/clk/ingenic/Kconfig > index 34dc0da79c39..434893133eb4 100644 > --- a/drivers/clk/ingenic/Kconfig > +++ b/drivers/clk/ingenic/Kconfig > @@ -1,4 +1,4 @@ > -menu "Ingenic JZ47xx CGU drivers" > +menu "Inge

Re: [PATCH v12 05/13] clk: ingenic: Add driver for the TCU clocks

2019-06-07 Thread Stephen Boyd
Quoting Paul Cercueil (2019-06-07 14:59:54) > Hi Stephen, thanks for the review. > > Quoting Paul Cercueil (2019-05-21 07:51:33) > >> diff --git a/drivers/clk/ingenic/tcu.c b/drivers/clk/ingenic/tcu.c > >> new file mode 100644 > >> index ..7249225a6994 > >> --- /dev/null > >> +++ b

Re: [PATCH 1/6] clk: Remove recursion in clk_core_{prepare,enable}()

2018-10-24 Thread Stephen Boyd
Quoting Derek Basehore (2018-10-23 18:31:27) > From: Stephen Boyd > > Enabling and preparing clocks can be written quite naturally with > recursion. We start at some point in the tree and recurse up the > tree to find the oldest parent clk that needs to be enabled or > prepar

Re: [PATCH 2/2] clk: bd718x7: Initial support for ROHM bd71837/bd71847 PMIC clock

2018-11-12 Thread Stephen Boyd
Quoting Matti Vaittinen (2018-11-11 23:45:53) > Hello Stephen & All, > > On Mon, Sep 03, 2018 at 09:38:43AM +0300, Matti Vaittinen wrote: > > > > On Sat, Sep 01, 2018 at 12:13:26PM -0700, Stephen Boyd wrote: > > > Quoting Matti Vaittinen (2018

Re: [PATCH v4 1/8] clk: clkdev/of_clk - add managed lookup and provider registrations

2018-11-30 Thread Stephen Boyd
Quoting Matti Vaittinen (2018-11-13 03:55:58) > With MFD devices the clk properties may be contained in MFD (parent) DT > node. Current devm_of_clk_add_hw_provider assumes the clk is bound to MFD > subdevice not to MFD device (parent). Add > devm_of_clk_add_hw_provider_parent to tackle this issue.

Re: [PATCH v4 1/8] clk: clkdev/of_clk - add managed lookup and provider registrations

2018-12-03 Thread Stephen Boyd
Quoting Matti Vaittinen (2018-11-30 02:50:22) > Hello Stephen, > > Thanks a bunch for taking the time and reviewing this! > > On Fri, Nov 30, 2018 at 12:54:10AM -0800, Stephen Boyd wrote: > > Quoting Matti Vaittinen (2018-11-13 03:55:58) > > > With MFD devices the c

Re: [PATCH v4 1/8] clk: clkdev/of_clk - add managed lookup and provider registrations

2018-12-04 Thread Stephen Boyd
Quoting Matti Vaittinen (2018-12-03 23:13:15) > On Mon, Dec 03, 2018 at 03:35:10PM -0800, Stephen Boyd wrote: > > > If the DT doesn't have the #clock-cells property in the node being > > registered then calling clk_get() will fail for any consumer devices > > that poi

Re: [PATCH v6 03/10] clk: of-provider: look at parent if registered device has no provider info

2018-12-04 Thread Stephen Boyd
Quoting Matti Vaittinen (2018-12-04 03:34:53) > It seems to be usual for MFD devices that the created 'clock sub-device' > do not have own DT node. The clock provider information is usually in the > main device node which is owned by the MFD device. Change the devm variant > of clk of-provider regi

Re: [PATCH v6 02/10] clk: Add kerneldoc to managed of-provider interfaces

2018-12-04 Thread Stephen Boyd
Quoting Matti Vaittinen (2018-12-04 03:33:48) > Document the devm_of_clk_del_provider and the > devm_of_clk_add_hw_provider functions. > > Signed-off-by: Matti Vaittinen > --- Applied to clk-next

Re: [PATCH v6 03/10] clk: of-provider: look at parent if registered device has no provider info

2018-12-05 Thread Stephen Boyd
Quoting Matti Vaittinen (2018-12-04 23:00:46) > Hello Stephen, > > I copied some parts of the v4 discussion here as well. Let's continue > them under this one email thread. (and yep, this is my bad we now have > multiple email threads - I did these new patches without waiting for > the final concl

Re: [PATCH v6 06/10] clk: clk-hi655x: Free of_provider at remove

2018-12-05 Thread Stephen Boyd
Quoting Matti Vaittinen (2018-12-04 03:37:29) > use devm variant for of_provider registration so provider is freed > at exit. > > Signed-off-by: Matti Vaittinen > --- Applied to clk-next

Re: [PATCH v6 07/10] clk: rk808: use managed version of of_provider registration

2018-12-05 Thread Stephen Boyd
Quoting Matti Vaittinen (2018-12-04 03:38:03) > Simplify clean-up for rk808 by using managed version of of_provider > registration. > > Signed-off-by: Matti Vaittinen > --- Applied to clk-next

Re: [PATCH v6 09/10] clk: apcs-msm8916: simplify probe cleanup by using devm

2018-12-05 Thread Stephen Boyd
Quoting Matti Vaittinen (2018-12-04 03:39:06) > use devm variant for of_provider registration. > > Signed-off-by: Matti Vaittinen > --- Applied to clk-next

Re: [PATCH v6 08/10] clk: clk-twl6040: Free of_provider at remove

2018-12-05 Thread Stephen Boyd
Quoting Matti Vaittinen (2018-12-04 03:38:32) > use devm variant for of_provider registration so provider is freed > at exit. > > Signed-off-by: Matti Vaittinen > Acked-by: Peter Ujfalusi > --- Applied to clk-next

Re: [PATCH v6 10/10] clk: bd718x7: Initial support for ROHM bd71837/bd71847 PMIC clock

2018-12-05 Thread Stephen Boyd
Quoting Matti Vaittinen (2018-12-04 03:39:38) > diff --git a/drivers/clk/clk-bd718x7.c b/drivers/clk/clk-bd718x7.c > new file mode 100644 > index ..d486859526ed > --- /dev/null > +++ b/drivers/clk/clk-bd718x7.c > @@ -0,0 +1,131 @@ > +// SPDX-License-Identifier: GPL-2.0 > +// Copyright (

Re: [PATCH v6 03/10] clk: of-provider: look at parent if registered device has no provider info

2018-12-05 Thread Stephen Boyd
Quoting Matti Vaittinen (2018-12-05 10:20:58) > On Wed, Dec 05, 2018 at 09:19:33AM -0800, Stephen Boyd wrote: > > Quoting Matti Vaittinen (2018-12-04 23:00:46) > > > But that won't solve the issue if we don't do "dirty hacks" in driver. > > > The de

Re: [PATCH v13 05/13] clk: ingenic: Add driver for the TCU clocks

2019-06-25 Thread Stephen Boyd
Quoting Paul Cercueil (2019-06-24 15:57:51) > diff --git a/drivers/clk/ingenic/tcu.c b/drivers/clk/ingenic/tcu.c > new file mode 100644 > index ..6d667c4a2bd5 > --- /dev/null > +++ b/drivers/clk/ingenic/tcu.c > @@ -0,0 +1,473 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * JZ47xx

Re: [PATCH v13 05/13] clk: ingenic: Add driver for the TCU clocks

2019-06-25 Thread Stephen Boyd
Quoting Paul Cercueil (2019-06-25 15:37:07) > > > > Do you need to get the clk by name? Or can that clk be "known" to the > > TCU somehow so we can already have a direct clk pointer? > > This clock is provided by a separate driver, so I have to obtain the > clock pointer from devicetree. Ok. >

[PATCH] idr: Document calling context for IDA APIs mustn't use locks

2019-07-30 Thread Stephen Boyd
uires. Furthermore, let's document ida_simple_get() with the same information so that callers know how this API works. Cc: Greg KH Cc: Tri Vo Cc: linux-doc@vger.kernel.org Cc: Jonathan Corbet Signed-off-by: Stephen Boyd --- See Greg's comment[1] for the reason why this patch is crea

Re: [PATCH] idr: Document calling context for IDA APIs mustn't use locks

2019-07-30 Thread Stephen Boyd
Quoting Matthew Wilcox (2019-07-30 14:12:50) > On Tue, Jul 30, 2019 at 02:07:52PM -0700, Stephen Boyd wrote: > > The documentation for these functions indicates that callers don't need > > to hold a lock while calling them, but that documentation is only in one > > plac

[PATCH v2 1/2] idr: Document calling context for IDA APIs mustn't use locks

2019-07-30 Thread Stephen Boyd
uires. Furthermore, let's document ida_simple_get() with the same information so that callers know how this API works. Cc: Greg KH Cc: Tri Vo Cc: Jonathan Corbet Cc: linux-doc@vger.kernel.org Signed-off-by: Stephen Boyd --- include/linux/idr.h | 9 ++--- lib/idr.c | 9

[PATCH v2 2/2] idr: Document that ida_simple_{get,remove}() are deprecated

2019-07-30 Thread Stephen Boyd
These two functions are deprecated. Users should call ida_alloc() or ida_free() respectively instead. Add documentation to this effect until the macro can be removed. Cc: Greg KH Cc: Tri Vo Cc: Jonathan Corbet Cc: linux-doc@vger.kernel.org Signed-off-by: Stephen Boyd --- include/linux/idr.h

Re: [PATCH v15 05/13] clk: ingenic: Add driver for the TCU clocks

2019-08-08 Thread Stephen Boyd
Quoting Paul Cercueil (2019-07-24 10:16:07) > Add driver to support the clocks provided by the Timer/Counter Unit > (TCU) of the JZ47xx SoCs from Ingenic. > > Signed-off-by: Paul Cercueil > Tested-by: Mathieu Malaterre > Tested-by: Artur Rojek > --- Acked-by: Stephen Boyd

[PATCH] devicetree: Expose dtbs_check and dt_binding_check some more

2019-08-13 Thread Stephen Boyd
. Cc: Masahiro Yamada Cc: Cc: Cc: Signed-off-by: Stephen Boyd --- I didn't find this sent, so sending again! Documentation/devicetree/writing-schema.md | 1 + Makefile | 6 -- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/Docu

Re: [PATCH] devicetree: Expose dtbs_check and dt_binding_check some more

2019-08-13 Thread Stephen Boyd
Quoting Rob Herring (2019-08-13 15:32:48) > On Tue, Aug 13, 2019 at 12:38 PM Stephen Boyd wrote: > > > > It wasn't obvious that this was a command to run based on 'make help', > > so add it to the top-level help for devicetree builds. Also, add an > >

Re: [PATCH v13 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-08-14 Thread Stephen Boyd
Quoting Brendan Higgins (2019-08-14 03:03:47) > On Tue, Aug 13, 2019 at 10:52 PM Brendan Higgins > wrote: > > > > ## TL;DR > > > > This revision addresses comments from Stephen and Bjorn Helgaas. Most > > changes are pretty minor stuff that doesn't affect the API in anyway. > > One significant cha

Re: [PATCH v3 2/4] soc: qcom: Add GENI based QUP Wrapper driver

2018-03-02 Thread Stephen Boyd
Quoting Karthikeyan Ramasubramanian (2018-02-27 17:38:07) > This driver manages the Generic Interface (GENI) firmware based Qualcomm > Universal Peripheral (QUP) Wrapper. GENI based QUP is the next generation > programmable module composed of multiple Serial Engines (SE) and supports > a wide range

Re: [PATCH v3 4/4] tty: serial: msm_geni_serial: Add serial driver support for GENI based QUP

2018-03-02 Thread Stephen Boyd
Quoting Karthikeyan Ramasubramanian (2018-02-27 17:38:09) > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig > index 3682fd3..c6b1500 100644 > --- a/drivers/tty/serial/Kconfig > +++ b/drivers/tty/serial/Kconfig > @@ -1104,6 +1104,17 @@ config SERIAL_MSM_CONSOLE > select

Re: [PATCH v3 4/4] tty: serial: msm_geni_serial: Add serial driver support for GENI based QUP

2018-03-06 Thread Stephen Boyd
Quoting Karthik Ramasubramanian (2018-03-05 16:51:23) > On 3/2/2018 3:11 PM, Stephen Boyd wrote: > > Quoting Karthikeyan Ramasubramanian (2018-02-27 17:38:09) > > > >> + size_t chars_to_write = 0; > >> + size_t avail =

Re: [PATCH v3 2/4] soc: qcom: Add GENI based QUP Wrapper driver

2018-03-06 Thread Stephen Boyd
Quoting Karthik Ramasubramanian (2018-03-02 16:58:23) > > > On 3/2/2018 1:41 PM, Stephen Boyd wrote: > > Quoting Karthikeyan Ramasubramanian (2018-02-27 17:38:07) > >> + > >> +/** > >> + * geni_se_get_qup_hw_version() - Read the

Re: [PATCH v3 4/4] tty: serial: msm_geni_serial: Add serial driver support for GENI based QUP

2018-03-08 Thread Stephen Boyd
Quoting Karthik Ramasubramanian (2018-03-07 22:06:29) > > > On 3/6/2018 2:45 PM, Stephen Boyd wrote: > > Quoting Karthik Ramasubramanian (2018-03-05 16:51:23) > >> On 3/2/2018 3:11 PM, Stephen Boyd wrote: > > > > Ok. I've seen similar designs in some m

Re: [PATCH 1/1] Documentation: clk: enable lock is not held for clk_is_enabled API

2018-03-16 Thread Stephen Boyd
Quoting Dong Aisheng (2018-01-19 05:37:15) > The core does not need to hold enable lock for clk_is_enabled API. > Update the doc to reflect it. > > Cc: Jonathan Corbet > Cc: Stephen Boyd > Suggested-by: Stephen Boyd > Signed-off-by: Dong Aisheng > --- Applied to clk

Re: [PATCH v4 2/8] dt-bindings: ingenic: Add DT bindings for TCU clocks

2018-03-19 Thread Stephen Boyd
Quoting Paul Cercueil (2018-03-17 16:28:55) > This header provides clock numbers for the ingenic,tcu > DT binding. > > Signed-off-by: Paul Cercueil > Reviewed-by: Rob Herring > --- Acked-by: Stephen Boyd -- To unsubscribe from this list: send the line "unsubscribe linu

Re: [PATCH v4 6/6] arm64: dts: sdm845: Add I2C controller support

2018-03-20 Thread Stephen Boyd
Quoting Doug Anderson (2018-03-19 16:56:27) > On Mon, Mar 19, 2018 at 3:15 PM, Sagar Dharia wrote: > > > > Yes, we typically have a "platform(sdm845 here)-qupv3.dtsi" defining > > most of the serial-bus instances (i2c, spi, and uart with > > status=disabled) that we include from the common header.

Re: [PATCH v4 4/6] tty: serial: msm_geni_serial: Add serial driver support for GENI based QUP

2018-03-20 Thread Stephen Boyd
Quoting Karthikeyan Ramasubramanian (2018-03-14 16:58:49) > diff --git a/drivers/tty/serial/qcom_geni_serial.c > b/drivers/tty/serial/qcom_geni_serial.c > new file mode 100644 > index 000..1442777 > --- /dev/null > +++ b/drivers/tty/serial/qcom_geni_serial.c > @@ -0,0 +1,1158 @@ > + > +#ifdef

Re: [PATCH v4 1/6] dt-bindings: soc: qcom: Add device tree binding for GENI SE

2018-03-20 Thread Stephen Boyd
Quoting Karthikeyan Ramasubramanian (2018-03-14 16:58:46) > Add device tree binding support for the QCOM GENI SE driver. > > Signed-off-by: Karthikeyan Ramasubramanian > Signed-off-by: Sagar Dharia > Signed-off-by: Girish Mahadevan Assuming Rob's comment is addressed:

Re: [PATCH v4 5/6] arm64: dts: sdm845: Add serial console support

2018-03-20 Thread Stephen Boyd
Quoting Karthikeyan Ramasubramanian (2018-03-14 16:58:50) > diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts > b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts > index 979ab49..ea3efc5 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts > @@ -12,4 +1

Re: [PATCH v4 4/6] tty: serial: msm_geni_serial: Add serial driver support for GENI based QUP

2018-03-21 Thread Stephen Boyd
Quoting Karthik Ramasubramanian (2018-03-20 15:53:25) > > > On 3/20/2018 9:37 AM, Stephen Boyd wrote: > > Quoting Karthikeyan Ramasubramanian (2018-03-14 16:58:49) > >> diff --git a/drivers/tty/serial/qcom_geni_serial.c > >> b/drivers/tty/serial/qcom_geni_s

Re: [PATCH v11 3/6] of: property: Add functional dependency link from DT bindings

2019-09-11 Thread Stephen Boyd
Quoting Saravana Kannan (2019-09-04 14:11:22) > Add device links after the devices are created (but before they are > probed) by looking at common DT bindings like clocks and > interconnects. > > Automatically adding device links for functional dependencies at the > framework level provides the fo

Re: [PATCH v11 0/6] Solve postboot supplier cleanup and optimize probe ordering

2019-09-11 Thread Stephen Boyd
Quoting Saravana Kannan (2019-09-04 14:11:19) > v10->v11: > - Dropped 6/7 and 7/7 from previous series that tried to handle cycles in DT > dependencies. We can solve it later when we actually hit a real world issue > in DT. > - Added a new 1/7 that shifts the numbering for the rest of the patch

Re: [PATCH v2 1/2] idr: Document calling context for IDA APIs mustn't use locks

2019-10-03 Thread Stephen Boyd
Quoting Stephen Boyd (2019-07-30 14:20:47) > The documentation for these functions indicates that callers don't need > to hold a lock while calling them, but that documentation is only in one > place under "IDA Usage". Let's state the same information on each IDA >

Re: [PATCH v11 3/6] of: property: Add functional dependency link from DT bindings

2019-10-08 Thread Stephen Boyd
Quoting Greg Kroah-Hartman (2019-10-04 08:37:50) > On Wed, Sep 11, 2019 at 03:29:25AM -0700, Stephen Boyd wrote: > > Quoting Saravana Kannan (2019-09-04 14:11:22) > > > + int ret = 0; > > > + struct device_node *tmp_np = sup_np; > > >

Re: [PATCH v1 3/3] docs: driver-model: Add documentation for sync_state

2019-10-14 Thread Stephen Boyd
Quoting Saravana Kannan (2019-10-11 12:15:21) > The sync_state() driver callback was added recently, but the > documentation was missing. Adding it now. > > Signed-off-by: Saravana Kannan > --- > .../driver-api/driver-model/driver.rst| 43 +++ > 1 file changed, 43 insert

Re: [PATCH v11 3/6] of: property: Add functional dependency link from DT bindings

2019-10-16 Thread Stephen Boyd
Quoting Saravana Kannan (2019-10-08 11:57:49) > On Tue, Oct 8, 2019 at 7:53 AM Stephen Boyd wrote: > > > > Quoting Greg Kroah-Hartman (2019-10-04 08:37:50) > > > On Wed, Sep 11, 2019 at 03:29:25AM -0700, Stephen Boyd wrote: > > > > Quoting