Re: [PATCH 13/14] Pramfs: Write Protection

2009-06-17 Thread Paul Mundt
On Thu, Jun 18, 2009 at 08:24:35AM +0200, Marco Stornelli wrote: > 2009/6/18 Paul Mundt : > > H8300 is a nommu platform, so it has no TLB to flush. Yoshinori Sato is > > the maintainer. Consult the MAINTAINERS file, that's what it is there for. > > I know the MAINTAINERS file but for h8300 there i

Re: [PATCH 13/14] Pramfs: Write Protection

2009-06-17 Thread Marco Stornelli
2009/6/18 Paul Mundt : > On Wed, Jun 17, 2009 at 06:58:00PM +0200, Marco wrote: >> Jared Hulbert wrote: >> > > Why not just fix flush_tlb_range()? >> > > >> > > If an arch has a flush_tlb_kernel_page() that works then it stands to >> > > reason that the flush_tlb_kernel_range() shouldn't work with

Re: [PATCH 13/14] Pramfs: Write Protection

2009-06-17 Thread Paul Mundt
On Wed, Jun 17, 2009 at 06:58:00PM +0200, Marco wrote: > Jared Hulbert wrote: > > > Why not just fix flush_tlb_range()? > > > > > > If an arch has a flush_tlb_kernel_page() that works then it stands to > > > reason that the flush_tlb_kernel_range() shouldn't work with minimal > > > effort, no? > >

Re: [PATCH 13/14] Pramfs: Write Protection

2009-06-17 Thread Mike Frysinger
On Wed, Jun 17, 2009 at 12:58, Marco wrote: > Jared Hulbert wrote: >> > > +#if defined(CONFIG_ARM) || defined(CONFIG_M68K) || >> > > defined(CONFIG_H8300) || \ >> > > + ? ? ? defined(CONFIG_BLACKFIN) >> > > + ? ? ? /* >> > > + ? ? ? ?* FIXME: so far only these archs have flush_tlb_kernel_page(), >

Re: [PATCH 13/14] Pramfs: Write Protection

2009-06-17 Thread Marco
Jared Hulbert wrote: > > > +/* init_mm.page_table_lock must be held before calling! */ > > > +static void pram_page_writeable(unsigned long addr, int rw) > > > +{ > > > + ? ? ? pgd_t *pgdp; > > > + ? ? ? pud_t *pudp; > > > + ? ? ? pmd_t *pmdp; > > > + ? ? ? pte_t *ptep; > > > + > > > + ? ? ? pgdp =

Re: [PATCH 13/14] Pramfs: Write protection

2009-06-17 Thread Paul Mundt
On Tue, Jun 16, 2009 at 07:35:24PM -0700, Jared Hulbert wrote: > > +/* init_mm.page_table_lock must be held before calling! */ > > +static void pram_page_writeable(unsigned long addr, int rw) > > +{ > > + ? ? ? pgd_t *pgdp; > > + ? ? ? pud_t *pudp; > > + ? ? ? pmd_t *pmdp; > > + ? ? ? pte_t *ptep;

Re: [PATCH 13/14] Pramfs: Write protection

2009-06-16 Thread Jared Hulbert
> +/* init_mm.page_table_lock must be held before calling! */ > +static void pram_page_writeable(unsigned long addr, int rw) > +{ > +       pgd_t *pgdp; > +       pud_t *pudp; > +       pmd_t *pmdp; > +       pte_t *ptep; > + > +       pgdp = pgd_offset_k(addr); > +       if (!pgd_none(*pgdp)) { >

[PATCH 13/14] Pramfs: Write protection

2009-06-13 Thread Marco
From: Marco Stornelli Write protection. Signed-off-by: Marco Stornelli --- diff -uprN linux-2.6.30-orig/fs/pramfs/wprotect.c linux-2.6.30/fs/pramfs/wprotect.c --- linux-2.6.30-orig/fs/pramfs/wprotect.c 1970-01-01 01:00:00.0 +0100 +++ linux-2.6.30/fs/pramfs/wprotect.c 2009-06-1