Re: [PATCH 1/12] ext3 balloc: reset windowsz when full

2006-11-28 Thread Hugh Dickins
On Tue, 28 Nov 2006, Mingming Cao wrote: > Port a series ext2 balloc patches from Hugh to ext3/4. The first 6 > patches are against ext3, and the rest are aginst ext4. Thanks for all that, Mingming: whichever is appropriate, all twelve Acked-by: Hugh Dickins <[EMAIL PROTECTED]> or Signed-off-by:

[PATCH 9/12] ext4 balloc: fix off-by-one against rsv_end

2006-11-28 Thread Mingming Cao
-- Subject: ext2 balloc: fix off-by-one against rsv_end From: Hugh Dickins <[EMAIL PROTECTED]> rsv_end is the last block within the reservation, so alloc_new_reservation should accept start_block == rsv_end as success. --

[PATCH 2/12] ext3 balloc: fix off-by-one against grp_goal

2006-11-28 Thread Mingming Cao
-- Subject: ext2 balloc: fix off-by-one against grp_goal From: Hugh Dickins <[EMAIL PROTECTED]> grp_goal 0 is a genuine goal (unlike -1), so ext2_try_to_allocate_with_rsv should treat it as such. -

[PATCH 6/12] ext2 balloc: fix _with_rsv freeze

2006-11-28 Thread Mingming Cao
Sync up a reservation fix from ext2 in ext3 -- Subject: ext2 balloc: fix _with_rsv freeze From: Hugh Dickins <[EMAIL PROTECTED]> After several days of testing ext2 with reservations, it got caught inside ext2_try_to_allocate_with_rsv: alloc_new_

[PATCH 12/12] ext3 balloc: fix _with_rsv freeze

2006-11-28 Thread Mingming Cao
-- Subject: ext2 balloc: fix _with_rsv freeze From: Hugh Dickins <[EMAIL PROTECTED]> After several days of testing ext2 with reservations, it got caught inside ext2_try_to_allocate_with_rsv: alloc_new_reservation repeatedly succeeding on the win

[PATCH 8/12] ext4 balloc: fix off-by-one against grp_goal

2006-11-28 Thread Mingming Cao
Subject: ext2 balloc: fix off-by-one against grp_goal From: Hugh Dickins <[EMAIL PROTECTED]> grp_goal 0 is a genuine goal (unlike -1), so ext2_try_to_allocate_with_rsv should treat it as such. -- Sync up with ext2 reservation fix in ext4 Signed

[PATCH 11/12] ext4 balloc: use io_error label

2006-11-28 Thread Mingming Cao
-- Subject: ext2 balloc: use io_error label From: Hugh Dickins <[EMAIL PROTECTED]> ext2_new_blocks has a nice io_error label for setting -EIO, so goto that in the one place that doesn't already use it. --

[PATCH 10/12] ext4 balloc: say rb_entry not list_entry

2006-11-28 Thread Mingming Cao
-- Subject: ext2 balloc: say rb_entry not list_entry From: Hugh Dickins <[EMAIL PROTECTED]> The reservations tree is an rb_tree not a list, so it's less confusing to use rb_entry() than list_entry() - though they're both just container_of(). --

[PATCH 7/12] ext4 balloc: reset windowsz when full

2006-11-28 Thread Mingming Cao
-- Subject: ext2 balloc: reset windowsz when full From: Hugh Dickins <[EMAIL PROTECTED]> ext2_new_blocks should reset the reservation window size to 0 when squeezing the last blocks out of an almost full filesystem, so the retry doesn't skip any

[PATCH 5/12] ext3 balloc: use io_error label

2006-11-28 Thread Mingming Cao
-- Subject: ext2 balloc: use io_error label From: Hugh Dickins <[EMAIL PROTECTED]> ext2_new_blocks has a nice io_error label for setting -EIO, so goto that in the one place that doesn't already use it. --

[PATCH 3/12] ext3 balloc: fix off-by-one against rsv_end

2006-11-28 Thread Mingming Cao
-- Subject: ext2 balloc: fix off-by-one against rsv_end From: Hugh Dickins <[EMAIL PROTECTED]> rsv_end is the last block within the reservation, so alloc_new_reservation should accept start_block == rsv_end as success. --

[PATCH 4/12] ext3 balloc: say rb_entry not list_entry

2006-11-28 Thread Mingming Cao
-- Subject: ext2 balloc: say rb_entry not list_entry From: Hugh Dickins <[EMAIL PROTECTED]> The reservations tree is an rb_tree not a list, so it's less confusing to use rb_entry() than list_entry() - though they're both just container_of(). --

[PATCH 1/12] ext3 balloc: reset windowsz when full

2006-11-28 Thread Mingming Cao
Port a series ext2 balloc patches from Hugh to ext3/4. The first 6 patches are against ext3, and the rest are aginst ext4. -- Subject: ext2 balloc: reset windowsz when full From: Hugh Dickins <[EMAIL PROTECTED]> ext2_new_blocks should reset the

Re: a question about ext4_fsblk_t

2006-11-28 Thread Mingming Cao
On Sun, 2006-10-22 at 16:50 +0800, guomingyang wrote: > >I also find many places where the block number type is not changed in > namei.c and dir.c. Why? They are all file logical blocks, ext4_fsblk_t is for on disk blocks. Takashi Sato has a patch to define all file logical blocks as ext3

Re: [PATCH 1/6] ext2 balloc: fix _with_rsv freeze

2006-11-28 Thread Mingming Cao
On Tue, 2006-11-28 at 20:07 +, Hugh Dickins wrote: > On Tue, 28 Nov 2006, Mingming Cao wrote: > > On Tue, 2006-11-28 at 17:40 +, Hugh Dickins wrote: > > > After several days of testing ext2 with reservations, it got caught inside > > > ext2_try_to_allocate_with_rsv: alloc_new_reservation re

Re: Boot failure with ext2 and initrds

2006-11-28 Thread Mingming Cao
On Tue, 2006-11-28 at 14:33 -0800, Andrew Morton wrote: > On Tue, 28 Nov 2006 13:04:53 -0800 > Mingming Cao <[EMAIL PROTECTED]> wrote: > > > Thanks, I have acked most of them, and will port them to ext3/4 soon. > > You've acked #2 and #3. #4, #5 and #6 remain un-commented-upon and #1 is > uncle

Re: [PATCH 5/6] ext2 balloc: say rb_entry not list_entry

2006-11-28 Thread Mingming Cao
On Tue, 2006-11-28 at 17:43 +, Hugh Dickins wrote: > The reservations tree is an rb_tree not a list, so it's less confusing to > use rb_entry() than list_entry() - though they're both just container_of(). > > Signed-off-by: Hugh Dickins <[EMAIL PROTECTED]> > --- > Acked. Thanks, Mingming >

Re: [PATCH 6/6] ext2 balloc: use io_error label

2006-11-28 Thread Mingming Cao
On Tue, 2006-11-28 at 17:44 +, Hugh Dickins wrote: > ext2_new_blocks has a nice io_error label for setting -EIO, > so goto that in the one place that doesn't already use it. > > Signed-off-by: Hugh Dickins <[EMAIL PROTECTED]> > --- > Acked, Mingming > fs/ext2/balloc.c |7 +++ > 1

Re: [PATCH 4/6] ext2 balloc: fix off-by-one against grp_goal

2006-11-28 Thread Mingming Cao
On Tue, 2006-11-28 at 17:42 +, Hugh Dickins wrote: > grp_goal 0 is a genuine goal (unlike -1), > so ext2_try_to_allocate_with_rsv should treat it as such. > > Signed-off-by: Hugh Dickins <[EMAIL PROTECTED]> Acked. Thanks, Mingming > --- > > fs/ext2/balloc.c |4 ++-- > 1 file changed,

Re: Boot failure with ext2 and initrds

2006-11-28 Thread Andrew Morton
On Tue, 28 Nov 2006 13:04:53 -0800 Mingming Cao <[EMAIL PROTECTED]> wrote: > Thanks, I have acked most of them, and will port them to ext3/4 soon. You've acked #2 and #3. #4, #5 and #6 remain un-commented-upon and #1 is unclear? - To unsubscribe from this list: send the line "unsubscribe linux-e

[RFC][PATCH 1/1] Comprehensive Secure Deletion for ext4

2006-11-28 Thread Harry Papaxenopoulos
Hello All, As promised a few weeks ago, we have composed a complete patch to add secure deletion functionality in ext4. With this patch, we can ensure that data, meta-data and the filename of any file marked with the special attribute "s", are overwritten right after it is deleted. The patch perf

Re: Boot failure with ext2 and initrds

2006-11-28 Thread Mingming Cao
On Tue, 2006-11-28 at 17:38 +, Hugh Dickins wrote: > > > > And could you check the start and end block for every rsv_window_add and > > rsv_window_remove, to see if it was keep creating and removing the same > > window in the same block group? > > The same every time it settled on a usable re

xfs preallocation writeup, for comparison

2006-11-28 Thread Eric Sandeen
As promised, here is a writeup of xfs preallocation routines. I don't hold these up as the perfect or best way to do this task, but it is worth looking at what has been done before, to get ideas, find better ways, and avoid pitfalls for ext4. XFS preallocation interfaces.

xfs defragmentation writeup, for comparison

2006-11-28 Thread Eric Sandeen
As promised, here is a writeup of xfs defragmentation routines. I don't hold these up as the perfect or best way to do this task, but it is worth looking at what has been done before, to get ideas, find better ways, and avoid pitfalls for ext4. XFS defragmentation interface. =

Re: Boot failure with ext2 and initrds

2006-11-28 Thread Hugh Dickins
On Tue, 21 Nov 2006, Mingming Cao wrote: > On Mon, 2006-11-20 at 16:19 +, Hugh Dickins wrote: > > After four days of running, the EM64T has at last reproduced the same > > hang as it did in an hour before: stuck in > > ext2_try_to_allocate_with_rsv, > > repeatedly ext2_rsv_window_add, ext2_try_

Re: [PATCH 1/6] ext2 balloc: fix _with_rsv freeze

2006-11-28 Thread Hugh Dickins
On Tue, 28 Nov 2006, Mingming Cao wrote: > On Tue, 2006-11-28 at 17:40 +, Hugh Dickins wrote: > > After several days of testing ext2 with reservations, it got caught inside > > ext2_try_to_allocate_with_rsv: alloc_new_reservation repeatedly succeeding > > on the window [12cff,12d0e], ext2_try_t

Re: [PATCH 3/6] ext2 balloc: fix off-by-one against rsv_end

2006-11-28 Thread Mingming Cao
On Tue, 2006-11-28 at 17:41 +, Hugh Dickins wrote: > rsv_end is the last block within the reservation, > so alloc_new_reservation should accept start_block == rsv_end as success. > > Signed-off-by: Hugh Dickins <[EMAIL PROTECTED]> > --- > Thanks, Acked. This is not a problem for now, as the

Re: [PATCH 2/6] ext2 balloc: reset windowsz when full

2006-11-28 Thread Mingming Cao
On Tue, 2006-11-28 at 17:40 +, Hugh Dickins wrote: > ext2_new_blocks should reset the reservation window size to 0 when squeezing > the last blocks out of an almost full filesystem, so the retry doesn't skip > any groups with less than half that free, reporting ENOSPC too soon. > I realize th

Re: [PATCH 1/6] ext2 balloc: fix _with_rsv freeze

2006-11-28 Thread Mingming Cao
On Tue, 2006-11-28 at 17:40 +, Hugh Dickins wrote: > After several days of testing ext2 with reservations, it got caught inside > ext2_try_to_allocate_with_rsv: alloc_new_reservation repeatedly succeeding > on the window [12cff,12d0e], ext2_try_to_allocate repeatedly failing to > find the free

[PATCH 4/6] ext2 balloc: fix off-by-one against grp_goal

2006-11-28 Thread Hugh Dickins
grp_goal 0 is a genuine goal (unlike -1), so ext2_try_to_allocate_with_rsv should treat it as such. Signed-off-by: Hugh Dickins <[EMAIL PROTECTED]> --- fs/ext2/balloc.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- 2.6.19-rc6-mm2/fs/ext2/balloc.c 2006-11-24 08:18:02.0

[PATCH 5/6] ext2 balloc: say rb_entry not list_entry

2006-11-28 Thread Hugh Dickins
The reservations tree is an rb_tree not a list, so it's less confusing to use rb_entry() than list_entry() - though they're both just container_of(). Signed-off-by: Hugh Dickins <[EMAIL PROTECTED]> --- fs/ext2/balloc.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- 2.6.19-rc

[PATCH 1/6] ext2 balloc: fix _with_rsv freeze

2006-11-28 Thread Hugh Dickins
After several days of testing ext2 with reservations, it got caught inside ext2_try_to_allocate_with_rsv: alloc_new_reservation repeatedly succeeding on the window [12cff,12d0e], ext2_try_to_allocate repeatedly failing to find the free block guaranteed to be included (unless there's contention). F

[PATCH 3/6] ext2 balloc: fix off-by-one against rsv_end

2006-11-28 Thread Hugh Dickins
rsv_end is the last block within the reservation, so alloc_new_reservation should accept start_block == rsv_end as success. Signed-off-by: Hugh Dickins <[EMAIL PROTECTED]> --- fs/ext2/balloc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- 2.6.19-rc6-mm2/fs/ext2/balloc.c 2006-

[PATCH 6/6] ext2 balloc: use io_error label

2006-11-28 Thread Hugh Dickins
ext2_new_blocks has a nice io_error label for setting -EIO, so goto that in the one place that doesn't already use it. Signed-off-by: Hugh Dickins <[EMAIL PROTECTED]> --- fs/ext2/balloc.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) --- 2.6.19-rc6-mm2/fs/ext2/balloc.c 200

[PATCH 2/6] ext2 balloc: reset windowsz when full

2006-11-28 Thread Hugh Dickins
ext2_new_blocks should reset the reservation window size to 0 when squeezing the last blocks out of an almost full filesystem, so the retry doesn't skip any groups with less than half that free, reporting ENOSPC too soon. Signed-off-by: Hugh Dickins <[EMAIL PROTECTED]> --- fs/ext2/balloc.c |