Re: e2fsprogs coverity patch

2007-02-12 Thread Andreas Dilger
On Feb 09, 2007 18:11 -0800, Brian D. Behlendorf wrote: > This check is unnecessary since fs_type is guaranteed to be set earlier in the > function. I'm not positive this is the right fix. If we are creating a journal device, we shouldn't be using the normal defaults based on the size of the jou

Re: e2fsprogs coverity patch

2007-02-12 Thread Brian Behlendorf
Hi Ted, Sorry about failing to read the SUBMITTING-PATCHES file, I hadn't noticed it. Yes I'm willing to certify to the Developer's Certification of Origin 1.1 statement, please add the following line to the patches: Signed-off-by: Brian Behlendorf <[EMAIL PROTECTED]> I'll make sure to ad

[PATCH 1/1][RFC] EXT34 retry loop issue V(2)

2007-02-12 Thread Dmitriy Monakhov
Patch depends on : "[PATCH 0/1][RFC] prepare_write positive return value V(2)" This patch solve ext3/4 retry loop issue. Issue description: What we can do if block_prepare_write fail inside ext3_prepare_write ? a) Stop transaction and do retry if possible, but what happend if reboot comes af

[PATCH 0/1][RFC] prepare_write positive return value V(2)

2007-02-12 Thread Dmitriy Monakhov
Changes from ver(1) - __page_symlink(): In order to be on a safe side add explicit zeroing content before fail (just in case). -do_lo_send_aops(): If prepare_write can't handle total size of bytes requested from loop_dev it is safer to fail. - pipe_to_f